From patchwork Fri Nov 4 18:34:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 15748 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp572039wru; Fri, 4 Nov 2022 11:36:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4a45vEWBW032IPwuKdruZO8n5YYEmwBMUPqVERqdm+nwbumltXy5097ect5RToatEIX9gm X-Received: by 2002:a05:6402:cb7:b0:461:17e9:4ea3 with SMTP id cn23-20020a0564020cb700b0046117e94ea3mr356710edb.49.1667586967530; Fri, 04 Nov 2022 11:36:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667586967; cv=none; d=google.com; s=arc-20160816; b=EBNk+Q0WBdGdKdy/aO2NDWoyX4+KfCW0mB6TnCdgxq+28z6cKrQCJ2OzP5mqy75qcp 7OoJtqklDw4AxgcIgWwP1cOcAplcSlXOgowPdBJx1D6Yi2S5EnMF/WZh5AKP68AT5rgA wdhbyHhqrWx8CKnKNcwbHfdIq/N0iEEc4Ar30HblBLqCfQS0Np8N2YQnXErCu+3th4/P +zk2EZNu0dhdeMyKVOB+Utt3BQ3chQGa7iQSf1ehSi4Cf/GQ2by/MCab7Mvjx6tuKHVU NmIEQ8xf9zw30as8G0qaRVl96fb9ZoZplKfyQvJpfKznS8uv3uWMoQM74cbAbEx0ecQ6 oDzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=KP3QgESsiuyhvCuGDc69HOv+WL0/vQW1MQMFUpi3nYM=; b=0egQQWWuKJOWFsBaJG3AejqT4+LsIpiH7c0xqXeXMgxIiMDdOOYsNGNGX3FC93MSeh gHR4rGH+Oj/PiwzMNX01EvAnVAdaDap/N/3kOegj+gLmVcD323GfsfTe6mnRP0uHBEMX LLHXy0SpuJmmjqJbTOMnzhgOtYdn00Fr6/PvUcAvmyj0A33o5b7B4YBcbm6zabz4Zm6s ZnKZCDAivObMrSfUWMYEIpk7Bgal7syMlF8f6CwK5L8z5M9ILlSscvzj0q3pDpCuTdha Gt5jE9eeLi9EwQYIXu6mJ5XvI158tU2rqcEW/XqlIEbIyYaY5sSdFHnCmUR6K/iagFV9 98LA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=mk6+ezga; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nc38-20020a1709071c2600b00791a67e4c04si6742908ejc.31.2022.11.04.11.35.43; Fri, 04 Nov 2022 11:36:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=mk6+ezga; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232095AbiKDSfL (ORCPT + 99 others); Fri, 4 Nov 2022 14:35:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231897AbiKDSfK (ORCPT ); Fri, 4 Nov 2022 14:35:10 -0400 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AA5012F for ; Fri, 4 Nov 2022 11:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667586901; bh=hp0FgrNepDKLSNCKZLrPBSzkRWyWgrFj8BHfBxyz8Ds=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=mk6+ezgaLY4F7HfP3LNQvNUj7KQfYv16P21dszAGgTINmX5jjRQsOau8dEMRkoAOy cpA668cLDqi4y2A+rjqpxLXYtU1TzVyQjcyYRKnaFnj5opINE2PW3FaCogZjzPt09p QMyVN2OTdVGmLXLW9HAr5RrlblYKMkeTpOywE1Xk= Received: by b-6.in.mailobj.net [192.168.90.16] with ESMTP via ip-206.mailobj.net [213.182.55.206] Fri, 4 Nov 2022 19:35:01 +0100 (CET) X-EA-Auth: Mf2Unhvy4C6KZ0+FTvygUlpAP2szYr3OpQncwjcpdnKHkp+ZTvwxP4GYPJfKhSzlN2+evs3xGSpLXe1jKjzuFCVBufeArKhQ Date: Sat, 5 Nov 2022 00:04:56 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] staging: rtl8723bs: Simplify underutilized 2D array to 1D array Message-ID: <4fb8d9783553d15a58e774d7137519d46e58ee3a.1667586648.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748591672059097985?= X-GMAIL-MSGID: =?utf-8?q?1748591672059097985?= Member variable "Value" of structure iqk_matrix_regs_setting is declared to be a 2D array of [3][IQK_Matrix_REG_NUM] grid. However the primary index of this array is only used for index 0, the other two elements are never used. Simplify this array to a one dimension degree. The resultant code is simpler and is easy to maintain. Suggested-by: Dan Carpenter Signed-off-by: Deepak R Varma --- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 18 +++++++++--------- drivers/staging/rtl8723bs/hal/odm.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) -- 2.34.1 diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c index a52748f7b56e..9317a4462c02 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -244,8 +244,8 @@ void ODM_TxPwrTrackSetPwr_8723B( Final_CCK_Swing_Index = 0; setIqkMatrix_8723B(pDM_Odm, Final_OFDM_Swing_Index, RFPath, - pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0][0], - pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0][1]); + pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0], + pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[1]); setCCKFilterCoefficient(pDM_Odm, Final_CCK_Swing_Index); @@ -257,8 +257,8 @@ void ODM_TxPwrTrackSetPwr_8723B( pDM_Odm->Remnant_OFDMSwingIdx[RFPath] = Final_OFDM_Swing_Index - PwrTrackingLimit_OFDM; setIqkMatrix_8723B(pDM_Odm, PwrTrackingLimit_OFDM, RFPath, - pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0][0], - pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0][1]); + pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0], + pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[1]); pDM_Odm->Modify_TxAGC_Flag_PathA = true; PHY_SetTxPowerIndexByRateSection(Adapter, RFPath, pHalData->CurrentChannel, OFDM); @@ -267,16 +267,16 @@ void ODM_TxPwrTrackSetPwr_8723B( pDM_Odm->Remnant_OFDMSwingIdx[RFPath] = Final_OFDM_Swing_Index; setIqkMatrix_8723B(pDM_Odm, 0, RFPath, - pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0][0], - pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0][1]); + pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0], + pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[1]); pDM_Odm->Modify_TxAGC_Flag_PathA = true; PHY_SetTxPowerIndexByRateSection(Adapter, RFPath, pHalData->CurrentChannel, OFDM); PHY_SetTxPowerIndexByRateSection(Adapter, RFPath, pHalData->CurrentChannel, HT_MCS0_MCS7); } else { setIqkMatrix_8723B(pDM_Odm, Final_OFDM_Swing_Index, RFPath, - pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0][0], - pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0][1]); + pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[0], + pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[ChannelMappedIndex].Value[1]); if (pDM_Odm->Modify_TxAGC_Flag_PathA) { /* If TxAGC has changed, reset TxAGC again */ pDM_Odm->Remnant_OFDMSwingIdx[RFPath] = 0; @@ -1760,7 +1760,7 @@ void PHY_IQCalibrate_8723B( /* by sherry 20120321 */ if (final_candidate < 4) { for (i = 0; i < IQK_Matrix_REG_NUM; i++) - pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[0].Value[0][i] = result[final_candidate][i]; + pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[0].Value[i] = result[final_candidate][i]; pDM_Odm->RFCalibrateInfo.IQKMatrixRegSetting[0].bIQKDone = true; } diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h index fe9782d2d4fd..e16a769850c5 100644 --- a/drivers/staging/rtl8723bs/hal/odm.h +++ b/drivers/staging/rtl8723bs/hal/odm.h @@ -481,7 +481,7 @@ enum odm_type_alna_e { /* tag_ODM_TYPE_ALNA_Definition */ struct iqk_matrix_regs_setting { /* _IQK_MATRIX_REGS_SETTING */ bool bIQKDone; - s32 Value[3][IQK_Matrix_REG_NUM]; + s32 Value[IQK_Matrix_REG_NUM]; bool bBWIqkResultSaved[3]; }; From patchwork Fri Nov 4 18:35:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 15749 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp572229wru; Fri, 4 Nov 2022 11:36:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Lz3zRy/cF2BU67+8nNizqb6jbUu/MWvKgOIDsWlKxBZeX8/fnRM+s/PokUGvoFu+w5Cxt X-Received: by 2002:a05:6402:2813:b0:461:e7bc:560a with SMTP id h19-20020a056402281300b00461e7bc560amr37514804ede.340.1667586995947; Fri, 04 Nov 2022 11:36:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667586995; cv=none; d=google.com; s=arc-20160816; b=Q6g2UL2Y/GMzZVP3gQOb3J4jKOOitwNP3eM6snWMZAfErg7fpD1MueXHtelkV20OgF QP7+4bWmUVcIUh46xaRGxlovEaSNGKE0Xx41ZJ7wUXQjBOOOy+iHc91nY7fCAgVkQi88 lQMTo7Xe+muH8ottCWRBrZA553oIp0Pq0Eq/Txj2ccwsYFyK4SlDFXC8BYEEEQCBnEkB X1/ZiNjHycjBgGnwlUb2NL49JHSg0++zdyoK0EaC54g6o0gHzyNKysJdIEL79M1dC5J7 WpM/HGqCiF/ucHTyYlu0lJU8rzRR5y0KntdhGGlXJVnFsK/HSR2tfICiDVPB3NpHCFPI PHOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=npkYAfEp9c0rzxVIyizhQvWMrBytFPoiMViD4dFClpQ=; b=LkAVUgQmGaoHeLbMC6X4tTjNvTJN01qGLi7KzppNzkJipcEUgDD+qogpUBArkuVuau kG5XQen2jByS8gL4jrKMNjrHRUv9BBH03g1N/jCOoqBwx/T+nDhiN/tk0+Ul42yCLuxK bujyzFvQk2jVzrMQmOruvDLfOAM6acTTLH2Xynfa3wwPBlnJNK31gHOy3/oj+7eegAWj cwjTPqFN8ixgs4PsVVTBzwTMD8RgkqnCZ0uDs6UzXT6cSymYAy0o7LMnHqjH182kYSzj AB5GfrhGPLRjT8bM3jnr/4CZKJT8/a7q3MwTLxlIdOdtchuGTpvH4yMKOS5B6hjMVr8L XCQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b="Q2NuLmL/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v30-20020a50d09e000000b00458d1c48708si197028edd.303.2022.11.04.11.36.07; Fri, 04 Nov 2022 11:36:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b="Q2NuLmL/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232197AbiKDSfm (ORCPT + 99 others); Fri, 4 Nov 2022 14:35:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232194AbiKDSfh (ORCPT ); Fri, 4 Nov 2022 14:35:37 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E38B4731A for ; Fri, 4 Nov 2022 11:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667586928; bh=0B53dwmxeG45YNVJ4Hk+8mn0kfMKjj9deNa9hc7yTfs=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=Q2NuLmL/hfSwbeyuFz+iWBAaq68nrgoC1bD2s6wpXsRE64OVFSoLXo1VSpbdtg6ay Ol7ViECLDn7J3NnGNkf9essCyBDaGwU4VN3jxtmijoWSmaECaJxjyrLfrVFT5j7/34 lDLsscIdjFmUNldKQaDsMVH+9QLu6wuLt2HN/aDY= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via ip-206.mailobj.net [213.182.55.206] Fri, 4 Nov 2022 19:35:28 +0100 (CET) X-EA-Auth: mgpYO5K4+REdUFPKKUYsnK0F2jW6dgwbxmTkgKC0MXpQOKCap7NNTWay5++oa438urRr3fiiYiRIkOADL6v0DdsQbIFDB4u5 Date: Sat, 5 Nov 2022 00:05:23 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] staging: rtl8723bs: Remove unused member variable Message-ID: <1b22e45254f7b8cafbf5b78d1e02380295b9ab02.1667586648.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748591701900671237?= X-GMAIL-MSGID: =?utf-8?q?1748591701900671237?= Member variable bBWIqkResultSaved of struct iqk_matrix_regs_setting is declared but never used. Remove it. Signed-off-by: Deepak R Varma --- drivers/staging/rtl8723bs/hal/odm.h | 1 - 1 file changed, 1 deletion(-) -- 2.34.1 diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h index e16a769850c5..6891fa30c7f4 100644 --- a/drivers/staging/rtl8723bs/hal/odm.h +++ b/drivers/staging/rtl8723bs/hal/odm.h @@ -482,7 +482,6 @@ enum odm_type_alna_e { /* tag_ODM_TYPE_ALNA_Definition */ struct iqk_matrix_regs_setting { /* _IQK_MATRIX_REGS_SETTING */ bool bIQKDone; s32 Value[IQK_Matrix_REG_NUM]; - bool bBWIqkResultSaved[3]; }; /* Remove PATHDIV_PARA struct to odm_PathDiv.h */