From patchwork Fri Sep 29 05:14:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 146421 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp3792999vqu; Thu, 28 Sep 2023 22:18:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQJdHq1J7CxYq9JA65w1Y0+VuvyLptm/+S67T3E/aEaBgUoYLuOM+2Uf3A33971W6u6YyO X-Received: by 2002:a05:6a20:6a23:b0:159:cf93:9b50 with SMTP id p35-20020a056a206a2300b00159cf939b50mr3433287pzk.46.1695964734290; Thu, 28 Sep 2023 22:18:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695964734; cv=none; d=google.com; s=arc-20160816; b=ZaHMEskv7zbO405Ce2AucML5KCTVazEkb83i/LpmJiK5yNkwc3Fbx7ggDYQJH+gqtC UkkqkKOmrJukQUnRZ5WxfXhAcncdFF2M+1aQcnH/J7mLy1lMhrZuMJbdsUKiwIkOVsJe 0C46q//vDKllX4DfLnMxdgZOPlTYbxZimxqeHAs8M/fVwGCDy1R7TtLhtxnXMxdwPLIG 1FYHZxQfv57p5lqjTcN7f0PDi3X4j8jTsYRiSHYZxV0bDCdBECROfx+eeaXkq+15kb8B 5160T+Mh4MvTey0cGrZ+drxXKHjEfWmGTG4LchRUn48pEQQhNE3qqQwWAeUtfvhmFGvz gYYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=jqYR373wqB/Ka/1ubfdY5IUNgcFm7MgEQ74lHP0vhos=; fh=YygLGKUlh4nHQ5Rdr9ftF/ryVinr9z2zBS9B5G9J/50=; b=flH17SeEUcxvlHrNLCJeCNdENSlOvvodVSqh0UllUrv/o1DVmCuuHZnMPYzmyxNxar UhbIBcfYB7OJL7h0YVwVPn6sbwj85apu1g1ZYu8/NVsGLBP8GCtgjY8xkj2ZFXYQ5sfK ks1aTVv0L/19X6bm7J/zmUpCj8zQyIClcX9Gw191xzswG4bFL9KZKCxS19igxF5IJ4pw Q2pTJik5vudGPT4pArkLi2tFGDsqaqiaaQ0AHGF9vOQPPqmzW/s9ITEwJKL7HDG7zjnn 3B+Au7e54qlCr2nez1SnNCNCXK5rYeKSw6fXnaDj9ow4VIjfn0zj6cyf44QnEzCpW6ut NJAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b="do/G6q9r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id t12-20020a1709027fcc00b001c6139bf838si12182316plb.544.2023.09.28.22.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 22:18:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b="do/G6q9r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EB7A48389DAA; Thu, 28 Sep 2023 22:18:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231429AbjI2FOi (ORCPT + 20 others); Fri, 29 Sep 2023 01:14:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbjI2FOh (ORCPT ); Fri, 29 Sep 2023 01:14:37 -0400 Received: from mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 567EE195 for ; Thu, 28 Sep 2023 22:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1695964460; bh=5TrBxRkf8axAboRq5eJan1h4q+4K8csemq/WK/VP9ZA=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=do/G6q9r/tlorBmTdac9FvUvIjtHyBXdJqg2ExEi6A3UgQ2kL1IuO8CIXkKPo4iVv 0Ih7El6ezPjRTCOtJ5bZol3iNCoIpDlBsXxUhxqGuqjI79z3y1UB08uD8TRI0/fOOW UCai0Mi8pDHABqMbn1jj8VaW/OBcdNEVXteTkniQ= Received: by b221-5.in.mailobj.net [192.168.90.25] with ESMTP via ip-20.mailobj.net [213.182.54.20] Fri, 29 Sep 2023 07:14:20 +0200 (CEST) X-EA-Auth: tVqjOmq4lkR80hgPN1Q6rvpztdtUdTqm+kt5z3NoCdz7P1X7GYld++tOOVSzXEg4yFVPF8nuORj/+y7BiDt+O1Bd4GglWdfR Date: Fri, 29 Sep 2023 10:44:16 +0530 From: Deepak R Varma To: Bob Peterson , Andreas Gruenbacher , gfs2@lists.linux.dev, linux-kernel@vger.kernel.org Cc: linux-kernel-mentees@lists.linuxfoundation.org, Dan Carpenter , Deepak R Varma Subject: [PATCH] gfs2: No need to be "extern" at the time of definition Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 28 Sep 2023 22:18:36 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778347916991411771 X-GMAIL-MSGID: 1778347916991411771 No need to for the extern keyword at the time of function definition. Remove it to silence the following Smatch warnings: fs/gfs2/super.c:1579:13: warning: function 'free_local_statfs_inodes' with external linkage has definition fs/gfs2/super.c:1594:21: warning: function 'find_local_statfs_inode' with external linkage has definition Signed-off-by: Deepak R Varma --- fs/gfs2/super.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.39.2 diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 02d93da21b2b..fad36ed89853 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c @@ -1576,7 +1576,7 @@ static void gfs2_free_inode(struct inode *inode) kmem_cache_free(gfs2_inode_cachep, GFS2_I(inode)); } -extern void free_local_statfs_inodes(struct gfs2_sbd *sdp) +void free_local_statfs_inodes(struct gfs2_sbd *sdp) { struct local_statfs_inode *lsi, *safe; @@ -1591,8 +1591,7 @@ extern void free_local_statfs_inodes(struct gfs2_sbd *sdp) } } -extern struct inode *find_local_statfs_inode(struct gfs2_sbd *sdp, - unsigned int index) +struct inode *find_local_statfs_inode(struct gfs2_sbd *sdp, unsigned int index) { struct local_statfs_inode *lsi;