From patchwork Thu Sep 28 09:19:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oded Gabbay X-Patchwork-Id: 145905 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp3192680vqu; Thu, 28 Sep 2023 02:58:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYf8ABfslHD3WwlescmhMFnVHUOIsDucKVtJ2W155v2RX7veRLRDeSDf4htJJoP1BilgUV X-Received: by 2002:a17:90a:f2cf:b0:26d:5049:cf48 with SMTP id gt15-20020a17090af2cf00b0026d5049cf48mr608598pjb.40.1695895086953; Thu, 28 Sep 2023 02:58:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695895086; cv=none; d=google.com; s=arc-20160816; b=RrDDpRg3sx4Yld57gcc5bZCKYnH/WMcyuD8h70j3qiNlFGVWbAOENfa4GiQvkp48cn i+iTxqujl0tMIiNNK4W3cR87uXAhkULOEdfYveCftcnqaUj5e1FqzHXbgDwzkHUKaIXs JI89AVzpVG4U014JPQzl3BZi0hZKrRbLVw5/2Qz9CcX9kah7zmIWCnWNlHOWAiZIhRWk OMe7qLxe0mM/Y+y7zc/NJloTZuKd6bvoAYg6NG58JyZ5HiqVxX1BaV3cBXkCfwboIDa6 JJ7VoGYhcB08gP9hTWZpVipxqn9gyJ27wMQRyZY0iZRvj5s1tpibOBESObwAD1vV47cZ N/9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=JUBij7C8/YR4a76vu5vQ2KAT5dW8g6gIZ0v1S+WZScU=; fh=FP+ffrafBoziKtAld7u50Ql/WsbhgFISxH3NOU3Jvlo=; b=XmZ8CU35QBFT3hq9h9ThB9twDC5KEIePd/pVE0Yv2mW830ElFxL/YQ9Y/GbZLrg4il A4pt9RJYO+utd620Fkb7yuy6ui5Mg8iyV7wAIFjPjIjP6IlhFYU/sxFLrjYm1h+cVpr5 VuJEo5KCKxC+7MMP7TxB6gkt1BocsLC7+slTV1s60Usoyq2jVc0Dgzc0myYV2bRMl0y7 aqU0VP+9y8GX6aW3X7O/gyd4NE8heDSgcpeMTEd5Nq0mKlxpAKv++aWn6PilZyKVuidb irTLksOkcM2Rf25gLIpdHmiMsNB9rAZKkCdqnf3KwUb8dj9TmLAZo5dHm/XBuGrJE4bI +k9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sxZosAON; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id mj19-20020a17090b369300b0027761a3a4b0si9845081pjb.0.2023.09.28.02.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 02:58:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sxZosAON; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2C8D181A43E6; Thu, 28 Sep 2023 02:20:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231550AbjI1JUH (ORCPT + 21 others); Thu, 28 Sep 2023 05:20:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjI1JUE (ORCPT ); Thu, 28 Sep 2023 05:20:04 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A38C8E for ; Thu, 28 Sep 2023 02:20:02 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3DB0C433C8; Thu, 28 Sep 2023 09:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695892801; bh=9e29ZnhPKlU/RRKb54lBCqFLUcPtDveR1H2fkbEg0Mw=; h=From:To:Cc:Subject:Date:From; b=sxZosAONQP0lCPkBzlF1Si/T9gAVuSwvT2UYa38Fr4lHYbVjJMOBuN42Xnqcb2Zid 23LGgKhjtUoqQR/9vWtPpCdnOicoNQSC/VfEe9s4BLtow8WcrPtbOD129Y1xgENvuw WNpdabr3e1tz5Xxb1j4m9Fwyx1wRr81EOBQpmyasDe4m8LBov2r19m1lZWInqqRSw+ PKtq7XBjf0i3syZQ9PysfLeFP+QArk+Trdgg02++goSRXbKSXWSDMq8JeaAUM3juWD p9LxjVJzxMPNyvj2Nww2lkeYMd0j7N1hfKkH2WPcGzLfB+RvR7ODzjCGRWVIf75Z0h YDSWEE6sXZKOQ== From: Oded Gabbay To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Dafna Hirschfeld Subject: [PATCH 1/3] accel/habanalabs: remove wrong doc for init_phys_pg_pack_from_userptr Date: Thu, 28 Sep 2023 12:19:54 +0300 Message-Id: <20230928091956.47762-1-ogabbay@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 28 Sep 2023 02:20:22 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778274886522033469 X-GMAIL-MSGID: 1778274886522033469 From: Dafna Hirschfeld The function does not pin the pages so remove that from the inline doc. Signed-off-by: Dafna Hirschfeld Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/memory.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/accel/habanalabs/common/memory.c b/drivers/accel/habanalabs/common/memory.c index ba59e921236e..0b8689fe0b64 100644 --- a/drivers/accel/habanalabs/common/memory.c +++ b/drivers/accel/habanalabs/common/memory.c @@ -832,7 +832,6 @@ int hl_unreserve_va_block(struct hl_device *hdev, struct hl_ctx *ctx, * physical pages * * This function does the following: - * - Pin the physical pages related to the given virtual block. * - Create a physical page pack from the physical pages related to the given * virtual block. */ From patchwork Thu Sep 28 09:19:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oded Gabbay X-Patchwork-Id: 145888 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp3187104vqu; Thu, 28 Sep 2023 02:43:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwmMQJQX0iVmXcwAJDo/Nx94Ku731y2eDfh7ZqO1TveXIRwoaQhyhC5LoMRgusw/wKRLNp X-Received: by 2002:a17:902:dacc:b0:1c3:6d97:e89e with SMTP id q12-20020a170902dacc00b001c36d97e89emr785149plx.58.1695894180914; Thu, 28 Sep 2023 02:43:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695894180; cv=none; d=google.com; s=arc-20160816; b=b4SP7Y1VrjZ+LGXcLmMGAgEjKIpSUvIRgwXJ8u9jVR+SWy504rgYJ1+nRiT8ZiD9Lk hedbmbarld4j82wopXn0efWIfo6X73fwstnXjKvb5938AdEacZp0kjfItE990XLDgtyj ME1xlmqG/qrihfYzqOJIqx6JfCadRqZKvAcY+LovGUyysNzKgaSXGThl/MnHMgXW2eOo jl5X6RrL9mE72PB+OTWtQBUY5029Pc8eeCAY5pduh/bYBVdUTRCwhckSymxUaELugXOd 256IBZE5SabeLQFKe/uHuks63Q5AIOv3JYRw9GQC7lwYtqHU4Yt2dke69IHd53DKZFHR n4ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gJxCn6Q93QFyPMvTDY+mD4L3P4MCfemiM2GfDs2qNHs=; fh=UajbL9n+ytOhwLCTZFWzEEqdsmzR9U8Ujlf0+lLyGQo=; b=b3GCPxa7HIvNa1tYICV/O7tHvOI4JFPTYtvzNuL27yY13khpil8/TnNh2Sl06u387j bNk0TKGr5BhMWOOc3k9P/QAolCXm3sRfwx7VZ/YwwDaVPFZcRn2/Fw9rkt2w0y3S9N0I rGLt0rb9rOuzDVqoYbGmFacZnfifGPOnjQeiPkWlKr2zVI1hA7t1nNJP53ue4PId8+4T g1A8+rTwauqnaRGsjMRC7j6YOLCbuGLrI0K9ItvCZtRZld9a11s6ffDlIpj4BNHylZ7r +xUErstjhtvQx8C5iKkWnXikvhrdtdhGQXXGSc/L+bP+N+IE+Ku0o4n6tGYVktHQL/FJ coAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="fWvw/wPi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id z4-20020a170903018400b001bdd35033f4si1672826plg.387.2023.09.28.02.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 02:43:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="fWvw/wPi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 483AE803B3A0; Thu, 28 Sep 2023 02:20:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231571AbjI1JUJ (ORCPT + 21 others); Thu, 28 Sep 2023 05:20:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230207AbjI1JUF (ORCPT ); Thu, 28 Sep 2023 05:20:05 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7BDCAC for ; Thu, 28 Sep 2023 02:20:03 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63BC0C433C9; Thu, 28 Sep 2023 09:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695892803; bh=Vyr3UyZZ56ptALGkLm5eY95Jkj8E0OURUt5Ep5UjUSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fWvw/wPiff/w5nZ05hgT3Q5bBjC92yz+6Tn8DSykvtTgZ1x7o/N9qDR6pezkqCnVy 7mcUOaGNqemrx5WMZkRtV7KU+jz3+qBZlF3eZWJsgrA3sbX9n/1/ZIetV8lF1j8sga 3sXmBdjrzopQ3NLEllo5CDvoYCETqSpjy1XYqUQLbi4uNt8A/mXDP7M22Wk/6HvDC2 o+nbirwXjZ0PdHTfO4NZBy44ZRJ6Ja/TZdA0/nT6ns+7004DLHZmUlPppKc6AkEK4+ JxAVgwTI4OXZ797dcURyFyLsHVFbIOE7Z5DNzQFhHC2hL2OP2AiQfHZjkeji7jB6hF BlQH1Leh1yU7g== From: Oded Gabbay To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: farah kassabri Subject: [PATCH 2/3] accel/habanalabs: fix bug in decoder wait for cs completion Date: Thu, 28 Sep 2023 12:19:55 +0300 Message-Id: <20230928091956.47762-2-ogabbay@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230928091956.47762-1-ogabbay@kernel.org> References: <20230928091956.47762-1-ogabbay@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 28 Sep 2023 02:20:21 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778273936955377175 X-GMAIL-MSGID: 1778273936955377175 From: farah kassabri The decoder interrupts are handled in the interrupt context same as all user interrupts. In such case, the wait list should be protected by spin_lock_irqsave in order to avoid deadlock that might happen with the user submission flow. Signed-off-by: farah kassabri Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- .../accel/habanalabs/common/command_submission.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/accel/habanalabs/common/command_submission.c b/drivers/accel/habanalabs/common/command_submission.c index 4f7b70d9754c..3aa6eeef443b 100644 --- a/drivers/accel/habanalabs/common/command_submission.c +++ b/drivers/accel/habanalabs/common/command_submission.c @@ -3526,7 +3526,7 @@ static int _hl_interrupt_wait_ioctl_user_addr(struct hl_device *hdev, struct hl_ u64 *timestamp) { struct hl_user_pending_interrupt *pend; - unsigned long timeout; + unsigned long timeout, flags; u64 completion_value; long completion_rc; int rc = 0; @@ -3546,9 +3546,9 @@ static int _hl_interrupt_wait_ioctl_user_addr(struct hl_device *hdev, struct hl_ /* Add pending user interrupt to relevant list for the interrupt * handler to monitor */ - spin_lock(&interrupt->wait_list_lock); + spin_lock_irqsave(&interrupt->wait_list_lock, flags); list_add_tail(&pend->list_node, &interrupt->wait_list_head); - spin_unlock(&interrupt->wait_list_lock); + spin_unlock_irqrestore(&interrupt->wait_list_lock, flags); /* We check for completion value as interrupt could have been received * before we added the node to the wait list @@ -3579,14 +3579,14 @@ static int _hl_interrupt_wait_ioctl_user_addr(struct hl_device *hdev, struct hl_ * If comparison fails, keep waiting until timeout expires */ if (completion_rc > 0) { - spin_lock(&interrupt->wait_list_lock); + spin_lock_irqsave(&interrupt->wait_list_lock, flags); /* reinit_completion must be called before we check for user * completion value, otherwise, if interrupt is received after * the comparison and before the next wait_for_completion, * we will reach timeout and fail */ reinit_completion(&pend->fence.completion); - spin_unlock(&interrupt->wait_list_lock); + spin_unlock_irqrestore(&interrupt->wait_list_lock, flags); if (copy_from_user(&completion_value, u64_to_user_ptr(user_address), 8)) { dev_err(hdev->dev, "Failed to copy completion value from user\n"); @@ -3623,9 +3623,9 @@ static int _hl_interrupt_wait_ioctl_user_addr(struct hl_device *hdev, struct hl_ } remove_pending_user_interrupt: - spin_lock(&interrupt->wait_list_lock); + spin_lock_irqsave(&interrupt->wait_list_lock, flags); list_del(&pend->list_node); - spin_unlock(&interrupt->wait_list_lock); + spin_unlock_irqrestore(&interrupt->wait_list_lock, flags); *timestamp = ktime_to_ns(pend->fence.timestamp); From patchwork Thu Sep 28 09:19:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oded Gabbay X-Patchwork-Id: 145906 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp3192689vqu; Thu, 28 Sep 2023 02:58:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4V07mSnn/F47q+1B5W2ebksg0CEHtD5uQT/DG2VX4soUVFUUGdC3RFbBCMRRZyIprUS2N X-Received: by 2002:a17:90b:30d5:b0:277:1070:7490 with SMTP id hi21-20020a17090b30d500b0027710707490mr586545pjb.44.1695895088554; Thu, 28 Sep 2023 02:58:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695895088; cv=none; d=google.com; s=arc-20160816; b=VWp/BCW49FDDNznkx/u7Ec/PUQxljWzUUa1LWfJAOO6nhnBOCAcy7KKIH2nfztqxt9 F9nlIzdsGguxFehAze29nnwmCHrFpX1oZu/JZxea+C+pOVQnpq+w9ZuDugy+kwosoBG8 aEtPNp9C82JNtTn3Imfm1FejmpOwr+RXKv8DrC2k6Up7qL+fQQc/5abfWD7H0u/fkVGa KZIVHLcVajAVU2gayfEzd3KbmHkp4HGng1vB8Ai9vQRUtwwZmYNuRSLFIT2tTm+ijyzQ JJVX/AGUh3Gf2JngK9cC4FupsL6eZpiXGml199gdM0QupYaWPDZfjEQsWMsJn5p8z8Lt QzlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=t2oxnsVS3R/tww6z0b5UpsExZImUyHB+ImnvXUnCX70=; fh=PceJZ/KGF6ujSpGwn68DXpj5qiXzqwvBM4Q702GUgLM=; b=tMHCOMuK7PmhQ/hmzwUGhUeoN/imWJNnukcmh9PI81xiLweZENbaEbYFZ96x+33PDf AMZPNg7eg3bSyluzu4NfkrwrqWP2DIJKqK1RSfJiFelXIt9ygMcpT3PFTXm+utjCgYu2 bbvgaaBGdNTY2q9JAXmfRz2EPG/2XpOUIJKmWeCcd8u4osMMbvGttHQixqIHVcyG0ZWd HbJMu3hsp7LG2LMmxpyBl2WQDgBjXwG4CxybpXx0j6IQwW4OZtS7sMTOJX4aNBBcDGtW qTRu9B76y3DxXAhASQoFS/vjOw+8AbzSZI49DJUU6da3XkjCnWnOBk5YE/VB/erfysnC ZoXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DcQuR0gU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id nu17-20020a17090b1b1100b0026b6a7d9e43si9458011pjb.14.2023.09.28.02.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 02:58:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DcQuR0gU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B3E1C81B6A89; Thu, 28 Sep 2023 02:20:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231597AbjI1JUM (ORCPT + 21 others); Thu, 28 Sep 2023 05:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231474AbjI1JUG (ORCPT ); Thu, 28 Sep 2023 05:20:06 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89DC28E for ; Thu, 28 Sep 2023 02:20:05 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1222DC433C7; Thu, 28 Sep 2023 09:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695892805; bh=BMuxTiku+IlvNWwdHgMDtNzm/glYc+SS1e8AMX4mWDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DcQuR0gUyWlSbivUkssE/B80V9GssI/Sv70+YozuQ8mwVjvvCppHi6w79RQGWwM0A AXrNFtz6WHErXiRxjmbS+BQomkhMwtD2/nhCPai/v0RdA7qvXrmb7lSGSIJ+bnW7tV 8pblNnvZfW6PVrPPTSmp2phezQQges2ydSBKEzuGMjMoiBm3JFojfdKj7a57M6ewy2 PFm33xdcHFLvd1P/WVYknIwavX2OjMngsTN5Bb/Di45039mGZW0IPE275scvjABXVj IzQMnpIx2IvUpCbGPUgaTZPGbDsUDDoHdCnBFC8X8UuCE1UB/itxbXPGAQAmPFzzZO 4Cyl1INTMbrHw== From: Oded Gabbay To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Tomer Tayar Subject: [PATCH 3/3] accel/habanalabs/gaudi2: perform hard-reset upon PCIe AXI drain event Date: Thu, 28 Sep 2023 12:19:56 +0300 Message-Id: <20230928091956.47762-3-ogabbay@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230928091956.47762-1-ogabbay@kernel.org> References: <20230928091956.47762-1-ogabbay@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 28 Sep 2023 02:20:24 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778274888423130027 X-GMAIL-MSGID: 1778274888423130027 From: Tomer Tayar Non-completed transactions from PCIe towards the device are handled by the AXI drain mechanism. This handling is in the PCIe level, but the transactions are still there in the device consuming some queues entries, and therefore the device must be reset. Modify to perform hard-reset upon PCIe AXI drain events. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- .../habanalabs/include/gaudi2/gaudi2_async_ids_map_extended.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/habanalabs/include/gaudi2/gaudi2_async_ids_map_extended.h b/drivers/accel/habanalabs/include/gaudi2/gaudi2_async_ids_map_extended.h index 57e661771b6c..b2dbe1f64430 100644 --- a/drivers/accel/habanalabs/include/gaudi2/gaudi2_async_ids_map_extended.h +++ b/drivers/accel/habanalabs/include/gaudi2/gaudi2_async_ids_map_extended.h @@ -1293,7 +1293,7 @@ static struct gaudi2_async_events_ids_map gaudi2_irq_map_table[] = { .name = "" }, { .fc_id = 631, .cpu_id = 128, .valid = 1, .msg = 0, .reset = EVENT_RESET_TYPE_NONE, .name = "PCIE_P2P_MSIX" }, - { .fc_id = 632, .cpu_id = 129, .valid = 1, .msg = 0, .reset = EVENT_RESET_TYPE_NONE, + { .fc_id = 632, .cpu_id = 129, .valid = 1, .msg = 0, .reset = EVENT_RESET_TYPE_HARD, .name = "PCIE_DRAIN_COMPLETE" }, { .fc_id = 633, .cpu_id = 130, .valid = 1, .msg = 0, .reset = EVENT_RESET_TYPE_NONE, .name = "TPC0_BMON_SPMU" },