From patchwork Wed Sep 27 10:35:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 145118 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2351420vqu; Tue, 26 Sep 2023 20:20:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGA+1PDCyYeQ2deycNKKLoEQHVV61t4E2STB38UlVxy1gTuL4BzxYAIY2q6liKoIHMXFPPI X-Received: by 2002:a05:6a00:8c8:b0:68a:3b39:a486 with SMTP id s8-20020a056a0008c800b0068a3b39a486mr1286978pfu.24.1695784800154; Tue, 26 Sep 2023 20:20:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695784800; cv=none; d=google.com; s=arc-20160816; b=t7AvxmjUlTiK1+P2P9AigzxHF1jsHXBjpANpLDVN8quy4P8HtMVWum9YUnzZQFIkuh 0tKNXqDwaylt3sgmATCnwDbVzEH1V31KQP7MQWu15cFHd6LGPGP96PeYl+MWNnKFyyMr C9DgmkV2FAPI1MZjPj+dkxGORhLVqnkWPrhNgIj+aLBu0Zo2h0kC4yHuq3nsNBBwGFhs M6du/Q9nA02uLIygVhUVmSk3z7cKD+pD2RDccqNqUb9PXQ5qSO5pjr3CFdZHCVdzmbpa uFZnLyHsZPMCOoxNikXc8FFTm+LLOnNqAAl4Iuqj2hgsIjCreAnrTGCESSHQSaQZOPmf Lx7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=y2Oy9IbcJAO4TckQw5cyGmXyDb0C603Xo937js6lATQ=; fh=FPOLHMy3WNmsotXE752d1f/EDAavI5JB/ZCx9wiEcQM=; b=oc05ANl5YSlfw+bxGayvHeI7vJJfx2yMyk8SG2hzM1u8kr3mTOf8nEmdybY/HklJwa ubfGX/B/K4l06/lZ6Kkzh/vnh0UjD0iX2qiB5EBsyitzPTVY6Q5mgNDNRN4dx0QuC0G2 MjArgYJexBShSbBHJpitp6/Mjbq55G9gUO3nra6QaAmO4D6d7HVGZTF1Mag9gl3A/Fc0 1rPB+ibK+pBwb4xLuE0rJLx3XoQJ3GiUhHjYSAruxjVimQVFEo305q3zl5LILlFA3rL3 fhrpzuEFpcOYI27mntjEG7uTJW2ZWg3EuYE3s0Na3bigxrYuDPvThTz2LqkE3j9PL7bo YTIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id q187-20020a632ac4000000b00577a083624csi13860634pgq.89.2023.09.26.20.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 20:20:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 09DAF80E6C9E; Tue, 26 Sep 2023 20:17:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230193AbjI0DRg (ORCPT + 28 others); Tue, 26 Sep 2023 23:17:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbjI0DPb (ORCPT ); Tue, 26 Sep 2023 23:15:31 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E8768A77 for ; Tue, 26 Sep 2023 19:35:58 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RwLMD5hNpz4f3n63 for ; Wed, 27 Sep 2023 10:35:52 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAXqtkIlRNlpd30BQ--.22085S3; Wed, 27 Sep 2023 10:35:54 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, naoya.horiguchi@nec.com, osalvador@suse.de, willy@infradead.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] mm/page_alloc: remove unnecessary check in break_down_buddy_pages Date: Wed, 27 Sep 2023 18:35:13 +0800 Message-Id: <20230927103514.98281-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230927103514.98281-1-shikemeng@huaweicloud.com> References: <20230927103514.98281-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAXqtkIlRNlpd30BQ--.22085S3 X-Coremail-Antispam: 1UD129KBjvdXoW7XF4rWr4xXr18KF1UJw4Utwb_yoWDKFX_ua n7trn3tFy5KFyIgF17C3WxGrZ7Ww1F9w1xWw4YgFsxKa4UZ3Zrta1kAF95Jr4Dua95uryD u3ZxtFW2vr1S9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbf8YFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r18M28IrcIa0xkI8VCY1x0267AKxVWUCVW8JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26F4UJVW0owA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28E F7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F4 0EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_ Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28IcxkI7VAKI4 8JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xv wVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjx v20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20E Y4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267 AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU0PPEDUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-0.8 required=5.0 tests=DATE_IN_FUTURE_06_12, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 26 Sep 2023 20:17:49 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778159242659177298 X-GMAIL-MSGID: 1778159242659177298 1. We always have target in range started with next_page and full free range started with current_buddy. 2. The last split range size is 1 << low and low should be >= 0, then size >= 1. So page + size != page is always true (because size > 0). As summary, current_page will not equal to target page. Signed-off-by: Kemeng Shi Acked-by: Naoya Horiguchi --- mm/page_alloc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e18e0e20eff8..bad979493dde 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6696,10 +6696,8 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page, if (set_page_guard(zone, current_buddy, high, migratetype)) continue; - if (current_buddy != target) { - add_to_free_list(current_buddy, zone, high, migratetype); - set_buddy_order(current_buddy, high); - } + add_to_free_list(current_buddy, zone, high, migratetype); + set_buddy_order(current_buddy, high); } } From patchwork Wed Sep 27 10:35:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 145177 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2406775vqu; Tue, 26 Sep 2023 22:49:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLOr+rhzbc12q4E3xXv+/5JFGoVG0Q4Wr2TrpPxzqGMCvjpOt8yxEob6hFE87V5ibmNd2v X-Received: by 2002:a05:6808:1382:b0:3ae:87c8:437e with SMTP id c2-20020a056808138200b003ae87c8437emr1312547oiw.41.1695793756068; Tue, 26 Sep 2023 22:49:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695793756; cv=none; d=google.com; s=arc-20160816; b=eZUtKmc3xEOoZIJwtXD2hV8VNx8VM4DugFBKUCM4M7JxykF7oHR1F8C9SseLc4ugrQ no4GSsBZsJ6tniKX5h0Cn4w4Tis+E5F4VeZT34J3sVK715vfhl7085EL802AnkQtll71 VYs6HfmWtLj7zqKgEwB4Crg8t8yAsP4FAgQ0C9P4JdGqFi1Ixj2Wg2uqkcuekovTRxIT dZkQfabPvL7Q/rWfCj2kuWWFJY1D6GX0kXhUHR7/jGOXKc9MVXdzFAX/zawGKpJTR37/ kihwm5INI329tVBKb4RhqSIGASYkVxmK0XiMneXAQM9UDZhBBk7JY1YL4GdYkV5NQPVz JnjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=TsaRnoIwmlBXORY3Z2FLxJyfJzi6RROOxWn8MOHu9jU=; fh=FPOLHMy3WNmsotXE752d1f/EDAavI5JB/ZCx9wiEcQM=; b=BdowMch10af5ARzSthwj4SLEsZq+fODt1qun9aEkrLFee3FiQKeo7e6/I7zMgX5SWl 5RG6V9ua3vFzfgHyjhYb+iNabROLA0ux3Y/uAB6ecq/N8SJCkkv39rFPum44yVZPKrzY q6pHuOjECxcad7ZHShSAsqZqzMvkapBSRho8j2oL/83AbKbXdeISAVbN78er2WaykZOU BsANnFolL/x7tLeLFSZFBYVWfxgqLxNSZnZ51IOcM6kSvBlVYQUkRXq28hsWlh94xMNH qqCNTIshh26jAaUyAjijiFXGapdLHFLyo3QATaN50YHf7FHvX6hu52J8lXv5g1sMpQxJ PUcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id t23-20020a656097000000b0053074c54c3fsi3749890pgu.868.2023.09.26.22.49.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 22:49:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 23A4E809A7B6; Tue, 26 Sep 2023 22:42:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229847AbjI0FmF (ORCPT + 25 others); Wed, 27 Sep 2023 01:42:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbjI0FlO (ORCPT ); Wed, 27 Sep 2023 01:41:14 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E7BD8A74 for ; Tue, 26 Sep 2023 19:35:58 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RwLMF14qMz4f3n6H for ; Wed, 27 Sep 2023 10:35:53 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAXqtkIlRNlpd30BQ--.22085S4; Wed, 27 Sep 2023 10:35:55 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, naoya.horiguchi@nec.com, osalvador@suse.de, willy@infradead.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] mm/page_alloc: remove unnecessary next_page in break_down_buddy_pages Date: Wed, 27 Sep 2023 18:35:14 +0800 Message-Id: <20230927103514.98281-3-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230927103514.98281-1-shikemeng@huaweicloud.com> References: <20230927103514.98281-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAXqtkIlRNlpd30BQ--.22085S4 X-Coremail-Antispam: 1UD129KBjvdXoWrZr45Zr15Cw18ArW7ZF47urg_yoWDArb_CF s7twnxtFy5tFy7ta13C3WxJrWkW34Fkr4xXF1aqrn8Ja4DXFn7J3WDJFy5CrWUuayru348 uasrX3y7tr4I9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbf8YFVCjjxCrM7AC8VAFwI0_Xr0_Wr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r15M28IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26F4UJVW0owA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28E F7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F4 0EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_ Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28IcxkI7VAKI4 8JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xv wVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjx v20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20E Y4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267 AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IUnwa9DUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=1.7 required=5.0 tests=DATE_IN_FUTURE_03_06, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 26 Sep 2023 22:42:29 -0700 (PDT) X-Spam-Level: * X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778168633476469863 X-GMAIL-MSGID: 1778168633476469863 The next_page is only used to forward page in case target is in second half range. Move forward page directly to remove unnecessary next_page. Signed-off-by: Kemeng Shi Acked-by: Naoya Horiguchi --- mm/page_alloc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index bad979493dde..7df77b58a961 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6678,20 +6678,18 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page, int migratetype) { unsigned long size = 1 << high; - struct page *current_buddy, *next_page; + struct page *current_buddy; while (high > low) { high--; size >>= 1; if (target >= &page[size]) { - next_page = page + size; current_buddy = page; + page = page + size; } else { - next_page = page; current_buddy = page + size; } - page = next_page; if (set_page_guard(zone, current_buddy, high, migratetype)) continue;