From patchwork Tue Sep 26 15:53:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 144953 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2017099vqu; Tue, 26 Sep 2023 08:54:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGovOgAcP70yYmahK5iqsfuM1D4CceIAeyqhl5pu6C51puUs2Z90IsAcDPR3QRO9Dx3/ACh X-Received: by 2002:a05:6a20:5492:b0:14d:f087:c0cc with SMTP id i18-20020a056a20549200b0014df087c0ccmr12354278pzk.48.1695743677287; Tue, 26 Sep 2023 08:54:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695743677; cv=none; d=google.com; s=arc-20160816; b=w91cqbS6kdQfFIfz1i9HxWp3ZeHN2v+QOQ7U/bLSrzTjIvY5RubmRjMK0x46OIjjrF RxTScL0wjfahjOiwFTTg1oPZc+oRvqtDs98ZPmrLJwUsP3eYU5V6HsXDrHxyGE74bm5V j4QnNHdShuhwTIfY8jKTkxXF2YfW0liLQ42z26asXTQdDGLxooNpAmUDxlV612YGxKo1 XMR4ag7Jeu8JUrZdkfciKWZwG3ffPIZkRTEpznl+uS2h3FztH8wWXxNIXhV6CkQyItCL LMqWeaGfO/UH5yDkrHM18tHDY6AV+s5I8rYTO1SfB2dGhjXSnwFtrc8MG5ZaYJM02xX3 5rPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=eE4Kw4ynJn/fY0uTa13p94UN/QAJIGEXQWpl87QwNb8=; fh=hn2K8zH58zhgy12DX7GhzjVYO69QJpZQVgFrLxMK9VM=; b=OhfoNvGTbUt/fi45A7lmkKQZ/VeJxaJbAqmUsy0lfCVVIUxl5gaGF4MgaKLOkM85Wn FIVZyTOXJhJfi7x/F9BwPsOkbkRJQcwqifFKljR6tA3iKf4JzemOBv+LRT2un4ZA8MSH 6dFKPKd1L0IzSYLjUEPbAkWCKUq9n7JO4tCq7zgLAsrh8FY5aVrxgdBv0yWgX83XzsGI BgPYFamUHn+t1sIilmXtf5xR7/U7AKFr6GDXWH9xTVbaIMS9mORc0bGEPmBr2oOujp0W S6/8G6N9i1/46jJejFkM/Ft911RKodTqtn57KWPYp11MNmK6k5THZUKdeY+kCWN0nE2W OycQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u8XvF9TN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id bs125-20020a632883000000b00564929df8besi11837436pgb.568.2023.09.26.08.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 08:54:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u8XvF9TN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D727281BAA76; Tue, 26 Sep 2023 08:54:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234417AbjIZPy2 (ORCPT + 28 others); Tue, 26 Sep 2023 11:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjIZPy1 (ORCPT ); Tue, 26 Sep 2023 11:54:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F9511D; Tue, 26 Sep 2023 08:54:20 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A87CDC433C7; Tue, 26 Sep 2023 15:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695743660; bh=a0yWQ4vIBE8N4N1i6VC7OsRaMv2o6zjb5hCiz+yfCDg=; h=From:To:Cc:Subject:Date:From; b=u8XvF9TNvYBIvrKGre6i0T5K/DxCKJ68oIb6JbO8VGJGPKPUtxj2iQV0QAlrQmQMl Bt/H5gf0wWHzL4UZiKV6SlC1INMtcUIQNo+ws9TsR4vPogc6mJCuIq01pzcOH/FcQO 7lbfPQXpttXVAI7h7Ds6HVt9Czq16CePiSqFtI/iy/erHiz3I1Wosqwqbcc1Vdf0dG raDlRaAtChbAc5Fa2llBkCd2kw3SZBNIsNgaR25fItAhCPnxrWlTbBf46ycs1jlrRk MgxL71snrZUpfA3A0gS8xU8+P5f9ay/d9BB33I1yvjRYjoHmRLCj6uYTudPpqcoA02 bVhve0ve4Pd9g== Received: (nullmailer pid 31792 invoked by uid 1000); Tue, 26 Sep 2023 15:54:17 -0000 From: Rob Herring To: Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Ray Jui , Scott Branden , Broadcom internal kernel review list Cc: Ray Jui , Scott Branden , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] dt-bindings: PCI: brcm,iproc-pcie: Fix example indentation Date: Tue, 26 Sep 2023 10:53:40 -0500 Message-Id: <20230926155351.31117-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 26 Sep 2023 08:54:34 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778116122106589841 X-GMAIL-MSGID: 1778116122106589841 The example's indentation is off. While fixing this, the 'bus' node is unnecessary and can be dropped. It is also preferred to split up unrelated examples to their own entries. Signed-off-by: Rob Herring Acked-by: Conor Dooley Reviewed-by: Florian Fainelli --- .../bindings/pci/brcm,iproc-pcie.yaml | 124 +++++++++--------- 1 file changed, 60 insertions(+), 64 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml index 0972868735fc..0cb5bd6cffa1 100644 --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml @@ -117,68 +117,64 @@ unevaluatedProperties: false examples: - | - #include - - bus { - #address-cells = <1>; - #size-cells = <1>; - pcie0: pcie@18012000 { - compatible = "brcm,iproc-pcie"; - reg = <0x18012000 0x1000>; - - #interrupt-cells = <1>; - interrupt-map-mask = <0 0 0 0>; - interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_NONE>; - - linux,pci-domain = <0>; - - bus-range = <0x00 0xff>; - - #address-cells = <3>; - #size-cells = <2>; - device_type = "pci"; - ranges = <0x81000000 0 0 0x28000000 0 0x00010000>, - <0x82000000 0 0x20000000 0x20000000 0 0x04000000>; - - phys = <&phy 0 5>; - phy-names = "pcie-phy"; - - brcm,pcie-ob; - brcm,pcie-ob-axi-offset = <0x00000000>; - - msi-parent = <&msi0>; - - /* iProc event queue based MSI */ - msi0: msi { - compatible = "brcm,iproc-msi"; - msi-controller; - interrupt-parent = <&gic>; - interrupts = , - , - , - ; - }; - }; - - pcie1: pcie@18013000 { - compatible = "brcm,iproc-pcie"; - reg = <0x18013000 0x1000>; - - #interrupt-cells = <1>; - interrupt-map-mask = <0 0 0 0>; - interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_NONE>; - - linux,pci-domain = <1>; - - bus-range = <0x00 0xff>; - - #address-cells = <3>; - #size-cells = <2>; - device_type = "pci"; - ranges = <0x81000000 0 0 0x48000000 0 0x00010000>, - <0x82000000 0 0x40000000 0x40000000 0 0x04000000>; - - phys = <&phy 1 6>; - phy-names = "pcie-phy"; - }; + #include + + pcie@18012000 { + compatible = "brcm,iproc-pcie"; + reg = <0x18012000 0x1000>; + + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 0>; + interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_NONE>; + + linux,pci-domain = <0>; + + bus-range = <0x00 0xff>; + + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + ranges = <0x81000000 0 0 0x28000000 0 0x00010000>, + <0x82000000 0 0x20000000 0x20000000 0 0x04000000>; + + phys = <&phy 0 5>; + phy-names = "pcie-phy"; + + brcm,pcie-ob; + brcm,pcie-ob-axi-offset = <0x00000000>; + + msi-parent = <&msi0>; + + /* iProc event queue based MSI */ + msi0: msi { + compatible = "brcm,iproc-msi"; + msi-controller; + interrupt-parent = <&gic>; + interrupts = , + , + , + ; + }; + }; + - | + pcie@18013000 { + compatible = "brcm,iproc-pcie"; + reg = <0x18013000 0x1000>; + + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 0>; + interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_NONE>; + + linux,pci-domain = <1>; + + bus-range = <0x00 0xff>; + + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + ranges = <0x81000000 0 0 0x48000000 0 0x00010000>, + <0x82000000 0 0x40000000 0x40000000 0 0x04000000>; + + phys = <&phy 1 6>; + phy-names = "pcie-phy"; }; From patchwork Tue Sep 26 15:53:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 144955 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2017267vqu; Tue, 26 Sep 2023 08:54:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGV4467LaqHIzXTrtFU3GVYPbn15MQ3yTo1MeUd0RLnkwIeGb0lWsVQN8iEnnGE3ZZ8uLLB X-Received: by 2002:a25:40d0:0:b0:d7e:dd21:9b16 with SMTP id n199-20020a2540d0000000b00d7edd219b16mr8245776yba.8.1695743694198; Tue, 26 Sep 2023 08:54:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695743694; cv=none; d=google.com; s=arc-20160816; b=A9J+B9ip4TeMO6Mllo6yp2z7tbVBSlznE+rvJePGHAUuWIjUlS1YSJ9izXqBFppTQl FQ82TjPp4KiqRevY/1MuVYYJui1Fu68d2YcKBt1l0JOpe1c37VqHF93bSxPSB/Mc0tLK Bti1iRM12CMd+QGLinFJMBnWzASVBkNfHGZjUjroS+g50rTa4QoAxpodwFUqACxaBVpi WeQpe3YPiVmHIQXY49YoDeyPcwrEn6OEljCEFNLnRIIsNptx4XPfuFGMwHbhLqjb3mWd ueXtSbs3Dq9HaQPZkMkdm+4U299pQx8T7vKYfo1xUuKktQgR+X87D2kKN54kInVnGjp2 LTzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=S7by+08dfDdQZGf/Ou2Zmhw/ocp5DCbukILt2C/oxDY=; fh=hn2K8zH58zhgy12DX7GhzjVYO69QJpZQVgFrLxMK9VM=; b=EuYHjE8nIlnfId6Td6ulsK0M/S8VOXXmqmQh0igPPQ7VIYZ8JY6WstM7hNaCM98EAy ldZN10X5IaTwRf9VuJM8/slbnnlRxI6debhC4sLhIGjoenOp1Y6OSmVEMQRXJAkUpuTL hVg95HZxamrG6s5fRowWWfRn1bxYdLEq3pR0fyVU7lB4v92Nra2jnuadkRsBSvyj7hQ+ yMsmxELGi0rYDAAWpvSNm4UMP4Bd2wVaxuBAwnqgMFwluCtNL5pTSqv79OmJ2IFVRPzp Nuw0MZxzjyvJPQ0ScqSpdfKys+gilnEg+c6LbHSJzURDkHUA9OrDkKAapAFBKgpckCz7 KF2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WBBUB6Xz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id y8-20020a63ce08000000b00578af1e2f3csi13081149pgf.426.2023.09.26.08.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 08:54:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WBBUB6Xz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 451DE81D0B5C; Tue, 26 Sep 2023 08:54:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235098AbjIZPyf (ORCPT + 28 others); Tue, 26 Sep 2023 11:54:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234862AbjIZPyb (ORCPT ); Tue, 26 Sep 2023 11:54:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4377B11D; Tue, 26 Sep 2023 08:54:25 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BDDBC433C7; Tue, 26 Sep 2023 15:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695743664; bh=IisQzbKZxN86Cmpj6sgM5QxS9FVQkRRtLBZ6IuRw+iE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WBBUB6Xznr6UTOr+mgpHWKwE9UZwVwuPbr1/gMfyB3NT5I0clLCHbaz8QPs6gPwwN SaAD4lmhJVbmQMwy78pk8h9sq+1kw/v3pnRVxgvCYTp9UQxDsrYkrGq/4FTUAmKYTe y5HgfwdLIhJIW37hs8697WdZ4FNNCb/i+DnSpQQU9TBbH0lqi7MMxaCck+rmD/E1GG Esq+PYlcyytwkFG54QUEBSBYrJGvE+ZYool3nzuca6gtZG7gLMkRyksJIXMEl51IYl URoV4RnSjRbNA60NGDJx//TFKX9ZGuXJVLNjlvNx0VjZFXan/rOmITY7tEi/tsJ1G2 iyfFH7QtsMviA== Received: (nullmailer pid 31938 invoked by uid 1000); Tue, 26 Sep 2023 15:54:21 -0000 From: Rob Herring To: Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Ray Jui , Scott Branden , Broadcom internal kernel review list Cc: Ray Jui , Scott Branden , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] dt-bindings: PCI: brcm,iproc-pcie: Drop common pci-bus properties Date: Tue, 26 Sep 2023 10:53:41 -0500 Message-Id: <20230926155351.31117-2-robh@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230926155351.31117-1-robh@kernel.org> References: <20230926155351.31117-1-robh@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 26 Sep 2023 08:54:52 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778116139971286510 X-GMAIL-MSGID: 1778116139971286510 Drop the unnecessary listing of properties already defined in pci-bus.yaml. Unless there are additional constraints, it is not necessary. Signed-off-by: Rob Herring Acked-by: Conor Dooley Reviewed-by: Florian Fainelli --- .../devicetree/bindings/pci/brcm,iproc-pcie.yaml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml index 0cb5bd6cffa1..6730d68fedc7 100644 --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml @@ -34,13 +34,6 @@ properties: description: > Base address and length of the PCIe controller I/O register space - interrupt-map: true - - interrupt-map-mask: true - - "#interrupt-cells": - const: 1 - ranges: minItems: 1 maxItems: 2 @@ -54,16 +47,8 @@ properties: items: - const: pcie-phy - bus-range: true - dma-coherent: true - "#address-cells": true - - "#size-cells": true - - device_type: true - brcm,pcie-ob: type: boolean description: > From patchwork Tue Sep 26 15:56:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 144960 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2020232vqu; Tue, 26 Sep 2023 09:00:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXAVqt97jaERwEc0jW9XwBYlhSGsaXBx8d5XqD3m/dE+LbyJ4nuiZug5lWx5JFDuuAGSZe X-Received: by 2002:a05:6a20:5616:b0:14d:792:aafb with SMTP id ir22-20020a056a20561600b0014d0792aafbmr10272169pzc.54.1695744016955; Tue, 26 Sep 2023 09:00:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695744016; cv=none; d=google.com; s=arc-20160816; b=xbAGu7cAnb93zEXz1CDSwwHp4vngyKMnysBe/6JGqahEjmxKVXwVuMEGoxV9l2mAic G087qxFpYTPzkkz7zS3sqlMUVPg2su4z5MqdPD4/mBUwajiPXnPFhlMYCWjAjOUlXRNN JBsxot6pyTT1+N5dvZJwItixAREXpVoiQBmMEEhHDCpLom3UrH427Okxil7dSLLRgEY0 vnH0MTfwLP87fEOcq7ZG+tLL4d34UYeuSKho7+kV8WnmBwAkwP2GxdjVk3a8qVsIF0lC RZATUGTlIs6Xxh3c5OyNmgKo9w7dRkgyw8XmGhT9tAPnYmkWvbtsRGweCGLi1a9+d7Vm /L2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SAA8Mh8dfVgMsJi1DhCvyFro7wqdYTJAXQiTsNS3ntg=; fh=LQwqGn03HtLnQs8aMTx0gzcqBhmZXmhaovWf2zNPl2Q=; b=04CqhXrQU8iUeohy3/mKL7KSTyUqofyCsrC8GRKrT5+5YTlwIMMqk4R2m0cQ8tfIvl 55PvRgqDTLaGDlwX2+gMfnRhS5igHJaA3QeS7eijtJjYxtAe3kHXygkO28qlooZh78NR bmUS5ZHQugRHxZ3d0xnBzm0p0rvkx/GVgYaCMJlLh5txE6kubz0WZB2+u51l3X9tR+Hr SfuWq2zzHekI47hE+u6AD0jHVthrhWpPoZ5OJlEfa1gNvFKo8YXPE8B/u5tJ01ip79ul d5UtGyI6LEHSgztkeoLN+gt+5FbYUpeRoGLgRhN3eaPGG4mnjkc+3+zLKjGUVWs9MTbE DSCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pQ0bxYsF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id b2-20020a170902650200b001bc92dc57bbsi11921429plk.633.2023.09.26.09.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 09:00:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pQ0bxYsF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 7BE22806AFDB; Tue, 26 Sep 2023 08:57:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235145AbjIZP4y (ORCPT + 28 others); Tue, 26 Sep 2023 11:56:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231137AbjIZP4w (ORCPT ); Tue, 26 Sep 2023 11:56:52 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8691FEB; Tue, 26 Sep 2023 08:56:46 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBE57C433C7; Tue, 26 Sep 2023 15:56:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695743806; bh=sz3LleGIgkDcRxsY10cRbgEtugt9GVhiu7ELFn1C6PM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pQ0bxYsFFW6f3k8Mm9YI6BmpG2prf+7jIv4S+F1z1386cIVcJob8goJ79mN/ygtGn LwBrPO/JVUlO2j/UqOLwnuLiiuNReUALoxduWfNpBG+Vutf0qrLwcNG8vPlPi089J5 IO1Pi7q35HxGeadWPmr72WV1Ws73n6gXn2qQWFHUVYiGDyDUlXRp/CiPJQG9JD8O5/ zoYNs+M/fzB/ue4ZgOpi5QCQU2NOWZXT3GqxctlK2SWJCTzPh8cxzrPoziiWg7AtX1 01nGw9jArczGNVvuYj9s3xXZjLKyxdmORBTQayk4tcv57YsVKpqLXfOQpBdBZcDVQO wq2vZyE2CDYwA== Received: (nullmailer pid 34714 invoked by uid 1000); Tue, 26 Sep 2023 15:56:43 -0000 From: Rob Herring To: Bjorn Helgaas , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Krzysztof Kozlowski , Conor Dooley , Ray Jui , Scott Branden , Broadcom internal kernel review list Cc: Ray Jui , Scott Branden , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] dt-bindings: PCI: brcm,iproc-pcie: Fix 'msi' child node schema Date: Tue, 26 Sep 2023 10:56:09 -0500 Message-Id: <20230926155613.33904-3-robh@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230926155351.31117-1-robh@kernel.org> References: <20230926155351.31117-1-robh@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 26 Sep 2023 08:57:00 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778116478581451385 X-GMAIL-MSGID: 1778116478581451385 The 'msi' child node schema is missing constraints on additional properties. It turns out it is incomplete and properties for it are documented in the parent node by mistake. Move the reference to msi-controller.yaml and the custom properties to the 'msi' node. Adding 'unevaluatedProperties' ensures all the properties in the 'msi' node are documented. With the schema corrected, a minimal interrupt controller node is needed to properly decode the interrupt properties since the example has multiple interrupt parents. Signed-off-by: Rob Herring Acked-by: Conor Dooley Reviewed-by: Florian Fainelli --- .../bindings/pci/brcm,iproc-pcie.yaml | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml index 6730d68fedc7..0e07ab61a48d 100644 --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml @@ -12,7 +12,6 @@ maintainers: allOf: - $ref: /schemas/pci/pci-bus.yaml# - - $ref: /schemas/interrupt-controller/msi-controller.yaml# properties: compatible: @@ -63,20 +62,24 @@ properties: msi: type: object + $ref: /schemas/interrupt-controller/msi-controller.yaml# + unevaluatedProperties: false + properties: compatible: items: - const: brcm,iproc-msi - msi-parent: true + interrupts: + maxItems: 4 - msi-controller: true + brcm,pcie-msi-inten: + type: boolean + description: + Needs to be present for some older iProc platforms that require the + interrupt enable registers to be set explicitly to enable MSI - brcm,pcie-msi-inten: - type: boolean - description: > - Needs to be present for some older iProc platforms that require the - interrupt enable registers to be set explicitly to enable MSI + msi-parent: true dependencies: brcm,pcie-ob-axi-offset: ["brcm,pcie-ob"] @@ -104,6 +107,11 @@ examples: - | #include + gic: interrupt-controller { + interrupt-controller; + #interrupt-cells = <3>; + }; + pcie@18012000 { compatible = "brcm,iproc-pcie"; reg = <0x18012000 0x1000>;