From patchwork Mon Sep 25 22:05:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 144607 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1514600vqu; Mon, 25 Sep 2023 15:10:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBLAtES9ZsqNEX0inzenhRRDTg9gEIimSit3fVrKn10Kb62y2CMqga0udiFth10gRBV/sO X-Received: by 2002:a17:902:db11:b0:1c4:486f:5939 with SMTP id m17-20020a170902db1100b001c4486f5939mr7375524plx.3.1695679841844; Mon, 25 Sep 2023 15:10:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695679841; cv=none; d=google.com; s=arc-20160816; b=bm8u9pI7lHc6iLD+obNKhCeKaKTEYK1MZvCBg7HjB3Sh8RMbv5LmRGh880yaSZoyNL p57RWlaBGRfuVBkkOJHocWHpF09wdemD+npIdCJqVdypGNJJzGBluAjPEj6ZpXzhO8Hj v0ANdyHCaOYI7h/Qi0JAcNZ73CzrQwVMJwpeFi7mdpPmu1O/AmDwl0oSPp7wtYtO2+Xi nsq5kHTFzFDYZA6jEuexSYwKwqDWwR0QRg3DILR5/cwY3AJNsJz0KxEU9bPMc+zT2a0l eGiZLw1JXAmxyhIdgLgeeYmSu/zeoArY0Yz23sZ5PREIA9PpXgebT4VNcZ/fyfTt9eh+ usFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=H9jbVOY5DK6lTtqocr07kac3nahdCbmJYdpUVZ3OQ14=; fh=QJHwarUSeo+o/bO7iovvCkMYfaqQAw3RHX8SlU1RgZI=; b=l/XPX4uBDJ/FCZ/maDNIhDuGamhbNyjr4twqvTGwD17OTt6cUdZ6+AtHjMUslvpZG9 awQaiOuqLUXxtIk97Wcx9AZAaV33PzkbIHan69A78z3vV7RwTeiU3Ze8ePuJDN5ekoSu GpwBYJzhJ8hfOlb0VHr3zXakzH71WkYQAmM2qoMV5TcJtBjCNnqgE4DpdOwaHeBYU+Ad dn6Y553lG0KCKisqgcKsLq80nOHxe513dBwp4k4P3iqplFd2Ogl/4Vj90HYnsvLEn7Fh rjuNIODiLQJwDjFTt2zfAyKaIxoUx4KQ8kBPJrES0BEGOnkt+spI+xysBKcBIYL6IJD1 bxiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YsiWcjhP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id u15-20020a170903124f00b001bbcddd6e82si12370375plh.91.2023.09.25.15.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 15:10:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YsiWcjhP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E2EB98069F18; Mon, 25 Sep 2023 15:05:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229958AbjIYWFc (ORCPT + 28 others); Mon, 25 Sep 2023 18:05:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjIYWFb (ORCPT ); Mon, 25 Sep 2023 18:05:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC8F1116 for ; Mon, 25 Sep 2023 15:05:24 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F298C433C8; Mon, 25 Sep 2023 22:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695679524; bh=H4jPOTCta7deecGCFZSg91gHO4eF5tZipTzNxDka1fc=; h=From:To:Cc:Subject:Date:From; b=YsiWcjhPsQdx8BhkOak0BQnIP6/PyKjreGSE1FoJowCn7x4tkGxL2IJWJyN3ePum1 zV9eMnG9xI95nOvPD/AoP3K1bSM+v7jO27cVG0ORvNdYcXiFGRu4GQ98JlBe/3woRl gov+dtq00vnipriX/C4L9TPpr3hVZvNvxc9u/YuVWz+9WnAsfkUahXTJckCrs+ISmI S/1dsZHwd+GjRPHm+YVM9wi3s5a4J/uQSkIo1SVavDbW+GXEfLtpM23hiQ/MSEg7dn U2KXurs33xuWywDZ2mi25KX8oMN8Hs6CbCeWocgqmsJxCDMd8FryfwjR2Dm5X/vd+g nYyKFr3JYWv1w== Received: (nullmailer pid 2026838 invoked by uid 1000); Mon, 25 Sep 2023 22:05:20 -0000 From: Rob Herring To: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Krzysztof Kozlowski , Conor Dooley Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: arm,coresight-cti: Drop type for 'cpu' property Date: Mon, 25 Sep 2023 17:05:05 -0500 Message-Id: <20230925220511.2026514-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 25 Sep 2023 15:05:31 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778049186235670903 X-GMAIL-MSGID: 1778049186235670903 'cpu' has been added as a single phandle type to dtschema, so drop the type here. Signed-off-by: Rob Herring Reviewed-by: Mike Leach Acked-by: Conor Dooley --- Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml index 6216cfb0a188..b9bdfc8969cd 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml @@ -92,7 +92,6 @@ properties: maxItems: 1 cpu: - $ref: /schemas/types.yaml#/definitions/phandle description: Handle to cpu this device is associated with. This must appear in the base cti node if compatible string arm,coresight-cti-v8-arch is used, From patchwork Mon Sep 25 22:05:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 144608 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1514632vqu; Mon, 25 Sep 2023 15:10:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHw8SMwRMik1m0tF1IjZaBWGpe0PL9zC6CgwQ2fQl/KwJIYGQvuxs20S3J64q2iqSwArJue X-Received: by 2002:a05:6870:3329:b0:1d6:567b:7a93 with SMTP id x41-20020a056870332900b001d6567b7a93mr9710221oae.11.1695679844809; Mon, 25 Sep 2023 15:10:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695679844; cv=none; d=google.com; s=arc-20160816; b=kSmAU+i0Vnc1+3fDlV7xSSEqRdSo8PRKPlJ5h0MjwkWJ+iPZpmvNfZYWBZORC0NCsD W1UK9EmOTv1AQPDiIWAB5AP31o3b4nSoLlQOVCY1hWqpdYaWnU5DjD3kkrumvxURBVOh pUeZyCcSFESQpLAQYq2iWeXqEyitY797FgXkFgxGYl47eJaftJiBmpDT+2NS6CTpYzp1 cpS8zck+3FEZgzSTRaD12I2YLd+dHMlUjoS6+Hf5LWSYJmKyJqY5k6KPSUNo/gHSCKN4 lAn8m4FZsesCFaQvaLkEpke1b7xMH865g6HSRcpjtXbJ1j/kAR5gI0LIh1h4c5RBQ+SZ NUkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8Lpi4L35EpEcFkFdbaQw2NZqBHY2yxUr7rmNsNfyJbI=; fh=QJHwarUSeo+o/bO7iovvCkMYfaqQAw3RHX8SlU1RgZI=; b=BiJvuLFJxzRfvUmCmiIpiDA4dMTI8XkrqQysnP9pv5w2Ym+ygvPx1ZcaFCWONIuSxh /59oqghi+OR8gmYZZ+4ay/8uD62HKrt/zaCRcViO1uhxXOgoDF2lAoYHf/cs6xJRxwtd 7OHDkT+HKOLCWEZurahMB4W92uq0RS4rV4ys/7QXpZ7S7pQF2FikSouzmmnPzRVucDsF qtAjyKen3S0PIDKR5xdvf1xYQRF1ynrm8lnnDg62cdZ3mqK0uEFZBVzsxdnxOe336na8 QergaZMFGn4CDN+7oVD4oVdfpPqn39MyJzTwFfW+Y16+X0pjqV3pKwRvLQ3JewhltfjN AaYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c4+YavJe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id ca10-20020a056a02068a00b00573fffaed37si12739751pgb.476.2023.09.25.15.10.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 15:10:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c4+YavJe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id F05E2804ACD4; Mon, 25 Sep 2023 15:05:40 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230311AbjIYWFl (ORCPT + 28 others); Mon, 25 Sep 2023 18:05:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbjIYWFj (ORCPT ); Mon, 25 Sep 2023 18:05:39 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 056E7180 for ; Mon, 25 Sep 2023 15:05:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A5D5C433C8; Mon, 25 Sep 2023 22:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695679532; bh=FmZZfIJ7IjqsgMWeiyIf/YJBP5eLlOuuOdfPlbttg+A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c4+YavJePbk5XQhufDOKssIq1IW9tGV2SLanMeov18NhO3LjgeJSUdunp+PCdUPid cv6cNmJubZL8ILBF8xH3B9XfYk3Epuj212eYufl9Z3GBSGCaWPJ2Y924Ftlif9vhST JFp6ozAm1b+YgUOl5QeIamrwJ2spycsWUBPhLIQTP2IJE9iRqY1KR+DiviCyZyOW7i GvlMAIMvxBNT7LGNXXu+MrY9uKnrq+6zNLdGHwCWem90eIqJ/ew9VaKt8x6V8kNh+D ivOOj6JOuYTIrtAiCV8UZusUZLTFS0iyvQZOgirkJt7JF+yUXTFLYmaiFmhG2vXIoc qJv/N3jqi16gA== Received: (nullmailer pid 2027056 invoked by uid 1000); Mon, 25 Sep 2023 22:05:30 -0000 From: Rob Herring To: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Krzysztof Kozlowski , Conor Dooley Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] dt-bindings: arm,coresight-cti: Add missing additionalProperties on child nodes Date: Mon, 25 Sep 2023 17:05:06 -0500 Message-Id: <20230925220511.2026514-2-robh@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925220511.2026514-1-robh@kernel.org> References: <20230925220511.2026514-1-robh@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 25 Sep 2023 15:05:41 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778049188930271860 X-GMAIL-MSGID: 1778049188930271860 Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present for any node. Adding additionalProperties constraint on 'trig-conns' nodes results in warnings that 'cpu' and 'arm,cs-dev-assoc' are not allowed. These are already defined for the parent node, but need to be duplicated for the child node. Drop the free form description that the properties also apply to the child nodes. Signed-off-by: Rob Herring Reviewed-by: Mike Leach Acked-by: Conor Dooley --- .../bindings/arm/arm,coresight-cti.yaml | 33 ++++++++++++++----- 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml index b9bdfc8969cd..2d5545a2b49c 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml @@ -93,9 +93,7 @@ properties: cpu: description: - Handle to cpu this device is associated with. This must appear in the - base cti node if compatible string arm,coresight-cti-v8-arch is used, - or may appear in a trig-conns child node when appropriate. + Handle to cpu this CTI is associated with. power-domains: maxItems: 1 @@ -112,12 +110,12 @@ properties: description: defines a phandle reference to an associated CoreSight trace device. When the associated trace device is enabled, then the respective CTI - will be enabled. Use in a trig-conns node, or in CTI base node when - compatible string arm,coresight-cti-v8-arch used. If the associated - device has not been registered then the node name will be stored as - the connection name for later resolution. If the associated device is - not a CoreSight device or not registered then the node name will remain - the connection name and automatic enabling will not occur. + will be enabled. Use in CTI base node when compatible string + arm,coresight-cti-v8-arch used. If the associated device has not been + registered then the node name will be stored as the connection name for + later resolution. If the associated device is not a CoreSight device or + not registered then the node name will remain the connection name and + automatic enabling will not occur. # size cells and address cells required if trig-conns node present. "#size-cells": @@ -129,6 +127,8 @@ properties: patternProperties: '^trig-conns@([0-9]+)$': type: object + additionalProperties: false + description: A trigger connections child node which describes the trigger signals between this CTI and another hardware device. This device may be a CPU, @@ -140,6 +140,21 @@ patternProperties: reg: maxItems: 1 + cpu: + description: + Handle to cpu this trigger connection is associated with. + + arm,cs-dev-assoc: + $ref: /schemas/types.yaml#/definitions/phandle + description: + defines a phandle reference to an associated CoreSight trace device. + When the associated trace device is enabled, then the respective CTI + will be enabled. If the associated device has not been registered + then the node name will be stored as the connection name for later + resolution. If the associated device is not a CoreSight device or + not registered then the node name will remain the connection name + and automatic enabling will not occur. + arm,trig-in-sigs: $ref: /schemas/types.yaml#/definitions/uint32-array minItems: 1