From patchwork Mon Sep 25 19:02:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 144543 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1435479vqu; Mon, 25 Sep 2023 12:30:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEaPKUjXhLPQ0i+9gIx8vYRRbcemD93JQWr+NvSQdHowBDMZXRbIUGQ3VHLGJeM6UWazhaz X-Received: by 2002:a05:6359:209:b0:143:8469:5cc7 with SMTP id ej9-20020a056359020900b0014384695cc7mr4814263rwb.2.1695670224991; Mon, 25 Sep 2023 12:30:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695670224; cv=none; d=google.com; s=arc-20160816; b=duCEZNrEGC9dSnSdYaLd8dsIeRX619RHbtS6R36nz7lYF0xTTxUrhTozJt/35Qm41r Mey4c8MnMv4PbefM0xwWtop/deBbWW3gfgDGTgEY8CVyFA+UgM1aY61q2aajqalsW9tE amJ1uS/Ftmb+13VuzzjMlgsyxNW7X10lTK96cnBPJc7vprkQ9KpdE5AFWZc7wDAwfwv4 JUr5QMVFtGc/QecbGPN/v6egmH43xEMlqHbygoIS4DB4FlI252/y4QbsoHpAHB03wVUW DQ/ut+MYJHxgsqU9dE7kzdl//fqnOvQfty51gd4MmNIH020QHf9k9NFisocq/wD7u1+U 2Plg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=bzPT01PebKfDOtktQYY9oEppsd2oSvLIW7l6f+eWLYc=; fh=MhE4FHKs0gF3gYdI2wM49DEmcWYyUKy178z48Esw7l4=; b=DOS4fWq7w/cHPAL+O/wU94cznTIOFXXYXVhz48nKdOgcofPUTl6kceBOG9TugrCUKi jg4zGoc7NaUQB1SypJN3/VyT3l5lVk+AG084fyL1II+3f/KXJVykMNeqBi+TWFu1lEJ9 IVKeOcoozmvkcMX4YkVi6JNi6VyRZsUKXykp1Ja2vROwH+jxioZzAbYQujupF5ol/dqf 5FxQD/JoydapEc4tDaNcL5PHddyeJOHhmVOSWTyKSF/x9t/UkFzyCDcNn2VtpYGaoRsi lwoJPRpu8yZdXw4ux14F+SAFqLZ5l/ClFHz2zBe5no3hcJr5j9zJppCgIK62zKL06jQM F7lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MquU9wD8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id j191-20020a638bc8000000b00578ccb95206si10199274pge.745.2023.09.25.12.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 12:30:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MquU9wD8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A64D3807666B; Mon, 25 Sep 2023 12:03:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233274AbjIYTDG (ORCPT + 29 others); Mon, 25 Sep 2023 15:03:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjIYTDF (ORCPT ); Mon, 25 Sep 2023 15:03:05 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E89495; Mon, 25 Sep 2023 12:02:59 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50FA6C433C9; Mon, 25 Sep 2023 19:02:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695668579; bh=fXjtOigHLEJ1WJtElTztBusz+atOZCq2/IkS7MCl4mI=; h=From:To:Cc:Subject:Date:From; b=MquU9wD8hYsuyJWG2dXdLxBp2tuZNIl4+TT9klhR9RxTVPdroNxfrbZhxKeimjh4Y JfrN6BpcD6a0DJu8IW9uLq9NwYfBWzgMfBLgIyJcbP8hrirGR8PpT3IuWlzM9yKWjf 7AjkLV1PsBQAep7IecnHVy7fJJebuBwDTHWGFxUPQYfzizjByavVoA4V+bNujsVAza rzwf0ZJyGALJUb0SHKewArrjJJOopNKS51TmvMLrVkQz0FWGknyWN9SYJY3D0v3h0+ HEwZcBOe3A0Bm4BmV44LbmkXA2yecvLWHmR6iyqMajxbX8NxN3BAlg3iOmhJqXOSIy FCAD5Dx2HQCmA== Received: (nullmailer pid 1712705 invoked by uid 1000); Mon, 25 Sep 2023 19:02:57 -0000 From: Rob Herring To: "Rafael J. Wysocki" , Viresh Kumar , Michael Ellerman , Nicholas Piggin , Christophe Leroy Cc: linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] cpufreq: pmac32: Use of_property_read_reg() to parse "reg" Date: Mon, 25 Sep 2023 14:02:35 -0500 Message-Id: <20230925190242.1712212-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 25 Sep 2023 12:03:10 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778039102202457970 X-GMAIL-MSGID: 1778039102202457970 Use the recently added of_property_read_reg() helper to get the untranslated "reg" address value. Acked-by: Viresh Kumar Signed-off-by: Rob Herring --- v2: - Add missing include --- drivers/cpufreq/pmac32-cpufreq.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/pmac32-cpufreq.c b/drivers/cpufreq/pmac32-cpufreq.c index ec75e79659ac..df3567c1e93b 100644 --- a/drivers/cpufreq/pmac32-cpufreq.c +++ b/drivers/cpufreq/pmac32-cpufreq.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include @@ -378,10 +379,9 @@ static int pmac_cpufreq_cpu_init(struct cpufreq_policy *policy) static u32 read_gpio(struct device_node *np) { - const u32 *reg = of_get_property(np, "reg", NULL); - u32 offset; + u64 offset; - if (reg == NULL) + if (of_property_read_reg(np, 0, &offset, NULL) < 0) return 0; /* That works for all keylargos but shall be fixed properly * some day... The problem is that it seems we can't rely @@ -389,7 +389,6 @@ static u32 read_gpio(struct device_node *np) * relative to the base of KeyLargo or to the base of the * GPIO space, and the device-tree doesn't help. */ - offset = *reg; if (offset < KEYLARGO_GPIO_LEVELS0) offset += KEYLARGO_GPIO_LEVELS0; return offset;