From patchwork Mon Sep 25 15:14:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 144469 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1292170vqu; Mon, 25 Sep 2023 08:23:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGh4P9EHfey/5R7sLoxTwmaMMBBfpbU5Zl/mp4plrs0btxGtUZDmuIk/vmE+rQX7i78FOiG X-Received: by 2002:a05:6a00:198b:b0:690:d0d4:b757 with SMTP id d11-20020a056a00198b00b00690d0d4b757mr9935636pfl.20.1695655421402; Mon, 25 Sep 2023 08:23:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695655421; cv=none; d=google.com; s=arc-20160816; b=OwN/KaCzOAjOhvUgz9l3MRS0tFabfZzcwA409Hv5AKJp1NbrbhA4E95mfwmWz1icEC UeNTdALvobhgxawC6ZYk1S+0cb6jVvc7+F8wLF3XqNLh17GiwvBiwoCUgkxMhi7oWQLS ymcbmE3H6F0ajK6cf40qTzBOcFs3CtJ0E4EXV7AvaxmhuNKpT2wl4Qeb8gn4MS2bClaJ bPmfPyLmG/xsh53dgJxczSlWw9q4lisKy2AZchfzgFmllGVkRZHpuuzGa0BvcyS6yIy0 hXSoCMhat1fepCHh9kdh0BvSGyBvJAcBw8GsLW2IZd/gIMEYQdsXmvd4FxoZHLqt12xm pewg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=WHXl4xdBH7oIae2xk+WqYNuDkHaLd41yOcEJ0WuOa9g=; fh=/jG6pSxYuz/sH3GE8TL4ZkjXquGz909VpkzWsKlqF8k=; b=XCgCTQCwhP9WkmirTjlUyt9JOifTu7m1wYZZuILPJWxQf8a26O09DtEKjYssi7LJve VT7C3ed4h5Gonf8suKEVObZyoZjrTrIhw8IhI/9OSRtpdojw8rNDBC1PZ4CokoEVfjwY pSP9xuXOMUwPOaol1nRgOue91Rqm+eITXFVv2csr9yd8jSLG2Zv+0b/KtTdMVx5pQLKN z+hL+LsQ4JCIfTC64uGa7ubB+dD/DOV8HNkU1MbAuhlALbvCHW4GBEV7QziuxyZunIHR MzS04JTKHSw5eqa17666Zuk7CLaBf7gh7q09qTUVAISPbbIhv9TmVIhwA1YvfsIbqv5h bM/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=ZG3777JS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id u9-20020a056a00158900b00690bdd81cadsi10982381pfk.155.2023.09.25.08.23.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 08:23:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=ZG3777JS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 17F9F80842C1; Mon, 25 Sep 2023 08:15:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232738AbjIYPPN (ORCPT + 29 others); Mon, 25 Sep 2023 11:15:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231603AbjIYPPM (ORCPT ); Mon, 25 Sep 2023 11:15:12 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79BB910E; Mon, 25 Sep 2023 08:15:03 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38PBieUO025114; Mon, 25 Sep 2023 10:14:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=W HXl4xdBH7oIae2xk+WqYNuDkHaLd41yOcEJ0WuOa9g=; b=ZG3777JSKZJLMXkkc yYwRlwAcHfJdGJGlTTl/QO9fkyuE+vILgTaAM+6s7WRy4HCneupT2XWWMpU5o6ry FBkwVtqv1tWjUCtiLO2R/bst+px811E4wmagbC/4ah05h55/ckoQPHBgJPIqIVV7 2CGOkJS94nG716VWUariaZP7XQbF54X7p+7Ysrto1IEy6FL4DAuJI5J9Wy3mcBwf jKMOWevfU52O8BYDI00hwCczi8kre4RLfvz0/ohuHmqzI15xUeXw7cFu1JjAdrke 2yjH9G4VzRhZeCw8t+YXPhNDGZlvlfOItMynjwBVfcxE0datGr21ihS2Qf8EXa2k NnhWQ== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3t9veja69h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Sep 2023 10:14:49 -0500 (CDT) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Mon, 25 Sep 2023 16:14:48 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Mon, 25 Sep 2023 16:14:48 +0100 Received: from EDIN4L06LR3.ad.cirrus.com (EDIN4L06LR3.ad.cirrus.com [198.90.238.160]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id CEA8C11CD; Mon, 25 Sep 2023 15:14:45 +0000 (UTC) From: Richard Fitzgerald To: CC: , , , Richard Fitzgerald , Mark Brown Subject: [PATCH 6.4, 6.5] ASoC: cs35l56: Disable low-power hibernation mode Date: Mon, 25 Sep 2023 16:14:43 +0100 Message-ID: <20230925151443.28956-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-GUID: -OFlxHOuJDNx62BothL6OVSGO-mCrdT7 X-Proofpoint-ORIG-GUID: -OFlxHOuJDNx62BothL6OVSGO-mCrdT7 X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 25 Sep 2023 08:15:24 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778023579148175105 X-GMAIL-MSGID: 1778023579148175105 commit 18789be8e0d9fbb78b2290dcf93f500726ed19f0 upstream. Please apply to 6.4 and 6.5. Do not allow the CS35L56 to be put into its lowest power "hibernation" mode. This only affects I2C because "hibernation" is already disabled on SPI and SoundWire. Recent firmwares need a different wake-up sequence. Until that sequence has been specified, the chip "hibernation" mode must be disabled otherwise it can intermittently fail to wake. Backport note: This is the same change as upstream commit, to delete one line, but the upstream commit would not apply cleanly on older branches because of minor differences to the surrounding code. Signed-off-by: Richard Fitzgerald Link: https://lore.kernel.org/r/20230912133841.3480466-1-rf@opensource.cirrus.com Signed-off-by: Mark Brown --- sound/soc/codecs/cs35l56-i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l56-i2c.c b/sound/soc/codecs/cs35l56-i2c.c index c613a2554fa3..494adabd4f43 100644 --- a/sound/soc/codecs/cs35l56-i2c.c +++ b/sound/soc/codecs/cs35l56-i2c.c @@ -27,7 +27,6 @@ static int cs35l56_i2c_probe(struct i2c_client *client) return -ENOMEM; cs35l56->dev = dev; - cs35l56->can_hibernate = true; i2c_set_clientdata(client, cs35l56); cs35l56->regmap = devm_regmap_init_i2c(client, regmap_config);