From patchwork Mon Sep 25 06:21:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 144311 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1072176vqu; Mon, 25 Sep 2023 02:05:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENR0ywska+82avlYc7gp3MBl69r2/CGx1tJB1W/XEDoRxb61AUmLy/ddi2Jn3LyOboMsBQ X-Received: by 2002:a17:902:e54e:b0:1c5:b1cc:fe0e with SMTP id n14-20020a170902e54e00b001c5b1ccfe0emr4965482plf.53.1695632739508; Mon, 25 Sep 2023 02:05:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695632739; cv=none; d=google.com; s=arc-20160816; b=pJMu0czFqiRpCUSfsfpxWpsV2epQvE0kh2TeUHo7cZHWBrVTC3V9nvKUXNB91x7bN4 KFvscJCBKXb2jpQvGkk/QPs9YNIsWSeevGvUhhZGyQF0fHDJk5JQbn4+K//BvJgOALKM OaWD+BvsLjxftSAHD1S0lxajJIrzOFsI0aQICq7V5HeYHFsqB9XT2wMGjMOyw0ZVE+MS qF0V+BIs2H63JWNBRYWXWdu4T7DN3YriHc2UCu0EloC7+5jrmKmeEMUxRtit82TFvhMJ Q83i9rPgEfG380TaEV5qQ6ox8GRZGcFrWIZVo4mSNLv5FliZjC6ashVZspSXX4YnRs+S Q8Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:subject:from:to :content-language:user-agent:mime-version:date:message-id :dkim-signature; bh=lGoflC/MDGiByLKpoE4UCpKhG9wCXgC3jrpF9mnawmc=; fh=uUeoF+0GaSUySnt5NJ8yi4FuCTrYD5hh+36uZY7EIak=; b=apcJiLxJqGGOXzV29pdofDobHLYvISnVw+6Zs3/Ii92JSvZ3+ISMWZRL1Jlcm9QeR4 pjHL17NzTVaHpclCYyhgVfWNVnbBHJk2I3cSxY2MFqIRt+xcck5sOWk25X8hTpCQg0o3 yXG44i8v53tN5vZvreHAS+FzERx3bwARNxpwqGpqLDRE1b3um5mfFyOJIR/KS9AwcEMW Ljx3amYKKXjymOSw+JcPNjzuvAYxoFPp+Wa9kqincmS/Qisb7Ekvedyo435eyFy+CL8k nZUZttXRZ1rAVTCcHvDaL6J2pbvry21pzJ89dFbZ5xAsWDKw6btvAM05QXn9YPF6NCof 74MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=ECMthtLk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id t4-20020a17090340c400b001bc434b9d95si9832762pld.156.2023.09.25.02.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 02:05:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=ECMthtLk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BEE1580477A4; Sun, 24 Sep 2023 23:23:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232164AbjIYGXr (ORCPT + 30 others); Mon, 25 Sep 2023 02:23:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232240AbjIYGXd (ORCPT ); Mon, 25 Sep 2023 02:23:33 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFED226A0 for ; Sun, 24 Sep 2023 23:21:39 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-40471c054f9so18560645e9.0 for ; Sun, 24 Sep 2023 23:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1695622897; x=1696227697; darn=vger.kernel.org; h=content-transfer-encoding:cc:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=lGoflC/MDGiByLKpoE4UCpKhG9wCXgC3jrpF9mnawmc=; b=ECMthtLkjF0hBBM6O/lZvvlfnDcHj5vR4Lxe+D45C7tZDbaykHERGtOEudoribQwOl Fte35//cCpWckzrS07O64yvry6jMO7VfOKtLeD/nXLDiv4Ysfkf+H89g1LNrj1z+yqOT 2I18D6Y96LGQEkTX0YHq8CBhSFjxCwXQXdq3HR3fjFYO2ESM8TMMf2E8WFwpGpGwdPup XZLZmKwIZdtOhxGa5aszprHKFkSXUEiPr/yUWolFA3Ywh6qOHjxnGhu8WpG7cMtjaH2c 2AkCOgUwfisfgx/0KcsWXaeaUjfgFWCRkxWW6LnHiDTfwMkT8kuRNTF18tyYP5NqQBI2 LJzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695622897; x=1696227697; h=content-transfer-encoding:cc:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lGoflC/MDGiByLKpoE4UCpKhG9wCXgC3jrpF9mnawmc=; b=HBAT1djwmFrZLhAKp0bUfZ20k6k+WLIbR9mvxHHuozFTZLGJ5MrtPI1wqpRPd6VVz3 9kpx3ghen5/yvZrCq31FzIGyJdM5kMhmXAejp+lxiUWTty6mo74O70dA0fpMHzZUJraz RXcKcoYIiTMbOYImbXnhbySj5BOmzKIfqQzqzsOLv+5HfyGX4XtOaDQXky46AOc/X6KU MlLHbEPvbribZ7HRmRQo2eKRTCgiyba94qEdjWLS/Wv9DvquGmC1ILS3Nsypg1dZ88kq Ap2wOiSBpPB8LlEvF3PsW1cEtW5TIWc+F1L6eY9rgW+pYMrlXLVVFNys5Wx9XkkeyKJi us2Q== X-Gm-Message-State: AOJu0YxAViUFHrHMIoJHKPP8DdccOIJfJzFXrx5iJ2LYFCAjGUe3rrG1 Bn3sppw0eTNQ9/bw5rTe/ruTSQ== X-Received: by 2002:a05:600c:4e05:b0:405:3cc1:e115 with SMTP id b5-20020a05600c4e0500b004053cc1e115mr5041954wmq.3.1695622896458; Sun, 24 Sep 2023 23:21:36 -0700 (PDT) Received: from [172.20.13.88] ([45.147.210.162]) by smtp.gmail.com with ESMTPSA id u23-20020a05600c211700b004042dbb8925sm14054942wml.38.2023.09.24.23.21.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Sep 2023 23:21:35 -0700 (PDT) Message-ID: <71897125-e570-46ce-946a-d4729725e28f@kernel.dk> Date: Mon, 25 Sep 2023 00:21:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Amir Goldstein , LKML , linux-unionfs@vger.kernel.org From: Jens Axboe Subject: [PATCH] ovl: disable IOCB_DIO_CALLER_COMP Cc: Zorro Lang X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 24 Sep 2023 23:23:46 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777999795438022345 X-GMAIL-MSGID: 1777999795438022345 overlayfs copies the kiocb flags when it sets up a new kiocb to handle a write, but it doesn't properly support dealing with the deferred caller completions of the kiocb. This means it doesn't get the final write completion value, and hence will complete the write with '0' as the result. We could support the caller completions in overlayfs, but for now let's just disable them in the generated write kiocb. Reported-by: Zorro Lang Link: https://lore.kernel.org/io-uring/20230924142754.ejwsjen5pvyc32l4@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/ Fixes: 8c052fb3002e ("iomap: support IOCB_DIO_CALLER_COMP") Signed-off-by: Jens Axboe diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c index 4193633c4c7a..693971d20280 100644 --- a/fs/overlayfs/file.c +++ b/fs/overlayfs/file.c @@ -391,6 +391,12 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, struct iov_iter *iter) if (!ovl_should_sync(OVL_FS(inode->i_sb))) ifl &= ~(IOCB_DSYNC | IOCB_SYNC); + /* + * Overlayfs doesn't support deferred completions, don't copy + * this property in case it is set by the issuer. + */ + ifl &= ~IOCB_DIO_CALLER_COMP; + old_cred = ovl_override_creds(file_inode(file)->i_sb); if (is_sync_kiocb(iocb)) { file_start_write(real.file);