From patchwork Sun Sep 24 09:31:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 144092 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp701933vqu; Sun, 24 Sep 2023 07:55:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFWZCEqnrVsJgu+bDBVXbZx1Rc4a06Opp7UfKUcu5xGQ74FBKWS9iQA1v6IFwKhTeyoCLR X-Received: by 2002:a17:90a:3d84:b0:268:81c6:a01f with SMTP id i4-20020a17090a3d8400b0026881c6a01fmr2821688pjc.26.1695567351624; Sun, 24 Sep 2023 07:55:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695567351; cv=none; d=google.com; s=arc-20160816; b=04aPwzjSquDUWQDPk8/gDLFGvHiYvK7x+INpewyFpK5WjG5xVR62y4JwDWiyjWhZED PUimuhfbZnZkQGbQsFxykXKhf1MKOhVORYMe33KMeZ+nbWv1m+mO0SgBGczLMQYyFXWx i5hp5k2uvZ198nASWAZgyHC/6JV1E8JVRoNcW90xDQJW6vnpUBz01vz+VJ6+KNxsH/dd 0MqSt9bGzsOVjYXMZDJhfZpdVItgwUGdmQEgzKL0d9htQZGzSb1EMOenHkFlBWBxcWzy yNNbHJb/a6U6cOZLW4K1mriog0XHbPYSrzd4v7eUSXdV6iY/ZF5tE4PDG+s58GcB+KKz MtYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=uhIVsE+ib8b0OcLzP7C28dZ20AkkqV+wYbZP9GhznoI=; fh=iztwNRZsoLJQSXr7Zomwi3gurFNjhkBf6qkkdVRttVc=; b=wwQ6JrWS4UM4T0R2AXQqcn4FRcIwQvCNYRo87kHkV5rqbbtIpB3zEeCn2lTC5g4/ea DOCjYpRIIPI/Aesglbs4JI3HkAUdDoEPG6Jmg1KX9thKw2SCvNqkgDI0OpENcVRtN2Pz JEv3lom2ymvQjG/BaadtWSJ2HHcWva/Yy2V5L8k+1qVKOzoqEwmJw50sWinzE7F4TtOD gVaZbpTXys0vfCkAMqp+yPBPNx3kz2UxZlG54nT9JA3XwQYrQkKxr7IJMSyOv9hpz7Ok zmTc5Qrnxgw05YpAPDnz8ABhCkYA7egPqYQkUOfXmruUKjeFoibunBQDykQPMfXGazYk O52w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="U/PBlAYY"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id z5-20020a17090ad78500b00267f3363479si7898243pju.57.2023.09.24.07.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Sep 2023 07:55:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="U/PBlAYY"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id E510C805AA0A; Sun, 24 Sep 2023 02:31:39 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229511AbjIXJbW (ORCPT + 30 others); Sun, 24 Sep 2023 05:31:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjIXJbV (ORCPT ); Sun, 24 Sep 2023 05:31:21 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F879FE for ; Sun, 24 Sep 2023 02:31:15 -0700 (PDT) Date: Sun, 24 Sep 2023 09:31:13 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1695547874; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uhIVsE+ib8b0OcLzP7C28dZ20AkkqV+wYbZP9GhznoI=; b=U/PBlAYYJf1FRVGWMJTshREY+NzD6WjH7rNSSYp0LbXPPfiBMT7A5lN2B8bPG5NouSugzS 2/YI66K6wbP73w6c6v0WYEGhMO1WrhDDtgp0L50K86FedFviTAvCNQ2ZB8Fb8I/PI+NSUm dPfvBLtv7yX/K/2iT5fK5PbQ6syf96A/FMNQpl8Opk5dN4uMzOAaxp25nkVCFQHY5D47Lu dFOLvov9d2pF7p15pu/nHKTaNE3kc3sffnW/kSMcLr9tbT36fQl3C8pudp1ZPdO5q1ZZmb bN4ebuop6edPGUJXEh4rn2YmnEI37cawzFZuAJ6SdSNpdKTm2JRjhO6RS0B+Rg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1695547874; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uhIVsE+ib8b0OcLzP7C28dZ20AkkqV+wYbZP9GhznoI=; b=XXk12dLav9cFryC3S6+GGdIVzw8dYg2wrFGWpj6I5ci176Q6qaW8eajxNVfyHWuyNRKLA7 soLCGU2Ryo0DPzAA== From: "irqchip-bot for Biju Das" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-fixes] irqchip: renesas-rzg2l: Fix logic to clear TINT interrupt source Cc: Biju Das , Claudiu Beznea , Geert Uytterhoeven , Marc Zyngier , tglx@linutronix.de In-Reply-To: <20230918122411.237635-2-biju.das.jz@bp.renesas.com> References: <20230918122411.237635-2-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Message-ID: <169554787327.27769.4173063850512079064.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 24 Sep 2023 02:31:39 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777378896118107068 X-GMAIL-MSGID: 1777931231117878771 The following commit has been merged into the irq/irqchip-fixes branch of irqchip: Commit-ID: 9b8df572ba3f4e544366196820a719a40774433e Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/9b8df572ba3f4e544366196820a719a40774433e Author: Biju Das AuthorDate: Mon, 18 Sep 2023 13:24:09 +01:00 Committer: Marc Zyngier CommitterDate: Sun, 24 Sep 2023 10:18:19 +01:00 irqchip: renesas-rzg2l: Fix logic to clear TINT interrupt source The logic to clear the TINT interrupt source in rzg2l_irqc_irq_disable() is wrong as the mask is correct only for LSB on the TSSR register. This issue is found when testing with two TINT interrupt sources. So fix the logic for all TINTs by using the macro TSSEL_SHIFT() to multiply tssr_offset with 8. Fixes: 3fed09559cd8 ("irqchip: Add RZ/G2L IA55 Interrupt Controller driver") Signed-off-by: Biju Das Tested-by: Claudiu Beznea Reviewed-by: Geert Uytterhoeven Reviewed-by: Claudiu Beznea Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20230918122411.237635-2-biju.das.jz@bp.renesas.com --- drivers/irqchip/irq-renesas-rzg2l.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c index 4bbfa2b..2cee547 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -118,7 +118,7 @@ static void rzg2l_irqc_irq_disable(struct irq_data *d) raw_spin_lock(&priv->lock); reg = readl_relaxed(priv->base + TSSR(tssr_index)); - reg &= ~(TSSEL_MASK << tssr_offset); + reg &= ~(TSSEL_MASK << TSSEL_SHIFT(tssr_offset)); writel_relaxed(reg, priv->base + TSSR(tssr_index)); raw_spin_unlock(&priv->lock); }