From patchwork Thu Sep 21 07:36:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Stitt X-Patchwork-Id: 143137 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5294373vqi; Thu, 21 Sep 2023 20:24:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8UPDnByXviwrtt3vKawGl9gou6kcWXFR3O4Wsl2/1asGQ0Z69A9lEGeCneaQfsuSmeJ3d X-Received: by 2002:a05:6359:6299:b0:143:8bc6:ac4 with SMTP id se25-20020a056359629900b001438bc60ac4mr1840957rwb.14.1695353099479; Thu, 21 Sep 2023 20:24:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695353099; cv=none; d=google.com; s=arc-20160816; b=zlWNI5wXx1Pug46xRgyG0GSGwfmsqtIXWVHNLSceuBDHuMOtLOw0RF/Ml5Aj7P6YqR 0fc+LqmGO3SDe5VoAawAPjgiCtn5gxvBfkKpLEz7oN5cQFODliWmCcHoNEFganZv/rST Z6RcDZ+H/xWZQKG03wJQ7krZ5pi0t0s1lolePnSwRjwGpvNI2cDDAxZAGzHEHzJ/RFuv YX4NX/vl1kjB3YHFr7JSyHEiVET17DFqoSLGmM/nhYTXsDUlUgATVFmhHFOberE1Po40 bQL6jaLkTAVt0JQmdBlszLEPibWq4H2+4DkYsp9/TAujE93SF5/a6LVkdP7ZtCII/ZpT 053g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=2Sd4hbhBemt6+PvRvK/BENUnRBVZPSiTQthHgyMmLUc=; fh=QXI9bA8FCNge3worq+h6tBTKZGQUiAdl6zi2UZqXj7M=; b=HOQSL7R8CJPfycmgnnO2cmzxjKUvy+hgXeQPSYHBcZeHSFMggHvAudFQP+OOCzvGJZ 3XeqtYM2lgAnZuDi1q1xb5WcrLXmeLLKdYUSd9d4yl7nLzrSAsQ0Af+EEuDGPET4tA1L aDGoS0nH/xC5M+YY783HlYmaqUueMDhPV/HLZnV07JwVwiceEvwP9wp1AzL13M3YpkZs kPJX7AkSctYEi6Sq6fcbuNrGQNrsTaH/LqLrHBDX7lDXU2iNR/EphV8ZCmndTUHCcCSs u9F4HcIMkCGIzsPrCjixo7ErC1WSx0GMpwOx2ZcoC0+oNz6SYhzCG/51enMPB6nQBUMm VwNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=ZvxswE2A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id x33-20020a634861000000b00578f4ca8b8fsi2866185pgk.260.2023.09.21.20.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 20:24:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=ZvxswE2A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id ACDB984E98B1; Thu, 21 Sep 2023 13:31:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231710AbjIUUaw (ORCPT + 29 others); Thu, 21 Sep 2023 16:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232680AbjIUUac (ORCPT ); Thu, 21 Sep 2023 16:30:32 -0400 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA86B905FD for ; Thu, 21 Sep 2023 10:46:52 -0700 (PDT) Received: by mail-pj1-x1049.google.com with SMTP id 98e67ed59e1d1-274800b0216so894932a91.0 for ; Thu, 21 Sep 2023 10:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695318412; x=1695923212; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=2Sd4hbhBemt6+PvRvK/BENUnRBVZPSiTQthHgyMmLUc=; b=ZvxswE2AnZy+bjBY+Uu8tHr8gMH2o82Ao997Nte5s90/C8v7gx8bNuyjkScxBV8gXL P9rpzdQjKyg7XUjUJ6vEK9bRbAZI4oGatkDKkXi3U6v4oCTubvVswCPOvY7mRrUHg4or qv4WPakU8QY5xYz5mCloH8TzSFUdPThdS9hnsJe84C0BXotdbgLN6XzlfxdPHhI8cDie dZCH7eRYj93vxOsGsY/bDjmt73jlt+U98EMN1Z2s7IQDzZJluAU6aHl7KeZf9bzTLrDl GoxSiJJWiOQyjfXta65jfsc/XPWDhF71IMHfOJfuHaekdvTmBNG2OYDgS67OQRRY74lr XhYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695318412; x=1695923212; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2Sd4hbhBemt6+PvRvK/BENUnRBVZPSiTQthHgyMmLUc=; b=DvpPGXhWoaHnbi+kHnn1jZf4ZWm2Y/f0gfis+V5ShmHekCMqdY1bpGC8EHnNb0Ji0Z Zjd2BWi+FYrYnn0KU5LRDJ/Sw1UhMp/8HJT+mPrlBsQeREn+lzplqE1nKLzlBU0pLuCw IXWQKeFQ1eKXVYFt09UiCEh85mdr+SuLDX09iZXtzAjfyOkiG44fNOREo/1NawZulAZE R9R8r3m1Kc/Gqf1sLm14ui6xwnbUx+H1JcrRCwGr8G86TbbfweO5AoYtRox0E3rHthFv N4ZRTMbvE0bzhxr0C0/c9cS58pAiBb+USvHv2iuXdes2jMGsLTIDMTSXBgDSVo0RmUmc dW0A== X-Gm-Message-State: AOJu0YxQn0Enmd0FI3Z6j7Dhad1ySKjutkVUk+vYRs+XBPheX1Zg8rOY 0tdLQPIct2N3VS+H/krT89ZdeIri1GjZbczdcA== X-Received: from jstitt-linux1.c.googlers.com ([fda3:e722:ac3:cc00:2b:ff92:c0a8:23b5]) (user=justinstitt job=sendgmr) by 2002:a81:b149:0:b0:59b:ebe0:9fd6 with SMTP id p70-20020a81b149000000b0059bebe09fd6mr74612ywh.6.1695281787226; Thu, 21 Sep 2023 00:36:27 -0700 (PDT) Date: Thu, 21 Sep 2023 07:36:26 +0000 Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAHnyC2UC/x3NywrCMBBG4VcpWTswbbygryIiuUzsv3AsE2mV0 nc3uPw256yuikGqu3SrM5lR8dKGfte5NAZ9CCE3u4EHz+ehp/o2TdOXsmEWqwQtUMSgmcaFYPk ZCHvGckehREfvuUQ+8ClH16KTScHnP7zetu0HJ/831YAAAAA= X-Developer-Key: i=justinstitt@google.com; a=ed25519; pk=tC3hNkJQTpNX/gLKxTNQKDmiQl6QjBNCGKJINqAdJsE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1695281786; l=1647; i=justinstitt@google.com; s=20230717; h=from:subject:message-id; bh=azwE+ZmdRI6O/nQsHa387F2VcNjnWz4bpJZWNz8mYqI=; b=4HCFbh7ZqzydD1p5IcPfSFx7e/laNJU8kusftwlxw5oJi2KxF9BHvAMRI3p7BtcLKVqzigrTX NHT8RDtFa++CJFD7cM80Ms7NYhx6XCn7cRz+AXha7ug2OLfrzDgoGS5 X-Mailer: b4 0.12.3 Message-ID: <20230921-strncpy-drivers-infiniband-hw-irdma-i40iw_if-c-v1-1-22d87aef7186@google.com> Subject: [PATCH] RDMA/irdma: replace deprecated strncpy From: Justin Stitt To: Mustafa Ismail , Shiraz Saleem , Jason Gunthorpe , Leon Romanovsky Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Justin Stitt X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 21 Sep 2023 13:31:10 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777706571488969562 X-GMAIL-MSGID: 1777706571488969562 `strncpy` is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. A suitable replacement is `strscpy_pad` due to the fact that it guarantees NUL-termination on the destination buffer. It is unclear to me whether `i40iw_client.name` requires NUL-padding but have opted to keep the NUL-padding behavior that strncpy provides to ensure no functional change. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Justin Stitt --- Note: build-tested --- drivers/infiniband/hw/irdma/i40iw_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 2cf0f715623872823a72e451243bbf555d10d032 change-id: 20230921-strncpy-drivers-infiniband-hw-irdma-i40iw_if-c-6330fb0507db Best regards, -- Justin Stitt diff --git a/drivers/infiniband/hw/irdma/i40iw_if.c b/drivers/infiniband/hw/irdma/i40iw_if.c index 4053ead32416..adbea33bf5b7 100644 --- a/drivers/infiniband/hw/irdma/i40iw_if.c +++ b/drivers/infiniband/hw/irdma/i40iw_if.c @@ -186,7 +186,7 @@ static int i40iw_probe(struct auxiliary_device *aux_dev, const struct auxiliary_ aux_dev); struct i40e_info *cdev_info = i40e_adev->ldev; - strncpy(i40iw_client.name, "irdma", I40E_CLIENT_STR_LENGTH); + strscpy_pad(i40iw_client.name, "irdma", I40E_CLIENT_STR_LENGTH); i40e_client_device_register(cdev_info, &i40iw_client); return 0;