From patchwork Thu Sep 21 06:02:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 142893 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5126278vqi; Thu, 21 Sep 2023 13:41:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEispK/3aOdcgbRnDTykLSwcToz4IOFRM7HuoKkiQPRp12dfiuNyP6/7VdRWrEY0/UsQ4lK X-Received: by 2002:a05:6830:41:b0:6bc:de9b:a3e6 with SMTP id d1-20020a056830004100b006bcde9ba3e6mr7548497otp.24.1695328911760; Thu, 21 Sep 2023 13:41:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695328911; cv=none; d=google.com; s=arc-20160816; b=TECLXfuwI3DefsX16T0lNiDng96yZjdtaePM6HA+Yaba/6gcWP94VMMMqcFGzp1ekb 2qjFB5URKbkrS+vgaiAm0dWXemikVrWz2kH6qnBzl/L/tZILCHs9XyL/l1IwT2sSJUqV Gi95Tl7YTNSuwyZ5898A/MRZSxdwF+CobkFyvQdJ5ZzOrTYx9mfW00f9R4OQTv+H0xdq JFHrvHSgU2NvGOSB/JvbBmhO7Yo6w7M8TLKGsQ7sRmCppRNMSi8yRiWZNY3NdViCHbIj tleRliHXg6VwZl+Wxk6hqkPuv0efrYLL8EdkhU1mK0PfLfAmFkRd/d2KgYUAUNZXBoqp D6ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gdqW2btEAGTjUcr6tPXF8qJKNeNz/rAyxIMM40y9I9w=; fh=PYlmPULgqCM74wGi5nVZG1JDMwK6OdNUKHaIgSc8Qhk=; b=NdXttGso7ETcz3vzsBzzpMmp1Q5/7Yo/ebbvZlIJkg0KuyHyhkFgQcagxXSSlYxxYS yjrsZycAYkIsM1bC4WeK9hZ36DrUNeiOGDVV0Arbria3Qg3DEuguzexBIhlFFiXWbFf3 mMHkLLYf72OlsIyPOj3iLWdAyEu8upIWAxkexdtOxXQ4jp1276yR1j1cPTihyjSVk2Zb wkuV5C49nC9O8BfgCgvTXQKjxRr2z3sbW0JZ0LSgRd572j21g6ZxCj+SW+RERQe23KWz H168btNsvwlvuY6XRd+AMQB8AuK/yDMH5WvxIEySBFmcx15ghdJCObRJQlz8IlXC8Ckw l3EQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=SWocHAyJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id x19-20020aa793b3000000b0068e4704fd5bsi2083964pff.346.2023.09.21.13.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 13:41:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=SWocHAyJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id B7907833AB02; Thu, 21 Sep 2023 12:31:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231165AbjIUTay (ORCPT + 28 others); Thu, 21 Sep 2023 15:30:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230487AbjIUTaK (ORCPT ); Thu, 21 Sep 2023 15:30:10 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6CD4AC3CC; Thu, 21 Sep 2023 11:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=gdqW2btEAGTjUcr6tPXF8qJKNeNz/rAyxIMM40y9I9w=; b=SWocHAyJZpAAngQ47nwB5OeiR3 YOZKLNFRzgqPHosliGblFbf62gIeaDU6/FjBeIqe4fSke+drAQNrno+yRUjWC/8YrkDRBb3xeUVNe v1aa3Yx6Djf7J4Kcs+fGBg1EcU4zRp1wV91uFHEmQFq8z/7kH624JMHQZlzQSa7+ec1kksacwnOkN cmjYrIMBWiI9qaFkO3kRcVzdbmFhGQHki/2SDPEdpVau5CEW5xVNFRBr6any6+WhfnmAlIJJ5rbhL m9vVbDkwAcYJv4JkF0jSsAxvB4w/bYDTanh0v+NcFWi+jtEWbbbS3otMbbq0oDgbPgA1sAvhUi2mu 9YNiyNCw==; Received: from [2601:1c2:980:9ec0::9fed] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qjClk-005Eii-0U; Thu, 21 Sep 2023 06:02:32 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Daniel Vetter , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, John Paul Adrian Glaubitz , linux-sh@vger.kernel.org Subject: [PATCH] fbdev: sh7760fb: require FB=y to build cleanly Date: Wed, 20 Sep 2023 23:02:28 -0700 Message-ID: <20230921060228.29041-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 21 Sep 2023 12:31:21 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777672496926678217 X-GMAIL-MSGID: 1777681208723206479 Fix build errors when CONFIG_FB=m and CONFIG_FB_SH7760=y: sh2-linux-ld: drivers/video/fbdev/sh7760fb.o: in function `sh7760fb_probe': sh7760fb.c:(.text+0x374): undefined reference to `framebuffer_alloc' sh2-linux-ld: sh7760fb.c:(.text+0x394): undefined reference to `fb_videomode_to_var' sh2-linux-ld: sh7760fb.c:(.text+0x3a0): undefined reference to `fb_alloc_cmap' sh2-linux-ld: sh7760fb.c:(.text+0x3a4): undefined reference to `register_framebuffer' sh2-linux-ld: sh7760fb.c:(.text+0x3ac): undefined reference to `fb_dealloc_cmap' sh2-linux-ld: sh7760fb.c:(.text+0x434): undefined reference to `framebuffer_release' sh2-linux-ld: drivers/video/fbdev/sh7760fb.o: in function `sh7760fb_remove': sh7760fb.c:(.text+0x800): undefined reference to `unregister_framebuffer' sh2-linux-ld: sh7760fb.c:(.text+0x804): undefined reference to `fb_dealloc_cmap' sh2-linux-ld: sh7760fb.c:(.text+0x814): undefined reference to `framebuffer_release' sh2-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0xc): undefined reference to `fb_io_read' sh2-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x10): undefined reference to `fb_io_write' sh2-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x2c): undefined reference to `cfb_fillrect' sh2-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x30): undefined reference to `cfb_copyarea' sh2-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x34): undefined reference to `cfb_imageblit' Fixes: 4a25e41831ee ("video: sh7760fb: SH7760/SH7763 LCDC framebuffer driver") Signed-off-by: Randy Dunlap Cc: Daniel Vetter Cc: Helge Deller Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: John Paul Adrian Glaubitz Cc: linux-sh@vger.kernel.org --- drivers/video/fbdev/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1762,7 +1762,7 @@ config FB_COBALT config FB_SH7760 bool "SH7760/SH7763/SH7720/SH7721 LCDC support" - depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ + depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721) select FB_IOMEM_HELPERS help