From patchwork Fri Nov 4 08:44:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Sae X-Patchwork-Id: 15426 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp260308wru; Fri, 4 Nov 2022 01:58:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM46Rkz9Xx/iNqHY0kgCXHFO/mFUUwdc8algXPyQPtDDXLyZO/vvYmle1fbLzC/OlfLBlkGv X-Received: by 2002:a05:6a00:168e:b0:53b:3f2c:3213 with SMTP id k14-20020a056a00168e00b0053b3f2c3213mr34536467pfc.56.1667552321026; Fri, 04 Nov 2022 01:58:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667552321; cv=none; d=google.com; s=arc-20160816; b=KPRYXLSn59470mvsq/+AmxzCHuvN+nqbAWl7kzLd0tyY1k+R/FkT3khEOzpFT4YTlF phX2+a0Q42xhdrzT5owCYaXX0ZmNfeyfwNQ+XSxsKbFu5zkTEONMAJfhwPSpWZKkbLxi BjUqmNQPE/BSMAZwv7GtJuY6AwaawwWgIG/6FJ0N3LICdbJcJiswfbMLvfs30ts8qeKx Yl1YyMFuosl42/qUYUwlmkUVIBD6VEN6QGJ47ggV4Lzxc1/bQYstgbOMR+VGc2S7KfpI R77tHf2dTQeWTTZ3CkGIk+3X+AIhn+DCmEpukARmzM1aQkGrdHZ2dvXGXT5ziMQ/4tE/ rpjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=LnTnSCx8bGe/itIiFqzHr6PiuVZoQPHFdlPu674Gkb4=; b=W1m5eSDSSSL4T4s7gYVW/Zq9f9tpIu9hV7AhgZqka8eo74tqZwOve4o7XiAS30V30F EdfkAAPtmxLtH+v33B5CWAzM+ebbUVrUtNp1adE4YCAvGqLnmADC0pTBnvEKSjvawHVs zodhVleB7de4MpVTCgjdwF+p0kabLwrI+IHHZohaslP8bJD0D10ml6NahNFmbxfRXUTy i+nGiK+rgCE6cZSUl9OPFibU3chRxNGFAS1oIm+k4dJu3MevU6ICpqUuI1JwuCxcyFmi 6hcN9KuVyumRlDZWtQjK4732LP2nSRc+3gS+/wdo6qhsOivEafC3S2k15Ly4PNCIGqe/ X1ug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w184-20020a6382c1000000b004393f62586csi3902974pgd.238.2022.11.04.01.58.25; Fri, 04 Nov 2022 01:58:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230297AbiKDIpR (ORCPT + 99 others); Fri, 4 Nov 2022 04:45:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbiKDIpP (ORCPT ); Fri, 4 Nov 2022 04:45:15 -0400 Received: from out28-173.mail.aliyun.com (out28-173.mail.aliyun.com [115.124.28.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA3BADA8; Fri, 4 Nov 2022 01:45:13 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.3188103|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.0085301-0.000443442-0.991026;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047212;MF=frank.sae@motor-comm.com;NM=1;PH=DS;RN=16;RT=16;SR=0;TI=SMTPD_---.Q.GlfjF_1667551464; Received: from sunhua.motor-comm.com(mailfrom:Frank.Sae@motor-comm.com fp:SMTPD_---.Q.GlfjF_1667551464) by smtp.aliyun-inc.com; Fri, 04 Nov 2022 16:44:49 +0800 From: Frank To: Peter Geis , Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: yinghong.zhang@motor-comm.com, fei.zhang@motor-comm.com, hua.sun@motor-comm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Frank , kernel test robot , Julia Lawall Subject: [PATCH net-next v2] net: phy: fix yt8521 duplicated argument to & or | Date: Fri, 4 Nov 2022 16:44:41 +0800 Message-Id: <20221104084441.1024-1-Frank.Sae@motor-comm.com> X-Mailer: git-send-email 2.31.0.windows.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748555342370160790?= X-GMAIL-MSGID: =?utf-8?q?1748555342370160790?= cocci warnings: (new ones prefixed by >>) >> drivers/net/phy/motorcomm.c:1122:8-35: duplicated argument to & or | drivers/net/phy/motorcomm.c:1126:8-35: duplicated argument to & or | drivers/net/phy/motorcomm.c:1130:8-34: duplicated argument to & or | drivers/net/phy/motorcomm.c:1134:8-34: duplicated argument to & or | The second YT8521_RC1R_GE_TX_DELAY_xx should be YT8521_RC1R_FE_TX_DELAY_xx. Fixes: 70479a40954c ("net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy") Reported-by: kernel test robot Reported-by: Julia Lawall Signed-off-by: Frank Reviewed-by: Andrew Lunn --- Hi Jakub > On Thu, 3 Nov 2022 10:50:47 +0800 Frank wrote: > > The second YT8521_RC1R_GE_TX_DELAY_xx should be YT8521_RC1R_FE_TX_DELAY_xx. > > > > Fixes: 70479a40954c ("[net-next,v8.2] net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy") > > There's a spurious space before the Fixes tag, please remove it. > > The patches does not apply to the net tree: > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/ > > please rebase and repost. spurious space has been removed. This pach should be work on following commit in net-next tree. - [net-next,v8.2] net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy https://git.kernel.org/netdev/net-next/c/70479a40954c v2 change: -add "Reviewed-by: Andrew Lunn " -fix tag name (full legal name) -change PATCH net to PATCH net-next -add warnings info drivers/net/phy/motorcomm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c index c7593f224177..bd1ab5d0631f 100644 --- a/drivers/net/phy/motorcomm.c +++ b/drivers/net/phy/motorcomm.c @@ -1119,19 +1119,19 @@ static int yt8521_config_init(struct phy_device *phydev) switch (phydev->interface) { case PHY_INTERFACE_MODE_RGMII: - val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS; + val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS; val |= YT8521_RC1R_RX_DELAY_DIS; break; case PHY_INTERFACE_MODE_RGMII_RXID: - val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS; + val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS; val |= YT8521_RC1R_RX_DELAY_EN; break; case PHY_INTERFACE_MODE_RGMII_TXID: - val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN; + val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN; val |= YT8521_RC1R_RX_DELAY_DIS; break; case PHY_INTERFACE_MODE_RGMII_ID: - val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN; + val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN; val |= YT8521_RC1R_RX_DELAY_EN; break; case PHY_INTERFACE_MODE_SGMII: