From patchwork Mon Sep 18 07:56:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: marius.cristea@microchip.com X-Patchwork-Id: 141884 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp3369583vqi; Tue, 19 Sep 2023 06:07:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG5uJ5J0POsFTcjpDIeZBitW6VjPWZsDjzZbDQYbsAXMZBWXm17dXGS2PMorzo5CHu3A3rx X-Received: by 2002:a17:903:22d0:b0:1c4:5e9e:7865 with SMTP id y16-20020a17090322d000b001c45e9e7865mr8522311plg.0.1695128829163; Tue, 19 Sep 2023 06:07:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695128829; cv=none; d=google.com; s=arc-20160816; b=dWZjWtNT3qHVUJZW2EftWY1VqjmL5INSmvc93zF7afFlQzgkmtLI5tVFKkD/BEZKEe oma3nITeQ5tN1LVfEtjhM9cCjzLkD0II2GjCA8+mjqaTpanDrDN2AHTU0EcYX/XcxFhS fi8zSL7s0c/RrjAOMBPQhSfBCaBcJe5yvkinPAaI3yoOkDzk5c1OCE4C8+Toabj8lL6y lNyB8MZF4lWhBXCEm9s+AZdcWup/661VzhNAgJldbNbzeF/IpaC6R+7AmyvIhrblWA7o FYeca9zur4foMHF0YUgHToH8dbX70h/5zmiqMxCzb5T5sRljftK0a/FPhLDYDah9Y5h+ z7nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iro0HFYEhKIam+TkaWESv1bTWh30swlez4DvlnfsIDM=; fh=CfXnvszhvWuE28iJMeSRS+uCCoveCk+buAgXjq9mGdM=; b=OwFHBLpT2CJkBaEfQ2vBDSdb2OSZlNEZRU/dgY7A4AxxOsqafDtz5qG3iOEZ4GvJHW xRi3EtpJxl6bkCBglBltQNZ640MerEFXvtnW6MaZbE6mrsy6FZHZ/KP7q08xNiTvnn7v unBR6zIGfPtysdk8dm7YNfYuNwTtNbY7i6mTbxbOSSRmzAUKFul9tV+XdIWSdrhM2AwL RqxcuMU1Gz7L9xNETTaNYHUt+TpPsK2IVvbTnocNAPOL5cD4o4zJEjvHw76l0kPzrT2X 36xe61IMpqD2iexSy0yDmomHVk/0PJFqErtHKshbjCUPa+eYcZvX3K4L2/oZlVmLifmT /geQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=YTGn2j14; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id u12-20020a17090341cc00b001bbc61fedafsi10062721ple.422.2023.09.19.06.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 06:07:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=YTGn2j14; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D70F880781DF; Mon, 18 Sep 2023 01:01:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238268AbjIRIBA (ORCPT + 27 others); Mon, 18 Sep 2023 04:01:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231451AbjIRIA0 (ORCPT ); Mon, 18 Sep 2023 04:00:26 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7506D10DB; Mon, 18 Sep 2023 00:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1695023862; x=1726559862; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=v6+UfxWrGkPBnYKXPVlGoapzSwF/8Nn2Ixda6Z4JnQ4=; b=YTGn2j14K3+preZ3xXgGB5y2jE2u+hbirdetucdxtGDZXs60C0gD+dyz slfIbY962xs9GF2sE4rMlzBlc8lCxy7oCzwDZRFnA8AwjfTOOoiUImU5N oSG1qxrYVDUKddy3LA25FGUH3ujd0MH2R+ewxmCMa3//7HevdjymlnbFy ffkxSjshFmiMjERnvIgfLqKDsyS5m+uGF22wYwphcU7Q0SGpvKzCWlYQ5 XnQ7bQ+oFIUynAJ9dLP/bOZFalklWK/vXj3qNHtvHmNTyuUPdbmnOypRe kwpwoehmiXnq2k/1ix5+61PVJj1PO8AI3OPDKUgVgla8pb/Kxn/58jd1a g==; X-CSE-ConnectionGUID: 3kEnWZhoRDqFxJjdItUUdg== X-CSE-MsgGUID: DZpMbPIAQSmYF2DMMDBOOA== X-ThreatScanner-Verdict: Negative X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="5345921" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Sep 2023 00:56:45 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 18 Sep 2023 00:56:37 -0700 Received: from marius-VM.mshome.net (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Mon, 18 Sep 2023 00:56:35 -0700 From: To: , , CC: , , , , , Subject: [PATCH v1] iio: adc: MCP3564: fix the static checker warning Date: Mon, 18 Sep 2023 10:56:33 +0300 Message-ID: <20230918075633.1884-1-marius.cristea@microchip.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 18 Sep 2023 01:01:47 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777471407402157023 X-GMAIL-MSGID: 1777471407402157023 From: Marius Cristea The patch 33ec3e5fc1ea: "iio: adc: adding support for MCP3564 ADC" from Aug 29, 2023 (linux-next), leads to the following Smatch static checker warning:         drivers/iio/adc/mcp3564.c:1426 mcp3564_probe()         warn: address of NULL pointer 'indio_dev' drivers/iio/adc/mcp3564.c 1421 struct iio_dev *indio_dev; 1422 struct mcp3564_state *adc; 1423 1424 indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*adc)); 1425 if (!indio_dev) { --> 1426 dev_err_probe(&indio_dev->dev, PTR_ERR(indio_dev), ^^^^^^^^^^^^^^^ Fixes: 33ec3e5fc1ea (iio: adc: adding support for MCP3564 ADC) Signed-off-by: Marius Cristea --- drivers/iio/adc/mcp3564.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) base-commit: 22da192f43f7d302d02644efa192ba5a05d935c9 diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c index 64145f4ae55c..9ede1a5d5d7b 100644 --- a/drivers/iio/adc/mcp3564.c +++ b/drivers/iio/adc/mcp3564.c @@ -1422,11 +1422,8 @@ static int mcp3564_probe(struct spi_device *spi) struct mcp3564_state *adc; indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*adc)); - if (!indio_dev) { - dev_err_probe(&indio_dev->dev, PTR_ERR(indio_dev), - "Can't allocate iio device\n"); + if (!indio_dev) return -ENOMEM; - } adc = iio_priv(indio_dev); adc->spi = spi;