From patchwork Tue Sep 19 05:22:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Stitt X-Patchwork-Id: 141766 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp3233191vqi; Tue, 19 Sep 2023 02:05:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyrWynxD740Ayj8cxeaKyWwQHClNGDWTv5SgtqbXbIQ0S39HXV02nSipuRzz2iMfpTWsj7 X-Received: by 2002:a17:902:e551:b0:1c3:dbad:52d4 with SMTP id n17-20020a170902e55100b001c3dbad52d4mr13136684plf.33.1695114317657; Tue, 19 Sep 2023 02:05:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695114317; cv=none; d=google.com; s=arc-20160816; b=d8G27UGEcdkwOI4B2HemVHzcutqTqyBF93Hr61MXimUEAXi96dW1K3GhFNXPAwWuyb slSolRl4nSaNXOSQdP+ewqt2O/GfA6AJza6U98NX6SEoWpmAIzMsfWgBXF0Sk4KYOEVH heOhXfXa+LEAWnVb0klRv5ywNT99Ze7+m7GKdJFpH/szkZAygW9veTUnVOrZCbqCiJyC epHfHZfNWYOJPof48GlKXyZYrMzaI7FQHAcT34zts6tVMF5wKiYS9OLYQoj9cvco7QsO DyN/4x/iEk1G4PdIH49TOm2aD/k7UMY+KpUYiqvic+XgF+bX6jXgBattZpnbl/PXV5vy SZ3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=oNNrBnYfOYV0KaxSsoYAY7HFcM1nxRdVcxEdAxuQSek=; fh=CkmrD9n8Cj/ZdTD++gmNnHorDVlDG2KJXCNoXsZN5Fg=; b=leuB73O9jYIOqjxGtpNN8Q2uEOf5ZAC3xTh1Mry3eJJxf9BQPM92RT+AFefLWE3TP9 sng20HXjYUxP0TEl7yYSpD3vPqKPlNR+Xmwx5beluAjA5JGoj8a2neauPdKgiYE4DVHF UKjn53phiI+giic3vXKAqJV22bHLw/DZgldu1P0irkDtfehF45d15na+w/ICQx7z1OnP 5wETNFXkVX7S8w7jPPcmmXncvb6z7iETfzrV4WDNPRPwWZblWtV3Rf1YI4PJMU6JiN1m L33GvnToUnY4mg6TCk01ea7p/MSP7MXc7NpEBsHNSez2H5SuTKXbLg6VE94E/AwZLcuI GKdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=X+qwkmjr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id j6-20020a170903024600b001b9e31bda39si9958523plh.118.2023.09.19.02.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 02:05:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=X+qwkmjr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 5F0A48211401; Mon, 18 Sep 2023 22:23:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231137AbjISFXF (ORCPT + 25 others); Tue, 19 Sep 2023 01:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230430AbjISFXE (ORCPT ); Tue, 19 Sep 2023 01:23:04 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1900BFD for ; Mon, 18 Sep 2023 22:22:58 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-59bdac026f7so64673577b3.0 for ; Mon, 18 Sep 2023 22:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695100977; x=1695705777; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=oNNrBnYfOYV0KaxSsoYAY7HFcM1nxRdVcxEdAxuQSek=; b=X+qwkmjrE/m6Y3db1xSgyl7S3kPbEGcalxftA7fkNKww/+j3oG2nC+qCVDMT6/mseQ Wi6AhHSmeLIMc7GR9I4i2vlQAXVIksyrOvifL5k+byDfZcshn2JyFVtBTXdRy48tEyJm HpS/om+iLyrB18/P3Gwhpj3FZhNipILnVPUu/mkVvP5hOxdMuZJIRlYt7uC45Pf9AKtN zXHd64CMMOlzHC9kUzeupQCAeZDi2Cqqa5uN0Uy5ZH50Jgu8LNlXXcFVSAuHqgJOiNRe ZuD0NXROCCVTiXMWmaZ5+tbUuJJxrdtnfzWX7FGV7pSMM+PWpQgzaN3Ea2rgi026lxA1 930w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695100977; x=1695705777; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oNNrBnYfOYV0KaxSsoYAY7HFcM1nxRdVcxEdAxuQSek=; b=hWcKWAPnYkAuwrEZOAHZFvzvKQJ8aKwH84+zF2k2u4C2RddRiMnaDd53euWVQS0BHM ZR7JmGc71ZjsR9dAqcZQPPhYnq7CFsZnUCFwwR/k/IECuSY6L8YHtfGAd26Tizhi1ovA mgXnNaR27LFceNoFX4tez6FJD5HgX0u4yvfRnq9JR/EBZWunKK0lfzloAYWtJ5zbAdMx ioLYjyOb0Fee94HuwlEO3m3Km8qs04IEMnxSpP2FpG1PwBdSc1ussLNRAcKc6H9ofj4O 1vQz04eVO2LMs73v2Z4LbzEO7pGy9h/e0eZTUnzMM0fUqeB1um7PSGrjB/GZ2nOkotbj P+2A== X-Gm-Message-State: AOJu0YyCHcKlzEPXu8JVKY8S9zuHm1izLwpZ5G80bpc1I08RNLWag3i6 6uv9zEgzuWhaP4cC1q0YOPCHOlHpwKe2i6phrg== X-Received: from jstitt-linux1.c.googlers.com ([fda3:e722:ac3:cc00:2b:ff92:c0a8:23b5]) (user=justinstitt job=sendgmr) by 2002:a25:cbc3:0:b0:d07:7001:495b with SMTP id b186-20020a25cbc3000000b00d077001495bmr246617ybg.11.1695100977385; Mon, 18 Sep 2023 22:22:57 -0700 (PDT) Date: Tue, 19 Sep 2023 05:22:51 +0000 Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIACowCWUC/5WNQQ6DIBAAv2I4dxtAY7Un/9F4QFx1kwpmMVhj/ HupP+hx5jBziIBMGMQzOwRjpEDeJdC3TNjJuBGB+sRCS53LWhUQVnZ22aFnisgBpm32DqibF78 huwgWKmlkPqiyr3MjUmhhHOhzTV5t4onC6nm/nlH97F/5qEBBZ8ruMRTa1pVtRu/HN96tn0V7n ucXgTQnLdUAAAA= X-Developer-Key: i=justinstitt@google.com; a=ed25519; pk=tC3hNkJQTpNX/gLKxTNQKDmiQl6QjBNCGKJINqAdJsE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1695100976; l=1508; i=justinstitt@google.com; s=20230717; h=from:subject:message-id; bh=OAz/JRiRID2OTRUyttHDX/ZpXIkZrNearv6uLWj/7bU=; b=x26VBNt6hCJK6tE9iCypOq5ZUv1fkpkRwGDtfS8IE17RETDDR0O83LqmzEj+caTfyJBrLb4x5 WBI5kzz6P7aCpbLgI0Es1r5kYhqhQdKrtYkMYnrEgathKQdL8i+TK6m X-Mailer: b4 0.12.3 Message-ID: <20230919-strncpy-drivers-hwmon-ibmpowernv-c-v2-1-37d3e64172bc@google.com> Subject: [PATCH v2] hwmon: (ibmpowernv) refactor deprecated strncpy From: Justin Stitt To: Jean Delvare , Guenter Roeck , Michael Ellerman , Nicholas Piggin , Christophe Leroy Cc: linux-hwmon@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Justin Stitt X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 18 Sep 2023 22:23:06 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777456190581647445 X-GMAIL-MSGID: 1777456190581647445 `strncpy` is deprecated for use on NUL-terminated destination strings [1]. A suitable replacement is `memcpy` as we've already precisely calculated the number of bytes to copy while `buf` has been explicitly zero-initialized: | char buf[8] = { 0 }; Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Justin Stitt Tested-by: Michael Ellerman Acked-by: Michael Ellerman (powerpc) --- Changes in v2: - prefer memcpy to strscpy (thanks Kees) - Link to v1: https://lore.kernel.org/r/20230914-strncpy-drivers-hwmon-ibmpowernv-c-v1-1-ba6b7f42c98c@google.com --- drivers/hwmon/ibmpowernv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec change-id: 20230914-strncpy-drivers-hwmon-ibmpowernv-c-80a03f16d93a Best regards, -- Justin Stitt diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c index 594254d6a72d..70ca833259ab 100644 --- a/drivers/hwmon/ibmpowernv.c +++ b/drivers/hwmon/ibmpowernv.c @@ -234,7 +234,7 @@ static int get_sensor_index_attr(const char *name, u32 *index, char *attr) if (copy_len >= sizeof(buf)) return -EINVAL; - strncpy(buf, hash_pos + 1, copy_len); + memcpy(buf, hash_pos + 1, copy_len); err = kstrtou32(buf, 10, index); if (err)