From patchwork Sun Sep 17 21:45:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 141203 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2311879vqi; Sun, 17 Sep 2023 14:46:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyYx8XAdLttaWH98MfZEl8o+hBZ4S+HaNoRuNcFRHQQeISRes50hdx5/LXDm4XxDi84R+G X-Received: by 2002:a05:6402:34cf:b0:52b:db44:79e3 with SMTP id w15-20020a05640234cf00b0052bdb4479e3mr14106247edc.4.1694987206029; Sun, 17 Sep 2023 14:46:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694987206; cv=none; d=google.com; s=arc-20160816; b=PBsevrUPhq3swrfu74dRTGiYptwMdGVqUQ/5Gz+swVqgM+DpU8G5PCw6MHe4Answjf JZKWWTrk3KFmV9/NkuSoSIClJyQ4nDKOjBgr9gKYbmOqZ9CoB3azEGoI5ptMVCZgdbPd ni5eisANP009Jc/Em2mf8r0Wzvg7WSkyqkOuBxkY553GvCf4BTZSY+UgyjhTHOTwKEUH +glQhnH47qHo+5tVL18DNlLw4q8prJ/YoEEWZcvnW2efMIJtGGOI3LIOBXGNFFsUTxqF TLVW9nB+7w/Xbd+c5J7gSQUx3ueDlBDB1z+89AdFluvIsMtuDTcJI8KOOGMLEnnd1nJ0 cz/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=xVBSnolouCtqJiDzj/JiK2IBo9L0GIIa5ThEzc5uobw=; fh=XbcmRug6/SzczusyoNU1I7Lu5oY0AN2u0mWDzKoxdSs=; b=hCHlll4fEAMp0DOxye6l0S6vqsEuhmkIuUFzS4KeiLDMT3sHFEgy67x+oJWpjI4NpT H5n6eqxpMS1Kh8GzUvd9krsPvknuGDJIdtf43S79jOTjBNfM2u2r4sWHT54k667rXPVl 4HznMk9frFrWGWlaOBmo/HA6qmJjY0Herc6JM5b0tDcg3g5mP/U0E8TsIdwmhHSTPQpc 7bJ21/OlFBYXAvHuEPFglJZBNMXvT7lOdToNDa3AD4rLiKtJ3lzWhj/qWjS46c/CVUk7 bwLGGclxm6Afjo8dJYwGj08f5w8nQ8xV/xOMKk2aSwO4/GXmWwEwbWnKbWKSCC5ahku0 7vNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=KrPde43Q; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id r21-20020aa7da15000000b00529f5c6b3ebsi6736784eds.656.2023.09.17.14.46.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Sep 2023 14:46:46 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=KrPde43Q; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D6F51385840F for ; Sun, 17 Sep 2023 21:46:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6F51385840F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1694987204; bh=xVBSnolouCtqJiDzj/JiK2IBo9L0GIIa5ThEzc5uobw=; h=To:CC:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=KrPde43Qbc7p5bHKRj7EM7RDV7n6IUebgkKJDDuzeKSRrug0dqNTDLkJw7y2EmXsS MLGUS2g9t/2T9OQot3PKL0drOdoz/OiOadwvReuc6BDPxl6SYuYvuFhYLaHJeL+TQ6 XObyAQGoOX1U2dcx+KEGD//FI2EjmfZenRBuxTa4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by sourceware.org (Postfix) with ESMTPS id 85E2D3858D32 for ; Sun, 17 Sep 2023 21:46:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85E2D3858D32 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38HLWnpb003798 for ; Sun, 17 Sep 2023 14:46:01 -0700 Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3t59qptfs0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Sun, 17 Sep 2023 14:46:01 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Sun, 17 Sep 2023 14:45:59 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Sun, 17 Sep 2023 14:45:59 -0700 Received: from vpnclient.wrightpinski.org.com (unknown [10.69.242.187]) by maili.marvell.com (Postfix) with ESMTP id 8EC4C5C68F6; Sun, 17 Sep 2023 14:45:59 -0700 (PDT) To: CC: Andrew Pinski Subject: [PATCH] Remove xfail from gcc.dg/tree-ssa/20040204-1.c Date: Sun, 17 Sep 2023 14:45:54 -0700 Message-ID: <20230917214554.1753158-1-apinski@marvell.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: nj_1KUUP5PoMqtiKTUe47MPalgUSv48a X-Proofpoint-GUID: nj_1KUUP5PoMqtiKTUe47MPalgUSv48a X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-15_20,2023-09-15_01,2023-05-22_02 X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Pinski via Gcc-patches From: Andrew Pinski Reply-To: Andrew Pinski Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777322904659427679 X-GMAIL-MSGID: 1777322904659427679 So the xfail was there because at one point the difference from having logical-op-non-short-circuit set to 1 or 0 made a difference in being able to optimizing a conditional way. This has not been true for over 10 years in this case so instead of keeping on adding to the xfail list, removing it is the right thing to do. Committed as obvious after a test on x86_64-linux-gnu. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/20040204-1.c: Remove xfail. --- gcc/testsuite/gcc.dg/tree-ssa/20040204-1.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/20040204-1.c b/gcc/testsuite/gcc.dg/tree-ssa/20040204-1.c index b9f8fd21ac9..aa9f68b8b42 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/20040204-1.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/20040204-1.c @@ -29,8 +29,4 @@ void test55 (int x, int y) /* There should be not link_error calls, if there is any the optimization has failed */ -/* ??? Ug. This one may or may not fail based on how fold decides - that the && should be emitted (based on BRANCH_COST). Fix this - by teaching dom to look through && and register all components - as true. */ -/* { dg-final { scan-tree-dump-times "link_error" 0 "optimized" { xfail { ! "alpha*-*-* arm*-*-* aarch64*-*-* powerpc*-*-* cris-*-* hppa*-*-* i?86-*-* mmix-*-* mips*-*-* m68k*-*-* moxie-*-* nds32*-*-* s390*-*-* sh*-*-* sparc*-*-* visium-*-* x86_64-*-* riscv*-*-* or1k*-*-* msp430-*-* pru*-*-* nvptx*-*-*" } } } } */ +/* { dg-final { scan-tree-dump-times "link_error" 0 "optimized" } } */