From patchwork Sun Sep 17 14:47:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "juzhe.zhong@rivai.ai" X-Patchwork-Id: 141152 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2166259vqi; Sun, 17 Sep 2023 07:48:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGguJLs2uLVMo24/dFAmOTZSVQu7ut6b2M0Ny+FEOi2yvbAFfSRCIGrrH5zJf5St31lq/4b X-Received: by 2002:a17:906:cc56:b0:9a5:c957:ed4a with SMTP id mm22-20020a170906cc5600b009a5c957ed4amr5544863ejb.46.1694962111220; Sun, 17 Sep 2023 07:48:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694962111; cv=none; d=google.com; s=arc-20160816; b=e3N6LB/axwD6fFvFa8yTvDjyur7O+4u5b/ND59r6eb79uJokeFwh3abBeVnGMTExSB U6qX4oXFkmPD+CoNFuoocUx+Leo5KWB3EJyqn1MnCKv3GhjpDvcZhSVdxSw+f53L9TfL 8REeo1aW1+DdXv9lTMK20ESTCQSDZgevzXOsXdPMKhIg+Z9bO7wU94XLOPdijlcIEsQ8 SBFgX4+EbmZDC78eInsfQ1MKgCGMVyJXIsLHiB5vyHBQf+soKPjs7Djj0ywAVdkrjOrG UgemFyU98KIOEqieAxBXG6MFpWVZWrexQ7PmzL/EfIYAK45FC/NqHqJ1kDRVG/GfcybO Grpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:feedback-id :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dmarc-filter:delivered-to; bh=AW4Ney9JsK4REXChVlC/pWFRB1bRtN1ap9ZHVeUA6KA=; fh=Hxj0cw/2jAkyitv6gv3v4BQlApRvZwleU4172JThTNQ=; b=uSMwmyjwCMsb4skfbXtecrsu3n4UD8WNCikdNsGq/8ltco3/cVbHVHKJXBajP2ebtp gkDD5z3jzHb+yLzJIbZlZElQSkfS3GLjqaHZxqFRCGO9/eSeD7V+U6Pj259i6J3hZHfy SNPLKiuAuz4bhk7Jjd9gdex8PCQQYDwGkMjLp93P0L4UMQTqLs7k29jiaR/474ZggN6K P+wDWf+bMWIfWlPRfD8FsFmoEkQPselPlAbHx49HZDDn0lnXDEOv7IPmkxrGXtHaHutP d70d0mWqLdMkMMHTzNC9QXU8oVWpxfQ/s709eJffvJOK14CIN17dx/cujLtsqxkbDYHO /mxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id gt10-20020a170906f20a00b009ad869ac653si7066129ejb.1011.2023.09.17.07.48.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Sep 2023 07:48:31 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 585CF385772B for ; Sun, 17 Sep 2023 14:48:25 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbg153.qq.com (smtpbg153.qq.com [13.245.218.24]) by sourceware.org (Postfix) with ESMTPS id C3CEF3858D32 for ; Sun, 17 Sep 2023 14:47:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C3CEF3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp64t1694962072tb8bj00c Received: from rios-cad122.hadoop.rioslab.org ( [58.60.1.26]) by bizesmtp.qq.com (ESMTP) with id ; Sun, 17 Sep 2023 22:47:51 +0800 (CST) X-QQ-SSF: 01400000002000G0V000B00A0000000 X-QQ-FEAT: uGhnJwy6xZLV35tAme8bRlP6k2QTg7QUJMOJMFTFQ3/jP2/E0PXIdu/gwRi0W emXGf6Yx8fwz9JrBlgLXaxMZVilg1GI/zWq3lGhgtwNO9gj13uHQ9N4OpOpS4VcXBTyRJyB yqS7DN7OX0KyhPT0KL56M7ivzXMHxM4tdvRcmFKd5aDnlkGaBlPFg6UPkP+qSnHsf8KVaWO 7fFZAnsrSsFVGtKBvqwD5YN9qZ/lenMITSHpvD4gQNLERsNw4oJojmKagSwIlomxroBUlvm NUtp058BF69kyaiMiGqWWQbLMC8H6K0j+5Rx/606LonKt2KUVFIJ/E1aphwpw9T1446lyBM fL2ihZ6G7Mzbm0Ta05j3bpzi0VHZ+VsdKC9b1plUSWeeEuRrU2/APexIVlQ/CkQGtnPOxpd xF3i6T6tLnk= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 2566592848175719988 From: Juzhe-Zhong To: gcc-patches@gcc.gnu.org Cc: richard.sandiford@arm.com, rguenther@suse.de, Juzhe-Zhong Subject: [PATCH V2] internal-fn: Support undefined rtx for uninitialized SSA_NAME Date: Sun, 17 Sep 2023 22:47:49 +0800 Message-Id: <20230917144749.1032038-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.3 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777296590543930431 X-GMAIL-MSGID: 1777296590543930431 According to PR: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110751 As Richard and Richi suggested, we recognize uninitialized SSA_NAME and convert it into SCRATCH rtx if the target predicate allows SCRATCH. It can help to reduce redundant data move instructions of targets like RISC-V. gcc/ChangeLog: * internal-fn.cc (expand_fn_using_insn): Support undefined rtx. * optabs.cc (maybe_legitimize_operand): Ditto. (can_reuse_operands_p): Ditto. * optabs.h (enum expand_operand_type): Ditto. (create_undefined_input_operand): Ditto. --- gcc/internal-fn.cc | 4 ++++ gcc/optabs.cc | 16 ++++++++++++++++ gcc/optabs.h | 14 +++++++++++++- 3 files changed, 33 insertions(+), 1 deletion(-) diff --git a/gcc/internal-fn.cc b/gcc/internal-fn.cc index 0fd34359247..61d5a9e4772 100644 --- a/gcc/internal-fn.cc +++ b/gcc/internal-fn.cc @@ -247,6 +247,10 @@ expand_fn_using_insn (gcall *stmt, insn_code icode, unsigned int noutputs, create_convert_operand_from (&ops[opno], rhs_rtx, TYPE_MODE (rhs_type), TYPE_UNSIGNED (rhs_type)); + else if (TREE_CODE (rhs) == SSA_NAME + && SSA_NAME_IS_DEFAULT_DEF (rhs) + && VAR_P (SSA_NAME_VAR (rhs))) + create_undefined_input_operand (&ops[opno], TYPE_MODE (rhs_type)); else create_input_operand (&ops[opno], rhs_rtx, TYPE_MODE (rhs_type)); opno += 1; diff --git a/gcc/optabs.cc b/gcc/optabs.cc index 32ff379ffc3..d8c771547a3 100644 --- a/gcc/optabs.cc +++ b/gcc/optabs.cc @@ -8102,6 +8102,21 @@ maybe_legitimize_operand (enum insn_code icode, unsigned int opno, goto input; } break; + + case EXPAND_UNDEFINED: + { + mode = insn_data[(int) icode].operand[opno].mode; + rtx scratch = gen_rtx_SCRATCH (mode); + /* For SCRATCH rtx which is converted from uninitialized + SSA, we convert it as fresh pseudo when target doesn't + allow scratch rtx in predicate. Otherwise, return true. */ + if (!insn_operand_matches (icode, opno, scratch)) + { + op->value = gen_reg_rtx (mode); + goto input; + } + return true; + } } return insn_operand_matches (icode, opno, op->value); } @@ -8147,6 +8162,7 @@ can_reuse_operands_p (enum insn_code icode, case EXPAND_INPUT: case EXPAND_ADDRESS: case EXPAND_INTEGER: + case EXPAND_UNDEFINED: return true; case EXPAND_CONVERT_TO: diff --git a/gcc/optabs.h b/gcc/optabs.h index c80b7f4dc1b..4eb1f9ee09a 100644 --- a/gcc/optabs.h +++ b/gcc/optabs.h @@ -37,7 +37,8 @@ enum expand_operand_type { EXPAND_CONVERT_TO, EXPAND_CONVERT_FROM, EXPAND_ADDRESS, - EXPAND_INTEGER + EXPAND_INTEGER, + EXPAND_UNDEFINED }; /* Information about an operand for instruction expansion. */ @@ -117,6 +118,17 @@ create_input_operand (class expand_operand *op, rtx value, create_expand_operand (op, EXPAND_INPUT, value, mode, false); } +/* Make OP describe an undefined input operand for uninitialized + SSA. It's the scratch operand with mode MODE; MODE cannot be + VOIDmode. */ + +inline void +create_undefined_input_operand (class expand_operand *op, machine_mode mode) +{ + create_expand_operand (op, EXPAND_UNDEFINED, gen_rtx_SCRATCH (mode), mode, + false); +} + /* Like create_input_operand, except that VALUE must first be converted to mode MODE. UNSIGNED_P says whether VALUE is unsigned. */