From patchwork Fri Sep 15 12:55:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 140507 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:a55:b0:13f:353d:d1ed with SMTP id 21csp393500rwb; Fri, 15 Sep 2023 08:24:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGrTGHCAWZo2tb97WqHN8jt8lCXqv4fpmUuBH84e7HnZNZZqLpj2Z5hgpmXzlG73JbdW9u X-Received: by 2002:a17:902:ecd2:b0:1bc:8fca:9d59 with SMTP id a18-20020a170902ecd200b001bc8fca9d59mr2329320plh.29.1694791463434; Fri, 15 Sep 2023 08:24:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694791463; cv=none; d=google.com; s=arc-20160816; b=m7/9JE7TFUz9Bk+jmIN84gMWLYiN7BsP0HGPYdbBCasOOevCNDbxx02UI4/ToWYNl1 reu4t5nfZL2sN2RBWOeOXpdQOBkoqMZLNVNDVuScX4PJ6oQ0gqIPCwPKNZJRW4PErYvG umqySKbOUEGbd3a0Gwo7E4//YIeRvuPngfnn33H2D3h0BkcHFztzAgVo3VpfHvW3TnQC QzvccCW2TM5qmpN4muzgXxkjnRdajFNr1XXLgUNV+amiC6HLpLL7VxyaWFFodNp/0tXG EolLuoghvQYXJInJcYx5KZZGw+d0iK2qbyiQ4p59nDu4G72J02DWatmS4a2WkQcLqguT BXow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=m7EqKPxcYmhqUUSygv21qZ32ZU2BZ3oQxs47F0gcyJg=; fh=V2t7NuB92xvGikXCFPkDGMEPbSVvTlj5Usarr8L27O0=; b=FltrJKKQT2m6+CWCI/ls4Vtijkdt4blqVVEHww3uVbXayB1kruVYhpXCaJP9MgycKJ ad9XhPnzq5jeGtEPGSMH0IiBSW0PGHs19ADmTEuOsqMb4fvRFggvd+f+qqJojojcKIqq NQFfFSvlG8amj1JrRxUdtNcHzeH1lRpSi/GvJyTsmo06JN9qTW9evh0ffbjfBrJHftdE 1d2QxTwn5Ea3W1HBkep7hpkNJpF3jrBAufYYEgQ6QjniXhCesKDervXXGzfLhfpwh81V DfifGhh6D5t+e2Ozk/my0jEVh1FgaZp55vj4rOu/5dov0VLTQFlIMQfhrYY6fabqa8g6 ZFzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QPOSQVtk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id d1-20020a170903230100b001c224748a65si3626088plh.476.2023.09.15.08.24.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 08:24:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QPOSQVtk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id C551E8094778; Fri, 15 Sep 2023 05:55:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235161AbjIOMzx (ORCPT + 32 others); Fri, 15 Sep 2023 08:55:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235139AbjIOMzv (ORCPT ); Fri, 15 Sep 2023 08:55:51 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 762F01BEB for ; Fri, 15 Sep 2023 05:55:45 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-401f68602a8so22780485e9.3 for ; Fri, 15 Sep 2023 05:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694782544; x=1695387344; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=m7EqKPxcYmhqUUSygv21qZ32ZU2BZ3oQxs47F0gcyJg=; b=QPOSQVtkQ4WGiENEJdIkRA5ESI2hotgNjGg76vwqM8yjmNIjgXT6Rz/ZTm8pzKq5/q LYWEkvB3Cu/wl876W7dBzp/7p0kY0AaZYr7PIBVicum3JCHV8dPK0rxos00Mym5YFrk5 aeWjQCiiI9+DJxZSCJ2RGdO0/9y3fGxuMl5OE27+N2yAnaygCXTKanG+hPTGx7w2bGqZ PFwYb9mSvIozJMg60Bd4XcZ4OlFdwlec53eMk89riR+q/Q5Bc+xSayE9H6FoqClJ36Lo WGRhazGk4+hVoKEDBUuRqEQ45hv14ogWcDLwt2ecXy3vSeQeGDkhwqPNtp1eGGGbyrES x/AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694782544; x=1695387344; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m7EqKPxcYmhqUUSygv21qZ32ZU2BZ3oQxs47F0gcyJg=; b=NumR6yxMzLpYd0ITnDjuvS6evXVt3ad1MjKEnqEEIy++VXAsFU+1Ba4oY/52j5HCgD NFEbly1FJPNN1eM1LVos7ObdOdQuc4QS/iETUvUcAY0jMR1jat3hHHauCMKI3MbheQP8 QZNWdjahmgi4PJNRIwWDrYafimO5VBxXAkgszhjeF9fjvOUHBRZgHwA07NedXxG++/Yw 53t7tw/JuuYnFXJWXjCcPqAVhf/lV9DMbk0RP87F4sFN6wsKzSWttkkLt0luOc3dApZq PsBnvtwLxUYXPIPobuvgEP74IGzBeNNUDEDMpXiOwLVmSDi5B0ud2cCcq6sD0qSFi2Wf O6LQ== X-Gm-Message-State: AOJu0YwDLXcHyArAY4ebl5C0BNx+myjvAWGFjFfjIGJ4QJtfdDZypcqX Vrzh7vQaxORg0wT1mi54MpytEg== X-Received: by 2002:a1c:ed19:0:b0:403:bb04:2908 with SMTP id l25-20020a1ced19000000b00403bb042908mr1359308wmh.23.1694782543945; Fri, 15 Sep 2023 05:55:43 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id r10-20020adfdc8a000000b0031aeca90e1fsm4408590wrj.70.2023.09.15.05.55.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 05:55:43 -0700 (PDT) Date: Fri, 15 Sep 2023 15:55:40 +0300 From: Dan Carpenter To: Kent Overstreet Cc: Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 1/2] bcachefs: acl: Uninitialized variable in bch2_acl_chmod() Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 15 Sep 2023 05:55:56 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777117653026600470 X-GMAIL-MSGID: 1777117653026600470 The clean up code at the end of the function uses "acl" so it needs to be initialized to NULL. Fixes: 53306e096d91 ("bcachefs: Always check for transaction restarts") Signed-off-by: Dan Carpenter --- fs/bcachefs/acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/bcachefs/acl.c b/fs/bcachefs/acl.c index 9653401957b3..6b1579e96dfe 100644 --- a/fs/bcachefs/acl.c +++ b/fs/bcachefs/acl.c @@ -417,7 +417,7 @@ int bch2_acl_chmod(struct btree_trans *trans, subvol_inum inum, struct btree_iter iter; struct bkey_s_c_xattr xattr; struct bkey_i_xattr *new; - struct posix_acl *acl; + struct posix_acl *acl = NULL; struct bkey_s_c k; int ret;