From patchwork Thu Sep 14 23:21:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Stitt X-Patchwork-Id: 139896 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp685329vqi; Thu, 14 Sep 2023 16:22:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNA0SnQLXuH30d8nWuJu83g45c3MJDFotO7UO2HpclnWCzpRPdFdaFn82ZY+cyltOEsJvr X-Received: by 2002:a17:903:228b:b0:1c3:3cde:7b44 with SMTP id b11-20020a170903228b00b001c33cde7b44mr88054plh.12.1694733724018; Thu, 14 Sep 2023 16:22:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694733724; cv=none; d=google.com; s=arc-20160816; b=w0BwADW5JuAvGXnhrfEMeXFB0XvMRkiJ7vS79SpDk4e3T4G7ZRYRwem1DsPb50uXzX WX2iEb9glNXTqPR1VfGaAqsn7Bejo8pX5aT4TExUd/ULL4uZru1LZSOc/HFo9IMq78Kw 5JwqCeGERyeepm4BtaKTYR491ziHMPDtU0b3pLlMn5TwdPKBjmsd2G+P9v2Nj1g08+7r PvPO4gPDT+s1Mb73Ps+hUBsHsyOqMkaOPmvyIF7IVhrTBhjcg99cwtmlJe3n0F0kI9rZ PP/EBIoi88fA67FvcpO11ZU3IFvQnFZdbMm50kqtqI09TZssYnhH4CzNeJUyb4qHNTH5 DA3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=K4BixPSI6K4mFdvHjP22A4GYUb6n9IBpB9f1xvsMH7k=; fh=CkmrD9n8Cj/ZdTD++gmNnHorDVlDG2KJXCNoXsZN5Fg=; b=jP0RaqOML1BQjIreQoUC55TPiDWO0+4og81GGee38ZKo28YC8XNIvDePxwHtG/qWkL 5M9xj4VXh2J/831XbyQ+37TU4PJh2HrNt2QKmDUKQsw5NkMo9pGgUVW4AZM3UMI1tzzv 219ZjVq+MhN1+iJA4MORTPojFs7kSCghfPjP0blbD4OYApESK8A1+2+2UItRnccyJNxE DiipP5XSlmUgMoFt52HDTO4lBa/YU6K412kzr2Ctp0kGtDeJPLtwXFUQDiiX96MFmpWJ 8RPwp01Ri7IOFd7t+nphVNcHJtA/DeL4lweCgpiDkAg8zui08HtIvZToGk1VtKDaUvcV fnYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=e0wVhOi6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id kg14-20020a170903060e00b001bf0e15c0a9si1549857plb.269.2023.09.14.16.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 16:22:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=e0wVhOi6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id E73E7836FFFB; Thu, 14 Sep 2023 16:21:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229499AbjINXVN (ORCPT + 33 others); Thu, 14 Sep 2023 19:21:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230086AbjINXVM (ORCPT ); Thu, 14 Sep 2023 19:21:12 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E8B41A2 for ; Thu, 14 Sep 2023 16:21:08 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d8186d705a9so1807347276.3 for ; Thu, 14 Sep 2023 16:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694733667; x=1695338467; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=K4BixPSI6K4mFdvHjP22A4GYUb6n9IBpB9f1xvsMH7k=; b=e0wVhOi64Sny8sVdEfpPEtHTV/fR9FWnHmeddV0l9GMAD+uWOLQ28c5NA2LLbelWZY rnSuVIGuyPLYM6dYp90NOGyrr6qG541NgfPOuZO765/WJ3rsMCYKo4jUVYAOM3yEQGQM cwpQOaO09fXWFN93J+x3cO9Z5TTOLUE1TjySdUwTv3XJvyY7Sf+gFZ1e3afS52AAN3/l 1o11N5J32JJ6k9M1h4uruNR+DBitlOaY66wwqf/zldspxmv2tLR1EFXPR++PShcg8aRt FSHYYjlh0JXoo+eqNl/jA3+vdsad+Tl0x10pcaUMtUy5Ilzkf5s9dTfE83UZIbg/mBqG +cQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694733667; x=1695338467; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=K4BixPSI6K4mFdvHjP22A4GYUb6n9IBpB9f1xvsMH7k=; b=XFF+p7DWG9x8HzOYugHBAZ3OGwH4rgBVn38Er987Mn1OSCH9+L9syt8cEfsHhLHN2z eByrC4Z4vGbUc5eywfFNiTX4CkTANnlC1qt1x54eer9/8iFv3FwX4ehCxNJo73nQtMkC UQ8qUawU4l/bXeQkKCcBDXod3z2fcJiWK4z47+/7pXNXmwmWV09FJtJz8V1Jmpbx3gG/ 2KePy3S3GSgdLHq2f1ssVTAEhck1cIoyfnOtIxliPwGlQS/v8V+7k3GSWME16We+kjqx aSq91EUDrXcl5FhPD38mHl+3l9dOwvDz/gY3vDzIYjkUl04lKZ7iHKuRzXvSqbSBu1wE NDTQ== X-Gm-Message-State: AOJu0Yxx/SSHtk4BPttY+SAo5KLIbkwz8nLzx8FXuIY+9sUSknZXDpqu P8p62vsNvI9qTau+0XK6anjCvXbB8RmL22/p7w== X-Received: from jstitt-linux1.c.googlers.com ([fda3:e722:ac3:cc00:2b:ff92:c0a8:23b5]) (user=justinstitt job=sendgmr) by 2002:a5b:cb:0:b0:d05:98ef:c16b with SMTP id d11-20020a5b00cb000000b00d0598efc16bmr208490ybp.5.1694733667417; Thu, 14 Sep 2023 16:21:07 -0700 (PDT) Date: Thu, 14 Sep 2023 23:21:06 +0000 Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAGGVA2UC/x3NMQ7CMAxA0atUnrGUNAhRroIYQuJSD3UiG6Wgq ncnYnzL/zsYKZPBbdhBqbFxkQ5/GiAtUV6EnLthdGNwkz+jvVVS/WJWbqSGy7YWQX6utWyk0jD h1UUXZn/JU4jQQ1Vp5s9/cn8cxw+ObRsDdAAAAA== X-Developer-Key: i=justinstitt@google.com; a=ed25519; pk=tC3hNkJQTpNX/gLKxTNQKDmiQl6QjBNCGKJINqAdJsE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1694733666; l=1418; i=justinstitt@google.com; s=20230717; h=from:subject:message-id; bh=EQqFhuW6eyqVcI+2qvkN1RrCgJ3Q+ZXalbGWG4ulzH0=; b=zl7/VHFqVwFRJkvIBYDgTR3z8vsBLvP/9HPrgIpXao92oev7YfIZMtLc+vTpq3+YfxHy/8tSV gQhyQ2VQBRIAJjn6FVAwdCVZDDTwvbnJgKbwaEimBGIqyZmsAX2qbOq X-Mailer: b4 0.12.3 Message-ID: <20230914-strncpy-drivers-hwmon-ibmpowernv-c-v1-1-ba6b7f42c98c@google.com> Subject: [PATCH] hwmon: (ibmpowernv) refactor deprecated strncpy From: Justin Stitt To: Jean Delvare , Guenter Roeck , Michael Ellerman , Nicholas Piggin , Christophe Leroy Cc: linux-hwmon@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Justin Stitt Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Sep 2023 16:21:27 -0700 (PDT) X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777057109443066100 X-GMAIL-MSGID: 1777057109443066100 `strncpy` is deprecated for use on NUL-terminated destination strings [1]. We should prefer more robust and less ambiguous string interfaces. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on the destination buffer without unnecessarily NUL-padding since `buf` is already zero-initialized. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Justin Stitt --- drivers/hwmon/ibmpowernv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec change-id: 20230914-strncpy-drivers-hwmon-ibmpowernv-c-80a03f16d93a Best regards, -- Justin Stitt diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c index 594254d6a72d..57d829dbcda6 100644 --- a/drivers/hwmon/ibmpowernv.c +++ b/drivers/hwmon/ibmpowernv.c @@ -234,7 +234,7 @@ static int get_sensor_index_attr(const char *name, u32 *index, char *attr) if (copy_len >= sizeof(buf)) return -EINVAL; - strncpy(buf, hash_pos + 1, copy_len); + strscpy(buf, hash_pos + 1, copy_len); err = kstrtou32(buf, 10, index); if (err)