From patchwork Thu Sep 14 21:29:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 139852 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp636190vqi; Thu, 14 Sep 2023 14:29:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAHKddJQ/stjh4cRXBXiyxAKPbFkGFJ9p7UCviGVTepHisKgm1Kig9D1kkoJAY2wT4ITf6 X-Received: by 2002:a17:90b:4c04:b0:273:f848:7da2 with SMTP id na4-20020a17090b4c0400b00273f8487da2mr6442993pjb.45.1694726974019; Thu, 14 Sep 2023 14:29:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694726974; cv=none; d=google.com; s=arc-20160816; b=VcxR2EcEa5DL7SNhFDF4Ewazb26iEqfLloBUoX1OtoXkXsri91TxC6TSHeLXiM8YNa +pPfF5REPa57+JajwBl0liA9meMslzIBva6GrJ5KUfO3mjHuoo9lGCS81e9uerjCcA9V JD9Wbssr2VgXT8i/ZVvj35AiOZ5rtX4k4eENodQkjxhEoU7DLCX8iKG/QgiKMHRhkcZy YnXN0a2UixdPI3Qdgzlp/q3Qp9LwOsrclGQwkNHxorROVDu1ynGc0WyT0YpcnNInlflf eU6igcXY2j60Zia9VXDEbFdvf4NZs2jj8rVMrs4wGul11YFb3Vjj0NcLG4BoTsBZ+E3h 6Mpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=e2MNcJrIOhJvdP7QE/S9suQvgf4vlHqpnYxoXfK0aWI=; fh=4V/qK/gupyips+5MiOvnl+k0n/b53gX3U+/awBrA61o=; b=pZlThftZ+ePr4Ir3VRx+9Yz2glQcJaJw/RYAp+GP5deJnRI64tZ20nzBdVNqlhsRCy QqS8UcO3xKuj6dd0wz5WgnyKmolyfMDkjCGvE6QxtbL0c/p+DCg7aNrV5V1Ys/Ipdn0K Ao4N/jM6R/8xUddKUorAprHjdMQDD8po1NNjJERdTY0uI8Zj86npKQLzAT5Ed0U7WD47 rbOBc9Sqr5IfdgXt4TTIxgUOEClja0mP/C6z2yO9u7c45wFMOniGiV0JGhbiDyx6jSNw 9Slch1Ipe2AK/8U3wuZgPbzfLxdoa+utKSD67lmuXVKMFKPMB/OE3aRTycJk/IbZD2tA auQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=MXB3N8iV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id q12-20020a17090a2e0c00b002736ff3cc79si4192567pjd.23.2023.09.14.14.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 14:29:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=MXB3N8iV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id CF3AF837B5EC; Thu, 14 Sep 2023 14:29:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229561AbjINV3N (ORCPT + 33 others); Thu, 14 Sep 2023 17:29:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbjINV3M (ORCPT ); Thu, 14 Sep 2023 17:29:12 -0400 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 101B01FD2 for ; Thu, 14 Sep 2023 14:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1694726946; bh=BV4XLAX1qRKE3joosWKkdrstGC2Xef+ew4wOGJWVraQ=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=MXB3N8iV8fS/QGP7iFxr4/TBKCnOBXtW/For8X4ZgL1ZvyTubd5UHQHDUcbVQWVD5 TERE2lBRizgX1mSjo9pyq6StmgkLVxsy1WX+APGm7Dj4BDpG3LTlmKrCbnleRgcmPL hkUqfyWh9JBengT1g5CtJ/A77X02zeQTuQollVeo= Received: by b221-5.in.mailobj.net [192.168.90.25] with ESMTP via ip-20.mailobj.net [213.182.54.20] Thu, 14 Sep 2023 23:29:05 +0200 (CEST) X-EA-Auth: OlP37/JzYx+th6M9PN5TMQDxD5U3rvxw4B/X0nxXCCiTZeq+s7qGkiiORs2Pi13LH5cx3wSKmFm8RAU0ykmSe2U9dLGW9MI7 Date: Fri, 15 Sep 2023 02:59:02 +0530 From: Deepak R Varma To: linux-kernel@vger.kernel.org, rostedt@goodmis.org Cc: linux-kernel-mentees@lists.linuxfoundation.org, ivan.orlov0322@gmail.com, skhan@linuxfoundation.org, Deepak R Varma Subject: [PATCH] tracing: Fix minor typos in samples header Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Sep 2023 14:29:31 -0700 (PDT) X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777050031904530973 X-GMAIL-MSGID: 1777050031904530973 Following minor corrections in the comments section of the trace events sample header file. - There are 6 parts of the TRACE_EVENT macro instead of 5 (name, TP_PROTO, TP_ARGS, TP_STRUCT, TP_fast_assign, TP_printk). - The example variable for __field_struct type should be the variable name instead of the variable. - Improve closing brace alignment to improve readability. Signed-off-by: Deepak R Varma --- samples/trace_events/trace-events-sample.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.39.2 diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h index 1c6b843b8c4e..551ecad212c8 100644 --- a/samples/trace_events/trace-events-sample.h +++ b/samples/trace_events/trace-events-sample.h @@ -61,7 +61,7 @@ #include /* - * The TRACE_EVENT macro is broken up into 5 parts. + * The TRACE_EVENT macro is broken up into 6 parts. * * name: name of the trace point. This is also how to enable the tracepoint. * A function called trace_foo_bar() will be created. @@ -93,7 +93,7 @@ * * __field_struct(struct bar, foo) * - * __entry->bar.x = y; + * __entry->foo.x = y; * __array: There are three fields (type, name, size). The type is the * type of elements in the array, the name is the name of the array. @@ -410,7 +410,7 @@ TRACE_EVENT_CONDITION(foo_bar_with_cond, TP_STRUCT__entry( __string( foo, foo ) - __field( int, bar ) + __field( int, bar ) ), TP_fast_assign(