From patchwork Thu Sep 14 01:06:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 139268 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp78546vqi; Wed, 13 Sep 2023 20:10:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEv3HOE++uexv1trnRp9wThdIpsOavTj9BGCj/vziu66qIgKCN77VUMvSIfzIInuOaSKhd2 X-Received: by 2002:a17:90b:3ec8:b0:261:2824:6b8c with SMTP id rm8-20020a17090b3ec800b0026128246b8cmr896331pjb.13.1694661058711; Wed, 13 Sep 2023 20:10:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694661058; cv=none; d=google.com; s=arc-20160816; b=jnUFpqXrfKuGuXqGxc2uYx1U4gcr8vFg2MeeMHoE5FQFwaxLLgzKYDS/9rwCcZejMo +HLYw7lYoFeZvv8ig+a0mOzH5tM8btBdS4G5kfNq9q/E3/n+RX36iw/4ZylePavrs1E4 LhHgdUwG2yZaL+biDxF/aMlmhkUpDpYB5xqCLVGH+oMZb2JvPyS0O8Ro0MwDTWk9Qx3l mHTyXeOYZ5nrJuq0drfnTTz5s6Y3nA81ZvUw6HYEVanbzF+C6XPFz9lJnNwqu/rznjWb l7b+pn+hC9kVCY7t50Xi/XVI1UjQev5+e5mruU1jnprprGg/Nb8r15Pl9vkpY/1xyEQ4 FisA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:from:subject :message-id:mime-version:date:reply-to:dkim-signature; bh=2k/uDSMMkxzMgxotysOQ1I84LqRn/bUax7yAixLpqCc=; fh=Jza7gkaAxpkPKiMJfFCjT8gng7ET82+P1m5QEsatQEw=; b=hjOhBFshqMPwakFfl9vLNd0BMwyT+DOlLJVxUBvGZUGykMrKOR+VDRkM46drZ8uf2T FVZV1Oh0GGEfugGiFAE5wN22FGwQQxdZW0tIpK5wBKPpja8QklVduY6QIf1sIYgFLP2C PChKpzxpuk0B5HnF9owxw3OqqARpBgVYEFn8oVmTssAsYZXP42dP/sgpt3n9+RD7r3C+ yqDZyXRBCDKyG4wqwogERwKy1fgg0coK8E9DxDfm+GD08/nSu35d4880zL996eusT9WB qY/mluIlRVicNE2qfq3h5ACtvCzYszC2jYKN1X0LXnMOtH+kZoUTPtFttINbBItI4TCL LLgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=lzYK9szf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id kk10-20020a17090b4a0a00b002683fd38fd4si808918pjb.31.2023.09.13.20.10.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 20:10:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=lzYK9szf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 314E980DBAC4; Wed, 13 Sep 2023 18:06:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233345AbjINBGq (ORCPT + 35 others); Wed, 13 Sep 2023 21:06:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233350AbjINBGo (ORCPT ); Wed, 13 Sep 2023 21:06:44 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51F721BCE for ; Wed, 13 Sep 2023 18:06:40 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d81503de9c9so548468276.3 for ; Wed, 13 Sep 2023 18:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694653599; x=1695258399; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id :mime-version:date:reply-to:from:to:cc:subject:date:message-id :reply-to; bh=2k/uDSMMkxzMgxotysOQ1I84LqRn/bUax7yAixLpqCc=; b=lzYK9szfFMR/skBd7EWiGnbfbrK7oawEVT3fgrS0+WZI56uBIdqMjTSFIzVDfbcgDu yUqXnMmAMaydCDSaQ/E5y+yJHqxUdIcyyqZHslmastkKAXef33nc2eeW6F6aTsHUXY/d iyHvVkFxKTtb36aIvb+ztzAJYeA9ZOCTvthq8rnh2JFeX1AY0ueijqjNFGF2fI7hfAPX eGu/3AWXCPNcajNEpTypoiywkCDhlpvgSTeE0nVv1NkBYedoevVFQBhP9PahRbwUOq0d ezO9gyeo8Qgi/RrrY8hCEpUUEx7s8VZSAqmgzJ2yqL9FXUNcsMqHe7A2ke7BI+QwDKqZ dZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694653599; x=1695258399; h=content-transfer-encoding:cc:to:from:subject:message-id :mime-version:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2k/uDSMMkxzMgxotysOQ1I84LqRn/bUax7yAixLpqCc=; b=jGLh6QE7TXGQUqGhphVefWKG81Wvl0Sa2qvY0JnrNNonfJ9Ou4FpWILI4D9IqSG7R9 HJncM/GGPmyoUycXuMOG+TbtlEEsR2Pcr9+NKiD8GP04Ngp+4gYKFzaA9z8sHmAoFtkZ +9G2BTTmFsSyVwJT8qqIi3dFDs7585ynkNk/6YM6LYx1Eobq7ciMAgYSXfwvrGZ+uMaC Vo7ByOX8jbtyJOvOuRx/pp60k5Xl1Q5JcsfIXLHEmA7mlhvPnC4k/s5vLUZIVnBhqz/F HxStl7/6lfksWvovK0sewqnWLiEGeyMvCn60/c0d5eoBMNA0c9CnZEDajB2nObyCTvcj bMGg== X-Gm-Message-State: AOJu0Yz3XmqCz6QiHT1G0aUG/5JkL8LIhv2N87JSH/7jS5q6T1Is+Iye D3jZVa/TmBSKHgAfWbxhoLToAvUxl4M= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:1816:b0:d0e:e780:81b3 with SMTP id cf22-20020a056902181600b00d0ee78081b3mr101657ybb.2.1694653599563; Wed, 13 Sep 2023 18:06:39 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 13 Sep 2023 18:06:36 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.42.0.283.g2d96d420d3-goog Message-ID: <20230914010636.1391735-1-seanjc@google.com> Subject: [PATCH] KVM: selftests: Assert that vasprintf() is successful From: Sean Christopherson To: Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Jones , Haibo Xu , Anup Patel , Sean Christopherson Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Sep 2023 18:06:52 -0700 (PDT) X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776980914178421876 X-GMAIL-MSGID: 1776980914178421876 Assert that vasprintf() succeeds as the "returned" string is undefined on failure. Checking the result also eliminates the only warning with default options in KVM selftests, i.e. is the only thing getting in the way of compile with -Werror. lib/test_util.c: In function ‘strdup_printf’: lib/test_util.c:390:9: error: ignoring return value of ‘vasprintf’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result] 390 | vasprintf(&str, fmt, ap); | ^~~~~~~~~~~~~~~~~~~~~~~~ Don't bother capturing the return value, allegedly vasprintf() can only fail due to a memory allocation failure. Fixes: dfaf20af7649 ("KVM: arm64: selftests: Replace str_with_index with strdup_printf") Cc: Andrew Jones Cc: Haibo Xu Cc: Anup Patel Signed-off-by: Sean Christopherson Reviewed-by: Andrew Jones Tested-by: Andrew Jones --- I haven't actually run the relevant tests, someone should probably do so on ARM and/or RISC-V to make sure I didn't do something stupid. tools/testing/selftests/kvm/lib/test_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d diff --git a/tools/testing/selftests/kvm/lib/test_util.c b/tools/testing/selftests/kvm/lib/test_util.c index 3e36019eeb4a..5d7f28b02d73 100644 --- a/tools/testing/selftests/kvm/lib/test_util.c +++ b/tools/testing/selftests/kvm/lib/test_util.c @@ -387,7 +387,7 @@ char *strdup_printf(const char *fmt, ...) char *str; va_start(ap, fmt); - vasprintf(&str, fmt, ap); + TEST_ASSERT(vasprintf(&str, fmt, ap) >= 0, "vasprintf() failed"); va_end(ap); return str;