From patchwork Wed Sep 13 12:41:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 138793 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp1075045vqx; Wed, 13 Sep 2023 06:11:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFkeJksJTBTcoNy+IhFN9WDkgT6/vQj2q9GpMemh45X1+ymTgayB6joefHTeLShsniG01r X-Received: by 2002:a05:6a20:3d92:b0:13d:ee19:7727 with SMTP id s18-20020a056a203d9200b0013dee197727mr2922794pzi.18.1694610678930; Wed, 13 Sep 2023 06:11:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694610678; cv=none; d=google.com; s=arc-20160816; b=aWi9bODKIOoQywTq+CK74Tfc4O5l2cM05VR0NRvIdhWjc4kSrylxCPj2jDju5TU/zq hfVaU8oUiOScmqwPXm86vh6gCx+DE0T5Tv5hyNB8g/q1QT/z8DnEoJ6c1u3wOK4XD0yN 5poEtonAgi7/HF1nW6v07lLLEoa7mBj9mIGJvV1sUt0MpFiiW0MuVl+1GjonQ/zX7idJ oPDoU/bNW+EFFT5ktVMPbtD5wbj8p7hEYdo6hqDqAn/9yxDI58yjEq6X3hNk8B7tl+au kPiiitusArkqIwlLKm3MKhGExcx6khNbaDg6EQaf+j7MA4ij4q/+bA6w9S53ifF3T927 Y6RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5wxY8Nr+doltqsjCVZrdmRVbVQCeH272LkSanWkW4jM=; fh=/bEltA5TsfQD0z7SkE7BBk6gL9u1eCtf0/uZ9slV6IM=; b=S8udRKfCR1XxUnTifsgXA7CSyUoY8LmzVxmIKg6Qe6uuIhkrxOIQCHBuehqXwXbVyh cDjEJA5fq02ipsL6yGGcv2NWwVWS+0DsCAOJMzE3unTJOKw3Mo0kTaYOI1m5G7YBzBqJ GGhjFQQmmNNwB4zlcLmeuGSe7AJZcb8YytWHBRrsdebDWxB41FMmDIVAqSuw+TgwNAA6 D6IeygoEdkpLdGariUSh3+G0VM4QNRvdBC3bZ5+5WmseHARHAjFKNGxdSkG2tfoDEgdS /PbsJ54XHtut8Ejc4rWuV9Yd+8pGCj8c0BjTl0fSrPeODiKJa+1UcrmCeqLMzMNDeVfb yY+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=flu41bUC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id r66-20020a632b45000000b0056482047ae0si10150576pgr.723.2023.09.13.06.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 06:11:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=flu41bUC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 6F6F08050601; Wed, 13 Sep 2023 05:42:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240515AbjIMMmK (ORCPT + 36 others); Wed, 13 Sep 2023 08:42:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231132AbjIMMmJ (ORCPT ); Wed, 13 Sep 2023 08:42:09 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 384DC19B1; Wed, 13 Sep 2023 05:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694608925; x=1726144925; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IvFLjYsEpiHrR+BQ0j+mSxRo0C5kF8/dWX+/TG66kjI=; b=flu41bUCRPBzBG45zGVW6uuxROm9dYbNiAYir9Za81esHg2vkvIlvy0B MRjMbSHEd1lRzOJwLT9ukXANDnqxckjaYGbHoYbGty8zDUPdExZb9ihMg IfpnvoBfjTbvbAl+F7LF46k7JFAOZOISUDWsXes1k+TszwebSFxkCc6o3 3qwZ50X9aNZDFGwmrX7ZEuPhuCikCJ2+PKFJ1GH4aZ2Fu4mK3FA0Bq5mM 9XfZj9zcAbgfFTcmoC23rqJH5OXK90s6z+YBmoDgV3mE3JKxQkGGi1CGz B8KfyrYVmao/2joAPe77I1XZDdf9c+aDlmxfXtuJ7LzQpyHFHSWkYLH5u A==; X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="358918745" X-IronPort-AV: E=Sophos;i="6.02,143,1688454000"; d="scan'208";a="358918745" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 05:42:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="867775703" X-IronPort-AV: E=Sophos;i="6.02,143,1688454000"; d="scan'208";a="867775703" Received: from pakurapo-mobl3.ger.corp.intel.com (HELO ijarvine-mobl2.ger.corp.intel.com) ([10.249.45.213]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 05:42:01 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: Fenghua Yu , Reinette Chatre , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: =?utf-8?q?Maciej_Wiecz=C3=B3r-Retman?= , Shaopeng Tan , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 1/1] selftests/resctrl: Move _GNU_SOURCE define into Makefile Date: Wed, 13 Sep 2023 15:41:53 +0300 Message-Id: <20230913124153.32077-1-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 13 Sep 2023 05:42:28 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776928087534588654 X-GMAIL-MSGID: 1776928087534588654 Currently, _GNU_SOURCE is defined in resctrl.h. Defining _GNU_SOURCE has a large impact on what gets defined when including headers either before or after it. This can result in compile failures if .c file decides to include a standard header file before resctrl.h. It is safer to define _GNU_SOURCE in Makefile so it is always defined regardless of in which order includes are done. Signed-off-by: Ilpo Järvinen --- tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/resctrl/resctrl.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile index 5073dbc96125..2deac2031de9 100644 --- a/tools/testing/selftests/resctrl/Makefile +++ b/tools/testing/selftests/resctrl/Makefile @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 -CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2 +CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE CFLAGS += $(KHDR_INCLUDES) TEST_GEN_PROGS := resctrl_tests diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h index 838d1a438f33..eff178befe4a 100644 --- a/tools/testing/selftests/resctrl/resctrl.h +++ b/tools/testing/selftests/resctrl/resctrl.h @@ -1,5 +1,4 @@ /* SPDX-License-Identifier: GPL-2.0 */ -#define _GNU_SOURCE #ifndef RESCTRL_H #define RESCTRL_H #include