From patchwork Wed Sep 13 11:46:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaldo Carvalho de Melo X-Patchwork-Id: 138758 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp1026438vqx; Wed, 13 Sep 2023 04:53:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYXlg77+Boq0rhMqidTO7H+CDvsXBp93THAl0yRcHUKsNRuug2LiSmsGDeSCTD0zp+zzny X-Received: by 2002:a17:903:2291:b0:1c1:f5a6:bdfa with SMTP id b17-20020a170903229100b001c1f5a6bdfamr2851807plh.7.1694605981343; Wed, 13 Sep 2023 04:53:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694605981; cv=none; d=google.com; s=arc-20160816; b=ZRSIJR3p6VnDCev9dfVb7f8CoDBvGfrmVHXDJ6osiuwPS4HMzqxgym1uXusJhqb/ib 6ccolqaOLemjIiqfQhY4h1Y1mSs9G3vLtZHfrTxi+y84qH5DbvxKZFvPFLKEkii+WO3T W2gVvEjvs8PHt+4yxSqdqdEGv4//9ar3stJUohd/ewTl0htfLpYf7Uy2xxxyv3BlaM+c GyRJOxRh/+FM94IzrKlc3FwnRV0+iL4QcQ9P24aoJ1G0ong7svRzTJ+PwqqjrncQLwKA SswvKBjcmqND3fVE8egeHElh8G31F1gZWCELdi2cqgGaffv8m4X1Jo/YbYqVTGMRA237 iI3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=g/IraH7N3pWB5Tdw89/717rLmvbW7hC6B5fnD6Jn6R8=; fh=jVX7/wfDkOuLW+d7FYvcL2GgpBLqu7BmPopQTtD+Byc=; b=XNBmtuxvGStAzJ8hssJmBoUNuC1ZPL9a4cfoyFgw+m1Gj7AfJOdYZzyVXk+czwKlwW n89iAoBEPxuqJ5Mh+fOOoXrhMxj5BwTJIz8Fqqh9QV1wgHhpUf+Cmb+XTe4aSqDeYZoP gqce88V7AjDZx+T4OajO5ZYcWCsZQ3sQF0P5zO4y3EnUc7VwAKxsMewpMxLSUfYfrRYL /bawMiQkShsNTB9iAoXEbwhWCJ+5h6YJVfQOyv7VfoRBgnGY2SvfJdvzqfqr4wl1v7e2 /g7J/4zw9Yo2BfFgvbqUU1Yme176EkWGSMmxI5NzFMs5iw8E30TXjWbf5lxtPo26UpfB xoOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C0S14i4Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id ay6-20020a1709028b8600b001badbe8e441si9805920plb.106.2023.09.13.04.52.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 04:53:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C0S14i4Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id B2E458114EDB; Wed, 13 Sep 2023 04:47:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240441AbjIMLrG (ORCPT + 36 others); Wed, 13 Sep 2023 07:47:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240280AbjIMLrE (ORCPT ); Wed, 13 Sep 2023 07:47:04 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F108319AF for ; Wed, 13 Sep 2023 04:47:00 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30694C433CA; Wed, 13 Sep 2023 11:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694605620; bh=BZf+zZM9sVwxroHem+Yy/Zphx5LTLZy6/U7KJ8tSUJM=; h=Date:From:To:Cc:Subject:From; b=C0S14i4ZI4B6TWqoTdN16n3YJAJQKVAIfTJKUqs2kAcKQ0i2GND4tG3VJZvRCmwnU DMx0DhDoSKQ9pgDUVhRaSYn1cFq2FB0XhsgvJaPp5KnD9uwunV3dWMQLpdMRBvcu3a gfRhfcI7zh+D0sEPLLa4SpZn14JRTf3+RDmXr/dSKWwCwx3m15vh68dpdeUJcKT3YJ scoYhR7q8zD7yQMEiEOpG/AdvEZrcp94hg5CswduQdFzDoAh26xDLp+lGmsmbhxDJ4 JklTC7zyOW7dfYnO0RFKjdozfEzm7vDwrRpGbRMCHcLM0SnQQPhOjfU1ov8dEYMfeM 86pGQUh4mKKPQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 18096403F4; Wed, 13 Sep 2023 08:46:57 -0300 (-03) Date: Wed, 13 Sep 2023 08:46:57 -0300 From: Arnaldo Carvalho de Melo To: Andrei Vagin , linux-kernel@vger.kernel.org Cc: Kees Kook , Adrian Hunter , Ian Rogers , Jiri Olsa , Namhyung Kim , Peter Zijlstra Subject: [PATCH 1/2 fyi] tools headers UAPI: Copy seccomp.h to be able to build 'perf bench' in older systems Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 13 Sep 2023 04:47:17 -0700 (PDT) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776923161530776143 X-GMAIL-MSGID: 1776923161530776143 tldr; Just FYI, I'm carrying this on the perf tools tree. - Arnaldo --- The new 'perf bench' for sched-seccomp-notify uses defines and types not available in older systems where we want to have perf available, so grab a copy of this UAPI from the kernel sources to allow that. This will be checked in the future for drift from the original when we build the perf tool, that will warn when that happens like: make: Entering directory '/var/home/acme/git/perf-tools/tools/perf' BUILD: Doing 'make -j32' parallel build Warning: Kernel ABI header differences: Cc: Adrian Hunter Cc: Andrei Vagin Cc: Ian Rogers Cc: Jiri Olsa Cc: Kees Kook Cc: Namhyung Kim Cc: Peter Zijlstra Link: https://lore.kernel.org/lkml/ Signed-off-by: Arnaldo Carvalho de Melo --- tools/include/uapi/linux/seccomp.h | 157 +++++++++++++++++++++++++++++ tools/perf/check-headers.sh | 1 + 2 files changed, 158 insertions(+) create mode 100644 tools/include/uapi/linux/seccomp.h diff --git a/tools/include/uapi/linux/seccomp.h b/tools/include/uapi/linux/seccomp.h new file mode 100644 index 0000000000000000..dbfc9b37fcaee47e --- /dev/null +++ b/tools/include/uapi/linux/seccomp.h @@ -0,0 +1,157 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +#ifndef _UAPI_LINUX_SECCOMP_H +#define _UAPI_LINUX_SECCOMP_H + +#include +#include + + +/* Valid values for seccomp.mode and prctl(PR_SET_SECCOMP, ) */ +#define SECCOMP_MODE_DISABLED 0 /* seccomp is not in use. */ +#define SECCOMP_MODE_STRICT 1 /* uses hard-coded filter. */ +#define SECCOMP_MODE_FILTER 2 /* uses user-supplied filter. */ + +/* Valid operations for seccomp syscall. */ +#define SECCOMP_SET_MODE_STRICT 0 +#define SECCOMP_SET_MODE_FILTER 1 +#define SECCOMP_GET_ACTION_AVAIL 2 +#define SECCOMP_GET_NOTIF_SIZES 3 + +/* Valid flags for SECCOMP_SET_MODE_FILTER */ +#define SECCOMP_FILTER_FLAG_TSYNC (1UL << 0) +#define SECCOMP_FILTER_FLAG_LOG (1UL << 1) +#define SECCOMP_FILTER_FLAG_SPEC_ALLOW (1UL << 2) +#define SECCOMP_FILTER_FLAG_NEW_LISTENER (1UL << 3) +#define SECCOMP_FILTER_FLAG_TSYNC_ESRCH (1UL << 4) +/* Received notifications wait in killable state (only respond to fatal signals) */ +#define SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV (1UL << 5) + +/* + * All BPF programs must return a 32-bit value. + * The bottom 16-bits are for optional return data. + * The upper 16-bits are ordered from least permissive values to most, + * as a signed value (so 0x8000000 is negative). + * + * The ordering ensures that a min_t() over composed return values always + * selects the least permissive choice. + */ +#define SECCOMP_RET_KILL_PROCESS 0x80000000U /* kill the process */ +#define SECCOMP_RET_KILL_THREAD 0x00000000U /* kill the thread */ +#define SECCOMP_RET_KILL SECCOMP_RET_KILL_THREAD +#define SECCOMP_RET_TRAP 0x00030000U /* disallow and force a SIGSYS */ +#define SECCOMP_RET_ERRNO 0x00050000U /* returns an errno */ +#define SECCOMP_RET_USER_NOTIF 0x7fc00000U /* notifies userspace */ +#define SECCOMP_RET_TRACE 0x7ff00000U /* pass to a tracer or disallow */ +#define SECCOMP_RET_LOG 0x7ffc0000U /* allow after logging */ +#define SECCOMP_RET_ALLOW 0x7fff0000U /* allow */ + +/* Masks for the return value sections. */ +#define SECCOMP_RET_ACTION_FULL 0xffff0000U +#define SECCOMP_RET_ACTION 0x7fff0000U +#define SECCOMP_RET_DATA 0x0000ffffU + +/** + * struct seccomp_data - the format the BPF program executes over. + * @nr: the system call number + * @arch: indicates system call convention as an AUDIT_ARCH_* value + * as defined in . + * @instruction_pointer: at the time of the system call. + * @args: up to 6 system call arguments always stored as 64-bit values + * regardless of the architecture. + */ +struct seccomp_data { + int nr; + __u32 arch; + __u64 instruction_pointer; + __u64 args[6]; +}; + +struct seccomp_notif_sizes { + __u16 seccomp_notif; + __u16 seccomp_notif_resp; + __u16 seccomp_data; +}; + +struct seccomp_notif { + __u64 id; + __u32 pid; + __u32 flags; + struct seccomp_data data; +}; + +/* + * Valid flags for struct seccomp_notif_resp + * + * Note, the SECCOMP_USER_NOTIF_FLAG_CONTINUE flag must be used with caution! + * If set by the process supervising the syscalls of another process the + * syscall will continue. This is problematic because of an inherent TOCTOU. + * An attacker can exploit the time while the supervised process is waiting on + * a response from the supervising process to rewrite syscall arguments which + * are passed as pointers of the intercepted syscall. + * It should be absolutely clear that this means that the seccomp notifier + * _cannot_ be used to implement a security policy! It should only ever be used + * in scenarios where a more privileged process supervises the syscalls of a + * lesser privileged process to get around kernel-enforced security + * restrictions when the privileged process deems this safe. In other words, + * in order to continue a syscall the supervising process should be sure that + * another security mechanism or the kernel itself will sufficiently block + * syscalls if arguments are rewritten to something unsafe. + * + * Similar precautions should be applied when stacking SECCOMP_RET_USER_NOTIF + * or SECCOMP_RET_TRACE. For SECCOMP_RET_USER_NOTIF filters acting on the + * same syscall, the most recently added filter takes precedence. This means + * that the new SECCOMP_RET_USER_NOTIF filter can override any + * SECCOMP_IOCTL_NOTIF_SEND from earlier filters, essentially allowing all + * such filtered syscalls to be executed by sending the response + * SECCOMP_USER_NOTIF_FLAG_CONTINUE. Note that SECCOMP_RET_TRACE can equally + * be overriden by SECCOMP_USER_NOTIF_FLAG_CONTINUE. + */ +#define SECCOMP_USER_NOTIF_FLAG_CONTINUE (1UL << 0) + +struct seccomp_notif_resp { + __u64 id; + __s64 val; + __s32 error; + __u32 flags; +}; + +#define SECCOMP_USER_NOTIF_FD_SYNC_WAKE_UP (1UL << 0) + +/* valid flags for seccomp_notif_addfd */ +#define SECCOMP_ADDFD_FLAG_SETFD (1UL << 0) /* Specify remote fd */ +#define SECCOMP_ADDFD_FLAG_SEND (1UL << 1) /* Addfd and return it, atomically */ + +/** + * struct seccomp_notif_addfd + * @id: The ID of the seccomp notification + * @flags: SECCOMP_ADDFD_FLAG_* + * @srcfd: The local fd number + * @newfd: Optional remote FD number if SETFD option is set, otherwise 0. + * @newfd_flags: The O_* flags the remote FD should have applied + */ +struct seccomp_notif_addfd { + __u64 id; + __u32 flags; + __u32 srcfd; + __u32 newfd; + __u32 newfd_flags; +}; + +#define SECCOMP_IOC_MAGIC '!' +#define SECCOMP_IO(nr) _IO(SECCOMP_IOC_MAGIC, nr) +#define SECCOMP_IOR(nr, type) _IOR(SECCOMP_IOC_MAGIC, nr, type) +#define SECCOMP_IOW(nr, type) _IOW(SECCOMP_IOC_MAGIC, nr, type) +#define SECCOMP_IOWR(nr, type) _IOWR(SECCOMP_IOC_MAGIC, nr, type) + +/* Flags for seccomp notification fd ioctl. */ +#define SECCOMP_IOCTL_NOTIF_RECV SECCOMP_IOWR(0, struct seccomp_notif) +#define SECCOMP_IOCTL_NOTIF_SEND SECCOMP_IOWR(1, \ + struct seccomp_notif_resp) +#define SECCOMP_IOCTL_NOTIF_ID_VALID SECCOMP_IOW(2, __u64) +/* On success, the return value is the remote process's added fd number */ +#define SECCOMP_IOCTL_NOTIF_ADDFD SECCOMP_IOW(3, \ + struct seccomp_notif_addfd) + +#define SECCOMP_IOCTL_NOTIF_SET_FLAGS SECCOMP_IOW(4, __u64) + +#endif /* _UAPI_LINUX_SECCOMP_H */ diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh index 4314c91978509a49..e21caadda7c11566 100755 --- a/tools/perf/check-headers.sh +++ b/tools/perf/check-headers.sh @@ -21,6 +21,7 @@ FILES=( "include/uapi/linux/perf_event.h" "include/uapi/linux/prctl.h" "include/uapi/linux/sched.h" + "include/uapi/linux/seccomp.h" "include/uapi/linux/stat.h" "include/uapi/linux/usbdevice_fs.h" "include/uapi/linux/vhost.h" From patchwork Wed Sep 13 11:48:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaldo Carvalho de Melo X-Patchwork-Id: 139153 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:a8d:b0:3f2:4152:657d with SMTP id gr13csp145609vqb; Wed, 13 Sep 2023 16:17:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElFzZ4teyz2zQZfuDPGtavYq2EMjlkbRulxzyDFOqGcLxJt0YVmibw4hYbBR7b0LYXcs1d X-Received: by 2002:a05:6a00:4a08:b0:690:28d0:b7cf with SMTP id do8-20020a056a004a0800b0069028d0b7cfmr544260pfb.16.1694647039057; Wed, 13 Sep 2023 16:17:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694647039; cv=none; d=google.com; s=arc-20160816; b=Z0Z13VZ8I7qUmEaIHeDBvXJ8En6J0xg+Jpxk8Iz5s+a+Hlh5AjpRHw+2yFKrbYfYg/ g56kAojVNc/RjvpKRNjUdth8dgkM/K8Lnkyx3jzSBJNEU/cl+ghEBQe8Q76nzOrmwX6E DeXEkOwACP5twTBXghk3xqHQ4fDfS7439APYDaOBR8J0E352yDQGpeQHuV5jc8TZ8yp7 WEDIg1b3EigDltY2Z/le3+ks1YBjiq1XKiQ7ch+IU96B+cmXSZ0Rg6N8/rgN1T9mnfq7 TnYA/Oymrl1LKko60BX82IaYJn0gHVbYZhVQPpRHDVsxihpevdho73tSJ9te2awBH5pK I7kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=9gt/M5ILEEedSiFQkrvvkY5+FnBn6vXs3VIBo1vnRu8=; fh=jVX7/wfDkOuLW+d7FYvcL2GgpBLqu7BmPopQTtD+Byc=; b=sSDdJfUQplkXY3Fqqk9tXr3Tiymi+BfolIl4oBms2yBFga8eiLBQ6FVvxNgTLn8CKg DxihNpiq8kX4sSC03DZHUlCsIK8o+ckFpRsx5A8Pon4XD2styd5UJ/lXY8Dmfjay5DoL RbdyCaxEPYk1ehuOLhpLXyLjBdb0wQffcI51iN4SzfCm78XRuwWNB6fNB7VDG8aDR2CP /2TUsDxS1hsh0w886brjXUdQwCFdDec71Lze2HAjnhR3S7nYGFuFGTY7b/I/CkioaW3F KuwBQ3/eDlIJvtexkaV9QEStMKKba3BY5/PVSBxJ2u/xSiqKywRzuKub6VHGM0O+nbu0 Aw4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hHdnDVQt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id fp7-20020a056a00608700b0069023e4bcb4si255558pfb.114.2023.09.13.16.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 16:17:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hHdnDVQt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7F03382159FE; Wed, 13 Sep 2023 04:48:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240398AbjIMLsi (ORCPT + 36 others); Wed, 13 Sep 2023 07:48:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235715AbjIMLsg (ORCPT ); Wed, 13 Sep 2023 07:48:36 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E833110E6 for ; Wed, 13 Sep 2023 04:48:32 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 620DEC433C8; Wed, 13 Sep 2023 11:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694605712; bh=Vb33qlf0ZwjYVrEHkwd4Hitu/bcjtnaGY47clFBlEh0=; h=Date:From:To:Cc:Subject:From; b=hHdnDVQtMAz1N4rWXipk/2tlW2VtQpoQblEp6kRsV9+ywz5deHrMFobG3aqYukla3 JM2tZqplzO2v4M7GhqN80/ODQoGcr0VyLE3poPmhWNMRnyO2i0Ew6toEbDL1VBKGpr NS1362FjxluAZBP/IKNCv6aInuLMFE6VIZ7JuBIgjTwIQxxjy6rqSnftY7s5muwNfG JN/juiZwVmz8b1bPsyBFylk3tpZL6c4VUeq4NxnsAD8uLj64FrJKLAyhyJtRDJthHT WI2/QWqgnaDDfPk3+806p7L5jWC+Ntz9vQTOsrl1RkNsBiNfxVFVeQmOrA2dCP88Mw rJVABKRyBH+AA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 95B5A403F4; Wed, 13 Sep 2023 08:48:29 -0300 (-03) Date: Wed, 13 Sep 2023 08:48:29 -0300 From: Arnaldo Carvalho de Melo To: Andrei Vagin , linux-kernel@vger.kernel.org Cc: Kees Kook , Adrian Hunter , Ian Rogers , Jiri Olsa , Namhyung Kim , Peter Zijlstra Subject: [PATCH 2/2 fyi] perf bench sched-seccomp-notify: Use the tools copy of seccomp.h UAPI Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Sep 2023 04:48:38 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776966213812809506 X-GMAIL-MSGID: 1776966213812809506 To keep perf building in systems where types and defines used in this new benchmark are not available, such as: 12 13.46 centos:stream : FAIL gcc version 8.5.0 20210514 (Red Hat 8.5.0-20) (GCC) bench/sched-seccomp-notify.c: In function 'user_notif_syscall': bench/sched-seccomp-notify.c:55:27: error: 'SECCOMP_RET_USER_NOTIF' undeclared (first use in this function); did you mean 'SECCOMP_RET_ERRNO'? BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_USER_NOTIF), ^~~~~~~~~~~~~~~~~~~~~~ /git/perf-6.6.0-rc1/tools/include/uapi/linux/filter.h:49:59: note: in definition of macro 'BPF_STMT' #define BPF_STMT(code, k) { (unsigned short)(code), 0, 0, k } ^ bench/sched-seccomp-notify.c:55:27: note: each undeclared identifier is reported only once for each function it appears in BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_USER_NOTIF), ^~~~~~~~~~~~~~~~~~~~~~ /git/perf-6.6.0-rc1/tools/include/uapi/linux/filter.h:49:59: note: in definition of macro 'BPF_STMT' #define BPF_STMT(code, k) { (unsigned short)(code), 0, 0, k } ^ bench/sched-seccomp-notify.c:55:3: error: missing initializer for field 'k' of 'struct sock_filter' [-Werror=missing-field-initializers] BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_USER_NOTIF), ^~~~~~~~ In file included from bench/sched-seccomp-notify.c:5: /git/perf-6.6.0-rc1/tools/include/uapi/linux/filter.h:28:8: note: 'k' declared here __u32 k; /* Generic multiuse field */ ^ bench/sched-seccomp-notify.c: In function 'user_notification_sync_loop': bench/sched-seccomp-notify.c:70:28: error: storage size of 'resp' isn't known struct seccomp_notif_resp resp; ^~~~ bench/sched-seccomp-notify.c:71:23: error: storage size of 'req' isn't known struct seccomp_notif req; ^~~ bench/sched-seccomp-notify.c:76:23: error: 'SECCOMP_IOCTL_NOTIF_RECV' undeclared (first use in this function); did you mean 'SECCOMP_MODE_STRICT'? if (ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req)) ^~~~~~~~~~~~~~~~~~~~~~~~ SECCOMP_MODE_STRICT bench/sched-seccomp-notify.c:86:23: error: 'SECCOMP_IOCTL_NOTIF_SEND' undeclared (first use in this function); did you mean 'SECCOMP_RET_ACTION'? if (ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp)) ^~~~~~~~~~~~~~~~~~~~~~~~ SECCOMP_RET_ACTION bench/sched-seccomp-notify.c:71:23: error: unused variable 'req' [-Werror=unused-variable] struct seccomp_notif req; ^~~ bench/sched-seccomp-notify.c:70:28: error: unused variable 'resp' [-Werror=unused-variable] struct seccomp_notif_resp resp; ^~~~ 14 11.31 debian:10 : FAIL gcc version 8.3.0 (Debian 8.3.0-6) Cc: Adrian Hunter Cc: Andrei Vagin Cc: Ian Rogers Cc: Jiri Olsa Cc: Kees Kook Cc: Namhyung Kim Cc: Peter Zijlstra Link: https://lore.kernel.org/lkml/ Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/bench/sched-seccomp-notify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/bench/sched-seccomp-notify.c b/tools/perf/bench/sched-seccomp-notify.c index b04ebcde40361636..a01c40131493b76d 100644 --- a/tools/perf/bench/sched-seccomp-notify.c +++ b/tools/perf/bench/sched-seccomp-notify.c @@ -9,7 +9,7 @@ #include #include #include -#include +#include #include #include