From patchwork Wed Sep 13 09:44:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cheng.lin130@zte.com.cn X-Patchwork-Id: 138723 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp966785vqx; Wed, 13 Sep 2023 02:49:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgwlOIj368KXr0Pxcy1gCgRtk2x8x/QtUUDUkpdRcwI9fzl7B0M6HPnlqzRor6lYvmnGuy X-Received: by 2002:a05:6a20:be11:b0:158:1387:6aa4 with SMTP id ge17-20020a056a20be1100b0015813876aa4mr697185pzb.30.1694598575377; Wed, 13 Sep 2023 02:49:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694598575; cv=none; d=google.com; s=arc-20160816; b=l9iaJ9ohvgxGVVNYFW3lxcloLmBjToudFctkurp/qemWFMRTlwT1INcYncBk4xJg/g m/uPlYM/Bhk/W2BgekC3uT34fRnYoKWZj0jwaWRiLY+oXaOnlQtLQxZg/Hy40HXDUc3B 4prSo5rqh2zvCO21anJq5FdtPHTvamHHnpQqsAWxM/8oVbXX9uppEqWIfN8JiYhg3onB MDvIjTWRcP5jUBjWMhFe/i6AFseSohKdOwiOrHM5p24iLlgz8nX58RrPsvdF8D9aMoxV WZsvWf7y8kX+67vl3kpCqRewKbZqDWfn8dTiCgGzmMtO8+2Or8J8EULkHDbS4LccjojO Cfmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=b5tRAsprURCrsjddLFWDAA4UuoEfwPLSzkeWOuLH0vM=; fh=hFgfcaIVoyhXbF2UwJZsnqb6ugEoYRhxDBvi1f/p9Jo=; b=0EU8iFgvMGM4wVHR6TD1dDSEKiqeq1p8GFe4j2Tjs7YTycy856SqloVN4Y2kUN/F9c k6pmgp5/6a0HLXESTxNsIXuNbSAxwQ12/CAL3fbFntKop6UWQNWCoPhDSgFbXl7xJAXG YYu+em8EOU47Qv9UEuOq0JjN6JwCaY+0RCbDbDKHa8zKjdmPrvWjXtHIf5o3+7xQv7lM GggEi+Zea/nixzp1KIO7z8XI4l2dWR/cECT4i/sjumpUCLS4YV2qXOBdO07i6KyQFHfG SW0JsPNIiMIi15cTOQPWTdlaOoqxPtdq0sFWrxJtA2+ALcoyEAprk4AorLmeczLwV4MD 9IZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id u14-20020a17090341ce00b001bc671d6d15si10304291ple.614.2023.09.13.02.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 02:49:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 90B6782557A8; Wed, 13 Sep 2023 02:45:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239420AbjIMJpH (ORCPT + 36 others); Wed, 13 Sep 2023 05:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239380AbjIMJpG (ORCPT ); Wed, 13 Sep 2023 05:45:06 -0400 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 474B9199D; Wed, 13 Sep 2023 02:45:00 -0700 (PDT) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4RlwXl072qz8XrRP; Wed, 13 Sep 2023 17:44:55 +0800 (CST) Received: from szxlzmapp04.zte.com.cn ([10.5.231.166]) by mse-fl1.zte.com.cn with SMTP id 38D9igvN028678; Wed, 13 Sep 2023 17:44:42 +0800 (+08) (envelope-from cheng.lin130@zte.com.cn) Received: from mapi (szxlzmapp05[null]) by mapi (Zmail) with MAPI id mid14; Wed, 13 Sep 2023 17:44:45 +0800 (CST) Date: Wed, 13 Sep 2023 17:44:45 +0800 (CST) X-Zmail-TransId: 2b076501848d054-bb4fd X-Mailer: Zmail v1.0 Message-ID: <202309131744458239465@zte.com.cn> Mime-Version: 1.0 From: To: , Cc: , , , , Subject: =?utf-8?q?=5BPATCH_v3=5D_xfs=3A_introduce_protection_for_drop_nlink?= X-MAIL: mse-fl1.zte.com.cn 38D9igvN028678 X-Fangmail-Gw-Spam-Type: 0 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 65018497.000/4RlwXl072qz8XrRP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 13 Sep 2023 02:45:15 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776915395756211519 X-GMAIL-MSGID: 1776915395756211519 From: Cheng Lin When abnormal drop_nlink are detected on the inode, shutdown filesystem, to avoid corruption propagation. Signed-off-by: Cheng Lin --- fs/xfs/xfs_inode.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index 9e62cc500..40cc106ae 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c @@ -919,6 +919,15 @@ xfs_droplink( xfs_trans_t *tp, xfs_inode_t *ip) { + + if (VFS_I(ip)->i_nlink == 0) { + xfs_alert(ip->i_mount, + "%s: Deleting inode %llu with no links.", + __func__, ip->i_ino); + tp->t_flags |= XFS_TRANS_DIRTY; + return -EFSCORRUPTED; + } + xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG); drop_nlink(VFS_I(ip));