From patchwork Tue Sep 12 13:27:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 138618 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp838826vqx; Tue, 12 Sep 2023 21:02:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHM+a1mixMKT44rKWZqsBSCWN4XAgwtpTgO3n82e/JNMBslic33XCJMGLtuIPJiHrycXzpn X-Received: by 2002:a05:6a00:1996:b0:68f:e810:e894 with SMTP id d22-20020a056a00199600b0068fe810e894mr1758167pfl.33.1694577777267; Tue, 12 Sep 2023 21:02:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694577777; cv=none; d=google.com; s=arc-20160816; b=ee1sSssgiqQXF5YFRZD7vZU2bmUVQKtccY+VS7i/7E2OlXBB1EBUGo1gR/GCFateaW YS6PdOOo25CPZM6LETL5BYF2t7xOrXQWDmbdF/26XDChgkCV+Y6PLHod35rcJn2JJzSZ 4MARQPN42+j5++Ps1tbHbmc3z7WUtUywkTFsQLHA1qSpilRrWtUbHZKH5LmGqIsGmh5a nKTaeNxzh3+E1jx6CHR/DYaMpdra+xhHeVLcLS0aKxQy1rKU4MWbP68ayZd86RMN1IYi k6X07T9mFXLXACpJ6Ogs1F1+rVKg1jqq2b5KyGJ+bwsbShwLZFxHntTHpA7OVV+03RpI 0UMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=p/qu/HO+QWXMZClGw2V6UqRARF88uGiEQkPRhZezuIw=; fh=SyhPsGKNo/JGCZgOgs8oor82YQAWZ9kc5f/0PFOAxm0=; b=O2QZl8HVCfC96WFXRHB1zHy3cBw7roRMvEaiS++NLigDPDi+u3Wzc7HRoXcGVN9din zpX2rJPef8Yp2dC9jtVXNaNva0A8DuIg+LmbK+nG0V5T1Mg1+JjCA3Vw4AA4lmyA1buu k20rlZ41JmeEERWjH6MuGDz34/o51UAYqO67rucO1Al8jhup59qGafHAbSadLpgoYesB YS82+VULGm7NO9kuyVlKalUpVYlJluiG1FJ3/EAZvm88pHPfVArLb82S4VZSxo74SC56 hrfFjlJezY2GIhDqTa8qBhNvBoSZZaQW4wei43YZxgsaly/MOAum4bOSM7P7Cqp3spUt bpbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=E4VZDDHN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id i191-20020a6387c8000000b005641dfc74casi6929980pge.745.2023.09.12.21.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 21:02:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=E4VZDDHN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 3674F83B6BF5; Tue, 12 Sep 2023 06:28:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235503AbjILN14 (ORCPT + 37 others); Tue, 12 Sep 2023 09:27:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232588AbjILN1y (ORCPT ); Tue, 12 Sep 2023 09:27:54 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C30610CE for ; Tue, 12 Sep 2023 06:27:50 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38CARhwA022397; Tue, 12 Sep 2023 08:27:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=p /qu/HO+QWXMZClGw2V6UqRARF88uGiEQkPRhZezuIw=; b=E4VZDDHNOq9yFT0BQ IKSGrO6SseUkOvvIZZJkGdrPcNvw79Y7DcMlOueJ0dWq85a2Xp41scQjLW+RqelQ zDmwZOGQGdwRXfW3SCh4zpBT3OAaQmbmUwPl3mXhy5hW3vxLX2wlEhpr6JF5ST1r WkGgyh+Cncjfr731MbVOCcNkqd9uOCneZ2234m34fJe+j5FwrnYnBNySFx68nUto 7ma/vzYbEw5JnQk5+0cOiZbFuM8R/+HqC5NWESp1BceVmrt/vD6A8iXq8P+dHtnB Wj8zFcn/UJRZc74l5ArGqZv32YcIEJFULknhRV9qWD6ogn30uqx/jlWGSMNxV7Da wpSrQ== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3t0p3xkm7r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 08:27:41 -0500 (CDT) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Tue, 12 Sep 2023 14:27:39 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Tue, 12 Sep 2023 14:27:39 +0100 Received: from edi-sw-dsktp-006.ad.cirrus.com (edi-sw-dsktp-006.ad.cirrus.com [198.90.251.125]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 1EE6C2A1; Tue, 12 Sep 2023 13:27:39 +0000 (UTC) From: Richard Fitzgerald To: CC: , , , Richard Fitzgerald Subject: [PATCH] ALSA: hda: cs35l56: Disable low-power hibernation mode Date: Tue, 12 Sep 2023 14:27:39 +0100 Message-ID: <20230912132739.3478441-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: ibH2zfBop7k4z-d0i_r4D_ZFe2-7TJA2 X-Proofpoint-GUID: ibH2zfBop7k4z-d0i_r4D_ZFe2-7TJA2 X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Sep 2023 06:28:02 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776893587265337485 X-GMAIL-MSGID: 1776893587265337485 Do not allow the CS35L56 to be put into its lowest power "hibernation" mode. This only affects I2C because "hibernation" is already disabled on SPI. Recent firmwares need a different wake-up sequence. Until that sequence has been specified, the chip "hibernation" mode must be disabled otherwise it can intermittently fail to wake. Signed-off-by: Richard Fitzgerald --- sound/pci/hda/cs35l56_hda_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/pci/hda/cs35l56_hda_i2c.c b/sound/pci/hda/cs35l56_hda_i2c.c index 83e4acdd89ac..757a4d193e0f 100644 --- a/sound/pci/hda/cs35l56_hda_i2c.c +++ b/sound/pci/hda/cs35l56_hda_i2c.c @@ -21,7 +21,6 @@ static int cs35l56_hda_i2c_probe(struct i2c_client *clt) return -ENOMEM; cs35l56->base.dev = &clt->dev; - cs35l56->base.can_hibernate = true; cs35l56->base.regmap = devm_regmap_init_i2c(clt, &cs35l56_regmap_i2c); if (IS_ERR(cs35l56->base.regmap)) { ret = PTR_ERR(cs35l56->base.regmap);