From patchwork Thu Nov 3 15:41:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Sterba X-Patchwork-Id: 14951 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp609109wru; Thu, 3 Nov 2022 08:43:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM45gsKLOPqmTSY1ugp8teechUCbrROCeFNAcrdYY9UEU9PJkDxdMujnYGMc8UKrFTAPk4xy X-Received: by 2002:a50:d5d5:0:b0:461:a30b:67a2 with SMTP id g21-20020a50d5d5000000b00461a30b67a2mr31268247edj.104.1667490193225; Thu, 03 Nov 2022 08:43:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667490193; cv=none; d=google.com; s=arc-20160816; b=XH86iNGp9pIG/ujHvUS39vRsOF1UoQrw/ASj6nZ0XZYLcSVqL8HGQgWlQ1q9iUxLy3 JbmO1vtChKBFejn/v3Rc0X4tOK6u+tOZ+qiv/cXV7v6Curppcqc3wmalJ6qlOOFsLA0v pSA8ZUK1lxReu8TcyXN8434ZH6fzDxAeRMKnUd8/B9KV7eg1AbSM3UwPi+Mp57i9+dbZ AJNzWYJT/fwKQLw2MRq+WdJTcBiYUKwted6869LZHsYc5MHVhNn+oBIPjL6UWJAwreYM wAOuNPSPofo6ixW0HQ4uW/IQ1/tbjToip8KveRDiKoQP59aOhkFZ1KgNsSUagkd1MgWG Ppzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lzXRoelaQpNOfPdsnWnywvovJbNUkTrxeUd8JkHPQyc=; b=mCA5XnEzHvlVa27SBCL+CT3NeRgdVOzq69yQoxMNjnWogAzv+5ah5dH4ZQM2QqCRcc P8h2Rgk0FWulrPGYendZZOJblcujM+K5xCcCcyFGULledhNWhg4VUMviK/5VgV3DOJdB 7uuB0krqByPKPhcqeN3r557d6SCQNjHwf/lPYWHRK4GmIarvHriCMPd2o9YYGpideG81 ODtwDzRxT1Y6+ZhMbDPBvGK9KTmTydo5Y7sqaQBRraRhZX9GTgAP88YAvQJS9f0ButVi PpH3IQ/jyjK/ouqWLvSdqk15QvESNUbZRKRvhy6c0FunyUjl2zKikM2rc4WCMs0CdNpO hwPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=HxFR8w2S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id di14-20020a170906730e00b00780f0b45416si1872460ejc.622.2022.11.03.08.42.48; Thu, 03 Nov 2022 08:43:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=HxFR8w2S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231790AbiKCPlY (ORCPT + 99 others); Thu, 3 Nov 2022 11:41:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231312AbiKCPlX (ORCPT ); Thu, 3 Nov 2022 11:41:23 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A16713DD2; Thu, 3 Nov 2022 08:41:22 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 4A83821BF7; Thu, 3 Nov 2022 15:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667490081; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lzXRoelaQpNOfPdsnWnywvovJbNUkTrxeUd8JkHPQyc=; b=HxFR8w2SepoxpGj57ONoePwAN74s58hiAl1o2dKnOQFbC7VIyRJKiI9xIIQdJnDIhOvHNH mpOeMPYpGCme6gFcWDZCt16CvK/JfPHnSnF4Rq3MTA5dk1xlZWUTghWU1slYIgzQdFk0oW JB0cfuw7hbdUrh9AMMofzkX1GQ9MF2U= Received: from ds.suse.cz (ds.suse.cz [10.100.12.205]) by relay2.suse.de (Postfix) with ESMTP id 3CACD2C141; Thu, 3 Nov 2022 15:41:21 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 8FBA1DA79D; Thu, 3 Nov 2022 16:41:02 +0100 (CET) From: David Sterba To: torvalds@linux-foundation.org Cc: David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [GIT PULL] Btrfs fixes for 6.1-rc4, part 2 Date: Thu, 3 Nov 2022 16:41:00 +0100 Message-Id: X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_SOFTFAIL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748490196943751809?= X-GMAIL-MSGID: =?utf-8?q?1748490196943751809?= Hi, a batch of error handling fixes for resource leaks, fixes for nowait mode in combination with direct and buffered IO. Please pull, thanks. - direct IO + dsync + nowait could miss a sync of the file after write, add handling for this combination - buffered IO + nowait should not fail with ENOSPC, only blocking IO could determine that - error handling fixes - fix inode reserve space leak due to nowait buffered write - check the correct variable after allocation (direct IO submit) - fix inode list leak during backref walking - fix ulist freeing in self tests ---------------------------------------------------------------- The following changes since commit 76a66ba101329316a5d7f4275070be22eb85fdf2: btrfs: don't use btrfs_chunk::sub_stripes from disk (2022-10-25 10:17:33 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-6.1-rc3-tag for you to fetch changes up to eb81b682b131642405a05c627ab08cf0967b3dd8: btrfs: fix inode reserve space leak due to nowait buffered write (2022-11-02 17:44:45 +0100) ---------------------------------------------------------------- Christophe JAILLET (1): btrfs: fix a memory allocation failure test in btrfs_submit_direct Filipe Manana (7): btrfs: fix lost file sync on direct IO write with nowait and dsync iocb btrfs: fix inode list leak during backref walking at resolve_indirect_refs() btrfs: fix inode list leak during backref walking at find_parent_nodes() btrfs: fix ulist leaks in error paths of qgroup self tests btrfs: remove pointless and double ulist frees in error paths of qgroup tests btrfs: fix nowait buffered write returning -ENOSPC btrfs: fix inode reserve space leak due to nowait buffered write fs/btrfs/backref.c | 54 +++++++++++++++++++++++++++---------------- fs/btrfs/ctree.h | 5 +++- fs/btrfs/file.c | 29 +++++++++++++++++------ fs/btrfs/inode.c | 16 +++++++++---- fs/btrfs/tests/qgroup-tests.c | 36 +++++++++++++++-------------- 5 files changed, 91 insertions(+), 49 deletions(-)