From patchwork Tue Sep 12 13:38:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 138285 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp515020vqx; Tue, 12 Sep 2023 09:08:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhmDQ17gdeeGQVTkyZuE5YoEh6eNOr0341cEo/u/iHFCN6UNCLaC4cJeyL9vz/elJjVUvy X-Received: by 2002:a05:6a00:1504:b0:68f:cb69:8e66 with SMTP id q4-20020a056a00150400b0068fcb698e66mr45155pfu.15.1694534934294; Tue, 12 Sep 2023 09:08:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694534934; cv=none; d=google.com; s=arc-20160816; b=sOTQxPQmPKJWP95rST0KPOjOKXlRAyucnUexQoSQYjMBSRuYXMfuOzJOyIvR2IqUNR CIsc3qjI6P/i3cqh2G8kSMNj+2fNHdmNin1sGnmu/49T8xY0+0D9GS53j2b4VBZUrGv7 Yi0N7Qxas8FpE1oze5G+4aCdZZTZ35SIKYjHKTSKWoEzaZ3pNXnVLq3Slhc0sDXAMkW2 DTjZcAkRcyEEwdr/qsU6gnU3BAfRwQFBpdJlBv6emDCt+cfaxWYzZzO03ZTe3DKj/zcI fp9OEVFCk8SrBqhhGbZHR7A4YXby9/z3kAQohmmCJCYLr/1MMSUClRskYLuCPm6rPfXw iEKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iqMo1WYDhsCRU6fDQRu1ohzwNK+mWlIu0GTmbZzTtUg=; fh=msJyvNxU746DPxHNUm730fSh0XzR8hw6ZQ26j1rHfOg=; b=kIQKzjrGjUf3T/A9QE2fwcwSOW7a82a99EcfJhldZckevIX0B+gKIcmIguvgjsaTYk iyfM0bdDND15u115DS31yU8PuiIfh0wJzG+jNG6DvaE7XgvbbZhbhXSnt5Uk3xPNUW5n n3BpOW0EVd2a6S7wOvOD8y1P0+BYpjQhsNr1hmRoj82Oe/TAEBDN+0q1XBT/rktM92e4 cJFTJWJrNIuBrPLT9qrSs2dmJaiCN9lTjhuA9UL05g0IfMwTTwf4CDYumMhm8SnTQC26 PK+y4Nnhm0fSOK93ifdUdmC9Gs8iLudZDG8jJuZMs7xpTT91kjG01luuczoYebuJNgaT GEZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=NcMixOk5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id be9-20020a056a001f0900b0068a0ca6b6e0si2519650pfb.398.2023.09.12.09.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 09:08:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=NcMixOk5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id E21C9822E56E; Tue, 12 Sep 2023 06:39:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235580AbjILNjC (ORCPT + 37 others); Tue, 12 Sep 2023 09:39:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235590AbjILNi7 (ORCPT ); Tue, 12 Sep 2023 09:38:59 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C268410D2 for ; Tue, 12 Sep 2023 06:38:55 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38CDUBmf032495; Tue, 12 Sep 2023 08:38:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=i qMo1WYDhsCRU6fDQRu1ohzwNK+mWlIu0GTmbZzTtUg=; b=NcMixOk5ZGVECb6yV g1EWRRON131fgiJtEBiDLbLkhTwW1pcOOChkHg1p6pvsYhqGbW2AN6+yaq2IDcvL 8PUnoCnORCnWlo0tZpHJR0rs+YGquye3qvXXW8CCV4yhvjsprMxskRiUkMENgQBm xbjWOkll4nhhLyBIsJ2GuID1WWJaYY/cQQOkpbJTdSfCvNa4340C8K3EWt0mg1gv gg/kz+pOVc//FMFtPwBZ2hq5LSjek7psWXkkH9qudIWTRzMGZcqkcV/EkXciQjW9 KR10Qyio5x2xap98LIkvR3KhMJE9sJbguQCsaw7orPMvnlVd/e5oo0MGR+lifprW CFPbQ== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3t0n4jb2wm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 08:38:42 -0500 (CDT) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Tue, 12 Sep 2023 14:38:41 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Tue, 12 Sep 2023 14:38:41 +0100 Received: from edi-sw-dsktp-006.ad.cirrus.com (edi-sw-dsktp-006.ad.cirrus.com [198.90.251.125]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 213352A1; Tue, 12 Sep 2023 13:38:41 +0000 (UTC) From: Richard Fitzgerald To: CC: , , , Richard Fitzgerald Subject: [PATCH] ASoC: cs35l56: Disable low-power hibernation mode Date: Tue, 12 Sep 2023 14:38:41 +0100 Message-ID: <20230912133841.3480466-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: _FpdWHdHakP3SNHYzSaj8a5hrimfKbEI X-Proofpoint-GUID: _FpdWHdHakP3SNHYzSaj8a5hrimfKbEI X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Sep 2023 06:39:13 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776848663187205895 X-GMAIL-MSGID: 1776848663187205895 Do not allow the CS35L56 to be put into its lowest power "hibernation" mode. This only affects I2C because "hibernation" is already disabled on SPI and SoundWire. Recent firmwares need a different wake-up sequence. Until that sequence has been specified, the chip "hibernation" mode must be disabled otherwise it can intermittently fail to wake. THIS WILL NOT APPLY CLEANLY TO 6.5 AND EARLIER: We will send a separate backport patch to stable. Signed-off-by: Richard Fitzgerald --- sound/soc/codecs/cs35l56-i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l56-i2c.c b/sound/soc/codecs/cs35l56-i2c.c index 9f4f2f4f23f5..d10e0e2380e8 100644 --- a/sound/soc/codecs/cs35l56-i2c.c +++ b/sound/soc/codecs/cs35l56-i2c.c @@ -27,7 +27,6 @@ static int cs35l56_i2c_probe(struct i2c_client *client) return -ENOMEM; cs35l56->base.dev = dev; - cs35l56->base.can_hibernate = true; i2c_set_clientdata(client, cs35l56); cs35l56->base.regmap = devm_regmap_init_i2c(client, regmap_config);