From patchwork Tue Sep 12 08:42:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavrilov Ilia X-Patchwork-Id: 138069 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp289199vqx; Tue, 12 Sep 2023 02:48:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVT8gOpA2/MEtpMhi8rnw2RuDB2stT0R4p3XOftN+cveKGPdVZDiJtxTK8iYPC4Da/9+CW X-Received: by 2002:a05:6870:d114:b0:1bf:61d1:a4d4 with SMTP id e20-20020a056870d11400b001bf61d1a4d4mr15343188oac.6.1694512139173; Tue, 12 Sep 2023 02:48:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694512139; cv=none; d=google.com; s=arc-20160816; b=gdm01duftJMqkiEUuUmtEdCHgUpgxuqGBY1iXGqTPNM4P8ZfpaphTAp6aGznKWKKJF UTjXn/llxMeXaeUtA9WPTqnCT0yu94CMHe3LM7WN507b0kOCe9l6rlUtpE78VzSg443E ySxHn9HRduTYCRWZcIDxrUdm9m6uwUNeIkmNI29WyCie9nv7fGK3mpFbCr+02UCkEDQq OYDkiAJDjN5mmkNb8TrCUggPt/IH/7B4JnfKCs3dOfOhzn9Ikmc/VqJrsF9q4SoLSAag AArBiSMPDYHLN6P8HZgYeGdD/m4onlNooXSoRXb+/oAQXjqkbjWBb7Y34U+YtY5KZgq1 Szig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature:dkim-filter; bh=ULzrGpftkZgLqATIEQXgFNjR2HUnbe9KTr0sViGMoMQ=; fh=lKd4sb+Jdcl5u8OaxppvM34J51CWXS8BRaNF+XgrJ5M=; b=h8B+vQMvNkDtUM15kDrG3NCJEs2ZMe1ZYNHa8jHruhrkF4xEZeyDs8huqf9Ln1Koji itmMgjypXE9PtBfT9YeSO196jUZEc8TbLOIKS7tS01bAcS9R1ogR1ZjCV3l8Ppv0HfCO ADo3++rgNNpzWp/TR8CVMyDp3DM40kaPrGiIFx22nC9M8/aE0qG+YmqvqTRst/U6Zdyz hfbDSpuF8XxRaF81VomZGxty4KPWb4LnTAnNbjp3RYg5pskbjpNoVzTzlB5RjdD6rlBN fZnYnOSW7ai/4/B7Z5Jiorqv5+GfHu5G3coFrZrB/T5kTEL+HbEAncQRkZLBijzRN8kF UiVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infotecs.ru header.s=mx header.b=gHYTFFAP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=infotecs.ru Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id m1-20020a656a01000000b005777bea0b5esi2678209pgu.901.2023.09.12.02.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 02:48:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@infotecs.ru header.s=mx header.b=gHYTFFAP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=infotecs.ru Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 4CCDC8280D7C; Tue, 12 Sep 2023 01:43:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233001AbjILInb (ORCPT + 38 others); Tue, 12 Sep 2023 04:43:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233202AbjILInR (ORCPT ); Tue, 12 Sep 2023 04:43:17 -0400 Received: from mx0.infotecs.ru (mx0.infotecs.ru [91.244.183.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B51B31713; Tue, 12 Sep 2023 01:42:51 -0700 (PDT) Received: from mx0.infotecs-nt (localhost [127.0.0.1]) by mx0.infotecs.ru (Postfix) with ESMTP id EFABC1024BAE; Tue, 12 Sep 2023 11:42:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx0.infotecs.ru EFABC1024BAE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=infotecs.ru; s=mx; t=1694508170; bh=ULzrGpftkZgLqATIEQXgFNjR2HUnbe9KTr0sViGMoMQ=; h=From:To:CC:Subject:Date:From; b=gHYTFFAPLdMsPM5Pglhq5rJXFvWAzOtxC5EZCa8JZOq4x9Odxtu3xVLVLZqM4P0Lr y4Z5sdtACPC9KR2lQQHFnL194uAKs3fmrgeati8dXyHH132EfcmaQfUw8i8P6MTPUR NxaUXFZp/usuxvfFywNunXhEOexl6wmpzrQC2GSk= Received: from msk-exch-01.infotecs-nt (msk-exch-01.infotecs-nt [10.0.7.191]) by mx0.infotecs-nt (Postfix) with ESMTP id EDF8E30268F3; Tue, 12 Sep 2023 11:42:49 +0300 (MSK) From: Gavrilov Ilia To: "David S. Miller" CC: David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lvc-project@linuxtesting.org" Subject: [PATCH net-next] ipv6: mcast: Remove redundant comparison in igmp6_mcf_get_next() Thread-Topic: [PATCH net-next] ipv6: mcast: Remove redundant comparison in igmp6_mcf_get_next() Thread-Index: AQHZ5VUc01wdWD2zyUKZD0c8csOa5g== Date: Tue, 12 Sep 2023 08:42:49 +0000 Message-ID: <20230912084100.1502379-1-Ilia.Gavrilov@infotecs.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.17.0.10] x-exclaimer-md-config: 208ac3cd-1ed4-4982-a353-bdefac89ac0a MIME-Version: 1.0 X-KLMS-Rule-ID: 5 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Status: not scanned, disabled by settings X-KLMS-AntiSpam-Interceptor-Info: not scanned X-KLMS-AntiPhishing: Clean, bases: 2023/09/12 07:28:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2023/09/12 03:38:00 #21880520 X-KLMS-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 12 Sep 2023 01:43:34 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776824760467611962 X-GMAIL-MSGID: 1776824760467611962 The 'state->im' value will always be non-zero after the 'while' statement, so the check can be removed. Found by InfoTeCS on behalf of Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Gavrilov Ilia Reviewed-by: David Ahern --- Repost according to https://lore.kernel.org/all/cdc2183a-c79a-b4bd-2726-bd3a2d6d5440@kernel.org/ net/ipv6/mcast.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index 5ce25bcb9974..421264a69e97 100644 --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -3011,8 +3011,6 @@ static struct ip6_sf_list *igmp6_mcf_get_next(struct seq_file *seq, struct ip6_s continue; state->im = rcu_dereference(state->idev->mc_list); } - if (!state->im) - break; psf = rcu_dereference(state->im->mca_sources); } out: