From patchwork Tue Sep 12 07:04:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamalesh Babulal X-Patchwork-Id: 138354 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp588171vqx; Tue, 12 Sep 2023 11:06:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5VfBUY53NFZ3F3WJzPA0DDRySSc1ejp314u5DT7zNevAHDtlVBEenLxhAgz48pi3TAxPT X-Received: by 2002:a17:902:a38d:b0:1bf:194a:953f with SMTP id x13-20020a170902a38d00b001bf194a953fmr450946pla.17.1694541994686; Tue, 12 Sep 2023 11:06:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1694541994; cv=pass; d=google.com; s=arc-20160816; b=I2dABEe948IGOFsCo0V+UZjbFOXdQH2Jep49Y4LwePhVWc9piWmN/DA4vRewyG3Vd6 ZuTw/gM4EMNny6nCL0kA83wvqzlJnVDwI4PAxEn+cJXux7ZZknPnwIY9b4ZGTI/HW1lV TU6p9u50V0gWELnqfaT0zylPofiFLoh9SLerUUUmeZoAow8LbwRLZf7IKyMCaj8FW2n/ iOaZJmSd+ZRdfA2qoDPugocG4XYv3+iGaWLTOHCWB7I17X/gmSVd1BNZXdXJrILM+gew /j8F1xHYHzUQP/SuaWzhLDTVDqcEk6vWNgvc0FQmKRsehV77mmT+wXfDRlSTLJNwt02i KFBw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=IbtARqtEJtnIVj732ScqBaTY+yhWlXka1stGRULn0WE=; fh=38cXEu1jWt6aUfV8dNAjZnnsO8IJLnL4ONruzKcIdJ4=; b=UBDjleeL9n1YRJx5PPUA8uAyfk36qFGjIK/Txoy6REZ1mpuTiwjdNxzZvDZXxjHMLL pOzW+CdE/b09JGOTwgCl9qzbrmBKBUxGul3uTZ4Kb0q9D7IzYFzWhDOK2l79QfsPKM1e LGplgteFsXpGNg7wflzn6Q/hWe6MElQ+38i24veQZrxiN2BRUYWIebXYet7qGKn0k/Q+ 4IvBvmAmMtFUDIKb9z5oOkADL3ikbHGewsX8NT8EFEfXqAp7vTcZP2OHKIQ8UbfUQO6w e7ZZ8EeU2lSDq1XqEk5CH8qDFGryherFk8es4fR0p27iNQu/Wu6uRKJX/M00YmsURDCD /iyw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=oTpm8pNo; dkim=pass header.i=@oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=EqOPPeqW; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id j4-20020a170903028400b001b9cdf11649si8538419plr.275.2023.09.12.11.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 11:06:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=oTpm8pNo; dkim=pass header.i=@oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=EqOPPeqW; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 6258685C4D7F; Tue, 12 Sep 2023 00:05:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231328AbjILHF2 (ORCPT + 38 others); Tue, 12 Sep 2023 03:05:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbjILHFX (ORCPT ); Tue, 12 Sep 2023 03:05:23 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF9E710DF; Tue, 12 Sep 2023 00:05:19 -0700 (PDT) Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38BJjYBH000817; Tue, 12 Sep 2023 07:05:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=IbtARqtEJtnIVj732ScqBaTY+yhWlXka1stGRULn0WE=; b=oTpm8pNo5rQ94xix2FhjyHu0uQx+3AEeddCPk21mhA5rDJloPLjL+BE73cTSvk3hVUwp Ef24r8BErllHf1t1PK80ALCXUzPQ3LALoIUrLDQW1awNsJecDyo04EGlgB4j7dOMRvdW vOearD+gJrQc9O2xng3JRe2Ab0ri6mqyrGgK60IQfVPtcXpU1Aow4tM7Ds71xOZk/EZF Y5P9wV6TEhvNMD9RS05eOEVhuuG6uMu0DZOpLtJOuL7WrpWDv9MqlsK2BFZEA2z/j0Rn R1qXYM/za6ELjJwltaFpFXRB5qXb3gYEJg3pgmFxLcsZz5S1R1l6Jx3i/L+seuBu/LID 5w== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3t1k4cu8cj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Sep 2023 07:05:01 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 38C71mhe007708; Tue, 12 Sep 2023 07:05:00 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2168.outbound.protection.outlook.com [104.47.73.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3t0f55bgeq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Sep 2023 07:05:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CQQQHjoAc6fx2vhv8wrkB8Oaq2CeDHkwB21brOfQz4q+BC1rnB49Tko3LTA01UdNynmrYyhiW9tQx7t4DiBicAIk+kTV+9ewLsnQC2PQrv9icBuB84LWH+8NmecRkXvjUulY88uiGaMmCPmjclsjQ36fYkhUeL+MJ+owhYc2c6yyiFsXKiFJMVkZil/qRjW6p2XmVTxGmw4dn4eCSrFfBn8xkKCE8ZGj7U/8bGZGxZhwSYA2+Fm8o6HXZsg1WGlogWABV425R6uHxkQDrK1FWfdXm0P1LjOpqWP4s9DddVOm9TidHCZ/V7DU8sMUYK8c45HwNaFePfRYY/U2BE3O1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IbtARqtEJtnIVj732ScqBaTY+yhWlXka1stGRULn0WE=; b=SJnwHr0ZYN0xf/w0LJVcT0vSdZ8wyrarzTXYQJM5SgGLe6DnHIPQIHi1YvTCo/puwKCn4D0Wgb+xqqyMkkMnDqw7VeGo+1/GAzFG0ZqQiEVZkN6kRZAIdJfkJUwB/SkmIMY5sBkaiS9V2M5/VQm1wFpexBgeW45b51wm1LImCTbdkHsMpofyKgHsp4GdMYhplb9zQEVVA/aBC8a8iwTs+ckxDs08Xm67IlnafW7onpupo5eTeu2CIAkefQdzg80SqR1NiJ59qKV7p57Npys9DCwRf/Tfz/Qu9sAYBYkjlZZTPwWKiW/+2NojpCdlRNyGspnRQFFGY08BvXZkul6GZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IbtARqtEJtnIVj732ScqBaTY+yhWlXka1stGRULn0WE=; b=EqOPPeqW1mnQ70nNOw0HQbZTh8p9Wx8QAHcmm7/iNmcgWRw/UxH43zbr1I4Td1RaEH9VTD4Vz992OU05OXx7sgthc+uQNqgKXi7Jh21JVYFtMWtU3E/kAmw+TZNnkSUexTTC1DkUW6wcwiyAVDtqaoz1xSaPVv/LeT2y/RYaeTI= Received: from DM6PR10MB3001.namprd10.prod.outlook.com (2603:10b6:5:69::23) by CH3PR10MB6689.namprd10.prod.outlook.com (2603:10b6:610:153::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.35; Tue, 12 Sep 2023 07:04:58 +0000 Received: from DM6PR10MB3001.namprd10.prod.outlook.com ([fe80::3c2a:5677:55fa:2d36]) by DM6PR10MB3001.namprd10.prod.outlook.com ([fe80::3c2a:5677:55fa:2d36%7]) with mapi id 15.20.6768.036; Tue, 12 Sep 2023 07:04:58 +0000 From: Kamalesh Babulal To: Tejun Heo , Zefan Li , Johannes Weiner Cc: Tom Hromatka , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] cgroup: Check for ret during cgroup1_base_files cft addition Date: Tue, 12 Sep 2023 12:34:34 +0530 Message-ID: <96694dfc5f4caf4d84a740c3b18b0a456c9ff522.1694501024.git.kamalesh.babulal@oracle.com> X-Mailer: git-send-email 2.41.0 X-ClientProxiedBy: MA0PR01CA0028.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:b8::16) To DM6PR10MB3001.namprd10.prod.outlook.com (2603:10b6:5:69::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB3001:EE_|CH3PR10MB6689:EE_ X-MS-Office365-Filtering-Correlation-Id: c3d55c30-b5a8-40c5-a105-08dbb35e9369 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6UVbpx/WvUJEEtpcHgDw4yMLxPPb7vaAMwEHHtzcBK3qVmyNnXZfuXCkMFNlud59ZJ67wNQ0UKevU4rMlmw5a11T461/W/1muDlUoXmkhf5mncjQtWACGbI1BjO4w02i5PBTdrUNpYfrLixtU0hTO+YuFIuG+UHvFUAu1HJitSxaH6+ZfFnpsgeLbyMeJZoEas+0CzL8sEoQCaXRJ9fiPqRYNtjLfJe1V/YntHgxE3+HSJCHsOY4tOR81i+uvi5vnytDdjzCLzqmOqP0RbuJ1/sSlHR508PY1u9Kmk0rRBj/OwsBQ9gwyAC2VSK2p4EoPWZ/61LL7kep8Rk1nhl9adMd0FLty69or6+I4RIWaYIe6RTIZdpHsYFc419EIJ98pZSk0yBi0/DgHE8/Jl1NyP7Aaws+nXmEOzj8UjXJ/IEi/j/CM0sPH1Fsv9WEO59Aki3ypyYQj+DGOyPCPHzNCnwSSzT1aTdtZW+S3HbLAMEXCrYHtWiQ9yOT3k4NH/k2WDlbmDChBYSGMU/xIMXQUC78sBMnPdE8tuJ0A0h1z8VqFeKK4YjTAf1WAs6yB1bx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB3001.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(136003)(376002)(366004)(396003)(451199024)(186009)(1800799009)(41300700001)(5660300002)(38100700002)(6666004)(6512007)(478600001)(83380400001)(2906002)(6506007)(6486002)(2616005)(4744005)(66556008)(66946007)(44832011)(66476007)(86362001)(316002)(110136005)(36756003)(8676002)(4326008)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DenBZuBWRv130BUwQk8Cw0zLI87w3mh/n9zsdpKsjbhNL0lDMfzYrGo5zsBsp9gp88aMODMnZhrXdC0VqNsefB0blXKWbCSLwnDUfFcHshxgDrdclKfhtQSo4er4lnXpNYl5aWP2E7rSON0nv4JtpzGX9GNr0mKLiCrtFl3nYjn2ZInab0p4ZLvbqKjgi6t9TCXeAAIFAFH8DsTKdH8qxNrJFWDUFond5QRd86lv30f7I80NqzW3fW+chnQDtgZAH8+vqmNfT0+Un1eRoDJ9sjk3RJ+Ga/agvv+4pVkS5ewrjOaizaAM8KlhJc562t0qsTAdl3jsUU+heJ8C/3BwhH8/rFO9jhy9YbZzJ3xMOQ4BoYuEGdXHRr6rN6IYZbyiqxGZslgYdIzHPFyC5x664D2iDyWXLTW8btFub4Wofwikw5578ZNnQERewFnG2IO4nBlmcdq6NlNbTd4sOv5HsXJXO8TW6z1HekRnTSd3Sz80j6jxSxTUCdf3kRjw6+FHlsF+Ob904fJHplFJir/pnCW11+BvKyB3g5kFuDqL5fK4/3E3fV+XzwJp5HqE+myYdx5q2EAa4JtTDrvXBrzIj5iCrLwBjWfMP7IiJX7gnNzohG2d3BCdU2Zy8zS9eQXyYh8pFfrq2D6UERsWiH7l58KdLrl1qZ7JYmcaLmWdUFcujBjFPYsiRGPr9fAOg6rcTBTsyI7sVJ/ep3vHPdJrPwP4eIUSV9TP2m8haYC1IVIgsaC8qhl6TPcNG3gaE7aNaxo0Sz3FntiPSpLF+TtyVDwZrayqCnEvp2KUC+a/DZx9mNnPse6k78KnvdITiSwi/96kjpTHHwTLDgsa0MFRcyuR1EXpr3F4OtoD3Rk2W4ZP6n6AIiqbNT4IkZ1pk/hoyz3bkVkLHF41ETnLGGINnlktgSKhr1599toi2agz5WJQPAWIgtmBJoN3a9KhK6tqz/QRNxKAIflF9kqIioEr01lt5KL+spYZPUftb3Z6uVuQezbP5y4KU+FFJtV/wAS+DzptUaV4E2vms06Xf+Mlq3CAJP5wAzq0kGlnBo9iqjsS7WG/x/H00Vh6tDOS3BZfAvJz6JTFFE586u4JBZ+Cx/tf9J/srEJ+USr3XptkNpRR9XiksFRrosnX8LempObHyHcnsNswfRl3pMlaHch190KY0A2plVJvGJnbPfCPN/NGsC8TUUGfmfZqER/DQCBw3Z4SRqSAoOVjwt27pRmvQmzVp2ppHjSkfBOAJe9zn1NjQkdaKFPwk0iC/G98lBPJHsu94z4eM+5B4v1CxrIIBbccdxT5HZSAzyizjNz7GmDOvb4s9/DwXNv0IqdHKKdvzs1Uz8Q2TGGmAAhdLHf7zUQ6kHEqCABbJI82vwDzyIRWAu0Ga9x8VHfmd+HdWmD6a1oUWHuUsCexe1RObiCl3eHvib2vXPYZn1SNBLaXSrFdvgKCjbE0xlthqatFnEOfLrZUZrBoPuof5NRi6AZ44hWPyA+Z+hRJAn9suYdQCj8voZT4ARcJtsIUjJJUwUB3B/vi8l/qnWRa7dzwrtVoACOR79k9KRLG6MPvcFCzZmQrC8gTrCR97iszVmWI36PlEKPLnF2JNRknML+F4HUJtVxHN41Xw1/fEWEUOJRpkx6+yUwPEtk4ZaWGdZMmDpghe3hFeKGhtAl1g7JV3Wy0/A== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: THndrcsiYDv2Cy3gL0ll3pZrbA+Qd3469cX711rf1oocPtvrYFoJiPkUGVu+vbtgpRbgDL+qikyx9B4NjP10yAQ0Cd0M553EFmhOtsPgUiFqc2gW6EsbhWrM/DtUfF5Ew+/j5DcuEE/H9GhhU9Fy1GV+vmWsl8hrqG0C8H08xJzaoQo4ySsLp9u6ZexWrXt2dnm+mffZsrzcdeEFAJTnDi29q2kVi+rLz1D7fhJVv95SOGX6nxvjXh5QxEbX3lHARLfmHQ0e7BePK5h+9otoU5NoFHLhXO+nVsACgcM+lHS2bRU/pZzjXS6FICPBc8W8drpW00ztzjMYkbknS3vteq/hNmVltn9thwZ05Q15coNPrcjBhgxyIBsPfVMJs0vJZJDjRkdoBlMVEIoHyo+Y0rtKjEt4lr/r+ky7P6nKLoWPcBeypJFpFVY69HS0WLn4VnTGLEeMfPWB+Lhf8/Ntu0fjHb82wPXKqTJGeodc7hoZ5swFobgReE//i6BArrwFlN4RKCXNKljIwgb6W+0U0PRzqAvar374m86+45dk7wpYF+B4ir8hRyUvETXOEp+NHRDnurex++JxDHmIjta8KEOZRrwxJ6MUMt+Xk2k/aigEJY+sslHDTn/OTYxxKI7R0dZJLOqX5UIVwhevJU6G4OeWfSJxTycCXojI+XUA5onPDnmCSPmueASAOP7UxRmUS99Ttf7SFyp06ok3Nl52mFJbP27Me9WTiAjtu+dSqVRQzd3bSmwfpMqKfvq8Wfoohl0Gp4JJDc2ZjLfCKHQ4F60SWb0WsSKvH36t1tCf4cuE3LKSoG0FR1TNEQgogqqB6hU/3PRyT+YQt6QfEKEZtNqIkyFO8CI0aE6/3I/ck8s= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3d55c30-b5a8-40c5-a105-08dbb35e9369 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3001.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 07:04:58.5700 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qxz9r9gpWODmWZJc9dp1kmscUpoWOUrKomyixnveWy+28GAIGIPsyLIFhbnFTyO2pu2GkUXzuYmQoan0tfoYO1vCG9ICpGtFsHbEGIBC56g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6689 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-12_04,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309120059 X-Proofpoint-GUID: _VMCm9yoGPwK1U7qHjUlNY_YXHCnORka X-Proofpoint-ORIG-GUID: _VMCm9yoGPwK1U7qHjUlNY_YXHCnORka Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Sep 2023 00:05:47 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776856066921923067 X-GMAIL-MSGID: 1776856066921923067 There is no check for possible failure while populating cgroup1_base_files cft in css_populate_dir(), like its cgroup v2 counter parts cgroup_{base,psi}_files. In case of failure, the cgroup might not be set up right. Add ret value check to return on failure. Signed-off-by: Kamalesh Babulal --- kernel/cgroup/cgroup.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 1fb7f562289d..a6b1ea324b0e 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -1731,8 +1731,10 @@ static int css_populate_dir(struct cgroup_subsys_state *css) return ret; } } else { - cgroup_addrm_files(css, cgrp, - cgroup1_base_files, true); + ret = cgroup_addrm_files(css, cgrp, + cgroup1_base_files, true); + if (ret < 0) + return ret; } } else { list_for_each_entry(cfts, &css->ss->cfts, node) { From patchwork Tue Sep 12 07:04:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamalesh Babulal X-Patchwork-Id: 138029 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp257609vqx; Tue, 12 Sep 2023 01:28:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoRDtPcrQbt1/Kh5wyvdmlpEMk0655Rfc0yFfU0CL/Z4gs3GHRkQk1ZvQcdvb8Y4WEhIHJ X-Received: by 2002:a05:6a20:321b:b0:149:7fea:d89d with SMTP id hl27-20020a056a20321b00b001497fead89dmr8830477pzc.54.1694507299027; Tue, 12 Sep 2023 01:28:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1694507299; cv=pass; d=google.com; s=arc-20160816; b=LKU5E0C/mAAP0uRwPk/GuRPo7Ewr3NKj1zZbO052jP2OECV2EWe+8D/b3CP5k5hzyZ vmMTyBh+dqgMRHa/sHVMcdP64CXIbBmaoMLO+PjiDgzv9Z/mKYvhYKzxGxxZXbni7+3X A5qL376jLERYnYkIqYrE6eG20P76G+yITio+0totUTDlwjokowuFGFgAFmUuqohAqogy KuYRkIDXfjXoTIQNTHZl9/YytY/3UhsjScPdv+QXeb1TZrtmn72txcT5lNvdy+QSVxFL fhfRhFBPnROVf0lpR89YTQuLg+fCLAKQ/gqvoBKW3TFZ28Ag7v3kHPJaQKWzxCeY0pJR 7CuQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=1b8I90tAdz+bE6JZJ/5tIQJobWNFIwRGJFQzIURIWZ8=; fh=38cXEu1jWt6aUfV8dNAjZnnsO8IJLnL4ONruzKcIdJ4=; b=lG0XIvkps13at2uPH56C645mW7iBvEzx1Knv7CU5qrsRc9EoimzsSCUcV4rENhnuXZ NDX5leKhZ5saA0qivPu77hMStBI0rlLzus/AwPACL87WiFMfKIFAWfv8iCVkWLoiODd5 7LWY8rO4xUidQJgtbVejSIbGsJbE4XbWDVNa39D5bemUbFxbzX4QhVlfz9rFy560HPCx 1Fso4krGxo8ECvQ2T91JSIJKGuCyXx7mnqE+kTdyqkmq79PnZeppeiaI3/pvacLwH84f gNvIm6kOJLz4fD8FN0ry1jpsxSXHSCKekqzfIH3k9el+tFwGnRa3QguAsicEdx3GCbZj CWsg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=mu8EXXGX; dkim=pass header.i=@oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=D8Ei0jIt; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id u12-20020a65670c000000b0056963f23048si7403398pgf.84.2023.09.12.01.28.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 01:28:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=mu8EXXGX; dkim=pass header.i=@oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=D8Ei0jIt; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 92E2E80CBF1A; Tue, 12 Sep 2023 00:05:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231356AbjILHFf (ORCPT + 38 others); Tue, 12 Sep 2023 03:05:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231318AbjILHFb (ORCPT ); Tue, 12 Sep 2023 03:05:31 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBE299B; Tue, 12 Sep 2023 00:05:26 -0700 (PDT) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38BJSOAl028444; Tue, 12 Sep 2023 07:05:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=1b8I90tAdz+bE6JZJ/5tIQJobWNFIwRGJFQzIURIWZ8=; b=mu8EXXGXnMounHiTfobQeETY3J9A6KgAubU6jPqiBGRyDNnyQmmC6esXq18xPQDnG/KU KS9R+g6N9HrKnHECuz1Z7cnZb/f7vSo+PzoY697afD0H7vavh0Nb/jV9igoth/Eta/c5 yPvDa+dx6mkq2M23YtALEZPydH9NX6qnwY7CRz66T1z3Rxs/w/392CbLLS+oFaT52YYz vBkX5Cfl7xYSYuWRq02Esc0oV/7KK673qRCP0cpZfjswDF1BCJX1SWLB1+jE46WJUg4O oT1ekhRNQFik9aSaBMKll0XhgHuRCOKAXbSY4cnRE5omDyGXzXdEtZcDXRt+E5McRmmY qQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3t1jp7b806-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Sep 2023 07:05:12 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 38C5Fg81004375; Tue, 12 Sep 2023 07:05:11 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2175.outbound.protection.outlook.com [104.47.73.175]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3t0f5636g4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Sep 2023 07:05:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R72GyMiHnwM1w0PlyNZGelCwSReM6Yy3WTg2zq3aqlkPPp4xKQj85X0OG16cfiVl0kXXKRevoGHltqzWOqekMa5sQbP2Z1AjO1wq9rK//cqO8ikqjESZq2DW8YNlVQC4UOZZ4zOy8DA+xP+lrL0Rv1I+GmYV/yTWvdHoPRnTTqVYcXbm9dSi0r1waHaY8wor20zJqx6GH1XbC4fch+nYM2UExM3OeJ7aVSHwE3wgVMLupqD6MdpLXOV2ybrIFdj6Pp1s+w18hCjg7ZPRPMPfWvSjdeG4z5evXrduB3Y9plrPiVx/Y9F64djlCL/XFYXm3OSalFqwPcj4PINN1o/E2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1b8I90tAdz+bE6JZJ/5tIQJobWNFIwRGJFQzIURIWZ8=; b=m5vkwXzda57PutSNSuhSWRaMnrU3A3xyDL9/uYGCWqfKQk0qJhLu77lDiY44lxi0ofiQ/p9PIvDhOIOxCJKHwOaB1K1QSruFAtBlTHY2xLcBEnkSwmT+D5G/2qzTdYNUuZWf/zRnCM6UQBPM8cQnJV/qVE7aSRJnx8nZea2VwZOhYuOxoJdZtuEbRXdiO+CpaTO1o19ZAqKyFb9IVS5xvkYeWt7a1GGqRE+JyA9kxDdnPLAecJs/WFRnJnuBUjB9rx2IS9nA81aePPLUAvGSL2XbF9hGcnZhqGO+pFMUloPj94tQp0IHOa0vrRb34Fl8MH0BsgaBE/v5bxSgFc7SKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1b8I90tAdz+bE6JZJ/5tIQJobWNFIwRGJFQzIURIWZ8=; b=D8Ei0jItgRhTL5P/z7Crw9FRkx7JUTOE1ZXS+LUwxenHAfTuqfND0na1pEGImEejob9zjRuUuJHZRpUXw2/2ey2aARDvZOs9X4VWNlQecQuvrFCBLKNRrauwz7Nn8D8Bs0oD8CTKRLC1vEZxvNGxbYLHqONJv0mgTAZJT3NGDFM= Received: from DM6PR10MB3001.namprd10.prod.outlook.com (2603:10b6:5:69::23) by CH3PR10MB6689.namprd10.prod.outlook.com (2603:10b6:610:153::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.35; Tue, 12 Sep 2023 07:05:09 +0000 Received: from DM6PR10MB3001.namprd10.prod.outlook.com ([fe80::3c2a:5677:55fa:2d36]) by DM6PR10MB3001.namprd10.prod.outlook.com ([fe80::3c2a:5677:55fa:2d36%7]) with mapi id 15.20.6768.036; Tue, 12 Sep 2023 07:05:09 +0000 From: Kamalesh Babulal To: Tejun Heo , Zefan Li , Johannes Weiner Cc: Tom Hromatka , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] cgroup: Avoid extra dereference in css_populate_dir() Date: Tue, 12 Sep 2023 12:34:35 +0530 Message-ID: <5870fc2459d97b2e47c5a8dc47f1a2a3837c5e03.1694501024.git.kamalesh.babulal@oracle.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <96694dfc5f4caf4d84a740c3b18b0a456c9ff522.1694501024.git.kamalesh.babulal@oracle.com> References: <96694dfc5f4caf4d84a740c3b18b0a456c9ff522.1694501024.git.kamalesh.babulal@oracle.com> X-ClientProxiedBy: MA0PR01CA0012.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:80::11) To DM6PR10MB3001.namprd10.prod.outlook.com (2603:10b6:5:69::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB3001:EE_|CH3PR10MB6689:EE_ X-MS-Office365-Filtering-Correlation-Id: 197d33f3-9074-4bc4-6dd6-08dbb35e99ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jiq7fUoT/iilzomZTKko8Xqd7jo3sUr7OX6igufTiDV7CEmqVq5NBhw6GPmIr+uMhVtjkairuhehwEiNOUWo5Ox8T5fH+fnN3IMLv1bOMOYOubfaAXxcLuqa3Gdia24XBCOsYs5VCaM9RT/bXJEGmaTrqDyfTsKfpnVzkSezLPWnHe7jIexr/GPhahowOx/ZeeisQCoOagBTXFyWPPWarrf8icuGm0ktSvH16C93uOFgOo9yHRYdANR3DKbeGgqKJy8Nb/9dJ2xPwGvR+0ArdzGb62xp0+3rZVKFCMYrpD3/qmvZmPLb3cJ7DmlI0+cjySFGdsb0hm3Bxg6RmCMr9bpyc4iC8yKKivAMcRRmW25Ntb3txVOoeDKxXUFdWpRGj6n4sac4zt72CcBUtAA6fTc9YWeiCDX5BIt5UO4iel7IStLKdM39/M2V0TZzG2c7MjyvqipbmXCQde+MsBGAFotgUtYza5GIAxT4xNl/D89eItBJsLDfUYcyRsO2g5remNQuijDBpnmLu2R+8DAJfKRSPQjReCbCDHupqRqKKTxDMoqBfhy6mlN8hpfImIjF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB3001.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(136003)(376002)(366004)(396003)(451199024)(186009)(1800799009)(41300700001)(5660300002)(38100700002)(6666004)(6512007)(478600001)(83380400001)(2906002)(6506007)(6486002)(2616005)(66556008)(66946007)(44832011)(66476007)(86362001)(316002)(110136005)(36756003)(8676002)(4326008)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +37z2nvEMD5/8X2fEzhwCQFQ37zjvfFa0KoLhzJQL4aQBP+k0ktJP0ByGgUpMXHz6MJKS0Ve+a+O4Bbhw7R8r08nvy1tLCD7Uh+sabGlzVT3i1oOHeSZ8ATkHZAUR38nSZgYuAabptlVtR3fCFIzRwXLdoBA+Q6ThK64BeVxG/C+lqZsEVRjIVWwipBiLHn6/1/iEtRchBT4dtO6L672jXCk+joia7PD/K9cdiUqSXN5VpBSToxZ4vHQQpH2l350SRW+AZvM5LYS1iCxSXmZR9U+7NSgfxtt5XsPaYzOsdN+4L1aHE7ujiu5JSjvQcsi+4IQ0/tvDA2FKcCFcpjjUUmbUDCVhjMjdfK7LKcglDVe49IOmSD2hszAxJVpORwcK4wfWVJwAd53kIRWH7ZYmkoAMYvLfpunLkFaVPNNkzWM+0Jinykt7MeIS9CDirS4KNzZH7oa0pytf+uYeLqWHCpW/lpwIDWLhjM0fM0hELNGFZRj3rn63gexMuxc7atfWeoQwC3Ly8nA6yi1n8IdenMOZxJa0pwt64IklVgKdsUKXuU9gD7cctdsnWOyzwyvQNJn0NyD/Gcz087hZRuUjusfCxn+mppoARJmkU7CPNnZatcHfkDItFoKNI2mfrMH/l3okybqiU1rE4+KScQI6ZmKvkFwJyE+saOW9OxSnQ2+5dat++SYzZ2wdYd50D+9/EQe4vN5w784yQ3OnJXdVmznwLT8mOLGIKqXqhAk69JODFyhL+uGPD6TwA8XxINbk2+KdoQcUgaQkok2DDMaTLflu6u0XFzo2YvHvGhncJ+1Q7SDvX5x4OUBeQNAkND0LUdbPiyjOFZJYu3vzJ6HQnNX2SAwe7hkT/giXU4h9oQkxnQOWXnmAUz+Lfo2g2vRMisInGe9eJoyChd2m3/qkLmgnPRCueoHoZvja8q+3s6pJhBdO4G7JLhFobZaPGnJwrNCw/7SDMkK0funsYQ5U3NWNGw5g6eCFgDPJHUKJgwZYnhVDCVKohtXu+mFB12OdwOfVByOU5L66lCcm4IyYHRjhqmJeGFT3Bb04yiliLQf1f+2F4WvFjomv4a32hXd8Ouj8R5nEDm7GQFebtw3nlz5XVn+Qk+h31p1aSje340XZGpyNwbNgtAqZMA3cBA4KYBQcX+3nktPc7NWEwAfRtuXmxSN38w2IuhWsXOAvN5qecxRa0ZohLqskkX4S+kQ14gwz0JsOJ8snfCDmMDoFTNExwMR+v4x9Z8mb/a5HKvreiq8YCD/pUww7jDman9EkSb9Enje9BZZ/JNc1clwkA8WrUwM3t4ctb6fVpQE27SGL8X/QOtIhiHKGpD+0xNkkY722X/o5w/xid8XzyNUTRMf0jlOzqKGtrbTYCt+5esGm3Gutr1OMejej5MhLrd53+HNzy0NCb568X/yyPWSAKd444NJrXPpEb0zZOveQncXJyrctjHnc346Qzy7xKHaDN3lqDxy1cP1u/qpBvtywlwoJrQoqUSWkVeOLPYFbmRYXZGifYYrFRyTaAIJ2ChMFGske9g2468xpIHm/G2nntqi80XkqVPhK/EWHEWV2LRx58keSy5TUfjsqslphFHuYHysdGqA3QDO61nLFm9pZSJO8jjcPNGFLKS3UOe+3+DZ6sfhQbAyySqHI+ydsYxKV5MQrRJFdeSl4D/Vx7WDbQ== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2i/ofW1SxHZFOlpcNT7Ge65XxzLWKZyXn/bEJFBJv66zO/RB6f+Ie0lvM8iDCXR6fs6xbCR3SriPMrhEGJxQUxSEILnx7xLOvrtwurmgQtkyedxLEvqexiJh8iPDnlObmu6KdlC1z3hiAWUZOeuxVZAATMFFarNeGU7Qfg63miR4EfhFWRZVhjWx0f8Xl9oue7Id3N6HAioefSLQJ1yuCvuVfe3+LXOuww4gpPfLzDdgv1WwfNutHjSo5opQBWLqhZ5SVvBCgfR0Rsojm7y2lSpu+2pIe1S8tlL4/iGVJxfHMLTKZtGn5PfHaag0/QE7EpuKYyOip0GlyyrKLdVifBhbY54spwXenY+dHne9fYXTegLMdClHSlOcUXirEwtNmKlzGi8LtsCQ/nl9MaJoXfoGNQvoGhz0QE0hkEGCNz2nWwIeTGlRYui8DWarMG2pX6f+KMdGxxYQM2LhfYCfjFTRdA6U91AV4nr64j1NJNHRTLL4tPkgK6yDV/jzMbV8vGMFwXNqErW3m6rceCNCHlDJSjt3ipsshBaWxbQQLLCgo96EkJqOqevNHJ5hTGGrhH8CXhTNlakSYeGq+fSSPz0YMRVh6zbmeNzVAbt8kUjK2hyPeQj58wyGBXn0Y40RlcEi/fPYXx8gBnGKoZtC+oIogBs9/r/We+dzMEy4FlLZd3HnzHbdbVKILVhWsd747AIk0MPcOmWLBd4WWHCwZ2nibdFWNs9StikfWD6rtoHwSj9l3ImjRBMaEG881T/kxWlbXCOAG04nZnHshKjB73jT6PSce3yrBdHO9NB5R3o4A2tb1SNB2LJGqNPGTyZNERgesmY4TwWyQzXzbXGz9dWsPtrkrZeUFq2ywy9Lmtc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 197d33f3-9074-4bc4-6dd6-08dbb35e99ee X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3001.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 07:05:09.4806 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k8m/8fUv8MXG1Ta0a333OcT4oEyFhb0QBIKgJOCzsuBS0w5x6Astmpp60v+v2pSAjwRGuzUFSzzzcnX2o6U9rCrshitXDOc5tHwptPcgcnI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6689 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-12_04,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=862 mlxscore=0 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309120059 X-Proofpoint-GUID: FQXGoZ8vA68ldli-vK952ASrNNx--xGB X-Proofpoint-ORIG-GUID: FQXGoZ8vA68ldli-vK952ASrNNx--xGB Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 00:05:57 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776819685758493731 X-GMAIL-MSGID: 1776819685758493731 Use css directly instead of dereferencing it from &cgroup->self, while adding the cgroup v2 cft base and psi files in css_populate_dir(). Both points to the same css, when css->ss is NULL, this avoids extra deferences and makes code consistent in usage across the function. Signed-off-by: Kamalesh Babulal --- kernel/cgroup/cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index a6b1ea324b0e..f8ff85033e5a 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -1719,13 +1719,13 @@ static int css_populate_dir(struct cgroup_subsys_state *css) if (!css->ss) { if (cgroup_on_dfl(cgrp)) { - ret = cgroup_addrm_files(&cgrp->self, cgrp, + ret = cgroup_addrm_files(css, cgrp, cgroup_base_files, true); if (ret < 0) return ret; if (cgroup_psi_enabled()) { - ret = cgroup_addrm_files(&cgrp->self, cgrp, + ret = cgroup_addrm_files(css, cgrp, cgroup_psi_files, true); if (ret < 0) return ret;