From patchwork Fri Sep 8 08:43:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 137706 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ab0a:0:b0:3f2:4152:657d with SMTP id m10csp403302vqo; Fri, 8 Sep 2023 01:44:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGYDsBvGz7uLDd0tg90ggdDUOzmjk0a+/mrtUf34ZHtokSif8MnXFAUpZyEY6gpIcgmlpj X-Received: by 2002:a05:6512:455:b0:500:9214:b309 with SMTP id y21-20020a056512045500b005009214b309mr1451239lfk.56.1694162678255; Fri, 08 Sep 2023 01:44:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694162678; cv=none; d=google.com; s=arc-20160816; b=O5xqdklJc4XvkJNB7Su6xSQX1rRygFeLw9ewCHtyX3bpcMKG/RTOsGcR4s/46+9U0Y NSGoMLOF/dLvVFljpT/+/cioOJlIgWcgd5b1ZHIuAXqifg1FqDbe+ZYNFtuoJ8BN3Uwe btyUUAYYyniGok44IY9xkYyKQkqEwyQO/TDqL0TB2/IbuP8fAyaHGmPDBWnCC/R8rTgh CIseTOoOTmBg9ASaG/pAHnJuxQZkl6PJ737odNbIZ1Fp5KVtjnbNLJJ2QJ+r/wOKaVVi AS/JNtyvC8Z0IuzAx2mMlFTZDawhcK1663ZRtHcLr8ITTJuAzAWHz8EMRInwAeD/+1/f T1jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=ZJ1h2miLRdz7yaG9DWDTtHAP/AtS3WjeUY8fBdxygCU=; fh=Hp+9zlZKvbBe8EKhuhRO1HzybF9R8P3bsE8+GVZ4CVs=; b=hiAuhgPa7BPaSCX9QVTeuE889rFLhsXnNFWYpYVbjlAX1la7KC/1YWHVBpbVKDDKLE nhNSiUh23CEBmxNtki2JtSaieayZzD2x7aqJi0gvzVVoaapnyVrVcdwurbaqY479mHEG mGoCDO4EAizbxop7LJuK+Bgvwh4VoTEqhcsK84y0DZ753E/wG4HciZyy7vWCWQwvgQeH Yw1idDkF7KfigIx3L0BZkZU2anp+Z46EO628KPgHHVupZOikglG+C2DtbbYhGIW1WqOu 6jU5a9WbvPe6Y4+Bl4B7I5w4kTuiNOI2NuWCPBD/nFsPOWdWPCSSFxOQWvURnkZdhC58 +Czw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=rhNqWeDB; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id r20-20020aa7c154000000b0052328243d1csi1043948edp.141.2023.09.08.01.44.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Sep 2023 01:44:38 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=rhNqWeDB; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 22B663858D38 for ; Fri, 8 Sep 2023 08:44:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 22B663858D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1694162677; bh=ZJ1h2miLRdz7yaG9DWDTtHAP/AtS3WjeUY8fBdxygCU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=rhNqWeDBiOwEnqaPRubhVOHI2le9vRUkEqCwPR6TExsonuoLm0p+pHlfUO+hM8YKy 1UU64/R4o5WC8VVVu6LPOvG/qQRb0OFzy91Ap+ararna1JhjEDKcOH0U25rCUFptbg vpAQRrkj/9RLwP9USb8MLTQfYhqIXUDvjfdlb7LA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id 649B23858D1E for ; Fri, 8 Sep 2023 08:43:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 649B23858D1E Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3ab3aceaf2aso1185765b6e.2 for ; Fri, 08 Sep 2023 01:43:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694162630; x=1694767430; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZJ1h2miLRdz7yaG9DWDTtHAP/AtS3WjeUY8fBdxygCU=; b=koENxaaZaZv6jd7U//PJZ9wKhZgm6jGNw6YOxOANsFUSQiXkAJTxi+yaWSiFAy9pGp Ia04HuK8oK6N9LH6Tqme0vFgzK7CDvuJR0PDUGKqS/5CM5LVMUcXXwOfMMcVJG8d/wd3 IZPK4mmjLiOjBsENRICkQyo9q+YLENWwBNW2fP89AtAEE9l0Kt2JT5o/WIIR8tmHEBcB h9mwI4vlqyVM0TK0HVcF5Dq9cwrM2NH/u52mkWSNtxWDf6pWqpViCvCnQgsUvgoKkglw ECqq4TtIKdl09vPsemuZ7OSSlaTcajPm5bJO6QgL8WjNfNcfvcRh7QBAQyuliV1VMOy0 xpWQ== X-Gm-Message-State: AOJu0YxYWRTQx/JgJ1YppJ5Y0PXm4b2PSJfgxwmP/VU3Baqp8VHYogfJ VkLecLwo+5npdxNQA2yeTv+v8ALogb7MqpAl/MoPjA== X-Received: by 2002:aca:2b15:0:b0:3a7:449c:8aae with SMTP id i21-20020aca2b15000000b003a7449c8aaemr2063728oik.26.1694162630244; Fri, 08 Sep 2023 01:43:50 -0700 (PDT) Received: from localhost.localdomain ([139.178.84.207]) by smtp.gmail.com with ESMTPSA id w6-20020a056808018600b003a76d7f596esm493985oic.54.2023.09.08.01.43.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Sep 2023 01:43:49 -0700 (PDT) To: gcc-patches@gcc.gnu.org, Kyrylo.Tkachov@arm.com, richard.earnshaw@arm.com, stam.markianos-wright@arm.com Subject: [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c Date: Fri, 8 Sep 2023 08:43:21 +0000 Message-Id: <20230908084321.567591-1-christophe.lyon@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christophe Lyon via Gcc-patches From: Christophe Lyon Reply-To: Christophe Lyon Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776458324018474691 X-GMAIL-MSGID: 1776458324018474691 The test was declaring 'int *carry;' and wrote to '*carry' without initializing 'carry' first, leading to an attempt to write at address zero, and a crash. Fix by declaring 'int carry;' and passing '&carrry' instead of 'carry' as parameter. 2023-09-08 Christophe Lyon gcc/testsuite/ * gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c: Fix. --- .../arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c index a8c6cce67c8..931c9d2f30b 100644 --- a/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c +++ b/gcc/testsuite/gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c @@ -7,7 +7,7 @@ volatile int32x4_t c1; volatile uint32x4_t c2; -int *carry; +int carry; int main () @@ -21,45 +21,45 @@ main () uint32x4_t inactive2 = vcreateq_u32 (0, 0); mve_pred16_t p = 0xFFFF; - (*carry) = 0xFFFFFFFF; + carry = 0xFFFFFFFF; __builtin_arm_set_fpscr_nzcvqc (0); - c1 = vadcq (a1, b1, carry); + c1 = vadcq (a1, b1, &carry); if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000) __builtin_abort (); - (*carry) = 0xFFFFFFFF; + carry = 0xFFFFFFFF; __builtin_arm_set_fpscr_nzcvqc (0); - c2 = vadcq (a2, b2, carry); + c2 = vadcq (a2, b2, &carry); if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000) __builtin_abort (); - (*carry) = 0xFFFFFFFF; + carry = 0xFFFFFFFF; __builtin_arm_set_fpscr_nzcvqc (0); - c1 = vsbcq (a1, b1, carry); + c1 = vsbcq (a1, b1, &carry); if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000) __builtin_abort (); - (*carry) = 0xFFFFFFFF; + carry = 0xFFFFFFFF; __builtin_arm_set_fpscr_nzcvqc (0); - c2 = vsbcq (a2, b2, carry); + c2 = vsbcq (a2, b2, &carry); if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000) __builtin_abort (); - (*carry) = 0xFFFFFFFF; + carry = 0xFFFFFFFF; __builtin_arm_set_fpscr_nzcvqc (0); - c1 = vadcq_m (inactive1, a1, b1, carry, p); + c1 = vadcq_m (inactive1, a1, b1, &carry, p); if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000) __builtin_abort (); - (*carry) = 0xFFFFFFFF; + carry = 0xFFFFFFFF; __builtin_arm_set_fpscr_nzcvqc (0); - c2 = vadcq_m (inactive2, a2, b2, carry, p); + c2 = vadcq_m (inactive2, a2, b2, &carry, p); if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000) __builtin_abort (); - (*carry) = 0xFFFFFFFF; + carry = 0xFFFFFFFF; __builtin_arm_set_fpscr_nzcvqc (0); - c1 = vsbcq_m (inactive1, a1, b1, carry, p); + c1 = vsbcq_m (inactive1, a1, b1, &carry, p); if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000) __builtin_abort (); - (*carry) = 0xFFFFFFFF; + carry = 0xFFFFFFFF; __builtin_arm_set_fpscr_nzcvqc (0); - c2 = vsbcq_m (inactive2, a2, b2, carry, p); + c2 = vsbcq_m (inactive2, a2, b2, &carry, p); if (__builtin_arm_get_fpscr_nzcvqc () & !0x20000000) __builtin_abort ();