From patchwork Wed Sep 6 09:47:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "juzhe.zhong@rivai.ai" X-Patchwork-Id: 137561 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ab0a:0:b0:3f2:4152:657d with SMTP id m10csp2200197vqo; Wed, 6 Sep 2023 02:48:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjH2EhlNV2OKi0YVCj4mbKgKzQF7ttbjEWzmtpCHkKz7hvwx7L1yCPghQfGZ8xJpUbEMiA X-Received: by 2002:ac2:58d6:0:b0:4fb:9469:d659 with SMTP id u22-20020ac258d6000000b004fb9469d659mr1796125lfo.23.1693993718389; Wed, 06 Sep 2023 02:48:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693993718; cv=none; d=google.com; s=arc-20160816; b=z8zb11xJBcBSKwmfpoltNoTgAtgaY9xUgF09UEmP/XIUm/4d/cPHSHrccgDzq2g89B oYcNFME1VTUkVXYADqwky45+v2/FMvw60No+UKzZuvLaFhiDZxA1ySbNNmgyAJ3U6iBN q6BhuLw//OJBjMzywN/D7Reo2NyhH9ecX6vl05UGdCC5m8lNcNnIlp+y5RaXTDRKPA2e hWD/wOrRRu7EqIiRRuZbH0aoMzX2ZTZVBn0VKuPntoc9j0Y5j8jzI282Hp6F1+mFLJFx hTR7uUxjQB7APjVSfLiwqYxxIqYEQ5eJAr+D9FlaVpUmFXHRcU9kXTye4POFUa7dhs1v ypDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:feedback-id :content-transfer-encoding:mime-version:message-id:date:subject:to :from:dmarc-filter:delivered-to; bh=QTRfSzulS/MBb3tznMF0AuGhAZdkCmES8y8EZDV0tyk=; fh=arl273cIQBNH1P6XLxHQvF0scgitfd773vOV+bwQx3o=; b=QdCvFAypXNtmZPXQCDzz1+/F3Q8auY0IHc8WNzZ5OAOjc8WU8bUDQRtMMbDp7l7uoK nD9BK4COy3Cbjn5XljaHfeQX7/wnVb/q767Tk6bik5w1oPFvi3nMW21Ll2cmHIWMKMZN 029omzm52qaYyq9EZgZYKHLjxwU5T3Z1wZEgdbz4YcRpTXAuE4GWZ7Xm2/EuTLdVJJxs fM8PswDbdFJYhi8u/fTc0a2qg3E86eeJSb1dH03BWYg/EcV/FphQOaIajcrtwXR4zbxK 7/sFaasOpHJ7wm1oWXqKtbadRKuozz8zWB2azY9PwJsWBF7cQvymiPgHjJaaykwQjf/S iPNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id g14-20020a1709061e0e00b009a1b857e3b7si9062202ejj.481.2023.09.06.02.48.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 02:48:38 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 189F83857BA4 for ; Wed, 6 Sep 2023 09:48:34 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) by sourceware.org (Postfix) with ESMTPS id 3B2113858D35 for ; Wed, 6 Sep 2023 09:48:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B2113858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp79t1693993681tcml00cd Received: from rios-cad121.hadoop.rioslab.org ( [58.60.1.9]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 06 Sep 2023 17:48:00 +0800 (CST) X-QQ-SSF: 01400000000000G0V000000A0000000 X-QQ-FEAT: mRz6/7wsmIhtv7RVaemk2JCel9zmVCOHt1YHikYkA9YSgStr686ZPFDHYO8lp uNrJZbJUdyfwkkBWctc0RGdtiLI0fgM29DdFU10phzIjvTYEhK4WAgpiq3zsJi3RY8jNT7v p4bMEOBuoi9RNS2ilFx6OuWIumK01DcFRuyd/NMkCk9nQ46HzwwF10eFrAXvuK2KeixWgp1 IhPJ3f0iWZO5YKXN+9uu0ucJIo1otxIotCcu3zWCz/1MIULnK6CCpeSbBz/lI0dernO6/BU sFiiRs8WQ0502sF+YYp8ewKX9Nn/veMWCPjYWWOLVmG+12oJpkfZzDPW2wlcj8wN02qTjRP E/8PVsAU+RRJB95xzleBEt+KmEQMUvZTWejPql+ErEIJ6O7ggpG/lE6ti5W6KD87YJKri94 X-QQ-GoodBg: 2 X-BIZMAIL-ID: 11135231160392943862 From: Juzhe-Zhong To: gcc-patches@gcc.gnu.org Subject: [PATCH] RISC-V: Fix incorrect mode tieable which cause ICE in RA[PR111296] Date: Wed, 6 Sep 2023 17:47:59 +0800 Message-Id: <20230906094759.4040203-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.3 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kito.cheng@sifive.com, kito.cheng@gmail.com, Juzhe-Zhong Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776281157415587427 X-GMAIL-MSGID: 1776281157415587427 This patch fix incorrect mode tieable between DI and V2SI which cause ICE in RA. PR target/111296 gcc/ChangeLog: * config/riscv/riscv.cc (riscv_modes_tieable_p): Fix bug. gcc/testsuite/ChangeLog: * g++.target/riscv/rvv/base/pr111296.C: New test. --- gcc/config/riscv/riscv.cc | 7 +++++++ .../g++.target/riscv/rvv/base/pr111296.C | 18 ++++++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 gcc/testsuite/g++.target/riscv/rvv/base/pr111296.C diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 228515acc1f..2c0c4c2f3ae 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -7648,6 +7648,13 @@ riscv_hard_regno_mode_ok (unsigned int regno, machine_mode mode) static bool riscv_modes_tieable_p (machine_mode mode1, machine_mode mode2) { + /* We don't allow different REG_CLASS modes tieable since it + will cause ICE in register allocation (RA). + E.g. V2SI and DI are not tieable. */ + if (riscv_v_ext_mode_p (mode1) && !riscv_v_ext_mode_p (mode2)) + return false; + else if (riscv_v_ext_mode_p (mode2) && !riscv_v_ext_mode_p (mode1)) + return false; return (mode1 == mode2 || !(GET_MODE_CLASS (mode1) == MODE_FLOAT && GET_MODE_CLASS (mode2) == MODE_FLOAT)); diff --git a/gcc/testsuite/g++.target/riscv/rvv/base/pr111296.C b/gcc/testsuite/g++.target/riscv/rvv/base/pr111296.C new file mode 100644 index 00000000000..6eb14fd83a8 --- /dev/null +++ b/gcc/testsuite/g++.target/riscv/rvv/base/pr111296.C @@ -0,0 +1,18 @@ +/* { dg-do compile } */ +/* { dg-options "-std=c++03 -march=rv64gcv -mabi=lp64d -Ofast -ftree-vectorize --param=riscv-autovec-preference=scalable" } */ + +struct a +{ + int b; + int c; +}; +int d; +a +e () +{ + a f; + int g = d - 1, h = d / 2 - 1; + f.b = g; + f.c = h; + return f; +}