From patchwork Tue Sep 5 02:48:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yangxingui X-Patchwork-Id: 137535 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ab0a:0:b0:3f2:4152:657d with SMTP id m10csp1808565vqo; Tue, 5 Sep 2023 09:59:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHu3EonRPtM2KFhuGvJoVJDXTE1UEiy+dfqnnqunY3daFkWOnW53YD2yRdNTS62M/01ONXD X-Received: by 2002:ac2:5e6b:0:b0:4fa:ad2d:6c58 with SMTP id a11-20020ac25e6b000000b004faad2d6c58mr254910lfr.61.1693933150582; Tue, 05 Sep 2023 09:59:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693933150; cv=none; d=google.com; s=arc-20160816; b=0ne10JB8TK7EPsxXUJoQYgngp4zUew+geRkYsUuUJA0ooBAeDp5WVM4NlrkN0vrhVe 2lzpcmobgE37LV/4IbCNKJM1ZnIiCBa/55LegfRLGms6KMnvRRYuuleWJiEw5JPVBpm/ fLAa5sjB6JIjOJXCz8E4qG10SO23nZXJ6pTfSpoybGx1psSbkjURaywzOzMNvVcIoeho Q4Kqp5QaBAF7eIyqMCJJeAt4GeqMtY9cNG9E+fMLHrHPxnWMpL6J9B8b/NF6SpTo3LJc eCJbS+ogpDFxqFIwMC6UVOhsAxb1Xc1vCpRNv2iBTwuzvKFlJ0FtemjNcKA57Uaabl8h TNgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=zNZQZz/K6L1bJV0TnyNgXtOhpS23ShvESk95hW0iff8=; fh=m7og4B5eYCctrLkxc9cSjvs8cj9BT5n6qf42E8IHCpg=; b=Qm1VhBB1iE22OmPLGIgUkS6yFmu2jcpitBQNT3RQl0Hx6xDkbW+wp8jbVxzYAJbVMO VpXlCoIiRdnJkZMZayCQ8JiY6Vu+HadM11+HMP0+k6DYSrFjVFA4Wp1XONzL3zouL85L J3q7/Z9imYfkf1JdtmTnjOj775N2oB7T4xyuJjSE9ywxtbcgGMvRJo9dUCfwMCIfPR/u 91i8OveNag6xExAqOirdleMYXAZkZHsE58MJWIn22yVOx4BvioCooizcI4ZDkIsJloNb kuxNWxvD0RpDEU2ZlzfsnsCtwsje1Gx/8MV+2zepq3r6vwOPFIkuK0r6X1EaX3q5f7Nb bdJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ay9-20020a056402202900b00528d30a7755si7625123edb.548.2023.09.05.09.58.58; Tue, 05 Sep 2023 09:59:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351126AbjIEQfA (ORCPT + 38 others); Tue, 5 Sep 2023 12:35:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343910AbjIEC53 (ORCPT ); Mon, 4 Sep 2023 22:57:29 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1A7FCC7; Mon, 4 Sep 2023 19:57:25 -0700 (PDT) Received: from dggpemm500012.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RfqpP119MzMl5y; Tue, 5 Sep 2023 10:54:05 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpemm500012.china.huawei.com (7.185.36.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 5 Sep 2023 10:57:23 +0800 From: Xingui Yang To: , , , CC: , , , , , , , , , , , , , , , , Subject: [PATCH v6 1/3] seq_file: Add helper macro to define attribute for rw file Date: Tue, 5 Sep 2023 02:48:33 +0000 Message-ID: <20230905024835.43219-2-yangxingui@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230905024835.43219-1-yangxingui@huawei.com> References: <20230905024835.43219-1-yangxingui@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500012.china.huawei.com (7.185.36.89) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776217646924666644 X-GMAIL-MSGID: 1776217646924666644 We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute for read-only file, but many of drivers want a helper macro for read-write file too. So we add DEFINE_SHOW_STORE_ATTRIBUTE() helper to reduce duplicated code. Signed-off-by: Luo Jiaxing Co-developed-by: Xingui Yang Signed-off-by: Xingui Yang Reviewed-by: Andy Shevchenko --- include/linux/seq_file.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/include/linux/seq_file.h b/include/linux/seq_file.h index bd023dd38ae6..e400007e410c 100644 --- a/include/linux/seq_file.h +++ b/include/linux/seq_file.h @@ -207,6 +207,21 @@ static const struct file_operations __name ## _fops = { \ .release = single_release, \ } +#define DEFINE_SHOW_STORE_ATTRIBUTE(__name) \ +static int __name ## _open(struct inode *inode, struct file *file) \ +{ \ + return single_open(file, __name ## _show, inode->i_private); \ +} \ + \ +static const struct file_operations __name ## _fops = { \ + .owner = THIS_MODULE, \ + .open = __name ## _open, \ + .read = seq_read, \ + .write = __name ## _write, \ + .llseek = seq_lseek, \ + .release = single_release, \ +} + #define DEFINE_PROC_SHOW_ATTRIBUTE(__name) \ static int __name ## _open(struct inode *inode, struct file *file) \ { \