From patchwork Tue Sep 5 12:21:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Feng X-Patchwork-Id: 137533 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ab0a:0:b0:3f2:4152:657d with SMTP id m10csp1808541vqo; Tue, 5 Sep 2023 09:59:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHHKpfasTWDw2GyIgh6e5O099FLjpAuJoE3/FVT4Z6A+qBzObRl5dR8krute4Fn+/DILHUN X-Received: by 2002:a05:6a20:8414:b0:11f:4707:7365 with SMTP id c20-20020a056a20841400b0011f47077365mr14643027pzd.38.1693933145992; Tue, 05 Sep 2023 09:59:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693933145; cv=none; d=google.com; s=arc-20160816; b=Yhw1EYhjzrQpTMAJMONcHGydNpi2oKH2UMolbcls5Qvz3Ed52T9z8AK8hpUy3b8l/4 YwCscW33D3kaiJutj5kEH80iYEfDMFyGDwbRsRgBXre7QntStrphwKDR6msRPlSd6KOs PS1UYyarr1jWt8ABbLtMOd3fBL/Yc/YvuQwnlPd03Wt60sBVJPxw54cyrHnCZ+/4Jdma pr6VpAmTFTvjtPX9puXcfyQwmxDfSVEzh7ifYwTRXZA6a4vRvzXyPLIEnQb1SwuTvEMV zG7mtKg3q5GQF95kzWAtxCRJnzLEa3lwYVEXWK34mNKYRV5gLzIFjkG7E3hCzoKOmhQ4 ukzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=difMXfuDEtMl4adFKVCVh0Uv8KKdBNISRfXkS+4N2gw=; fh=ByA4PyA3t3MVQtvdKmpD5vTPBa76xBqx8TY4z1JCxLA=; b=EnSHld0j8l9x9kr6Uyxs23IQWy84Jxw2LtzK2Ge5oI3/8TcxLgLUfELVivmu4YxRTu a9GP3xtcjhs4D478Wwj8GAtSPeMLGm8IKw6IZAQ8dKz1OeKgYV3j0ga/CB0AWAjgwo24 2MjNscEP+1V+rFtxFeupZ7Wrs6D+4T+78YV5DNawXAOuS6lQwzquNJDZX7EmY4nXHOAT SpbByCQcjvH/pqxld+t1JgCtk6vyQoCJuPkRbwQC6lIddIL5SQ+CrWK7As5y7ky8lkjv 9/9GjQLk59LpngukX+NK22z45K6ayvS8Cz8gWEQOutSf/4Evj7xcaEROpSutPlRDXmyJ kLHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q23-20020a656857000000b0056556d83a69si9494351pgt.234.2023.09.05.09.58.59; Tue, 05 Sep 2023 09:59:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241696AbjIEQir convert rfc822-to-8bit (ORCPT + 38 others); Tue, 5 Sep 2023 12:38:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354528AbjIEMVR (ORCPT ); Tue, 5 Sep 2023 08:21:17 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8828F1B3; Tue, 5 Sep 2023 05:21:11 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 4A0A124E17F; Tue, 5 Sep 2023 20:21:07 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 5 Sep 2023 20:21:07 +0800 Received: from ubuntu.localdomain (113.72.144.73) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 5 Sep 2023 20:21:06 +0800 From: Hal Feng To: Linus Walleij , Andreas Schwab , Conor Dooley , Emil Renner Berthing , Jianlong Huang , Hal Feng CC: , Subject: [PATCH v1 1/2] pinctrl: starfive: jh7110: Fix failure to set irq after CONFIG_PM is enabled Date: Tue, 5 Sep 2023 20:21:04 +0800 Message-ID: <20230905122105.117000-2-hal.feng@starfivetech.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230905122105.117000-1-hal.feng@starfivetech.com> References: <20230905122105.117000-1-hal.feng@starfivetech.com> MIME-Version: 1.0 X-Originating-IP: [113.72.144.73] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776217642159700737 X-GMAIL-MSGID: 1776217642159700737 The issue was found when we enabled CONFIG_PM and tested edge events using libgpiod. > # gpiomon -r gpiochip0 55 > gpiomon: error waiting for events: Permission denied `gpiomon` will call irq_chip_pm_get() and then call pm_runtime_resume_and_get() if (IS_ENABLED(CONFIG_PM) && sfp->gc.irq.domain->pm_dev). pm_runtime_resume_and_get() will fail if the runtime pm of pinctrl device is disabled. As we expect the pinctrl driver can be always working and never suspend during runtime, unset sfp->gc.irq.domain->pm_dev to make sure pm_runtime_resume_and_get() won't be called when setting irq. Fixes: 447976ab62c5 ("pinctrl: starfive: Add StarFive JH7110 sys controller driver") Signed-off-by: Hal Feng --- drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c index 5fe729b4a03d..72747ad497b5 100644 --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c @@ -968,8 +968,6 @@ int jh7110_pinctrl_probe(struct platform_device *pdev) if (ret) return dev_err_probe(dev, ret, "could not register gpiochip\n"); - irq_domain_set_pm_device(sfp->gc.irq.domain, dev); - dev_info(dev, "StarFive GPIO chip registered %d GPIOs\n", sfp->gc.ngpio); return pinctrl_enable(sfp->pctl);