From patchwork Fri Sep 1 18:50:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hamza Mahfooz X-Patchwork-Id: 137407 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c792:0:b0:3f2:4152:657d with SMTP id b18csp1080415vqu; Fri, 1 Sep 2023 11:51:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJUo/BQOZVRXMhfRa5y5gRzpeXXZM7QJHCDWDolmXilB4M9YYbg25XF23/FBONaqh1ytXS X-Received: by 2002:a17:907:7608:b0:99c:c50f:7fb4 with SMTP id jx8-20020a170907760800b0099cc50f7fb4mr2315276ejc.1.1693594302748; Fri, 01 Sep 2023 11:51:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693594302; cv=none; d=google.com; s=arc-20160816; b=QJf5kTGbpAbdIjUhIbTJ2R+snIZfdjLrUBE5dWP4A4TTxCZ/aUxHiI87anOtOhoACZ WP56gy9XSytzkvCr6gr9wWx0GhyE/ORr98QqcfwOkucu7409LGlu9Rl26374ePm4+FJ+ qu6+n/dQ3oXmRqPrzJCIiIB+f9D1dIC89fB/v9gl+AIeWkYYeAkBc3HP5DRdraL95tV7 iaEt6gynqMOrUgSc48ovuHryoCbKz7qvKjTi6EJLSk6n3HoNzFjUxJBpTTJOZwTdVr92 akXXfPiOEIRThAIpQrAqDBOdecm22al55KSy6KygF5s2Rr8zLgDcovO60RhOkSH6qSsk lfnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dmarc-filter :delivered-to; bh=06owwNNvSz2mqA8jgdi3nRpeZg/3llRvss1wFCnmE5g=; fh=c6tISvu76ma+8+kn3jxA9HnBetZMFWr9ThycsnXisAc=; b=mLqtCeq8NEdCpt5DsfdIvenzE04rdJWmNOI2tDUMixmWw2c+4yDd9EynL6120XpRvR 4CE6eU6N/btVDZduqwlgm561btwwwOKW7fz9rakkpJjNpDXXwSAv7l9nTLIyQV0aoZKI H6kqefGYApC3HuZsM1+dhq47IMeA8xlzgj7tUiw029Z2XkDsmstHMAv8uyqA2nYEGw5E hDodwmBqG6aM3x6L/l/77+xyV1QADqAu93+3FudLHJsYZuyM6akPKWm8gsD2giu12TXp ukdOZfmPp1hRbND5gZiszf+jE5L2qP91merzVD6VV54tJBffNTgC9EJOWITYJUrnsoGp miQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id y8-20020a170906914800b00993b3881eccsi2978357ejw.691.2023.09.01.11.51.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 11:51:42 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F2E1A3858C39 for ; Fri, 1 Sep 2023 18:51:37 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from MTA-11-3.privateemail.com (mta-11-3.privateemail.com [198.54.122.105]) by sourceware.org (Postfix) with ESMTPS id C3BEB3858D20 for ; Fri, 1 Sep 2023 18:51:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C3BEB3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=effective-light.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=effective-light.com Received: from mta-11.privateemail.com (localhost [127.0.0.1]) by mta-11.privateemail.com (Postfix) with ESMTP id AE50B18000B0; Fri, 1 Sep 2023 14:51:02 -0400 (EDT) Received: from hal-station.. (bras-base-toroon4332w-grc-39-74-12-11-94.dsl.bell.ca [74.12.11.94]) by mta-11.privateemail.com (Postfix) with ESMTPA; Fri, 1 Sep 2023 14:50:56 -0400 (EDT) From: Hamza Mahfooz To: gcc-patches@gcc.gnu.org Cc: Richard Biener , Joseph Myers , Marek Polacek , Martin Uecker , Hamza Mahfooz Subject: [PATCH] c: don't emit -Wmissing-variable-declarations for register variables [PR110947] Date: Fri, 1 Sep 2023 14:50:11 -0400 Message-ID: <20230901185011.154880-1-someguy@effective-light.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775862339463580664 X-GMAIL-MSGID: 1775862339463580664 Resolves: PR c/110947 - Should -Wmissing-variable-declarations not trigger on register variables? gcc/c/ChangeLog: PR c/110947 * c-decl.cc (start_decl): don't emit -Wmissing-variable-declarations for DECL_REGISTER VAR_DECLs. gcc/testsuite/ChangeLog: PR c/110947 * gcc.dg/pr110947.c: New test. Signed-off-by: Hamza Mahfooz --- Please push this for me if you think it looks good. Since, I don't have write access to the repository. --- gcc/c/c-decl.cc | 3 ++- gcc/testsuite/gcc.dg/pr110947.c | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/pr110947.c diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc index 1f9eb44dbaa..819af6aa050 100644 --- a/gcc/c/c-decl.cc +++ b/gcc/c/c-decl.cc @@ -5376,7 +5376,8 @@ start_decl (struct c_declarator *declarator, struct c_declspecs *declspecs, warning (OPT_Wmain, "%q+D is usually a function", decl); if (warn_missing_variable_declarations && VAR_P (decl) - && !DECL_EXTERNAL (decl) && TREE_PUBLIC (decl) && old_decl == NULL_TREE) + && !DECL_EXTERNAL (decl) && !DECL_REGISTER (decl) && TREE_PUBLIC (decl) + && old_decl == NULL_TREE) warning_at (DECL_SOURCE_LOCATION (decl), OPT_Wmissing_variable_declarations, "no previous declaration for %qD", decl); diff --git a/gcc/testsuite/gcc.dg/pr110947.c b/gcc/testsuite/gcc.dg/pr110947.c new file mode 100644 index 00000000000..19e38ed4d18 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr110947.c @@ -0,0 +1,4 @@ +/* { dg-do compile { i?86-*-* target x86_64-*-* } } */ +/* { dg-options "-Wmissing-variable-declarations" } */ + +register unsigned long current_stack_pointer asm("rsp");