From patchwork Thu Aug 31 12:13:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 137286 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c792:0:b0:3f2:4152:657d with SMTP id b18csp198217vqu; Thu, 31 Aug 2023 05:13:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGOwN84In41Bf9pjYvHwu66XB2OoAKhctPDEc6Sv+6A/aI72bQ7VPlAz86ueOQnSItnwwLS X-Received: by 2002:a17:907:77da:b0:9a1:f21e:cdfe with SMTP id kz26-20020a17090777da00b009a1f21ecdfemr3418159ejc.58.1693484018142; Thu, 31 Aug 2023 05:13:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693484018; cv=none; d=google.com; s=arc-20160816; b=BtWBoV2drhgxwVnuK7XK58Vl+2k5DmTvtPWg9/Teryf1C68rdugfMN3LBTdnIjJxzq ir7XZ0SY3c7dB608mLhUIsxD+Id1xp0COF0cGeguPodX5KlSg29M+Pnua3+D0wznylwp gY2xpbsgZRJlyhDIP671Xr0LPzmlboU7P0HnsYaJaj8789cxOLmD+eHLc2sI4m1Qti5H kjEoXFq8cP6Q52KBmYlxavOE25oY/dqSnUU+YLeQl5htN4cZbdq+jKOFj16rPoBtZcUB w7lpJEjtfxjzEw0mgYc2cvSxSqvw9J9RCnk/mH/0NTdtMuwUbEaUA1afYdU94FxqLBUR fSEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=HOtibnL+uEssl+IEw//VX7v7r2lqErmaCa2MhG2ABYQ=; fh=NLxAvL/bDfPg4AGOtxqvQlND8vazkZrNzKLY8+LAbBY=; b=O4AM7ebgoqI8oN5BdxzHcmVaa6jpyNqjGI9hNqkzKzP31XQ5wBDl5leE1DuRWM5ars FFhqM33jmsiOwmwjcGeHQAnXED8H/wI54pjgnt+NcVrHNT/fYYion9XVfjLcIyOcZaLq T6PJE5C8NdebjFFj340s2ZFJQqXsu3AlZgAQyvP0DlK5K5bqJROWvflvRsqnLQk+BtC5 xD3sAGuudcmaGDBXrpp5EDmokrUEMg0ljul3393Gf6RJCXfNAFU+RuqtStA9JIiLd8rb fhA//iaN3L9bp/K0ctDYpBj1gbiB6DU/ZC7+DH+Sm0XXpz2+I8Z9qT25XrCZAl+vruDc YDVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=kOOPQpjM; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id jj27-20020a170907985b00b00992b6f26c0esi837867ejc.672.2023.08.31.05.13.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Aug 2023 05:13:38 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=kOOPQpjM; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DB6813858418 for ; Thu, 31 Aug 2023 12:13:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB6813858418 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1693484013; bh=HOtibnL+uEssl+IEw//VX7v7r2lqErmaCa2MhG2ABYQ=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=kOOPQpjMifpn2ruK+xR6r6ciVfjUVTMqTLPQfh4wpBKs0lyTZHycimSWbQcSgQk0F l4XlIHHwwf7bx0lRzR2i+u74icXCzxi8UVRSRF3WmQVKigmqVo6jXIc7C6TbEtlU2X Jp7o0a+W9fAYiwyfgnWqN/UenlqCGVMhLQFRJRbk= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 3E511385841B for ; Thu, 31 Aug 2023 12:13:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E511385841B Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1c1e3a4a06fso4750895ad.3 for ; Thu, 31 Aug 2023 05:13:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693483991; x=1694088791; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HOtibnL+uEssl+IEw//VX7v7r2lqErmaCa2MhG2ABYQ=; b=bRDNWxgyPrbT5/IAN5If6wJ3/uu1I/9Th+CVbJMvm37l5VRagEt+9NE+G73t5CUxQq /BSFSZ3Yp7JUMJzpBFzOlLdCZI37+nrQ7aNyy49GXGJPR+38lDGILCeq95u1xEWRjhkU H0g2mIWZbt7e4YrOf1JZ+19XB5Ob5/7A4CvnmorR8AeYaMVeEw1ztMJEJ4P1IiUrMOhV rPiilPoaOKs25gNLzMf5Vty4SoECsftELymtGSt+UbwxGX+nj1vkKJw4txEfQTzPRasA P0f99FUVumIt+Cbhx5SyVAkhqS3+AP5dHRv6s1fwyXLJtJyz8tT1+awzUnPVeABggDhC 4rWg== X-Gm-Message-State: AOJu0YzIoiT5pFijvDmTLTxHmpgS23IzDfKNE/nwzQPdg3Ie91qCcA3s A+2r6LvNJxRwK0Igsyww+dLwOymqoUH9CQ== X-Received: by 2002:a17:902:d2cd:b0:1bb:994c:bc43 with SMTP id n13-20020a170902d2cd00b001bb994cbc43mr6167929plc.18.1693483990814; Thu, 31 Aug 2023 05:13:10 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:beed:e5d:7015:37c8]) by smtp.gmail.com with ESMTPSA id e7-20020a170902744700b001bdc9daadc9sm1156220plt.89.2023.08.31.05.13.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Aug 2023 05:13:10 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id C782911425E2; Thu, 31 Aug 2023 21:43:07 +0930 (ACST) Date: Thu, 31 Aug 2023 21:43:07 +0930 To: binutils@sourceware.org Subject: vms-alpha: Free memory on failure path Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3033.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775746697424343230 X-GMAIL-MSGID: 1775746697424343230 * vms-alpha.c (evax_bfd_print_eobj): Free rec on failure. diff --git a/bfd/vms-alpha.c b/bfd/vms-alpha.c index f4d1e009d06..9689dcb8738 100644 --- a/bfd/vms-alpha.c +++ b/bfd/vms-alpha.c @@ -6972,6 +6972,7 @@ evax_bfd_print_eobj (struct bfd *abfd, FILE *file) != pad_len - hdr_size) { fprintf (file, _("cannot read GST record\n")); + free (rec); return; } @@ -6987,7 +6988,6 @@ evax_bfd_print_eobj (struct bfd *abfd, FILE *file) evax_bfd_print_eeom (file, rec, rec_len); free (rec); return; - break; case EOBJ__C_ETIR: evax_bfd_print_etir (file, "ETIR", rec, rec_len); break;