From patchwork Thu Aug 31 08:09:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Biju Das X-Patchwork-Id: 137335 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c792:0:b0:3f2:4152:657d with SMTP id b18csp410377vqu; Thu, 31 Aug 2023 11:04:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKFLN//A8P2n97Lcrc68wzS5FNKWcmSV1Exh176QT9tL4CLL158CD4BbMmsSOjGLDiUGbI X-Received: by 2002:a05:6512:3da6:b0:500:977d:a4e1 with SMTP id k38-20020a0565123da600b00500977da4e1mr5294371lfv.40.1693505099564; Thu, 31 Aug 2023 11:04:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693505099; cv=none; d=google.com; s=arc-20160816; b=u1YMRFTQ6PZazrRjCvYel6RWOX8+uNUIIfAWpcJS/V2vVZXCcLqTPsjfqcI4HxbZdW 8sUkgLnrPxMjPT+SpHZ53tUhX3rw5L5DwD5uOMjr1MlqtrwbW8ZToSVQ8R27hUyZJCqk 18vb3lO7RTmxzbDwACygqjtRjYsBh7gXa//fPY7g68sgCX6IHPDeeJwz2Tv1kyPN9b2k emebEUkmhGFM0rgMLqE+adBfw/5brVY7RiUB1A1m4s33VjzYHPjKlBFpJuLDdA27A0c7 CrHL8HJ8ZMIXWHa3y+s4XAircVuy5lG2sh91BxzbBSUgQsiU5NNp9Sf2AvA2mdqPSNlP AtDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=BHGYHOskC9xVAHiT2QyYh5oyBQ/ZklIaQelxjjFFEXo=; fh=r00Pqt0uAaYxSoUnOtxebcCkqLeEbCP/usidTbTmIb4=; b=tCDTk7JB1gzfesOG/NfMuXgHYNgJ+3pzXLeQ6xC7YP9fNXH5WP0mQmspwkJjf5HK5M ce5XV5LT6ugkAhMm7kXY8qyaWl0x3uLFZet5QygvB2ytHE9nOUFH0Lnx6hZzpzyxoI1h 4Wk91ZIz3Eq7rlnQXqzVOvghm19NLS9WQVWdWuMfRn2mBm+4ps4E+19gyHZZa3ydYdwl Odej0Rjr8DQXywgwZOyaDL38l6m/tNIiWilxj8wVzO2Q+5cGSO1ksXKiASYJhq97MLMP wT9cLECbvZFYYDTlvnwufgqBnaw3J68aI1Ant8JJlAkfzQRQzXiO7lLiFrxzTwKx8bRu ACWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gf7-20020a170906e20700b009a5830bb1fdsi1354908ejb.1054.2023.08.31.11.04.14; Thu, 31 Aug 2023 11:04:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240206AbjHaIJ4 (ORCPT + 99 others); Thu, 31 Aug 2023 04:09:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232058AbjHaIJz (ORCPT ); Thu, 31 Aug 2023 04:09:55 -0400 Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 18143185 for ; Thu, 31 Aug 2023 01:09:51 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.02,216,1688396400"; d="scan'208";a="178287314" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 31 Aug 2023 17:09:51 +0900 Received: from localhost.localdomain (unknown [10.226.92.179]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id B69F84010DFB; Thu, 31 Aug 2023 17:09:46 +0900 (JST) From: Biju Das To: Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter Cc: Biju Das , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Douglas Anderson , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Zhu Wang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Laurent Pinchart , Helen Koike Subject: [PATCH v6 1/4] drm/bridge/analogix/anx78xx: Drop ID table Date: Thu, 31 Aug 2023 09:09:35 +0100 Message-Id: <20230831080938.47454-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> References: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775768803344852715 X-GMAIL-MSGID: 1775768803344852715 The driver has an ID table, but it uses the wrong API for retrieving match data and that will lead to a crash, if it is instantiated by user space or using ID. From this, there is no user for the ID table and let's drop it from the driver as it saves some memory. Signed-off-by: Biju Das Reviewed-by: Douglas Anderson Reviewed-by: Laurent Pinchart Reviewed-by: Andy Shevchenko Reviewed-by: Helen Koike --- v5->v6: * No change. v4->v5: * Added Rb tag from Andy and Helen. v3->v4: * Added Rb tag from Laurent and Douglas Anderson. v2->v3: * Updated commit header. v1->v2: * Dropped ID table support. --- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c index 800555aef97f..6169db73d2fe 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c @@ -1367,12 +1367,6 @@ static void anx78xx_i2c_remove(struct i2c_client *client) kfree(anx78xx->edid); } -static const struct i2c_device_id anx78xx_id[] = { - { "anx7814", 0 }, - { /* sentinel */ } -}; -MODULE_DEVICE_TABLE(i2c, anx78xx_id); - static const struct of_device_id anx78xx_match_table[] = { { .compatible = "analogix,anx7808", .data = anx7808_i2c_addresses }, { .compatible = "analogix,anx7812", .data = anx781x_i2c_addresses }, @@ -1389,7 +1383,6 @@ static struct i2c_driver anx78xx_driver = { }, .probe = anx78xx_i2c_probe, .remove = anx78xx_i2c_remove, - .id_table = anx78xx_id, }; module_i2c_driver(anx78xx_driver); From patchwork Thu Aug 31 08:09:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Biju Das X-Patchwork-Id: 137258 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c792:0:b0:3f2:4152:657d with SMTP id b18csp122899vqu; Thu, 31 Aug 2023 02:30:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQAa9OsJj1ojniqHvNcdFXowWttx7UE3ieNjragy4p7NtQZicz6F9d2EyJYDKXbmxGusWI X-Received: by 2002:a05:6870:1ca:b0:19f:5c37:abb9 with SMTP id n10-20020a05687001ca00b0019f5c37abb9mr5321630oad.12.1693474234829; Thu, 31 Aug 2023 02:30:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693474234; cv=none; d=google.com; s=arc-20160816; b=OH+bkbLCUdI5GAZhAtIiKrp5fZ8QdZW2/Bvw54aRT3LczK/rQGPNiKHpjsqc7Itj0M JVrehmjvuIKoxkVJipTbaNuSaX/J7TaZP5xqO2yaBzF/qttI3SoNSOEPhXb6NqCT7S4Y A3w7e1NSix6dK+hgV54JbWbPe4kkK7YMBPoQ+62xmNXPRiYq5IvnoioTzCWhv01raOmu trJGrXAE6wl59yVKX9k9wD305tIZ0+e+DDdM7XYYxfxf2ldREMFd9UKvApqtutLHVUf/ mNzbEjSWb12GaH2dby2JILPlfJ1YcrbwVcZZO0oAfFiboNchGYxwqWxePfBYW4SorqdS DyLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=qGOSPmjG1ZZMiUjimzrjai7WQOPNH2MlvNsTG0lP/yw=; fh=YwJMbeg+3jadkqx++b8GHN/wxtSTxMsJ/Z9NPf7adNs=; b=lrb6ezN+1PzgnXnazZR2aUK653HQRdTT2SUzBzr5hZ7/fjkv2mx2X/6R9YuLrVAvEN S2GVWjIOCu5BU+JKKrCoHygctUjv1QPyfKMYa9nbF6JIcLDrqFio8oge0KsPV5qMYW0L eqOHxsZd47jNRBmysERDDxEcHJWUA6hQn56+beyFh/vTGT1D9WmtIIApPnpxDf+hl9qq tlhIhJ55qROa81ZfzxH4FOJ0OCqYZd4oRQasKQIstP6iKsRfgLHMJFNACcTcluoiU334 X9YO2yAGhwEr7mOZJQPvfRTQVvIRoo926sMGl1ccIW7JAzVrXZ5hDeZHQmtcFoTDvUe8 1UOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kf11-20020a17090305cb00b001bf15337494si821676plb.401.2023.08.31.02.30.05; Thu, 31 Aug 2023 02:30:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244059AbjHaIKI (ORCPT + 99 others); Thu, 31 Aug 2023 04:10:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242791AbjHaIKF (ORCPT ); Thu, 31 Aug 2023 04:10:05 -0400 Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5AFFFCE7 for ; Thu, 31 Aug 2023 01:09:58 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.02,216,1688396400"; d="scan'208";a="178287328" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 31 Aug 2023 17:09:58 +0900 Received: from localhost.localdomain (unknown [10.226.92.179]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 780704010DFE; Thu, 31 Aug 2023 17:09:52 +0900 (JST) From: Biju Das To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter Cc: Biju Das , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Douglas Anderson , Laurent Pinchart Subject: [PATCH v6 2/4] drm/bridge: Drop conditionals around of_node pointers Date: Thu, 31 Aug 2023 09:09:36 +0100 Message-Id: <20230831080938.47454-3-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> References: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775736439261390158 X-GMAIL-MSGID: 1775736439261390158 This patch is based on commit c9e358dfc4a8 ("driver-core: remove conditionals around devicetree pointers"). Having conditional around the of_node pointer of the drm_bridge structure turns out to make driver code use ugly #ifdef blocks. Drop the conditionals to simplify drivers. While this slightly increases the size of struct drm_bridge on non-OF system, the number of bridges used today and foreseen tomorrow on those systems is very low, so this shouldn't be an issue. So drop #if conditionals by adding struct device_node forward declaration. Suggested-by: Douglas Anderson Signed-off-by: Biju Das Reviewed-by: Douglas Anderson Reviewed-by: Laurent Pinchart --- v5->v6: * Updated commit description. * Added Rb tag from Douglas Anderson and Laurent v5: * Split from patch#2 * Updated commit description * Added struct device_node forward declaration. --- include/drm/drm_bridge.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index c339fc85fd07..843736627f60 100644 --- a/include/drm/drm_bridge.h +++ b/include/drm/drm_bridge.h @@ -32,6 +32,8 @@ #include #include +struct device_node; + struct drm_bridge; struct drm_bridge_timings; struct drm_connector; @@ -716,10 +718,8 @@ struct drm_bridge { struct drm_encoder *encoder; /** @chain_node: used to form a bridge chain */ struct list_head chain_node; -#ifdef CONFIG_OF /** @of_node: device node pointer to the bridge */ struct device_node *of_node; -#endif /** @list: to keep track of all added bridges */ struct list_head list; /** From patchwork Thu Aug 31 08:09:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Biju Das X-Patchwork-Id: 137269 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c792:0:b0:3f2:4152:657d with SMTP id b18csp154409vqu; Thu, 31 Aug 2023 03:47:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkseEWMLXuhvEacsEOFIQ8iE7th1kLLH2h9JbuLbw2tBm2EpSn9PMciNVS6QpE9rDQIUCC X-Received: by 2002:a17:906:76c8:b0:9a1:db2e:9dc0 with SMTP id q8-20020a17090676c800b009a1db2e9dc0mr3678703ejn.44.1693478833877; Thu, 31 Aug 2023 03:47:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693478833; cv=none; d=google.com; s=arc-20160816; b=KZ2B6yRB5I1USc40VhngAfL89G0eLS48q/Qna99jo+czOa1e4lePtDeafW6ahGRmtB 6sot2YCEqBJdGBc9nZZUv4ZQgJK1wtNLawQMqwePK3QvEg9lN9yXxBM9GOzfdZeKnKTh q0P19+OcLZRjWI3q2MNlYDxlBb8t3wuAwzX0+myKmL0cI8EdlBH88oq+Yh1bn8VXUQ61 ORDCqkYMv4aWj/kPIL6ojws+/V6tcDfUc6AUc68wsM2PlSyFLYilFUHXwaFXXY0qOcYq AAXHwNU6y27gcrZH8JW/+2/VNrJsi+kUuDY5OKX7Wlzp4gAHgYTQJutH5ZjMduMH+jN3 r6IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=87rDRDLfR8euU4/qnJmzlvetsR8kRKEsMHeU8+ysTOU=; fh=F2myal56kH2u+3WwQSFXOpBQjczMtlSW5M2zy1ypF6o=; b=uDEw56GMkJc1c99t+utKs9mU5VrvvhOWneYXSkFy7GXkmp867FEEjRQHqiqaRn4j8Z 4XLekpwa/pB7ZHq5BnIPpJ2DVKxSSZdWoynmrD18D93zx45Rj42FaD3mQgwYPsHJ4cs0 bCMqqqU4N5+MsM8Drf4Clr9d0Z0QnZ97CF8XuiiRo4BF9+geF0J+YrXSwrKf7Un6IUxi 5mkPvCxHS83VHmWa5Nevu9zbnKVXRTP6kEKW5rvntqyUbUabiE2hN08UkdMHeLTX1OYY dLWTJQAciKsFRKgmWzbrEUx7U5TAKXM/aTuoulcAHET2vM/rIOdg1SVCFMj5mClWkTAo 0OBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oy25-20020a170907105900b0099b42c9082bsi790217ejb.508.2023.08.31.03.46.46; Thu, 31 Aug 2023 03:47:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241102AbjHaIK3 (ORCPT + 99 others); Thu, 31 Aug 2023 04:10:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241403AbjHaIKY (ORCPT ); Thu, 31 Aug 2023 04:10:24 -0400 Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B35E0E7F for ; Thu, 31 Aug 2023 01:10:06 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.02,216,1688396400"; d="scan'208";a="174580076" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 31 Aug 2023 17:10:05 +0900 Received: from localhost.localdomain (unknown [10.226.92.179]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id F07CA4010DFB; Thu, 31 Aug 2023 17:09:58 +0900 (JST) From: Biju Das To: Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter Cc: Biju Das , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Douglas Anderson , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Zhu Wang , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Thierry Reding , =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= , Guillaume BRUN , Rob Herring , Sandor Yu , Sam Ravnborg , Ondrej Jirman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andy Shevchenko Subject: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers Date: Thu, 31 Aug 2023 09:09:37 +0100 Message-Id: <20230831080938.47454-4-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> References: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775741261747015292 X-GMAIL-MSGID: 1775741261747015292 Having conditional around the of_node pointers turns out to make driver code use ugly #ifdef and #if blocks. So drop the conditionals. Suggested-by: Douglas Anderson Signed-off-by: Biju Das Reviewed-by: Douglas Anderson --- v5->v6: * Added Rb tag from Douglas Anderson. * Dropped conditionals from remaining drm/bridge drivers. v5: * Split from patch#2 --- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 -- drivers/gpu/drm/bridge/panel.c | 2 -- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 -- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 -- 4 files changed, 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c index 6169db73d2fe..ad8241758896 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c @@ -1231,9 +1231,7 @@ static int anx78xx_i2c_probe(struct i2c_client *client) mutex_init(&anx78xx->lock); -#if IS_ENABLED(CONFIG_OF) anx78xx->bridge.of_node = client->dev.of_node; -#endif anx78xx->client = client; i2c_set_clientdata(client, anx78xx); diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index 9316384b4474..7f41525f7a6e 100644 --- a/drivers/gpu/drm/bridge/panel.c +++ b/drivers/gpu/drm/bridge/panel.c @@ -302,9 +302,7 @@ struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel, panel_bridge->panel = panel; panel_bridge->bridge.funcs = &panel_bridge_bridge_funcs; -#ifdef CONFIG_OF panel_bridge->bridge.of_node = panel->dev->of_node; -#endif panel_bridge->bridge.ops = DRM_BRIDGE_OP_MODES; panel_bridge->bridge.type = connector_type; diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 6c1d79474505..52d91a0df85e 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -3541,9 +3541,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev, | DRM_BRIDGE_OP_HPD; hdmi->bridge.interlace_allowed = true; hdmi->bridge.ddc = hdmi->ddc; -#ifdef CONFIG_OF hdmi->bridge.of_node = pdev->dev.of_node; -#endif memset(&pdevinfo, 0, sizeof(pdevinfo)); pdevinfo.parent = dev; diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 04d4a1a10698..a8dd2a2e7c7b 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c @@ -1182,9 +1182,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, dsi->bridge.driver_private = dsi; dsi->bridge.funcs = &dw_mipi_dsi_bridge_funcs; -#ifdef CONFIG_OF dsi->bridge.of_node = pdev->dev.of_node; -#endif return dsi; } From patchwork Thu Aug 31 08:09:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Biju Das X-Patchwork-Id: 137292 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c792:0:b0:3f2:4152:657d with SMTP id b18csp207635vqu; Thu, 31 Aug 2023 05:31:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGADsNXuPIUqBaPRjqyUZyN1eJ0SSopfoIXK2lydbYYj/LcJJZCaOV+U1rmX74EKODGceMV X-Received: by 2002:a17:906:5303:b0:99d:f2dc:97e3 with SMTP id h3-20020a170906530300b0099df2dc97e3mr4052544ejo.20.1693485069680; Thu, 31 Aug 2023 05:31:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693485069; cv=none; d=google.com; s=arc-20160816; b=ofS12kTmzvg2r36x/g7GIlhTnpvFP/vfUvQzxQBHn6QhIahChgTiSBQWncD89rHLSU +CZwYsLkjpwfAge/1jIJ2cOwy1nUZDOd4IJT/vQVrkRSIOVBwON/vKCRpC0pJC9MCL/h nDl9yATeaTludL88m97GQaO0Tc4MncPzQkpVcrUpWHjvRqmsZjR/G/a379yEXCZHV6Ha KlbsC19fYsskFPl9BXyz0xMWoymu36GBPxsSQMYYAmouQpqQHmChAaRwfMwZNwN7QFss HD5N+ZbixcwU7OSVf4d41UbCV+SSFB1nHd+SaOKJR1dXlbAo3g8rSbZ6cApExt//g1yP fgzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8InaWKuPNDrBx8wPfS75NFfO+h3hCHjH20ybv01PaEw=; fh=gHbIAQ2s/60tD7lgzo7hkrHMCk52kBhBDeUsj1KQqy0=; b=YIqoQZsYbj4nKdd3Pnh3OtwitrNlmlC8MtalzgjFUyN9a30fnmhh1GfinkB5kFB9Sb fOGpbHzGVkSo9s6RKjFDxU4TjTbVrt8LhHWSB9ZhYAesrTrOiHhCEEgf07iLOn6UiFrQ uGYZNyEcl6JeFddWSgJRjsHq2phA/teHIkJkJfovH9NVCNyF5dlQsou5ImZ32qsPVT0K U1tVun30TMdlEGVot1Kb6f3XlQc71ImDcdhXOVW5A0Gf1IBq3oIeM479zp9YsDj5RmPf 2YYau1+rtK/ZiHjhjMmt3srbRhGjChbZpFaQzBUZLRUUm2w/6Rf81kxYRnIOT7L6gZm5 fqVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f15-20020a1709067f8f00b00987ae307f0dsi821535ejr.587.2023.08.31.05.30.37; Thu, 31 Aug 2023 05:31:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244404AbjHaIKf (ORCPT + 99 others); Thu, 31 Aug 2023 04:10:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242791AbjHaIKc (ORCPT ); Thu, 31 Aug 2023 04:10:32 -0400 Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8E540E4E for ; Thu, 31 Aug 2023 01:10:10 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.02,216,1688396400"; d="scan'208";a="174580102" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 31 Aug 2023 17:10:10 +0900 Received: from localhost.localdomain (unknown [10.226.92.179]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 6F5E24010DFF; Thu, 31 Aug 2023 17:10:06 +0900 (JST) From: Biju Das To: Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter Cc: Biju Das , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andy Shevchenko Subject: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge() Date: Thu, 31 Aug 2023 09:09:38 +0100 Message-Id: <20230831080938.47454-5-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> References: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775747800332364761 X-GMAIL-MSGID: 1775747800332364761 Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() and drmm_of_get_bridge() as it is guarded with #if..#else blocks in drm_bridge.h. Signed-off-by: Biju Das --- v6: * New patch. --- drivers/gpu/drm/bridge/panel.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index 7f41525f7a6e..9220a1c23697 100644 --- a/drivers/gpu/drm/bridge/panel.c +++ b/drivers/gpu/drm/bridge/panel.c @@ -482,7 +482,6 @@ struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge) } EXPORT_SYMBOL(drm_panel_bridge_connector); -#ifdef CONFIG_OF /** * devm_drm_of_get_bridge - Return next bridge in the chain * @dev: device to tie the bridge lifetime to @@ -550,5 +549,3 @@ struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm, return bridge; } EXPORT_SYMBOL(drmm_of_get_bridge); - -#endif