From patchwork Thu Nov 3 09:12:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: allen X-Patchwork-Id: 14771 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp409559wru; Thu, 3 Nov 2022 02:15:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6qQznOqeYWuIxvEJDsZ2k0zvUAJESJwEKmvKtC+np/ZG9772lOaerwmlU3dcCfMYG+rWkf X-Received: by 2002:a17:90b:692:b0:203:6c21:b4aa with SMTP id m18-20020a17090b069200b002036c21b4aamr46613675pjz.227.1667466940504; Thu, 03 Nov 2022 02:15:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667466940; cv=none; d=google.com; s=arc-20160816; b=fH+oVEaCVOUBwbSHfmxiE6N4rE62oaS59XFSu+roI1fxYv7JQIc52yxy4Vb/mClUgE R2JzP0nUaEnKXRVkYw/wz7BBV+L3H2KIVb5bfmfOfHwu0mSlbUUeu/JG9JZvq/2ifdLV hTVAofeJB56YTrPZTQK9KE81fjV+tojVPP5tQMCsG3EnZCl6QEfyWSl+N+TQo6zUBoj5 RVrRE6wd52JQSuX94T2lR1HmAPRoCSzd+r4HRUhL6gQ1iJP6T8m9oHWoJH68pKFeMV1X kLxI4OwxJtekf6AzoW7FydfRAZ4vY+byMvWsBF/SEH6ECnEzdIMgmR8bMUwF1XBenUNb bFWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from; bh=mM+NQj4Tq4Ji/rbfh/rxAp6Wp6zZB9twSoz+a2QZqhE=; b=VTW9+hNyvIbRkHKP3wlhij07QJQD6HqSaLXkipKnX9ixBZu8TbvbJ2cxiOg8dx94vx eKawKmKiMzDdnj/vwdLejx6xiOim1XZDuigzZuXzyz1+KAl/vX46nmEQxEHhQ1LoaDKU qZCk5hVwA3UT9P0RsqL2MNV74ZnBA1DIZUvlZsQFezFenqeM77etP1Tjc8PEfBPxkcen nse/6636W573f1sIZu05ywL+mmI+91XRwz98Bv5GQpewlbTeM0gtlA+yifk7j1m5iarI ZlDCCulRmNih/Oae+K8lUoUkOUt/ztZk36UBWoFumiGGtqsf5btowg602O1NtzWG0uRh TpFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v25-20020a637a19000000b0046265702353si463619pgc.203.2022.11.03.02.15.27; Thu, 03 Nov 2022 02:15:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231140AbiKCJOM (ORCPT + 99 others); Thu, 3 Nov 2022 05:14:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiKCJNb (ORCPT ); Thu, 3 Nov 2022 05:13:31 -0400 Received: from ironport.ite.com.tw (60-251-196-230.hinet-ip.hinet.net [60.251.196.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21CC3DF8D; Thu, 3 Nov 2022 02:13:01 -0700 (PDT) Received: from unknown (HELO mse.ite.com.tw) ([192.168.35.30]) by ironport.ite.com.tw with ESMTP; 03 Nov 2022 17:13:00 +0800 Received: from CSBMAIL1.internal.ite.com.tw (CSBMAIL1.internal.ite.com.tw [192.168.65.58]) by mse.ite.com.tw with ESMTP id 2A39CvID002433; Thu, 3 Nov 2022 17:12:57 +0800 (GMT-8) (envelope-from allen.chen@ite.com.tw) Received: from VirtualBox.internal.ite.com.tw (192.168.70.46) by CSBMAIL1.internal.ite.com.tw (192.168.65.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.14; Thu, 3 Nov 2022 17:12:57 +0800 From: allen CC: Allen Chen , Jau-Chih Tseng , Hermes Wu , Kenneth Hung , Pin-yen Lin , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , "open list:DRM DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: [PATCH v7 1/2] dt-bindings: it6505: add properties to restrict output bandwidth Date: Thu, 3 Nov 2022 17:12:42 +0800 Message-ID: <20221103091243.96036-2-allen.chen@ite.com.tw> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221103091243.96036-1-allen.chen@ite.com.tw> References: <20221103091243.96036-1-allen.chen@ite.com.tw> MIME-Version: 1.0 X-Originating-IP: [192.168.70.46] X-ClientProxiedBy: CSBMAIL1.internal.ite.com.tw (192.168.65.58) To CSBMAIL1.internal.ite.com.tw (192.168.65.58) X-TM-SNTS-SMTP: 2283999EE5B7323393A09A8AFC977A900C2CA3014ADDFE9C61A1B5BCFD52F12C2002:8 X-MAIL: mse.ite.com.tw 2A39CvID002433 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,PDS_RDNS_DYNAMIC_FP, RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748465814782426034?= X-GMAIL-MSGID: =?utf-8?q?1748465814782426034?= From: allen chen Currently there are no "upstream" users. So, no existing users to break. Add properties to restrict dp output data-lanes and clock. Signed-off-by: Pin-Yen Lin Signed-off-by: Allen Chen Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/bridge/ite,it6505.yaml | 68 +++++++++++++++++-- 1 file changed, 62 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml index 833d11b2303a7..b16a9d9127ddb 100644 --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml @@ -52,9 +52,49 @@ properties: maxItems: 1 description: extcon specifier for the Power Delivery - port: - $ref: /schemas/graph.yaml#/properties/port - description: A port node pointing to DPI host port node + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: A port node pointing to DPI host port node + + properties: + endpoint: + $ref: /schemas/graph.yaml#/$defs/endpoint-base + unevaluatedProperties: false + + properties: + link-frequencies: + minItems: 1 + maxItems: 1 + description: Allowed max link frequencies in Hz + + port@1: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: Video port for DP output + + properties: + endpoint: + $ref: /schemas/graph.yaml#/$defs/endpoint-base + unevaluatedProperties: false + + properties: + data-lanes: + minItems: 1 + uniqueItems: true + items: + - enum: [ 0, 1 ] + - const: 1 + - const: 2 + - const: 3 + + required: + - port@0 + - port@1 required: - compatible @@ -63,6 +103,7 @@ required: - interrupts - reset-gpios - extcon + - ports additionalProperties: false @@ -85,9 +126,24 @@ examples: reset-gpios = <&pio 179 1>; extcon = <&usbc_extcon>; - port { - it6505_in: endpoint { - remote-endpoint = <&dpi_out>; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + it6505_in: endpoint { + remote-endpoint = <&dpi_out>; + link-frequencies = /bits/ 64 <150000000>; + }; + }; + + port@1 { + reg = <1>; + it6505_out: endpoint { + remote-endpoint = <&dp_in>; + data-lanes = <0 1>; + }; }; }; }; From patchwork Thu Nov 3 09:12:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: allen X-Patchwork-Id: 14773 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp410330wru; Thu, 3 Nov 2022 02:17:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6srOKx4EwKVqVKEoZHSFC35CK3jbqPoBu2IvGZ7BTWziohTCHL3gGtXVszlARJMrCxjVhU X-Received: by 2002:a17:90a:2f88:b0:213:f498:eb63 with SMTP id t8-20020a17090a2f8800b00213f498eb63mr18447476pjd.232.1667467039425; Thu, 03 Nov 2022 02:17:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667467039; cv=none; d=google.com; s=arc-20160816; b=zdRVqy7IXxxwh4uL5WUc06L0uW8hN3iIXMmXtegMmsKYuFDd7xuTnNTt1kliosmdPF jLqmP78qlzg8inLPkcRuKO0xred2cYC88puGCt69CwUduDD+43mweODMoO4FhbN7zggP 3GkQ0Bf0fw3wgRMhPUuwMlvHPU3Ot6+DgF11hSn1xk6a5dLt99t2GiflKvw26EaOV+CU +ddQyU3QjtAoUE2pE/ROiEiJyerq3Djv8+TFrRhwCuRG9rIIRu7kkeoPszNPoGThBBBT r+sRfnESoLrqCk5Ayk0TxTQUodvvdmm4G4fESLrh625b6PObleEjU03etYDRa/8NMrl7 M93w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from; bh=Ewmr9E28IrsYhJT+ITfNeWjb7YaIlvn3KJP5fk+bn+o=; b=nudtFPnbdS03TQTbCeLAupVXKgF6FhIjBqJAgxGUpLmX6wki6ImBinueK0K2ldVv/C ehgqgSmneBR/4JdsPk1V0cR0FFD+jH4pc1yDqeRmExWAiLJpYzYOiquJv5G7WDXjnqh3 w+7jc+BbwnCWlQRWcM56KTT5leql02g+CxM7z4NmSIPSdNy5NSqUF0IqbH8i9IVFW67W St4/7oampqQMju9YbSp3VCIgHkU9nqszNDhi0+87kDwTL8VMVu0gqR88qyZjAz5HTrZ7 kMvqD1Gj65yaFJdEe3TNfJgIgtbF1RURyFRj0VUG+82C/KNAht3RMg6UBSmL5J8gs8Pz FupA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 189-20020a6306c6000000b004395afacb7csi419463pgg.214.2022.11.03.02.17.06; Thu, 03 Nov 2022 02:17:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231296AbiKCJOS (ORCPT + 99 others); Thu, 3 Nov 2022 05:14:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231295AbiKCJNh (ORCPT ); Thu, 3 Nov 2022 05:13:37 -0400 Received: from ironport.ite.com.tw (60-251-196-230.hinet-ip.hinet.net [60.251.196.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50346DFA3 for ; Thu, 3 Nov 2022 02:13:04 -0700 (PDT) Received: from unknown (HELO mse.ite.com.tw) ([192.168.35.30]) by ironport.ite.com.tw with ESMTP; 03 Nov 2022 17:13:00 +0800 Received: from CSBMAIL1.internal.ite.com.tw (CSBMAIL1.internal.ite.com.tw [192.168.65.58]) by mse.ite.com.tw with ESMTP id 2A39CvIb002434; Thu, 3 Nov 2022 17:12:57 +0800 (GMT-8) (envelope-from allen.chen@ite.com.tw) Received: from VirtualBox.internal.ite.com.tw (192.168.70.46) by CSBMAIL1.internal.ite.com.tw (192.168.65.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.14; Thu, 3 Nov 2022 17:12:58 +0800 From: allen CC: Allen Chen , Jau-Chih Tseng , Hermes Wu , Kenneth Hung , Pin-yen Lin , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , "open list:DRM DRIVERS" , open list Subject: [PATCH v7 2/2] drm/bridge: add it6505 driver to read data-lanes and link-frequencies from dt Date: Thu, 3 Nov 2022 17:12:43 +0800 Message-ID: <20221103091243.96036-3-allen.chen@ite.com.tw> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221103091243.96036-1-allen.chen@ite.com.tw> References: <20221103091243.96036-1-allen.chen@ite.com.tw> MIME-Version: 1.0 X-Originating-IP: [192.168.70.46] X-ClientProxiedBy: CSBMAIL1.internal.ite.com.tw (192.168.65.58) To CSBMAIL1.internal.ite.com.tw (192.168.65.58) X-TM-SNTS-SMTP: DC6DF12C906380A61B005FFE94DED121D09F7991A61E8A1C2B14214CD306F8A22002:8 X-MAIL: mse.ite.com.tw 2A39CvIb002434 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,PDS_RDNS_DYNAMIC_FP, RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748465918546357242?= X-GMAIL-MSGID: =?utf-8?q?1748465918546357242?= From: allen chen Add driver to read data-lanes and link-frequencies from dt property to restrict output bandwidth. Signed-off-by: Allen chen Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 80 +++++++++++++++++++++++++++-- 1 file changed, 77 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index a4302492cf8df..ed4536cde3140 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -437,6 +437,8 @@ struct it6505 { bool powered; bool hpd_state; u32 afe_setting; + u32 max_dpi_pixel_clock; + u32 max_lane_count; enum hdcp_state hdcp_status; struct delayed_work hdcp_work; struct work_struct hdcp_wait_ksv_list; @@ -1476,7 +1478,8 @@ static void it6505_parse_link_capabilities(struct it6505 *it6505) it6505->lane_count = link->num_lanes; DRM_DEV_DEBUG_DRIVER(dev, "Sink support %d lanes training", it6505->lane_count); - it6505->lane_count = min_t(int, it6505->lane_count, MAX_LANE_COUNT); + it6505->lane_count = min_t(int, it6505->lane_count, + it6505->max_lane_count); it6505->branch_device = drm_dp_is_branch(it6505->dpcd); DRM_DEV_DEBUG_DRIVER(dev, "Sink %sbranch device", @@ -2912,7 +2915,7 @@ it6505_bridge_mode_valid(struct drm_bridge *bridge, if (mode->flags & DRM_MODE_FLAG_INTERLACE) return MODE_NO_INTERLACE; - if (mode->clock > DPI_PIXEL_CLK_MAX) + if (mode->clock > it6505->max_dpi_pixel_clock) return MODE_CLOCK_HIGH; it6505->video_info.clock = mode->clock; @@ -3099,10 +3102,32 @@ static int it6505_init_pdata(struct it6505 *it6505) return 0; } +static int it6505_get_data_lanes_count(const struct device_node *endpoint, + const unsigned int min, + const unsigned int max) +{ + int ret; + + ret = of_property_count_u32_elems(endpoint, "data-lanes"); + if (ret < 0) + return ret; + + if (ret < min || ret > max) + return -EINVAL; + + return ret; +} + static void it6505_parse_dt(struct it6505 *it6505) { struct device *dev = &it6505->client->dev; + struct device_node *np = dev->of_node, *ep = NULL; + int len; + u64 link_frequencies; + u32 data_lanes[4]; u32 *afe_setting = &it6505->afe_setting; + u32 *max_lane_count = &it6505->max_lane_count; + u32 *max_dpi_pixel_clock = &it6505->max_dpi_pixel_clock; it6505->lane_swap_disabled = device_property_read_bool(dev, "no-laneswap"); @@ -3118,7 +3143,56 @@ static void it6505_parse_dt(struct it6505 *it6505) } else { *afe_setting = 0; } - DRM_DEV_DEBUG_DRIVER(dev, "using afe_setting: %d", *afe_setting); + + ep = of_graph_get_endpoint_by_regs(np, 1, 0); + of_node_put(ep); + + if (ep) { + len = it6505_get_data_lanes_count(ep, 1, 4); + + if (len > 0 && len != 3) { + of_property_read_u32_array(ep, "data-lanes", + data_lanes, len); + *max_lane_count = len; + } else { + *max_lane_count = MAX_LANE_COUNT; + dev_err(dev, "error data-lanes, use default"); + } + } else { + *max_lane_count = MAX_LANE_COUNT; + dev_err(dev, "error endpoint, use default"); + } + + ep = of_graph_get_endpoint_by_regs(np, 0, 0); + of_node_put(ep); + + if (ep) { + len = of_property_read_variable_u64_array(ep, + "link-frequencies", + &link_frequencies, 0, + 1); + if (len >= 0) { + do_div(link_frequencies, 1000); + if (link_frequencies > 297000) { + dev_err(dev, + "max pixel clock error, use default"); + *max_dpi_pixel_clock = DPI_PIXEL_CLK_MAX; + } else { + *max_dpi_pixel_clock = link_frequencies; + } + } else { + dev_err(dev, "error link frequencies, use default"); + *max_dpi_pixel_clock = DPI_PIXEL_CLK_MAX; + } + } else { + dev_err(dev, "error endpoint, use default"); + *max_dpi_pixel_clock = DPI_PIXEL_CLK_MAX; + } + + DRM_DEV_DEBUG_DRIVER(dev, "using afe_setting: %u, max_lane_count: %u", + it6505->afe_setting, it6505->max_lane_count); + DRM_DEV_DEBUG_DRIVER(dev, "using max_dpi_pixel_clock: %u kHz", + it6505->max_dpi_pixel_clock); } static ssize_t receive_timing_debugfs_show(struct file *file, char __user *buf,