From patchwork Wed Aug 23 08:28:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= X-Patchwork-Id: 136642 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp337219vqm; Wed, 23 Aug 2023 02:20:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgk6Zi90WGW8hq2rKOPPVAfh8Fgme7++sxzJbBhgM+gAFEpMbLrOsKVO+y4nGyD3coLhM7 X-Received: by 2002:a17:906:1010:b0:9a1:c370:1af3 with SMTP id 16-20020a170906101000b009a1c3701af3mr2966535ejm.16.1692782451386; Wed, 23 Aug 2023 02:20:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692782451; cv=none; d=google.com; s=arc-20160816; b=nWV8gPIjK1lrG+qdHBnFEAH7/7sNru1YjA++ud6w3loVeDaXOBuwAy6zI8ftxL1iH3 r1hruqLtPTPjQc8sjXaYoft1Tn4PT5ExP6/YvWcRKsMaTLBEKK+cQiSprVlpKytqlLR9 HnoIt4XKJnSmSL+qK1gK+EqzZeXcJm4grJYga4ARr8k1NZ1LWtOdQDWu5CqwcgI+pLZT nCekWe2qVz1l3RZl1kvJ0O+N+0A3WP1mkdwU1XtYhAOmjz9kwCBfMvLslVyGuRXjce1I zrcgS/9sf4Vd922f33hOXfiiwDFMiYpCmi/EBYrav2/vIUWW4jnGRoVET7rhBOELYVAk fbtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Kg7cEBg9bG3HXgVwMeFs8kQEsg/bcbuOUZYr3kHGmJw=; fh=nXycGrGouPEVHBX9ZNNRsZ70ess2tk2qtRdHAI2hdWs=; b=wDGqiqkqoqGChlJnH3jcBoP6wIrbsUTImS8B1AR8iCg7SW1iNSWWpNHTuEQj6ZuRgB F/Aj05nPYfATi/q1hdTa4Ig3drVS2Tp30Ps5z1yXbF3tlUkK1yj9RybVRVDkSYCYX2VI 6JFnNkF62EPbXbnw4WDZDCFzt3Q6bz1xUqwbppHZzkGjGlfwg9e6YGZY+s3Ud7TjJ//T 3BHW8QOuxbjV2TMJxgfguSl2PgCisXprtujqM7V0JTgIFjodkp0/GjzDCfDLX0wDzVE5 3KzEuXtmBl9xHqLC+C7mHXABvMHw4e1jiykia8ten5QS7CT9kmYveGDC1aQUMBkqKe+p 3f9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=B8XeCEiy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a170906154500b00987d66e6d26si8560161ejd.250.2023.08.23.02.20.27; Wed, 23 Aug 2023 02:20:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=B8XeCEiy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234644AbjHWIn1 (ORCPT + 99 others); Wed, 23 Aug 2023 04:43:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234305AbjHWIcg (ORCPT ); Wed, 23 Aug 2023 04:32:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B567210F5; Wed, 23 Aug 2023 01:28:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4ABAE614BE; Wed, 23 Aug 2023 08:28:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EA90C433C7; Wed, 23 Aug 2023 08:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692779333; bh=sgE48NtgP4eQen2ml46+iGXN2pZhCvwsUI3qxh709IA=; h=From:To:Cc:Subject:Date:From; b=B8XeCEiyNqSPMfc/NUpIMPqso5AROFao4byCojwbb5El1u6vSLFULDLvh/AQ9J9TP xYC4h2NCGDg1FNfUwHHbeRWhOJooIm4+18XN/Zy4G43BH0sr6vXTenjM5wA8rE7Imt fXncqCcjvg9fhu8gG9hy/3DATr+TuHwLPfzJxmsMishCx3lHyZuu/G7OjN1kAw1EHE I+nfxzy/zZ88AweOIeQHsgntA6vUTPBFDsyDnlsAs8aKjWUWAs9Btg8oLiuiahMdG5 cqMPbl0IfTurajBVvnWCCPWMFxx/8xrF99N9+NeOfPI7T3Ewe0NH9TNfwt2yCS2bJs PBxkutaUE1+BA== From: =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= To: Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, Randy Dunlap Cc: =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , linux-kernel@vger.kernel.org, Guo Ren , Drew Fustini , linux-next@vger.kernel.org, Stephen Rothwell Subject: [PATCH] riscv: Require FRAME_POINTER for some configurations Date: Wed, 23 Aug 2023 10:28:45 +0200 Message-Id: <20230823082845.354839-1-bjorn@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775011051986595496 X-GMAIL-MSGID: 1775011051986595496 From: Björn Töpel Some V configurations implicitly turn on '-fno-omit-frame-pointer', but leaving FRAME_POINTER disabled. This makes it hard to reason about the FRAME_POINTER config, and also triggers build failures introduced in by the commit in the Fixes: tag. Select FRAME_POINTER explicitly for these configurations. Fixes: ebc9cb03b21e ("riscv: stack: Fixup independent softirq stack for CONFIG_FRAME_POINTER=n") Signed-off-by: Björn Töpel --- arch/riscv/Kconfig | 1 + arch/riscv/Makefile | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) base-commit: 89bf6209cad66214d3774dac86b6bbf2aec6a30d diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index 10e7a7ad175a..cd8075c092c3 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -62,6 +62,7 @@ config RISCV select COMMON_CLK select CPU_PM if CPU_IDLE || HIBERNATION select EDAC_SUPPORT + select FRAME_POINTER if PERF_EVENTS || (FUNCTION_TRACER && !DYNAMIC_FTRACE) select GENERIC_ARCH_TOPOLOGY select GENERIC_ATOMIC64 if !64BIT select GENERIC_CLOCKEVENTS_BROADCAST if SMP diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile index 6ec6d52a4180..1329e060c548 100644 --- a/arch/riscv/Makefile +++ b/arch/riscv/Makefile @@ -87,9 +87,6 @@ endif ifeq ($(CONFIG_CMODEL_MEDANY),y) KBUILD_CFLAGS += -mcmodel=medany endif -ifeq ($(CONFIG_PERF_EVENTS),y) - KBUILD_CFLAGS += -fno-omit-frame-pointer -endif # Avoid generating .eh_frame sections. KBUILD_CFLAGS += -fno-asynchronous-unwind-tables -fno-unwind-tables