From patchwork Sun Aug 20 15:57:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 136273 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b82d:0:b0:3f2:4152:657d with SMTP id z13csp2539970vqi; Sun, 20 Aug 2023 08:58:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGqEPiWR8XmKX+SWn3pvVR8+UnT97/FlMJkDjpwsrd4Zt9U8Ch/um6SpJzDDl8Eg/6NChqt X-Received: by 2002:aa7:d3d2:0:b0:521:8777:b00d with SMTP id o18-20020aa7d3d2000000b005218777b00dmr3109932edr.15.1692547105942; Sun, 20 Aug 2023 08:58:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692547105; cv=none; d=google.com; s=arc-20160816; b=HgDwENUf9QGl6O6zL+YLATOfIlIGIA8kDHzuSZZ1C13sJ2sY9dJbt2DMGzdNqiKpOd n5acl6B3RCZGgymzg5kfFIX3coecz9t+X2hFs/vFl6VQ8BSh+qhCeQ2QCyZpwPJZ2DzR 0lGzJB/6PvRKr0H6dwqzjr8CaSBmX2aRdZr0vN+RRWNs3p3XJcJSWTDe1XPjaIwNRTKF jKh++tK0aAhkpEO9vkLhNChROE5OKAb0ka4TiRFEGmS/KYh3/xqB5Uzi0sQgofJpjjEf s1O+YKrvQRssFf6IizmllbMlfJsO1cubP5xBLGifL3Bo3x1nLcKpFCT2HmAKJPfcn9XL wPEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:to:subject :message-id:date:mime-version:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=qrPWXZKkk4eevAs0bUL3Z7A8sL8AyVDAxjB9x+91VpE=; fh=HBK5sYjCSY3abfomIo1OsC2COh3RKQ+LJ7T9VtS2mGI=; b=k3KxARvQFJmVp5djWV1mMzGoxYb01u27yin+g07HtbPfSJK4qWuIq6XFQEKkBp5GPf R85XgflI6DtZPl+EN7mJ23Y+4YTsm7MPSe7O5U6av/OyCE4BzHQMoAfN8jMLrFLlojwi PMMoJbK7gizAbhDG1m1Q2RxXDw4Vs7bPNLJsEwjm2bCZV2wqga4MCvCFSpy+WpxqlmI1 q9N9WB6MJRpDYTDH2kKASlKoE8SpWOhHiP4qfoUjnRWWeCb/Tum+L/hppoFAyrq/NXs9 IPo/JVfsuSOU+7bwjM5in2l7tQV3CnAYFsgBMOtWaGwuZb0Q8rPwKUkBtPfrA1FSZ8NJ HabQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=NIEo0ib7; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id q12-20020aa7da8c000000b0052567e6585dsi4392531eds.72.2023.08.20.08.58.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 08:58:25 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=NIEo0ib7; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D70FF385840E for ; Sun, 20 Aug 2023 15:58:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D70FF385840E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1692547104; bh=qrPWXZKkk4eevAs0bUL3Z7A8sL8AyVDAxjB9x+91VpE=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=NIEo0ib7LI41P1uf9RjtywU16BY9l0UJ8wsfEHe36qdh/OYesw9RLZr9RpURoJVfx 1AiJmionhqJi9aYAdj+ungd4hFH+AS7TzT2Pc94uETVb7pNgYqOvqamWqi5hpEHr81 KuqsfvtthCyev+BjYLpmBsAJCyrVTkhIU1vzeYc8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 84A073858D32 for ; Sun, 20 Aug 2023 15:57:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84A073858D32 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4ff9121fd29so3696828e87.3 for ; Sun, 20 Aug 2023 08:57:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692547060; x=1693151860; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qrPWXZKkk4eevAs0bUL3Z7A8sL8AyVDAxjB9x+91VpE=; b=ABcqXWRt8o5viv9U6wHfmFIgFNxYAqIxtbua93y3G7v30kJqezSufipj07INl0fgAg quCC+9h/uLBrKXt8c7sOQMv6mwQ1byJLzyop3oGRvpsbFIAuQ5N3KfcMEi+NNtXqbYXA dkNyrKG5Y8zAHQQQr3gpKymlDecVmG81WaZ53XoOWaqE9awAoVWQXOep9Kptf2viqlOq EQQs6lw8psMnWhf9CPBF030U2ogww638yWa0qQ2j2yl91hsCq2MqGPCqcX0RLHlHRvpm bFcrN+w5NfsTm82uadw4XFsEP5RftWH0WzVs7sQyTkwPAxcdK9ZA085+sIz8jrnETuJJ oKzg== X-Gm-Message-State: AOJu0YzC5FyalduoOgx4lCH7Mb5V/OkN08hVzI4/oPum+7HcY/55aJN2 6G90pW44YDvncm05SlAhteIgdNbh4s9ISr34cdSHOxiA1vA9VA== X-Received: by 2002:a19:4302:0:b0:500:7a21:3e78 with SMTP id q2-20020a194302000000b005007a213e78mr1010543lfa.55.1692547060149; Sun, 20 Aug 2023 08:57:40 -0700 (PDT) MIME-Version: 1.0 Date: Sun, 20 Aug 2023 17:57:29 +0200 Message-ID: Subject: [committed] i386: Micro-optimize ix86_expand_sse_extend To: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Uros Bizjak via Gcc-patches From: Uros Bizjak Reply-To: Uros Bizjak Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774764274217567383 X-GMAIL-MSGID: 1774764274217567383 Partial vector src is forced to a register as ops[1], we can use it instead of SRC in the call to ix86_expand_sse_cmp. This change avoids forcing operand[1] to a register in sign/zero-extend expanders. gcc/ChangeLog: * config/i386/i386-expand.cc (ix86_expand_sse_extend): Use ops[1] instead of src in the call to ix86_expand_sse_cmp. * config/i386/sse.md (v8qiv8hi2): Do not force operands[1] to a register. (v4hiv4si2): Ditto. (v2siv2di2): Ditto. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Uros. diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc index 460d496ef22..031e2f72d15 100644 --- a/gcc/config/i386/i386-expand.cc +++ b/gcc/config/i386/i386-expand.cc @@ -5667,7 +5667,7 @@ ix86_expand_sse_extend (rtx dest, rtx src, bool unsigned_p) ops[2] = force_reg (imode, CONST0_RTX (imode)); else ops[2] = ix86_expand_sse_cmp (gen_reg_rtx (imode), GT, CONST0_RTX (imode), - src, pc_rtx, pc_rtx); + ops[1], pc_rtx, pc_rtx); ix86_split_mmx_punpck (ops, false); emit_move_insn (dest, lowpart_subreg (GET_MODE (dest), ops[0], imode)); diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index 87c3bf07020..da85223a9b4 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -22923,8 +22923,7 @@ (define_expand "v8qiv8hi2" { if (!TARGET_SSE4_1) { - rtx op1 = force_reg (V8QImode, operands[1]); - ix86_expand_sse_extend (operands[0], op1, ); + ix86_expand_sse_extend (operands[0], operands[1], ); DONE; } @@ -23240,8 +23239,7 @@ (define_expand "v4hiv4si2" { if (!TARGET_SSE4_1) { - rtx op1 = force_reg (V4HImode, operands[1]); - ix86_expand_sse_extend (operands[0], op1, ); + ix86_expand_sse_extend (operands[0], operands[1], ); DONE; } @@ -23846,8 +23844,7 @@ (define_expand "v2siv2di2" { if (!TARGET_SSE4_1) { - rtx op1 = force_reg (V2SImode, operands[1]); - ix86_expand_sse_extend (operands[0], op1, ); + ix86_expand_sse_extend (operands[0], operands[1], ); DONE; }