From patchwork Wed Aug 16 11:33:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 136101 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b82d:0:b0:3f2:4152:657d with SMTP id z13csp1948402vqi; Sat, 19 Aug 2023 03:33:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/+bg236nwgM+GmySwlGnixfnxCAKRSFyn7+eZtAHdMlMZCg7JSW1RQVlP2UeNqv2FXqxL X-Received: by 2002:a05:6808:2a0c:b0:3a8:1c07:17d3 with SMTP id ez12-20020a0568082a0c00b003a81c0717d3mr2135468oib.19.1692441214727; Sat, 19 Aug 2023 03:33:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692441214; cv=none; d=google.com; s=arc-20160816; b=XnFOUNcVpY8YflwavcON9WzHkRcpxy/+FMfnUt4aoKrtfZfLPdQcE3hGlUNdJvRzWi wsiqcMAf1hfG/YxQNCxdIEJb3DWMiS+p+qaqNXM5ePmurXqNw47xyJray8tCVAqS67Bg jeiZKOfcHQTx5tAHUL3tfukPWyRZOFAkhC/0XxZQcqUWAIzD0xf1UZP2GJMuU5psyzNN FcbTkX+gM45ggpzP8ZHLGPS3xRyYhdtPo8lKmxaypvsmSOvuETCXoE8b/4AnBVhnf9Sg Uak79RdyPj4EV0kkzicygZmY+oIFstbEFFsF801TcXXKlj/QsZ90Uhpym1UyUxDSxOWd eX8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=asonBC2oSMy0xFMJfBsoqexDIynNnQ0GBVP4tIMWzsg=; fh=XqQyBCA3lB9axibsKnTw/y94kfph+nu2VsDl2S78uuw=; b=aEu4XcGc5Z65muKd6ZZlnnSJVXkncSd4HvHVWfphCZYIlswxqSm/ugaCvn+4/v65MX G6rRnK59ik4xz6NBPVYoTDNnjrE6ntj436IEGK7uTxU4r9qbIVFXE2MHQrSwFKoes8lQ TD77snGKDcb2hpJ0X5gWyc6NQv0QzP7XVO6c4Rk+oq5BuUmZ7u/iB6Gl5tqbe709aJIG MpWQqtdiwp/kUCJRmKiuqWseU8GWb+Rj6zL0L0gddlM/LsHvjH49l1vjlu2nXFs02ps7 Zu/BRiBYeCWv1XfLUXV3Xw5Pu+NxYuRb8yQmoWh4f5iE4GkuIsAtUMxKB9QpnR7zKL5Z kC8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id cl4-20020a056a0032c400b0067b77e7f473si3158131pfb.232.2023.08.19.03.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Aug 2023 03:33:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A5C0F4CD6D; Sat, 19 Aug 2023 01:31:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244624AbjHPLeZ (ORCPT + 99 others); Wed, 16 Aug 2023 07:34:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244683AbjHPLeL (ORCPT ); Wed, 16 Aug 2023 07:34:11 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDA7826A8 for ; Wed, 16 Aug 2023 04:33:36 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5d0c:f209:12a7:4ce5]) by xavier.telenet-ops.be with bizsmtp id aBZT2A00445ualL01BZTFl; Wed, 16 Aug 2023 13:33:28 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qWEm8-000p1Y-GO; Wed, 16 Aug 2023 13:33:26 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qWEmE-006A0c-RE; Wed, 16 Aug 2023 13:33:26 +0200 From: Geert Uytterhoeven To: Alessandro Zummo , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Arnd Bergmann , Valentin Caron Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] rtc: stm32: Use NOIRQ_SYSTEM_SLEEP_PM_OPS() Date: Wed, 16 Aug 2023 13:33:26 +0200 Message-Id: <20230816113326.1468435-1-geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774653239066375205 X-GMAIL-MSGID: 1774653239066375205 If CONFIG_PM_SLEEP=n (e.g. m68k/allmodconfig): drivers/rtc/rtc-stm32.c:904:12: error: ‘stm32_rtc_resume’ defined but not used [-Werror=unused-function] 904 | static int stm32_rtc_resume(struct device *dev) | ^~~~~~~~~~~~~~~~ drivers/rtc/rtc-stm32.c:894:12: error: ‘stm32_rtc_suspend’ defined but not used [-Werror=unused-function] 894 | static int stm32_rtc_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~ Indeed, the previous change mixed up the semantics between SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() and NOIRQ_SYSTEM_SLEEP_PM_OPS(). Fix this by using the modern NOIRQ_SYSTEM_SLEEP_PM_OPS() instead. Reported-by: noreply@ellerman.id.au Fixes: a69c610e13e2b2de ("rtc: stm32: remove incorrect #ifdef check") Signed-off-by: Geert Uytterhoeven --- drivers/rtc/rtc-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index 3ce4b3d08155b48d..76753c71d92eef3e 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -923,7 +923,7 @@ static int stm32_rtc_resume(struct device *dev) } static const struct dev_pm_ops stm32_rtc_pm_ops = { - SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) + NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) }; static struct platform_driver stm32_rtc_driver = {