From patchwork Thu Nov 3 04:52:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Sae X-Patchwork-Id: 14641 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp320866wru; Wed, 2 Nov 2022 21:56:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4puqWC/KtNwYuyJHYn6QqxFQza1eMOSjhtqvO3HMY+wDHi6NXu07qgVlR/HQMCUzaazChC X-Received: by 2002:a17:90b:3011:b0:213:deb7:d47f with SMTP id hg17-20020a17090b301100b00213deb7d47fmr20131495pjb.136.1667451416035; Wed, 02 Nov 2022 21:56:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667451416; cv=none; d=google.com; s=arc-20160816; b=joSHo8N0pTf8k4wAY2Q7DX2xjHj0FP6dT8jq7b0ASZ3bvYP2u71+WwYOH5LyTkyd+2 P0ozyD5iRlBq7Ve6bYmLHS7eHNT0bmkC+Ti/IgmSa8xsEA7omvsVJwvFRqp3+xzuvQ1c jGX8svTRVPqNfdfhubpM6eHdi+GEBnDyef2jlrjSg9otzpPinTSzyaDbTH2EwOO8n7pq O+RbG/xof4wegJkagOMGYIcVOgQf9UeHSFyXBK2WVjRBs8W6R914PPoMZT0ds8vns8BD 4MXqFPX+2G1iRLC5oWU1H9ZfbeBJSJQj/G8egA7aoeAgOfqHwuk1g9denLcXv3IrExMm H15w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=RwJvij7WAWr5l1dmCcxsJj+bs4bIchOxee67gw1FKus=; b=0kNdYpLG5APKmSHVtD9MyMgL0h/yfp+5Z/3hwoY6rk/NMcSF9XO/EXJypO1g3fXQv4 E33N/0jXDxXW9N42FCFahZG0PUVU782u0AKVtJV7Z0raWQ4876mkbj90p8K//8dcMmnQ tsL3qSR8wX7vOjIxJrWQd6xr/Chl8u+QdB9DDTT3eZIYIt5TRStP8TdywIz/UBLoaK6O vQb1sSY3Ws9czsFZ5TpJe14fGi4ryNnQwmDWMdmbgaBKY1dEupovE0bGEvSyF/3TDx5i Mx/+h5L5Y3OEraV4FIzt0Fpg4V42wFCjlIpY7l7TtE+D/Xy9meGqBmXf7G+UaqdxNc8b PTDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oe4-20020a17090b394400b002088ad6d93fsi4217823pjb.49.2022.11.02.21.56.36; Wed, 02 Nov 2022 21:56:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbiKCEwb (ORCPT + 99 others); Thu, 3 Nov 2022 00:52:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbiKCEw3 (ORCPT ); Thu, 3 Nov 2022 00:52:29 -0400 Received: from out28-73.mail.aliyun.com (out28-73.mail.aliyun.com [115.124.28.73]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 109ED175B4; Wed, 2 Nov 2022 21:52:26 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.4049321|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.00908338-0.000475167-0.990441;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047202;MF=frank.sae@motor-comm.com;NM=1;PH=DS;RN=16;RT=16;SR=0;TI=SMTPD_---.Q-Azxru_1667451137; Received: from sunhua.motor-comm.com(mailfrom:Frank.Sae@motor-comm.com fp:SMTPD_---.Q-Azxru_1667451137) by smtp.aliyun-inc.com; Thu, 03 Nov 2022 12:52:23 +0800 From: Frank To: Peter Geis , Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: yinghong.zhang@motor-comm.com, fei.zhang@motor-comm.com, hua.sun@motor-comm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Frank , kernel test robot , Julia Lawall Subject: [PATCH net-next v1.1] net: phy: fix yt8521 duplicated argument to & or | Date: Thu, 3 Nov 2022 12:52:32 +0800 Message-Id: <20221103045232.833-1-Frank.Sae@motor-comm.com> X-Mailer: git-send-email 2.31.0.windows.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748449535795041343?= X-GMAIL-MSGID: =?utf-8?q?1748449535795041343?= cocci warnings: (new ones prefixed by >>) >> drivers/net/phy/motorcomm.c:1122:8-35: duplicated argument to & or | drivers/net/phy/motorcomm.c:1126:8-35: duplicated argument to & or | drivers/net/phy/motorcomm.c:1130:8-34: duplicated argument to & or | drivers/net/phy/motorcomm.c:1134:8-34: duplicated argument to & or | The second YT8521_RC1R_GE_TX_DELAY_xx should be YT8521_RC1R_FE_TX_DELAY_xx. Fixes: 70479a40954c ("[net-next,v8.2] net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy") Reported-by: kernel test robot Reported-by: Julia Lawall Signed-off-by: Frank --- v1.1 -change PATCH net to PATCH net-next -add warnings info drivers/net/phy/motorcomm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c index c7593f224177..bd1ab5d0631f 100644 --- a/drivers/net/phy/motorcomm.c +++ b/drivers/net/phy/motorcomm.c @@ -1119,19 +1119,19 @@ static int yt8521_config_init(struct phy_device *phydev) switch (phydev->interface) { case PHY_INTERFACE_MODE_RGMII: - val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS; + val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS; val |= YT8521_RC1R_RX_DELAY_DIS; break; case PHY_INTERFACE_MODE_RGMII_RXID: - val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS; + val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS; val |= YT8521_RC1R_RX_DELAY_EN; break; case PHY_INTERFACE_MODE_RGMII_TXID: - val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN; + val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN; val |= YT8521_RC1R_RX_DELAY_DIS; break; case PHY_INTERFACE_MODE_RGMII_ID: - val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN; + val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN; val |= YT8521_RC1R_RX_DELAY_EN; break; case PHY_INTERFACE_MODE_SGMII: