From patchwork Thu Nov 3 02:50:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Sae X-Patchwork-Id: 14611 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp279879wru; Wed, 2 Nov 2022 19:53:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Op1MWfvW+JBRzW80SKQrWToRzf2mDtFGGty4+b3eixoC5MMVmLwhLFI39bUsa6E1uboZO X-Received: by 2002:a63:8741:0:b0:470:ef2:6f11 with SMTP id i62-20020a638741000000b004700ef26f11mr4514960pge.455.1667444027085; Wed, 02 Nov 2022 19:53:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667444027; cv=none; d=google.com; s=arc-20160816; b=0pybjkfr8OyGY2T7G6xuVuHixs5OIEbKNe1OpIm4YsvgBlf4LMNpGAntalhtggI/qG ze/vyYpcbmoRZyIHZ/Z0C4rsez/3TVwqv/5o944EoU/NEnzcuTub0uwz7LvdMhkKmXUr 1q6s1V0an41dISwTKKOejvmecMZkP5/9UqHlXB9wY+OSmbrbCkV5MQUJbeZ2MyLW7llp VgY51EPWQ7D354TsNXU+ZIbJK9f3LuAAs4NrsN8NIMwRmuGqSGqcEmS0kapIzwe5Nq0x 67ET2EfTk74xLUKYWqX5OiNknDEno1STKj/n/loIbg46n+jdIEceagAAAM/T9ZErCkp1 ss7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=LPdZv3UBOHzDbWQwF0fiSLmv8oX+PIqL23RjIu3Li4w=; b=ad9oDkpSRx+Ysoz//l6IWtbPyF1Fy4iTDWpt92RSRj4K83l11jzG0Ery2IUQVqwLBj HtRjbgcgZc5U0ZaFpJDASINBU+FQsPfZNbXa1K+OI+ae5FqTOHeDdDZwUmGIU5zThFZd VYIozsMF2D3AVYcEo00KHxKn7anOJApPSE9Hq1yYEOR8EGN91v8g9SpsIKZAYPPY304G BXzzoz/vEz7uBmOYVdN0QW9wqnfM0HyQsui/YA/axg1l1i//CYSlLgGTro7Wfd8H5QX1 XmI2quJquMtE/RTvY/kGtGRSzT/0T9lcC9SYrGbwu5L9n7FLlC910zVU0/BTue+wJ5iC z5Ww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f13-20020a631f0d000000b0044d72a10ab0si19035631pgf.342.2022.11.02.19.53.34; Wed, 02 Nov 2022 19:53:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230222AbiKCCwh (ORCPT + 99 others); Wed, 2 Nov 2022 22:52:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbiKCCwK (ORCPT ); Wed, 2 Nov 2022 22:52:10 -0400 Received: from out29-170.mail.aliyun.com (out29-170.mail.aliyun.com [115.124.29.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8B9715A00; Wed, 2 Nov 2022 19:51:27 -0700 (PDT) X-Alimail-AntiSpam: AC=SUSPECT;BC=0.6395016|-1;BR=01201311R831b1;CH=blue;DM=|SUSPECT|false|;DS=CONTINUE|ham_system_inform|0.0202667-0.000889277-0.978844;FP=3240711654452809652|1|1|3|0|-1|-1|-1;HT=ay29a033018047202;MF=frank.sae@motor-comm.com;NM=1;PH=DS;RN=16;RT=16;SR=0;TI=SMTPD_---.Q-4cLR7_1667443832; Received: from sunhua.motor-comm.com(mailfrom:Frank.Sae@motor-comm.com fp:SMTPD_---.Q-4cLR7_1667443832) by smtp.aliyun-inc.com; Thu, 03 Nov 2022 10:51:18 +0800 From: Frank To: Peter Geis , Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: yinghong.zhang@motor-comm.com, fei.zhang@motor-comm.com, hua.sun@motor-comm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Frank , kernel test robot , Julia Lawall Subject: [PATCH net] net: phy: fix yt8521 duplicated argument to & or Date: Thu, 3 Nov 2022 10:50:47 +0800 Message-Id: <20221103025047.1862-1-Frank.Sae@motor-comm.com> X-Mailer: git-send-email 2.31.0.windows.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748441788001052647?= X-GMAIL-MSGID: =?utf-8?q?1748441788001052647?= The second YT8521_RC1R_GE_TX_DELAY_xx should be YT8521_RC1R_FE_TX_DELAY_xx. Fixes: 70479a40954c ("[net-next,v8.2] net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy") Reported-by: kernel test robot Reported-by: Julia Lawall Signed-off-by: Frank Reviewed-by: Andrew Lunn --- drivers/net/phy/motorcomm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c index c7593f224177..bd1ab5d0631f 100644 --- a/drivers/net/phy/motorcomm.c +++ b/drivers/net/phy/motorcomm.c @@ -1119,19 +1119,19 @@ static int yt8521_config_init(struct phy_device *phydev) switch (phydev->interface) { case PHY_INTERFACE_MODE_RGMII: - val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS; + val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS; val |= YT8521_RC1R_RX_DELAY_DIS; break; case PHY_INTERFACE_MODE_RGMII_RXID: - val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS; + val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS; val |= YT8521_RC1R_RX_DELAY_EN; break; case PHY_INTERFACE_MODE_RGMII_TXID: - val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN; + val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN; val |= YT8521_RC1R_RX_DELAY_DIS; break; case PHY_INTERFACE_MODE_RGMII_ID: - val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN; + val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN; val |= YT8521_RC1R_RX_DELAY_EN; break; case PHY_INTERFACE_MODE_SGMII: