From patchwork Tue Aug 15 15:56:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Przywara X-Patchwork-Id: 135702 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:3f2:4152:657d with SMTP id x8csp756681vqo; Tue, 15 Aug 2023 16:30:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFrg1k9nDHnJRgMhIays9wyb12tmRUUOTYbFpGRuhVocov1uTHjr8hidw6Pph+2wwarFj4q X-Received: by 2002:a05:6a20:4284:b0:135:293b:efaf with SMTP id o4-20020a056a20428400b00135293befafmr510878pzj.10.1692142250065; Tue, 15 Aug 2023 16:30:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692142250; cv=none; d=google.com; s=arc-20160816; b=s12hY8LTsflNsI/qrkwA4T13rGYI9GGbr0YtTkneCjDkL9nK27q4e209MFBtX0pGdK WADPZV730UiLan2aHn3wKqFqxFxG4fI6S7qLnxcDaPP016gi8cLUHXOGLi4Gq4cltC1b IEQ3trMndRy5H5rA5TN9qSKOLiN5MGdMc9zjQcE67Fp7K+Rb2S6DPesI85mAG1PYMrst 4XUgBMaegjDEu/778UYFF51e7u7H2NmJbTJyadrVZfT84NgSb75EiPGsA2TYF00M5oap vvZtKvy+5M55n51g5PrC3dH4sBS+D9wDZG1v/09cj4DhdxuwMaP7dUH6RucoezX6OIJW vmcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=YlNSoMP2FgHmsuhuEnPfHxeLnh4batQSjqhc3RkeaO4=; fh=UBrbDth7y5oMgl8brvefl9eZ6RQ3QXA6llOLfOqxpDM=; b=yxN2R7fFENbmgQDlUfiUDlEEaF0ePaZK5cx67hu7zL9aNh1Wl4UJXco8aYRWL+JjbT 0LIYHx7sIHFwmy3Bka0hLJHQcYacDYjc2iZ4oDa2/rV+12d2uGl6Zh2LFiM0mOk99oRb UcqRMnJYIcTsppsxD7HrPGGjYaypBxMaszzY09rbNzj73JRz9WABzFEk8MKQt0ifM+hy S6ISvm7bb5Mwqb0zyYYv8snT+4Blc5T6KUazcznrMtvFU6sZkW5lTRIiBAgk25te8P4N e5jEDuRbQthTPHamO6PS1rE2hkZMq6hYrVITF8vNO4/e/h4Wmy6rprSsGVRySLOyoxAb D4pQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 36-20020a631664000000b005645bbe3ffbsi10406736pgw.577.2023.08.15.16.30.36; Tue, 15 Aug 2023 16:30:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238391AbjHOP5J (ORCPT + 99 others); Tue, 15 Aug 2023 11:57:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238371AbjHOP4d (ORCPT ); Tue, 15 Aug 2023 11:56:33 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8A4CA1B6; Tue, 15 Aug 2023 08:56:31 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A37C11FB; Tue, 15 Aug 2023 08:57:13 -0700 (PDT) Received: from donnerap.arm.com (donnerap.manchester.arm.com [10.32.100.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B2773F6C4; Tue, 15 Aug 2023 08:56:29 -0700 (PDT) From: Andre Przywara To: Shuah Khan , Nhat Pham , Johannes Weiner Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] selftests: cachestat: properly link in librt Date: Tue, 15 Aug 2023 16:56:10 +0100 Message-Id: <20230815155612.2535947-2-andre.przywara@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230815155612.2535947-1-andre.przywara@arm.com> References: <20230815155612.2535947-1-andre.przywara@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774339752013799288 X-GMAIL-MSGID: 1774339752013799288 Libraries should be listed last on the compiler's command line, so that the linker can look for and find still unresolved symbols. The librt library, required for the shm_* functions, was announced using CFLAGS, which puts the library *before* the source files, and fails compilation on my system: ====================== gcc -isystem /src/linux-selftests/usr/include -Wall -lrt test_cachestat.c -o /src/linux-selftests/kselftest/cachestat/test_cachestat /usr/bin/ld: /tmp/cceQWO3u.o: in function `test_cachestat_shmem': test_cachestat.c:(.text+0x890): undefined reference to `shm_open' /usr/bin/ld: test_cachestat.c:(.text+0x99c): undefined reference to `shm_unlink' collect2: error: ld returned 1 exit status make[4]: *** [../lib.mk:181: /src/linux-selftests/kselftest/cachestat/test_cachestat] Error 1 ====================== Announce the library using the LDLIBS variable, which ensures the proper ordering on the command line. Signed-off-by: Andre Przywara --- tools/testing/selftests/cachestat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/cachestat/Makefile b/tools/testing/selftests/cachestat/Makefile index fca73aaa7d141..778b54ebb0364 100644 --- a/tools/testing/selftests/cachestat/Makefile +++ b/tools/testing/selftests/cachestat/Makefile @@ -3,6 +3,6 @@ TEST_GEN_PROGS := test_cachestat CFLAGS += $(KHDR_INCLUDES) CFLAGS += -Wall -CFLAGS += -lrt +LDLIBS += -lrt include ../lib.mk From patchwork Tue Aug 15 15:56:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Przywara X-Patchwork-Id: 135681 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:3f2:4152:657d with SMTP id x8csp563128vqo; Tue, 15 Aug 2023 09:59:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHN3YfYSB4fHXAaSYLl/wKKMUz1vywH+qorNPOrf4fNP6u60KfVRqFEJdAdJxQuf2FvUiXh X-Received: by 2002:a05:6402:1006:b0:523:1fa2:4f40 with SMTP id c6-20020a056402100600b005231fa24f40mr9814596edu.19.1692118795040; Tue, 15 Aug 2023 09:59:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692118795; cv=none; d=google.com; s=arc-20160816; b=Yerx8fiYR2x1SjuCY/0IjzJxke9rPPI7JDNA0E7m3p7YUebj9xvfwAohe8JUVvanT7 grX7L6930RSV77Ex9tKUnSlG9+hYM3Zk15FFnf5L9Z4G6njGIORnDiE+WpFTShcsYc0k P54cgSn7qczIzaIWKK/PjxJOt2Q79D9YnqnfGXebpB/8AoY8/9HlhN+U9RM1kXWq+RJZ VnP3a7hRg6wZTAo4fYKY9U0TDLWtezgsrJJNPobaYVJZEPkDhIZ7eYnD12uaOasMmZAB Z6iaV4eh5GUgD6RqH/A+khC6jecWmz8SjL9TTgpJGx7dT1HCUzKY74vgt7cHcdAFsMEE qhqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=tXCPTU67nHHJh2NBnPH7qe9rwLgbiu4LYOJdDZZMm4o=; fh=UBrbDth7y5oMgl8brvefl9eZ6RQ3QXA6llOLfOqxpDM=; b=nMX13x6LDsJg1JDjCfZrc7+SEuWM8OgUd+S32GUiqy9OxdPeLSUZFUlj6jLjDlL/h+ 31+0c+SaT0hXr4N0UCflrEQk0/D+2PxoJNA9GAXnSdcYFTx6hv202IJ8U//YVvJtJUYH Vh+JR1Jk7e+N3MmJGtAAsuzODY1hbnN+oOqm9zIsLBDiyHiTnbuKJgv5qLzrIhf7pJ2/ InnGBVyIF7WqXt1l3y9TMhgRFyfYWqCm6FG5EA0vhhNfIhzHgeXMGFfu3XmA9bLFPNjQ ZsTSfecKcVJDxloumyM45hcAx/5O/t9P2X7WUnBd32ZICkw+qxypjikEEApB+vdrpWdE rXyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f25-20020a05640214d900b0052579075f2bsi755816edx.360.2023.08.15.09.59.31; Tue, 15 Aug 2023 09:59:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238386AbjHOP5H (ORCPT + 99 others); Tue, 15 Aug 2023 11:57:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238375AbjHOP4d (ORCPT ); Tue, 15 Aug 2023 11:56:33 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7B95319B3; Tue, 15 Aug 2023 08:56:32 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 92054143D; Tue, 15 Aug 2023 08:57:14 -0700 (PDT) Received: from donnerap.arm.com (donnerap.manchester.arm.com [10.32.100.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 431D13F6C4; Tue, 15 Aug 2023 08:56:31 -0700 (PDT) From: Andre Przywara To: Shuah Khan , Nhat Pham , Johannes Weiner Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] selftests: cachestat: use proper syscall number macro Date: Tue, 15 Aug 2023 16:56:11 +0100 Message-Id: <20230815155612.2535947-3-andre.przywara@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230815155612.2535947-1-andre.przywara@arm.com> References: <20230815155612.2535947-1-andre.przywara@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774315157784344787 X-GMAIL-MSGID: 1774315157784344787 At the moment the cachestat syscall number is hard coded into the test source code. Remove that and replace it with the proper __NR_cachestat macro. That ensures compatibility should other architectures pick a different number. Signed-off-by: Andre Przywara --- tools/testing/selftests/cachestat/test_cachestat.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c index 54d09b820ed4b..a5a4ac8dcb76c 100644 --- a/tools/testing/selftests/cachestat/test_cachestat.c +++ b/tools/testing/selftests/cachestat/test_cachestat.c @@ -19,7 +19,6 @@ static const char * const dev_files[] = { "/dev/zero", "/dev/null", "/dev/urandom", "/proc/version", "/proc" }; -static const int cachestat_nr = 451; void print_cachestat(struct cachestat *cs) { @@ -126,7 +125,7 @@ bool test_cachestat(const char *filename, bool write_random, bool create, } } - syscall_ret = syscall(cachestat_nr, fd, &cs_range, &cs, 0); + syscall_ret = syscall(__NR_cachestat, fd, &cs_range, &cs, 0); ksft_print_msg("Cachestat call returned %ld\n", syscall_ret); @@ -152,7 +151,7 @@ bool test_cachestat(const char *filename, bool write_random, bool create, ksft_print_msg("fsync fails.\n"); ret = false; } else { - syscall_ret = syscall(cachestat_nr, fd, &cs_range, &cs, 0); + syscall_ret = syscall(__NR_cachestat, fd, &cs_range, &cs, 0); ksft_print_msg("Cachestat call (after fsync) returned %ld\n", syscall_ret); @@ -213,7 +212,7 @@ bool test_cachestat_shmem(void) goto close_fd; } - syscall_ret = syscall(cachestat_nr, fd, &cs_range, &cs, 0); + syscall_ret = syscall(__NR_cachestat, fd, &cs_range, &cs, 0); if (syscall_ret) { ksft_print_msg("Cachestat returned non-zero.\n"); From patchwork Tue Aug 15 15:56:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Przywara X-Patchwork-Id: 135813 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b82d:0:b0:3f2:4152:657d with SMTP id z13csp251907vqi; Wed, 16 Aug 2023 12:59:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEml0zLEsCtT2jev7z92/+aGt3DEAv7ov1zIzfLJur7Q3NabR5KryCnmKI7KmA1Nbo5NNLs X-Received: by 2002:a17:902:82c8:b0:1bd:ea49:d004 with SMTP id u8-20020a17090282c800b001bdea49d004mr3100541plz.65.1692215998862; Wed, 16 Aug 2023 12:59:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692215998; cv=none; d=google.com; s=arc-20160816; b=gQenmkjwLCrqhnptwrxx+aYE23v6y8e5XvrPyzriMhpPVj+htCLzbtrAXVFV1BG9TI l6Md+GrPZIpZTf5Rxc3Z3pgcfBRUJ+sLJIBoy4BN76mHj+rZrXy1whsPUF9G8PiG7W9T KsHKq2F10YapzrWkVACnIS8Vr2fVMO1o2XvrRNZ1HagE+q9wKufdgbCM+4p4TMdvBvbo TvJsh3ezirgKHDTHNOtne8PiUSFMyRBBrMYyasQZprXlBLWLVY30+CfhBDFBZo+r0zzV ORB0W+oV1TkiXdAnhhKIFBy7pcZFbzFeSbWK9Itv+iBKxmkBAjhQ3TDQum8r2bssdLw4 rIew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=X11AuKtTvNC2UkBqL4LZFW9s6HCPxq5R6zq+xDkPXv8=; fh=UBrbDth7y5oMgl8brvefl9eZ6RQ3QXA6llOLfOqxpDM=; b=LDyfcrMwSYmmCPBl+2q53GiQHDaIL5w663JTsmEWWyuhAi/Cgab6i+rrYqEaykMQUR fNw6WSHLNH6lLD28ZtvSYSyop/X18Y8x5iEPk8RbwdiYzrhol2P034hBEJ2iAGP4qETi C4DVJoHrxmbEssQLkwKiOTxDqENY0KGCCPBC95koixfOhN0X7r1haQAUrwywvZa1vY2q 1P0bjbt7yZFDwnd0fEfUjM8mAbwkiJ1C+MHfgKdQy8br6Z3gwFC8gpGF6TwsxQPNZWEA cBrDgD+U87a4XTYLc+VUL7HkyjrK3nhSfeBaj6m4SX8Wnu99Ika6GAEIM42m8Z4UHsoK 3iUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k5-20020a170902c40500b001bb162e944dsi12680005plk.51.2023.08.16.12.59.45; Wed, 16 Aug 2023 12:59:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238398AbjHOP5L (ORCPT + 99 others); Tue, 15 Aug 2023 11:57:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238376AbjHOP4f (ORCPT ); Tue, 15 Aug 2023 11:56:35 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CCD74A6; Tue, 15 Aug 2023 08:56:33 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA2F21515; Tue, 15 Aug 2023 08:57:15 -0700 (PDT) Received: from donnerap.arm.com (donnerap.manchester.arm.com [10.32.100.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7B6893F6C4; Tue, 15 Aug 2023 08:56:32 -0700 (PDT) From: Andre Przywara To: Shuah Khan , Nhat Pham , Johannes Weiner Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] selftests: cachestat: test for cachestat availability Date: Tue, 15 Aug 2023 16:56:12 +0100 Message-Id: <20230815155612.2535947-4-andre.przywara@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230815155612.2535947-1-andre.przywara@arm.com> References: <20230815155612.2535947-1-andre.przywara@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774417082825031863 X-GMAIL-MSGID: 1774417082825031863 As cachestat is a new syscall, it won't be available on older kernels, for instance those running on a build machine. In this case, a run reports all tests as "not ok" at the moment. Test for the cachestat syscall availability first, before doing further tests, and bail out early with a TAP SKIP comment. This also uses the opportunity to add the proper TAP headers, and add one check for the syscall error handling (illegal file descriptor). Signed-off-by: Andre Przywara --- .../selftests/cachestat/test_cachestat.c | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c index a5a4ac8dcb76c..77620e7ecf562 100644 --- a/tools/testing/selftests/cachestat/test_cachestat.c +++ b/tools/testing/selftests/cachestat/test_cachestat.c @@ -15,6 +15,8 @@ #include "../kselftest.h" +#define NR_TESTS 8 + static const char * const dev_files[] = { "/dev/zero", "/dev/null", "/dev/urandom", "/proc/version", "/proc" @@ -235,7 +237,25 @@ bool test_cachestat_shmem(void) int main(void) { - int ret = 0; + int ret; + + ksft_print_header(); + + ret = syscall(__NR_cachestat, -1, NULL, NULL, 0); + if (ret == -1 && errno == ENOSYS) { + printf("1..0 # Skipped: cachestat syscall not available\n"); + return KSFT_SKIP; + } + + ksft_set_plan(NR_TESTS); + + if (ret == -1 && errno == EBADF) { + ksft_test_result_pass("bad file descriptor recognized\n"); + ret = 0; + } else { + ksft_test_result_fail("bad file descriptor ignored\n"); + ret = 1; + } for (int i = 0; i < 5; i++) { const char *dev_filename = dev_files[i];