From patchwork Thu Nov 3 00:19:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 14571 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp229612wru; Wed, 2 Nov 2022 17:33:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4TuS7uQcxh2i7Ch6uTRJ6mIIu3XLnxZIiC2cV23HXdRgT1gp/oxdCvTOtzqrJlEQCQ69ho X-Received: by 2002:a17:906:9750:b0:798:9ccc:845d with SMTP id o16-20020a170906975000b007989ccc845dmr26791853ejy.760.1667435580847; Wed, 02 Nov 2022 17:33:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667435580; cv=none; d=google.com; s=arc-20160816; b=lsYS5u7b0LdkHPeZfAk+sVvuW5QPeL+O6ea05aeFhxfG5YW45ZWe44HGhnjNtAYx+P Yw/l5IuXkuNJj7B/oRSfINqWhByoUPOlMKmeKcCyccmpBExFpC7Y1PDz0rXqzb0kOSIS l5oEgcAjukI4LwCiWF7JtgWD8sHSLj7RlzCXL8gmVzIgOVOA1eqiwdTiQvx97kzIGDvC lxyPoFbWrGXcySKWzUpljzDfpMlD3/mVzFBAIl3EjPOqLKeu20YkcEPwR/hs5WpAvoLW DvVOUj1VU+b//zIFxKfa8JbrHJtxxBh/tgZK0w/nfK0IA7jEN2w9h1+kfRN7w78hZ+Ol kDkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=mcmok62mxA5yi48HwvEwfpI0V5bJwILrpr/mqSiiPZQ=; b=vFJyvFsLtFtPWoMTJGXxpuGJrQ2Q1SHyhQTU0KbypPU0JboDmA9gMQxhIsbtevXVQ6 umDE37wOJmpafwoUz5VbJX2XjvtrJYRx0dIvTGN2zx7UQhxyz4J6J3O9QSu/QrUkxVt5 VhsmcNs4dLZAMfAN6hK6vuV8FW+c/LINhUnsIRQ4z12G+szVjz/Bj0RayOlYoZ5EgRyt G0zI4P6A9F6AeC4FFdi3at6J9kx1hL4qLcCue7puq75+B/dVUK07hHKyPHVJWGrld3uj PXlasAdwBNqppJIB3meaRNwOlBdrsh7dsWswVGxQ/zrm+xtoviD+B1lD5IJoco6N/7Mo MvDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=Vh9ZF32y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v19-20020a056402349300b0044f288e02edsi19019531edc.15.2022.11.02.17.32.36; Wed, 02 Nov 2022 17:33:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=Vh9ZF32y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230345AbiKCATf (ORCPT + 99 others); Wed, 2 Nov 2022 20:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiKCATd (ORCPT ); Wed, 2 Nov 2022 20:19:33 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7DA3645C; Wed, 2 Nov 2022 17:19:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 72EAFB8257D; Thu, 3 Nov 2022 00:19:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DC18C433C1; Thu, 3 Nov 2022 00:19:29 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="Vh9ZF32y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1667434767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mcmok62mxA5yi48HwvEwfpI0V5bJwILrpr/mqSiiPZQ=; b=Vh9ZF32yJixV6nU6uXNrd6rjYV/nySWWMzADticRkyBsQ2yV7HgXZ/J+YlWPXXrVBP0qPz hOoVeeHZis1/9sfBsuTIZZqto5LH3qzrTL3VN0BWUH14o6UwQLSDvkt/3J6qf1HfkgMBbG RuOyzMS+gPPASpjRFqARSxUGdIs7zVo= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id b57b712f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 3 Nov 2022 00:19:27 +0000 (UTC) From: "Jason A. Donenfeld" To: linux-staging@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Cc: "Jason A. Donenfeld" , Mauro Carvalho Chehab , Sakari Ailus Subject: [PATCH] staging: media: atomisp: make hive_int8 explictly signed Date: Thu, 3 Nov 2022 01:19:14 +0100 Message-Id: <20221103001914.81849-1-Jason@zx2c4.com> MIME-Version: 1.0 X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748432931225088693?= X-GMAIL-MSGID: =?utf-8?q?1748432931225088693?= The current definition of hive_int8 is a naked char, without any sign specifier. This is incorrect on platforms such as arm, where char is unsigned. Fortunately nothing in the kernel actually uses a hive_int8 type, but in case it gets used later rather than removed, this makes it explicitly signed. Cc: Mauro Carvalho Chehab Cc: Sakari Ailus Cc: Greg Kroah-Hartman Signed-off-by: Jason A. Donenfeld --- Greg - if you're going to take this for 6.1, that's fine with me. Otherwise, if it's for 6.2, I'll take this in my unsigned-char tree to keep all of these fixups together. -Jason drivers/staging/media/atomisp/pci/hive_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/hive_types.h b/drivers/staging/media/atomisp/pci/hive_types.h index 4b8a679fb672..55d36931f079 100644 --- a/drivers/staging/media/atomisp/pci/hive_types.h +++ b/drivers/staging/media/atomisp/pci/hive_types.h @@ -42,7 +42,7 @@ typedef unsigned int hive_bool; #define hive_false 0 #define hive_true 1 -typedef char hive_int8; +typedef signed char hive_int8; typedef short hive_int16; typedef int hive_int32; typedef long long hive_int64;