From patchwork Sat Aug 12 09:39:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Jinchao X-Patchwork-Id: 134852 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp1624787vqi; Sat, 12 Aug 2023 03:05:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGtbJAf0edFoczMAQ4G11SdOffgMK6DKieNlaQ/zPOQ8hzFY6yja5tmVZdsNvMTLTd9IB5m X-Received: by 2002:a05:6808:1294:b0:3a7:62ad:af39 with SMTP id a20-20020a056808129400b003a762adaf39mr7054746oiw.13.1691834705166; Sat, 12 Aug 2023 03:05:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691834705; cv=none; d=google.com; s=arc-20160816; b=wvUHd5cqWP1jnDl72DYk+6EazIxlQJn9guEOGQJq0TEoIvq49quFWs1vzsgGPIK1zP UopHBaIS64PNTBieS0xLg7WqtJPmyyCtahG97sch9h3pI1vKow9mvDdK13wn3dOWUmVj cX7686elAboLY1mFOhf5lH/QoLzyq1i0/UUKo1h5aDXpHzVZebhVEL/NKhyfJiG0ouSw 2Fgd25kPU3o1miHbpNNOHmrJOnAdl3DlOvBoK6+NfMEzYfwlagliUahTQhBay9p7GOSE 8fwj8kX+4BsAGzZd4nnJv+MWKVaiI+V5BLkHVebZW+xiEj9b5RXEdHbcIlEfdJggiO6i xqTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date; bh=EoEu7bqPUd8GwNlv2HpLv7L9vdyP8VDzJNE+PltpyGY=; fh=iuwT94R13If9sZD/to3WpolmtC1Am+Tgjz/seXR2AGM=; b=quM1kZV4AcLc9OKAKXttTMQOSJOSikMJ2kmp96bwjn90oAN6ytC7pKMAnPOYrdVMQb Y7Veexv66aC0gnTwY8lmwRwRHNEf3POKKT6vMMF7/PTlGt1YccD10CM1wvWdzQTsiPcO 0PF+ppGN4oJqJKD0fAXDStWhFuJp3SEA7zeUA+HyFGf8LEhNhi+CYrlzULRbJeAyk5XV ZlSF9wVcXacvkSNi4mESd36wPZu9tUHsrRX4nySSctMVn0Fyu3lNJ4QqnhrSGS2xnMgr M6fZAfywwB47A3KhzAyg0KwLovmibK0mYtLVW2uhe5eDm56IKZyYAkMbV0+QPJ+Y6iUX g6Mw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k7-20020a63d107000000b0053eee173733si4839345pgg.227.2023.08.12.03.04.52; Sat, 12 Aug 2023 03:05:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236564AbjHLJjm (ORCPT + 99 others); Sat, 12 Aug 2023 05:39:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231649AbjHLJjl (ORCPT ); Sat, 12 Aug 2023 05:39:41 -0400 Received: from wxsgout04.xfusion.com (wxsgout03.xfusion.com [36.139.52.80]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3117226A0 for ; Sat, 12 Aug 2023 02:39:41 -0700 (PDT) Received: from wuxshcsitd00600.xfusion.com (unknown [10.32.133.213]) by wxsgout04.xfusion.com (SkyGuard) with ESMTPS id 4RNFvq0Jvrz9xrdT; Sat, 12 Aug 2023 17:38:15 +0800 (CST) Received: from fedora (10.82.147.3) by wuxshcsitd00600.xfusion.com (10.32.133.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sat, 12 Aug 2023 17:39:28 +0800 Date: Sat, 12 Aug 2023 17:39:27 +0800 From: Wang Jinchao To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , , , Subject: [PATCH v2] drm/i915: Fix Kconfig error for CONFIG_DRM_I915 Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Originating-IP: [10.82.147.3] X-ClientProxiedBy: wuxshcsitd00603.xfusion.com (10.32.134.231) To wuxshcsitd00600.xfusion.com (10.32.133.213) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774017268003517157 X-GMAIL-MSGID: 1774017268003517157 When CONFIG_DRM_I915 is set to 'y' and CONFIG_BACKLIGHT_CLASS_DEVICE is set to 'm', we encountered an ld.lld error during the build process: ld.lld: error: undefined symbol: backlight_device_get_by_name >>> referenced by intel_backlight.c:955 >>> vmlinux.o:(intel_backlight_device_register) ld.lld: error: undefined symbol: backlight_device_register >>> referenced by intel_backlight.c:971 >>> vmlinux.o:(intel_backlight_device_register) ld.lld: error: undefined symbol: backlight_device_unregister >>> referenced by intel_backlight.c:999 >>> vmlinux.o:(intel_backlight_device_unregister) This issue occurred because intel_backlight_device_register and intel_backlight_device_unregister were enclosed within \#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) and #endif directives. However, according to Kconfig, CONFIG_DRM_I915 will select BACKLIGHT_CLASS_DEVICE only if ACPI is enabled. This led to an error, which can be resolved by removing the conditional statements related to ACPI. v2: Add a line starting with # Signed-off-by: Wang Jinchao --- drivers/gpu/drm/i915/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 01b5a8272a27..5003de921bf7 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -24,7 +24,7 @@ config DRM_I915 select IRQ_WORK # i915 depends on ACPI_VIDEO when ACPI is enabled # but for select to work, need to select ACPI_VIDEO's dependencies, ick - select BACKLIGHT_CLASS_DEVICE if ACPI + select BACKLIGHT_CLASS_DEVICE select INPUT if ACPI select X86_PLATFORM_DEVICES if ACPI select ACPI_WMI if ACPI