From patchwork Fri Aug 11 13:06:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 134565 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp1184743vqi; Fri, 11 Aug 2023 08:47:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGOsYNTHqS4FdLxsC6JWxSSdJmrfxYD6cJJR3ztafzzH4/Lvme1C6513uDIlM8ZabTT9IWu X-Received: by 2002:a2e:3806:0:b0:2b9:ef0a:7d4a with SMTP id f6-20020a2e3806000000b002b9ef0a7d4amr1777071lja.36.1691768851059; Fri, 11 Aug 2023 08:47:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691768851; cv=none; d=google.com; s=arc-20160816; b=xued+sldEbOQsItc3dlG7UJx8ndg3KIr1ZyApixM1CSenc7nnHnwcmIihTKz9Ogpxy tgqiQw0L7TP0tBZ4+NAuzyZMJOUoM1uQIjEerRadtdjVab/4iMt0eB9EzYKuw/usKb4i WxfKlrCNGD3zddEjfcPOZXPZDr667wBzkheF9RvLFbMfCjR8kdMzufVW8NH/CfS+iKhw +h105FvkZxGgQHYmRHFagHVbRSvWQrvuHAeUh7BLQYwsQDR1mSDj8JbJ26ssK6eIFYb1 YE7wqDeupOTOSLJgu3+pK9x2a5CzUUZ4GfnKI1CV2sqo3Sz+TIcUs3t3VK82W+08dkvV 2IRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=0An2e1abhdIFPUIRrageueiL8VrU4x/yiS800RQ/7AE=; fh=Cjix6MpusCdBkqrMYJTjkRkPCo3lC7oMGzpHnB8od8U=; b=d9Hav/eKy53RsdXZLXyGTxBobJNtS3QuYyij1y8RCDWkBjllgkSxX2yDU8qcIgMDst ASR3k5HWaf9dnCkXbcVoB31OMbDJAXJEwotaRBUQh/QFxquBQyqo8moKk9W3i5gvFk9Q VNrGPyLNqYvq+SXKkLSKHYPk1TinzlYBf7DeWpqV8Wbr+yINTq8HdgUO1jJugsTUojq5 tAyhgPmqAEr5dJTFDU3qw6eShFF7hefINBroYTHwBip0HwnsXQIpJajIVyednmK6hvUZ nv/8lNJVBYIuM/Knmm9u2NN46fTDTolkmpccvCocRGW+ik6D2548/8jRV+wjkBnosMYG FIdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=m8YQ5hgh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h14-20020a170906854e00b00992ae2a902dsi3542040ejy.786.2023.08.11.08.47.05; Fri, 11 Aug 2023 08:47:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=m8YQ5hgh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233612AbjHKNIK (ORCPT + 99 others); Fri, 11 Aug 2023 09:08:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236088AbjHKNHr (ORCPT ); Fri, 11 Aug 2023 09:07:47 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75D8F3582; Fri, 11 Aug 2023 06:07:22 -0700 (PDT) Received: from eugen-station.. (unknown [82.76.24.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madras.collabora.co.uk (Postfix) with ESMTPSA id F38F0660724A; Fri, 11 Aug 2023 14:07:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1691759238; bh=VXusoYfjHaf1R8Q5raJ4gZK4qcwaz24tSqOkD12Aa0A=; h=From:To:Cc:Subject:Date:From; b=m8YQ5hghF7NJPiDxoc0eVVVZW0KT3+2lKdL7KpjLs3T6BxQzGVqflAELP09jpQOva HlTaaoipnyBpu/3hJSrIVt4UDpTzRWTR4qmJhHq9X8Azx4jDM7yZizsCCk3H3t1Fhb ceQ30FZ58AU7DW3MyV5yuuYLrnAwLkSwn2zYf4C/fRHCrPtY36/oyHHugo0IlG4sE1 l/DJM/FmWQsaF94awvFv8xWprPaUGPYDcV0QQPw7J3kx0HwW0xFh6B8SDTexcgr11o 1DPHnpoDWquQy189H7EWvcmQUQPP3Hib3n7MMGjmeJ0749lDj6aXjNAfQkb7dzxTCV D4KR5yNet74cA== From: Eugen Hristev To: linux-mediatek@lists.infradead.org Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, conor+dt@kernel.org, kernel@collabora.com, Eugen Hristev Subject: [PATCH 1/2] dt-bindings: phy: mediatek,tphy: allow simple nodename pattern Date: Fri, 11 Aug 2023 16:06:59 +0300 Message-Id: <20230811130700.72787-1-eugen.hristev@collabora.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773948214857259047 X-GMAIL-MSGID: 1773948214857259047 The pattern for the nodename only allows t-phy@... , however, for the case when the t-phy has no `reg` and only `ranges` (basically when the t-phy is just a parent node), dtc will throw this warning: Warning (unit_address_vs_reg): /t-phy@1a243000: node has a unit name, but no reg or ranges property For a node like this: sata_phy: t-phy@1a243000 { ranges; sata_port: sata-phy@1a243000 { reg = <0 0x1a243000 0 0x0100>; }; }; it is normal that the parent node 't-phy' would be without any address, as in: sata_phy: t-phy { ranges; sata_port: sata-phy@1a243000 { reg = <0 0x1a243000 0 0x0100>; }; }; because being just a holder it does not have its own reg. However the binding does not allow such a name for the t-phy, so with this patch, making the `@[0-9a-f]+` part optional, such node is possible. Signed-off-by: Eugen Hristev --- Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml index 230a17f24966..2bb91542e984 100644 --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml @@ -64,7 +64,7 @@ description: | properties: $nodename: - pattern: "^t-phy@[0-9a-f]+$" + pattern: "^t-phy(@[0-9a-f]+)?$" compatible: oneOf: From patchwork Fri Aug 11 13:07:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 134546 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp1155223vqi; Fri, 11 Aug 2023 08:00:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEK8b+mf6iFWXwaBR3hYbdvQucHOvejb3KOmfDgxGHj9kUTiRgFQRtBY4TZZmIwGLj5a/Jw X-Received: by 2002:a17:902:c409:b0:1bd:b8c0:b57e with SMTP id k9-20020a170902c40900b001bdb8c0b57emr2093254plk.40.1691766035659; Fri, 11 Aug 2023 08:00:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691766035; cv=none; d=google.com; s=arc-20160816; b=MiuE9FOU0RW+5F7Ii0ucuGOR0Ay+EgkuNB34n8+QPjTPp/1hjTReL0QbGeIT35dr1j GBp6TlAbyyZd48ZysSwpC+5Zej2CzPhImgg5qZJHyufbhwiOuXvU7hvkyc/gctbtLB1T nDNPIv8R6LZkq9KxwVC3/4POXJbosECTWPAahLXweJQu4Ifig6CowB05ZOAYS5TmbGKJ GvasGbhTkDYTq8nhcejGxTXu70pVhiq5VjNnrdlyMioiiQ7/iictR1ihuiaZPN/E4qyV vif+hGdP3SGjkgKgHce7L/sFODlDJc09CN4L6PETHn0BRHwjrP5uIQWd7BP0PPc4ungh k/bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q1udk02jJf9ZFY6uF0638D/SCO6WNo6qeMTtQHkgqII=; fh=Cjix6MpusCdBkqrMYJTjkRkPCo3lC7oMGzpHnB8od8U=; b=mCF2AZHZSHdrNe3julnxXk9c+/4WqA1fl413W4IZtxvbpldY3DHIjFyGGwNmdo6k9b HxUuLgfbTwjkjsLCbGfHC5tm0k0WLheoMTdtgiMS88qyZQC236YVTN/YYc1MClPDThfk xlfwuzhKuV1Zv1z2Gy/X3ZLjBVNYhkWozHdocRHAhVk14hQBjK9wg87DtMICixmlyhoU 63zpXVE4AeEjA78g3rcIMv9IydS2E+1usoAQF9krL3BPzkGTe4VMuE78bbe1fn0nvU2X /PRDRTPpaxh70KrQ9L0PgkhPH6hQ8mrhETkC5/SfLCWusbh1rYq8ZFa2IQrKkbhOemMI yPXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kwwtPxd7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jy5-20020a17090342c500b001b81a9aa3d1si3310964plb.223.2023.08.11.08.00.14; Fri, 11 Aug 2023 08:00:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kwwtPxd7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236088AbjHKNIN (ORCPT + 99 others); Fri, 11 Aug 2023 09:08:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236102AbjHKNHs (ORCPT ); Fri, 11 Aug 2023 09:07:48 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75E383584; Fri, 11 Aug 2023 06:07:22 -0700 (PDT) Received: from eugen-station.. (unknown [82.76.24.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4773C660724B; Fri, 11 Aug 2023 14:07:18 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1691759239; bh=pYvofDw9e9+ITQ5T6M5o9bCA2xeJ+ybOXWp8n4SlWjs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kwwtPxd7+qLK4lsEr8RxlqIsd4QXW6rnr0W23fwIHV7RgNE1enjAjPa0uVVn/u5t/ iEzEryq+ZdS80f/J2n6ljCuJRi7Yvl5xQbdhElRA1zz4arhRWw9T3CU4URAViUO3XZ iFVFg8vKD78RIwNoVuT9RzEWOmNH9JFD+7oMOSwyRJZEYt0MU8hGHCTPnnQnRQ05jt 8LciYz1ow66Yo3q6DBOQT/bOAFg8EyMtIWPLrHKOH2zDgUc7vvDvzzFn/3AW+yh/7e WIEZbAuDUMMec+1APblaTsIKnCWpHfJYahJE8cMzNyq52EHHurhCVSYsQlTxqjB4Mj 4qnfQTjY88rug== From: Eugen Hristev To: linux-mediatek@lists.infradead.org Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, conor+dt@kernel.org, kernel@collabora.com, Eugen Hristev Subject: [PATCH 2/2] arm64: dts: mediatek: fix t-phy unit name Date: Fri, 11 Aug 2023 16:07:00 +0300 Message-Id: <20230811130700.72787-2-eugen.hristev@collabora.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230811130700.72787-1-eugen.hristev@collabora.com> References: <20230811130700.72787-1-eugen.hristev@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773941342649360597 X-GMAIL-MSGID: 1773945262892015483 Fix: Warning (unit_address_vs_reg): /t-phy@1a243000: node has a unit name, but no reg or ranges property Warning (unit_address_vs_reg): /soc/t-phy@11c00000: node has a unit name, but no reg or ranges property The ranges is empty thus removing the `@1a243000`, `@11c00000` from the node name. Signed-off-by: Eugen Hristev --- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +- arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi index 36ef2dbe8add..3ee9266fa8e9 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi @@ -905,7 +905,7 @@ sata: sata@1a200000 { status = "disabled"; }; - sata_phy: t-phy@1a243000 { + sata_phy: t-phy { compatible = "mediatek,mt7622-tphy", "mediatek,generic-tphy-v1"; #address-cells = <2>; diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi index 68539ea788df..24eda00e320d 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi @@ -434,7 +434,7 @@ pcie_intc: interrupt-controller { }; }; - pcie_phy: t-phy@11c00000 { + pcie_phy: t-phy { compatible = "mediatek,mt7986-tphy", "mediatek,generic-tphy-v2"; #address-cells = <2>;