From patchwork Fri Aug 11 08:07:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 134354 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp929413vqi; Fri, 11 Aug 2023 01:08:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHUIFeFyC4M0oIy7FtFRbMLT7ivW7kyLv9vYWZwivrmjhkViWRrgFO7GBlu2qYuK3PQZJ1b X-Received: by 2002:a17:906:105c:b0:994:542c:8718 with SMTP id j28-20020a170906105c00b00994542c8718mr1210941ejj.76.1691741296717; Fri, 11 Aug 2023 01:08:16 -0700 (PDT) Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id h9-20020a170906854900b009932528281asi3112675ejy.579.2023.08.11.01.08.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 01:08:16 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=MyIUAnn0; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EE8CF3858C5E for ; Fri, 11 Aug 2023 08:08:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE8CF3858C5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691741295; bh=9cBOAHAvjoT2FJ6F9w3DrJzBVvPIvL0cQgNGBuQqQxk=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=MyIUAnn0HWQHAGNhTB9Vy4R0S1a4jNphFnayrDbud6xgr1Ye5nxYyAU21mi0tyM2N TBrXSc54OAj2pfK20OcxEy/AfX23S9RtsOrxeG2aR3e7L6ozhVHURDa5rbzcJhHVsh ulJ96V/DsttBWuvKj8Ik6iOARMCxJLbnNHfeXx4o= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2075.outbound.protection.outlook.com [40.107.7.75]) by sourceware.org (Postfix) with ESMTPS id 25CCC3858415 for ; Fri, 11 Aug 2023 08:07:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25CCC3858415 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UhREfK7XufARnk+3+DE9ix6oiJYY9A48Y4YivB6YJBlDrqbj/NjGqxvCHnlViXFW6hzi/sWuEsLzOCupP0xj0zZ+4Wuosu8Xb9awhLaMLf+18wMwaUWdqdCUKNYzCu12DFhkYqVEE6bxz4YjNlVB8NRRSE5XYmMx7DborVK1mKQslji/vLods6nqpeJukzyrVBnhc0ZWwRgeeMtY/WHLVgUPv2iJa+o2v+6jPZYjxEWLYpGnW5qUdkc+kdt+kPwUqd/ccNcAxWq1YpgsP47gRcw6klkVa1yV3uLkhno00Sg2Nc4WFUnS0OH9vXIeXxOeM69jrkTeEXT8cUvkSaVACQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9cBOAHAvjoT2FJ6F9w3DrJzBVvPIvL0cQgNGBuQqQxk=; b=eHE/KT7TE5JsfF++OelLFUPiRFl0Qxyi78MnYfrisK5GK4M3OF3rSmrKaxhqsQH+VcIKVd1nEv681LX56Zlwb9yOrEQu5tcWJg4WB24lYNuwdr07O9OUZK9x2aaAGwfL7WOfNmpRdSYLSYhDzbtzjgf9i7X7Uvj0eeS8AtKnNzSN6ytcbwEB5EBI99cqn2uJ/1uPsReQLK/5GmlFX9U43gu4nxRg8cwSjtgPKqdqmLYQhYhZjjiw2htn1xZe7nWcQjXl7bRUT+DPL+QxqoKLJRL/2KksQIA/tzjPgYsvaD+chuSxB+eYg9HQ4YqZnE4kOajDl12/KaVLC9hKKAx7rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7648.eurprd04.prod.outlook.com (2603:10a6:102:e4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Fri, 11 Aug 2023 08:07:52 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Fri, 11 Aug 2023 08:07:52 +0000 Message-ID: <3d540eef-9167-1559-9414-111e6c23498d@suse.com> Date: Fri, 11 Aug 2023 10:07:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: Binutils Subject: [PATCH] gas: make S_IS_LOCAL() and S_IS_EXTERNAL() exclusive of one another X-ClientProxiedBy: FR3P281CA0143.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7648:EE_ X-MS-Office365-Filtering-Correlation-Id: e16ee9dd-06fb-43c1-4219-08db9a420f6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nad1ToQ1/JIn1oUwOa6nQSmiM75JRB2LecQ7vSo9OCZYz+vZQs0Yi6lNJF0N9FWUL1S6YosbDWCAncNJZNVI/v/v1RapQu59SBfzp7Qog9aed3iCMAAMjXrZaSymf0BtqUVj/SJk/zINllJqakz4Ono1bZAyGEgSiQulsN+k15EV6q/+RWSVbmMgZASRh2XG6TFhzbqYMFNznRzcU3NwD8zUVbYvMQwIrqcA8Qc2oqwEXTHF+lGQqhdVIYiZGRvKKLcETuNEBLPkPkOFz2P2dqE00ab4+KBTyQ2V2RxuHfK/TlNPhi/vutrRILpqfhpweLtzHqx00ZKQ4aqCQBsRRalmIGLosTF0A91mBL/GRB06sxj8EU/D+Wzu+i8wXoeV/VIdq7N253FTaphUjA/LLscMMo9NgpGjFofUR49XU/DH89jqgZlFTZF/01eFFQ7AgQekYQQzSgQCzm4jdkiwbt6Dv04FEvNCDeZ1f9fQzjCLqG3KRef038gRQdSdPid2nUTqWxBTPz1x3u0Cekkm6LKSOz3WFPIVRPN6Ml8gLie78Gr9c9M6s4BEAAFDGwB72n0evh2QDx3FZT2ZhI5zfd6fcKQZTtfhMy0PXga/WgWVpFWsDXU+0Eed+PDkPkCDG4dZho+TlMIJyy+V2sIh3w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(136003)(39860400002)(396003)(376002)(346002)(1800799006)(451199021)(186006)(31686004)(316002)(41300700001)(4744005)(2616005)(31696002)(86362001)(2906002)(5660300002)(8936002)(8676002)(6506007)(26005)(83380400001)(6512007)(66556008)(6486002)(66946007)(478600001)(6916009)(36756003)(38100700002)(66476007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ydOqAIQ4Sq5TkVJknv/Lt/4nJoYB?= =?utf-8?q?mCZAVw1E7vyR+CFCEvsoFDDJTCYH1qdnTgk5AkDS1hCguwizcEZlaOtOMG8a/Ypkq?= =?utf-8?q?OW5YQE76H9MYHeu1oQJSV/B8cIvvRwvLUh5CUgdj4HiXdi1n53sZsubjWvNHP6osc?= =?utf-8?q?YBQuqYKNfSSgWS2iyF0DE4f82BNFYFUykA/5JEoSYn1KBlPUVTmA1X5ZMfz3Y/tDL?= =?utf-8?q?8GGrp9A0gnqNT9UIs/uuK6yjCCtybFCw8wyj7wnFLdfRyARerMoiJcubAtNpBjP/y?= =?utf-8?q?Oo0MTQHlpRU/jnWXi9pwU+gVN/8Q7cUAl8YSuJEQY4ofnhJX3VaQXvZ4QDe6139tS?= =?utf-8?q?6qqI6NYeONk1rxt3gSfeWxsMzm6XVFU2QPLwzxEXQYyil5YqhPXeHVdQbHZ/wjt5l?= =?utf-8?q?4SKaE+c389Pnj/4x4oCY7T/ka/ZbBAorf4d41+ZYFO50f0NT2MAFB4/Xy1Eze5MH3?= =?utf-8?q?GYU0GgKfEUgKeyyKAEnWqocAXDkJ7SLeTBZoyZCPlh9W/TQTP+lBewNKYMlcMm8Cs?= =?utf-8?q?031nuA0pTLs3Uxgdt55Zhk1IjMHLdg49qMJH2TsLdEUkbANv/2zJN34UW3J1uVYyh?= =?utf-8?q?qqCrJEILLsfzUrjJCsbRnzw6C3XzL7oqxCek0APu2N7snMjjOeX0+/yHqG2PLp6Xe?= =?utf-8?q?OYYCikeTBxs+6GIiCFxuiwPossG6BAxHMbuUK0vroHpxGrRsDLAa3/jvN5w8VYQ+y?= =?utf-8?q?mq0nEK5esaev35uWG6TieFuLHdqTWgumAvR2V0inFRUYQB/xzGjD/UFeNlk2HlAsS?= =?utf-8?q?XRVQUS6G+M2InMAWmAOlseMlw5G6XO5coiwXgVzk7/otfO1BaOlw/bGoV/+9VEjpd?= =?utf-8?q?sBh0w52slYr7S6i8lZKGFw7YWEQuMXQuH/Ah6ebHOFmu2jv3C376G1T0VUkhDR/+9?= =?utf-8?q?PZ7Co8k6IeSzRugs52aj63CO6B5BVh3g7vpAivBnQA6CaM3NDWKOSsoqjOmzfXzAW?= =?utf-8?q?GHT3XjgW7iD686KFnHVbMiE5MRR6vCO4b1RRAlD1NTLJwcE01uIJLkevR88Hf1aZD?= =?utf-8?q?oLT+75L5Pezh4GoNooZju2aDFVdfPOUvvV/QxuMQXn9uoYVtIOyHIUdlEfNaS8QF6?= =?utf-8?q?is+EtaErxFM3AxjlgHhbw/ScE/9J13GkjL1uZ2Evmr0efYO46L+IV6IYq+DvKUsOm?= =?utf-8?q?lFHaVSa9wpIKmu+KPkf0PTI1NEAwNjTLVMeN8ggPv5mrwpJHAFCnZBjpll9SBiJff?= =?utf-8?q?A/2NjInp4iZY0gos7rApW+2dNdf7yDGSNBbkWFItWsWPMI5uwgnqAf0+LSu2h1vR8?= =?utf-8?q?EJ2tq5K94b5ssZZ8ivNsG/7lekKhTZEU8ePFcrO9oeO58/J4ql2rdYomxHRyCypFJ?= =?utf-8?q?vOqV+EYl8dCzoQgHk6kXPet+cCa5b8Z7iKh7m6gdyiisvA8bfRN51ESR758y25eil?= =?utf-8?q?1ymUL7fdYAnVisd2sE+ENxcEvIK4KlJE8pj+m6rmrX3U4ky9gWEe5KpE7vGXYum57?= =?utf-8?q?GUWfbn3Iu3i/F8v7CdVwdVyhnC7tSm+RrymxO9IKSEZC6gNNz767lUDIr2YNknzWq?= =?utf-8?q?oHNJBXujHiHg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e16ee9dd-06fb-43c1-4219-08db9a420f6b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2023 08:07:52.2196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: soXQ0xydChp0nWAawl2V8vNXHMoEkI1O4DoJloBmA5OqqkkrGcAH2W96INYHJX5Aod5gK1NYNf3RLsVJa/b58Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7648 X-Spam-Status: No, score=-3027.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773919322163477705 X-GMAIL-MSGID: 1773919322163477705 While they aren't opposites of each other, there also shouldn't be any symbol for which both return true; both may return false. Therefore use S_IS_EXTERNAL() in S_IS_LOCAL(), thus subsuming the sanity check which so far both did alike. --- a/gas/symbols.c +++ b/gas/symbols.c @@ -2420,15 +2420,14 @@ S_IS_LOCAL (symbolS *s) if (s->flags.local_symbol) return 1; - flags = s->bsym->flags; - - /* Sanity check. */ - if ((flags & BSF_LOCAL) && (flags & BSF_GLOBAL)) - abort (); + if (S_IS_EXTERNAL (s)) + return 0; if (bfd_asymbol_section (s->bsym) == reg_section) return 1; + flags = s->bsym->flags; + if (flag_strip_local_absolute /* Keep BSF_FILE symbols in order to allow debuggers to identify the source file even when the object file is stripped. */