From patchwork Thu Aug 10 12:25:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 133986 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp409022vqi; Thu, 10 Aug 2023 06:09:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFH2CvMcAZfV8or2WOkAgU6r+my+ARARWvI0QddiBj6im//ryERuNpVCZ01r7Fap+B6Hagz X-Received: by 2002:a05:6a00:cc1:b0:682:37be:c9fe with SMTP id b1-20020a056a000cc100b0068237bec9femr3301285pfv.10.1691672992593; Thu, 10 Aug 2023 06:09:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691672992; cv=none; d=google.com; s=arc-20160816; b=IWl/X/J9bo4lmij1uFOBF2CpTIfCQPpSgoyscBSJqmiJSoSHTBdsfmoo4hilOk3ang 5MmdRY785r3WvnD9uP6m25f6tSU8KXo3fyxY1/qOSlSU3/EdC02ypPLuMPGbzDjnMC4m IVwyyyNs+SUkd0QOCTxdAg5xvvP1WIO58D5LgvrGRoz0+zxOlV/z4pOF4+3FFVPeETtw FlHkCSU59fU0GbtXcGVCIO4wpgOZi35ott9XDOMxvHsmE0Z9rurQT52Hr7oIvdjqFiGF fKBCj/3Ol/9q+rDCV0Ar3tDB4hP0nM3iAhAScQ6oKjixSIm5dV510BezpPuj6j2FQHDF /U9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=tGHLahA8TlYBy7zz8/mf3T9pHpbyYP05WLJPtAuuQOA=; fh=bFiconCAXkrW0fZVE558isz0sKjGAHVODTTSsgDfnkM=; b=kJWebYscQRVwCV67Q+1nOXkaecnoyASzRS1nzOfEgtr6kS1kYRbsz1fQYd7fM68SQX qbYGjYp0jl9VqAPR90JDAb0Ks4lcuG2ePe4R6An0X0Oqpk9DO4fcrBroY927GS7s6vaK gyG8Q3HLJ46FpPIJ8dgvwthiu3GTJZmelpFYRozS8O92WQpPur9GwjQrL9M+ticNgxca nyAou0vVqYcUaTbvz1xtTGRCUnpBxtbr3PiLXvCeFXiI6hq0wj8dcHcQi2O2mh4CI+AS BHPaV+7qUsV1uHS7xEWURRRn97WrXUuOISDJajn8Dx4a+da7/9i2n5RyYCya0/VISg13 kD9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AerNdbBB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t37-20020a056a0013a500b0066d45f035a5si1525428pfg.320.2023.08.10.06.09.33; Thu, 10 Aug 2023 06:09:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AerNdbBB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234904AbjHJMZh (ORCPT + 99 others); Thu, 10 Aug 2023 08:25:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230240AbjHJMZg (ORCPT ); Thu, 10 Aug 2023 08:25:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CC1EE54 for ; Thu, 10 Aug 2023 05:25:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 32CB7615F6 for ; Thu, 10 Aug 2023 12:25:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E78B0C433C8; Thu, 10 Aug 2023 12:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691670334; bh=1f1uo4HhIlgH6LQc+YKtqnOOYeuciSTPT0zrCjcnXio=; h=From:To:Cc:Subject:Date:From; b=AerNdbBBddvE2On+cYp4dMdrRdmJXjHtrNolxFfAV6vrZ2QzZ1qT0twkSqjmM23yC K5fy8gieyWVpD5iQoxXB0jSUKvbzzKe9BORAnv0WHXgirr0mUJKYdAeEkBbkEw2WhR 27HVE3jF6a/HaNxFGrLK5dR6KsuhFT/ecpVn2QgZTW9fCLPO7DCRTggzjdq9fBTR48 BzvpjUAJ5KcEs5Gmgyc1Z9Kn3Yy05orERx1bhHepK0A18Jo3rXnoMVktfxTLjNCFjr ZhSdNpD3GJBtyvtMtgL2G5/ffwXQso5G+mFSH92Rcw5LObLD7JEvwFrfHQPjzR8WNO 3h4ggjR0pZfaQ== From: Arnd Bergmann To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Arnd Bergmann , Geoff Levand , Petr Machata , Piotr Raczynski , Wolfram Sang , Liang He , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] ethernet: ldmvsw: mark ldmvsw_open() static Date: Thu, 10 Aug 2023 14:25:15 +0200 Message-Id: <20230810122528.1220434-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773847700047803578 X-GMAIL-MSGID: 1773847700047803578 From: Arnd Bergmann The function is exported for no reason and should just be static: drivers/net/ethernet/sun/ldmvsw.c:127:5: error: no previous prototype for 'ldmvsw_open' [-Werror=missing-prototypes] Signed-off-by: Arnd Bergmann Reviewed-by: Simon Horman Tested-by: Simon Horman # build-tested --- drivers/net/ethernet/sun/ldmvsw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c index 734a817d3c945..a9a6670b5ff1f 100644 --- a/drivers/net/ethernet/sun/ldmvsw.c +++ b/drivers/net/ethernet/sun/ldmvsw.c @@ -124,7 +124,7 @@ static void vsw_set_rx_mode(struct net_device *dev) return sunvnet_set_rx_mode_common(dev, port->vp); } -int ldmvsw_open(struct net_device *dev) +static int ldmvsw_open(struct net_device *dev) { struct vnet_port *port = netdev_priv(dev); struct vio_driver_state *vio = &port->vio; @@ -136,7 +136,6 @@ int ldmvsw_open(struct net_device *dev) return 0; } -EXPORT_SYMBOL_GPL(ldmvsw_open); #ifdef CONFIG_NET_POLL_CONTROLLER static void vsw_poll_controller(struct net_device *dev) From patchwork Thu Aug 10 12:25:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 133980 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp401839vqi; Thu, 10 Aug 2023 06:01:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYsS3bIhQ+6GNHXa5S/bEg6MkWiJOt9BkiPpYpFclq9JXeF4KK2qGMldEIzNCzqkKfLaN6 X-Received: by 2002:a17:907:1dd6:b0:99c:75f7:19c1 with SMTP id og22-20020a1709071dd600b0099c75f719c1mr1949671ejc.39.1691672483507; Thu, 10 Aug 2023 06:01:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691672483; cv=none; d=google.com; s=arc-20160816; b=yrKQD0EuaPXxCB9MSYD5Edj3lQTKnsG9LzbpsK1x1wHjkfslo7wUKSeOsnT2vIbGca dzHWxg+kFNgUrQA/jLyaeeeIBbYI8rIL3mCwGJDRbOoC+nTfxVm7x/nOaAs+215+4zIF hEsTQ54201rgNt2AAohDwtRA9+fSxOdnW3ZHSZDO0himUdstgQqKZUXwxtnP9d1b95sg anHSEhaN3i+1+MsO5tMDmfGF/0iSsdfrcDvyxgiKlzdBzGwYr3WLokJz7FYm1Q6Sn6Uz FZ6m9BqASpVvIi3c0N8Pk47+znunJLgZdeood9/ndsk6DeA5nh/jaNoqChDnzBkmD/EQ XTyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=aB2S0os31v4qU/SxGD0Mf+BuWdL0UDsluqSIj9waDH8=; fh=VHMJWWYSNcrRitOITgPdJA+vzqOzyWtogoaaX1/rWeE=; b=iNyeSH3nqNNdNq6ORHY7QgpWE+ccGP5LhBlyqCUAW3kuP24oC8DCjffVM/B8pWNShN k9ROwpEEUMndG5TOoTG7A/uETychZG4pe7eNZZepQu/dh1INduEDBUQOL6JmerXCyOZA FiA3cAGzsWyxPAeDBhMP/kZ27sUiUix3kxHUMtnxZuX1XLSLpEtx5pWgcnbC6t0/4dmE 5ZjJ65iIDkTgKksQiu7Er7PBulg9FjCLMTDd9p87oJkX5o33BNN78Y9aM9aJdwqn38IV tmHbvKd85NIrpWgWl0aKASQX40qcFRQKaiFii5ER7d2w9DD4YDoqwDZL49ZMmqOo943D hl/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UCUG+UaK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ks13-20020a170906f84d00b00992b75d594csi1441734ejb.317.2023.08.10.06.00.42; Thu, 10 Aug 2023 06:01:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UCUG+UaK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231774AbjHJMZp (ORCPT + 99 others); Thu, 10 Aug 2023 08:25:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235045AbjHJMZo (ORCPT ); Thu, 10 Aug 2023 08:25:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72EC02136 for ; Thu, 10 Aug 2023 05:25:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 07A8065161 for ; Thu, 10 Aug 2023 12:25:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40B8FC433C7; Thu, 10 Aug 2023 12:25:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691670342; bh=OloAD6QmGKnXstqvq00Y+1wIzRiY4JGxfjab4MiA+Yo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UCUG+UaKbFVMZ9rgnD2AroLE1C9PsQ8Q1mvArgMkR/ncOGxxpBmvZ2n55P2acCo+v rBlTdyWGsxBjjTwfPMv7TdJpnM9bqYSBI6I19btGwMDjXaNy6gzwdC3HMhPb2hB3Uh 3TRtdzVVIwWLO+6cz8EJRN95g8zzhn5A4ckz1abhvlZjSS6N725Xo9dch1PNvke7v2 rJwNyEPg/+fdgzCVxyNi9f7xkqaNvDo3Cz8Xrgr0GGCXssSaIjdnDm0fVm215fSvy4 3864eGhUBbvDZ4I9ivPs0llLT5X1c5KREGx3hi1kD/C6vTyMlnja8v6a1EiGz2DNwN AJlljoPSntnHA== From: Arnd Bergmann To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Arnd Bergmann , Haoyue Xu , Guofeng Yue , Yang Yingliang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] ethernet: atarilance: mark init function static Date: Thu, 10 Aug 2023 14:25:16 +0200 Message-Id: <20230810122528.1220434-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230810122528.1220434-1-arnd@kernel.org> References: <20230810122528.1220434-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773847165968149430 X-GMAIL-MSGID: 1773847165968149430 From: Arnd Bergmann The init function is only referenced locally, so it should be static to avoid this warning: drivers/net/ethernet/amd/atarilance.c:370:28: error: no previous prototype for 'atarilance_probe' [-Werror=missing-prototypes] Signed-off-by: Arnd Bergmann Reviewed-by: Yang Yingliang --- drivers/net/ethernet/amd/atarilance.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/atarilance.c b/drivers/net/ethernet/amd/atarilance.c index ec704222925d8..751454d305c64 100644 --- a/drivers/net/ethernet/amd/atarilance.c +++ b/drivers/net/ethernet/amd/atarilance.c @@ -367,7 +367,7 @@ static void *slow_memcpy( void *dst, const void *src, size_t len ) } -struct net_device * __init atarilance_probe(void) +static struct net_device * __init atarilance_probe(void) { int i; static int found;