From patchwork Wed Aug 9 19:20:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 133519 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:9d8d:b0:139:fa0d:b2d with SMTP id d13csp146183rwo; Wed, 9 Aug 2023 14:10:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEogi9AGxnnb3MdkTOK/VtyV7E5+LAGvbitfp8o2RTZCPkQAUPtE8jH7y4tG5JKu2FZT2WE X-Received: by 2002:a9d:7f0d:0:b0:6b9:5734:135f with SMTP id j13-20020a9d7f0d000000b006b95734135fmr251554otq.28.1691615442083; Wed, 09 Aug 2023 14:10:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691615442; cv=none; d=google.com; s=arc-20160816; b=lrq1VVC2kBKVCvQrQstMrqTqKEMqQlJClfhKbwMXzbm9uhRQH5EIt+0QooJ4uqZUDP ft1XL+jj4mujGmJEccXpuLyJimK7S+nobmMv8kyavFOwMb3dwjeezSL2Mxdwgq7rZQgY 09kuV2e6MRDltYNRfww0/RWUPIpNmXanQNBjQot1W5VOoNBUgJhFJvfxgRpB7e1Gg01G JeSYw64+XSwEC1G0vVbSUiuMqhm4zC/uZVD1JTOr1MFUK6yCwNGCEgl+TOkHcMYsB/IY YnnjIRM5ADOnuEo/dsq7EKiOMJa68GFsv12XNfx84ws9u1THPfkDtyUAVGQYK1CpsyBM rmOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=mFQ707YTlR2asiZeDkwXq23zTGpUUmFrLAoTxhmG6mY=; fh=VohwHOOqzSlyJV69dvs7BsalUDFtNFz6jeRDBhhLiNI=; b=Nq+RWjQ6BEeQBtvVQc1s3PT616L36IesIJ4t8GJG+DxVOuCNfWais5T38vmHmaPFu/ It7dLbJVVpjUHpSt9g7+tuwSh50Yc0m81465pgJ90XSRvAZT5jRowTn15im+zj3MJamR MhaVJ4iG6JEJ10a9m7ymE04LZGcFL1PvUUeAnYC7ZMmSjr/Xpf6radPLeZerJBBoouEO keL/cyKMIH6AHHuebcMs75KXfpnIP8XsEqfBHnICEjs0gj5b2wHOyUo/ghvTYWovzk8k SxgUXb/6/PEAyJjdHSJlo0Hf4MV6vWLoG4NsMaW5VwyBaed9KfyaRL/lWGkdlQ2hgklr 3SJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OPxuvbEu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z19-20020a63e113000000b0056341268ed7si57953pgh.853.2023.08.09.14.10.27; Wed, 09 Aug 2023 14:10:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OPxuvbEu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233624AbjHITVM (ORCPT + 99 others); Wed, 9 Aug 2023 15:21:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233635AbjHITVK (ORCPT ); Wed, 9 Aug 2023 15:21:10 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBAF426BB for ; Wed, 9 Aug 2023 12:20:51 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b9aa1d3029so2692371fa.2 for ; Wed, 09 Aug 2023 12:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691608830; x=1692213630; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mFQ707YTlR2asiZeDkwXq23zTGpUUmFrLAoTxhmG6mY=; b=OPxuvbEuXJUXjzQ89YLv2sBdDf2wZx0cITcGYsNii8MZxxcnyBJ5c8rcGtK4hVNqNi bvgzBFviOD+kPmESZ/f8KkYo1Tv4TXZ49/bRINZspYc17BdlSD05VYIkNxNSlmSS371+ jwLhwnJvThpOeD4qf8YunREVa8PM03sXZsgIrD8mGorZpFd6UIYeMzkb5q05orFGHF5r BovPTMhwNsuDP3MLkpcd8kIa1I80udRfhv2g01ZSk0MrTImMoFeaWGt+GN7BmDdbyQTl NsqVezWpl0l/iFlkMcS9J26abIdSn7zpTVTagZSULfvqCxhQkoj5QIzkr/Qur0IJFYVf Pmaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691608830; x=1692213630; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mFQ707YTlR2asiZeDkwXq23zTGpUUmFrLAoTxhmG6mY=; b=c+am9L9Ir/s7k6qrADq2nZGA1TlPd1YIuh8PPyHAI866m/2jIEBib5iZPa7eOL+LGc pxXDT+N5W8T7K3IWGosssj4qAP/fEkslBi4hP3xrq9j/NlYPYflqx8ri9ADlRMqdBm9k /MvPciXQwU7k/+OgnOsRyWR5HdadK4LclY/2ZLNcoB1YmZfpfe/EWpjdIktAAVEXeOgn o5eNVpBWc12OJPseaXbj1/9x8xs/hBCHiQQwDxcoUlxsY60N2C5C9VIAeppvCDuVVtkD iJCqiHJHoNsYpQZU9BbQtldR6C0J5U/ZQh4FCXlsMkbdTkWc1FDmaTSdTOuRMfaOBsgF f7Sw== X-Gm-Message-State: AOJu0YwK40ahqjVbfHG8DO+/TUW2k92p5akBPA0NjyEJimomq8bf8d91 o4XFsmk814pErIOkDnSjhyIlem3aOInbY1OPT0M= X-Received: by 2002:a2e:91c8:0:b0:2b9:514d:64c1 with SMTP id u8-20020a2e91c8000000b002b9514d64c1mr112691ljg.8.1691608829483; Wed, 09 Aug 2023 12:20:29 -0700 (PDT) Received: from [192.168.1.101] (abxi185.neoplus.adsl.tpnet.pl. [83.9.2.185]) by smtp.gmail.com with ESMTPSA id o3-20020a2e9b43000000b002b9ed203af1sm2863218ljj.132.2023.08.09.12.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 12:20:29 -0700 (PDT) From: Konrad Dybcio Date: Wed, 09 Aug 2023 21:20:24 +0200 Subject: [PATCH v3 1/6] arm64: dts: qcom: msm8998: Drop bus clock reference from MMSS SMMU MIME-Version: 1.0 Message-Id: <20230531-topic-8998_mmssclk-v3-1-ba1b1fd9ee75@linaro.org> References: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> In-Reply-To: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , AngeloGioacchino Del Regno , Michael Turquette , Stephen Boyd , Jeffrey Hugo , Imran Khan , Rajendra Nayak , Joonwoo Park , Jeffrey Hugo , Will Deacon , Robin Murphy , Joerg Roedel , Jeffrey Hugo Cc: Marijn Suijten , Dmitry Baryshkov , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691608824; l=1046; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=dMjovGWIjyf4UWgt36DKFCmom9ibnuPYDRAv7j4Cf+8=; b=0aJhMLANoopT9Wyll4mX1KVx6JDNVknG/kysgc0OBuv4vVfhC4gUTx23xhiPcZ61jRec2O2fQ 9NkAHlkn2sqD1DWLMOhTzsIB89GXL0lNqi5IveyKMkOX4DQlv8M6WaN X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773787354153213719 X-GMAIL-MSGID: 1773787354153213719 The MMSS SMMU has been abusingly consuming the exposed RPM interconnect clock. Drop it. Fixes: 05ce21b54423 ("arm64: dts: qcom: msm8998: Configure the multimedia subsystem iommu") Reviewed-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index a41a34dbcc3c..e40f6461f4fd 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -2743,10 +2743,10 @@ mmss_smmu: iommu@cd00000 { clocks = <&mmcc MNOC_AHB_CLK>, <&mmcc BIMC_SMMU_AHB_CLK>, - <&rpmcc RPM_SMD_MMAXI_CLK>, <&mmcc BIMC_SMMU_AXI_CLK>; - clock-names = "iface-mm", "iface-smmu", - "bus-mm", "bus-smmu"; + clock-names = "iface-mm", + "iface-smmu", + "bus-smmu"; #global-interrupts = <0>; interrupts = From patchwork Wed Aug 9 19:20:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 133448 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp3030484vqr; Wed, 9 Aug 2023 12:39:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/zoC6H0Asg35hCBC0bcwibHzy7OJiITdzcjB7D0ZrN1vIB/jLPyjq+saOVWhMGGattNZG X-Received: by 2002:a05:6512:224c:b0:4fe:167e:9f04 with SMTP id i12-20020a056512224c00b004fe167e9f04mr34493lfu.61.1691609956972; Wed, 09 Aug 2023 12:39:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691609956; cv=none; d=google.com; s=arc-20160816; b=snmSuob/9hqo8hzbCqGarFkmcXVEYBkElOVH4hO60EEfeLnUq+CnOQeVqShJ9pDOR0 J6hU235QQq+8iy/JB0tzrrvPqg2TP6FRczSuGGsmEnQMgYqsWteml0COhmjjjRhgQ5WS UFA6rP3Z1Kct4ViGhCM7BTjUwFmFFGEHHhmK17QgONDrn7dCIn/lyFSLITAQZNmQPC5C iJYKswduvf709b/mvxuIJhtSDnTvmMXfeM+ZuivauoNZz9+ZfAzZ9xsqnbzCOwM2WEtU fGG+fSwE/gOFIZUl3Hur0RGszPHzWwQLmrGLDWRle858XXQv1Dzzdu3oXh1iHqtxy8yK Sztw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=DE94Q6lf2K2gSTbQ4obZ5qNHgQeup5/EEo7g9MBB54w=; fh=VohwHOOqzSlyJV69dvs7BsalUDFtNFz6jeRDBhhLiNI=; b=ucJ+MVwbemPO9IJvQQm7tUOwOhdFEcVftMYL+xn0fNPad5UINZT9M45kUi74dB8nJK AABTMc0CMGelxis21KM6aTR3XPTH9DmQslLA2bJIOifDnHdmqffXDam+DD9gquP/t1XB nGbwOT+7IsvF8tMr8tRjtJWmSeWFsmNp/8Tm6GsGqw9xGj9SCfb5oOGfTDmPY8jhZeFm s8u2VNEW+WX15yUEvCb2UlGegU/lsHN1+LarFMb6Fln0zmdmmAUXW2S8WlMhE/qz5sr9 dj5d72AmzR0hq3jajaeXlSyDK8Uo5ZFxBv2ZXAOGkivmjz7VDWEofk4NWPPGfbOc2C1g 6VwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hVZmOV05; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f20-20020aa7d854000000b00523346514dasi6270827eds.240.2023.08.09.12.38.53; Wed, 09 Aug 2023 12:39:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hVZmOV05; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233637AbjHITVN (ORCPT + 99 others); Wed, 9 Aug 2023 15:21:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233617AbjHITVM (ORCPT ); Wed, 9 Aug 2023 15:21:12 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD8763C15 for ; Wed, 9 Aug 2023 12:20:55 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2b9c0391749so3009411fa.0 for ; Wed, 09 Aug 2023 12:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691608834; x=1692213634; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DE94Q6lf2K2gSTbQ4obZ5qNHgQeup5/EEo7g9MBB54w=; b=hVZmOV05FAUjR8G8bAhpPHpxnHhQ6DhH1iewP44ue5XrvSdFh1IvsOVHkaiJ8DJSlG OzOwcDv+13bnppTHDKixF9LK3nkTDiV+dt1xhzEyEn/hXtWbFalKXwbjBGPTqK7Ue3S8 VhYQt8NK97pnxqSmf/IX2GvUWhC0cKQylUtb4hwZV6v8kC75kW3GRNvdZMrY65f6fawZ 7C3wht1lSE7lEXy0viadI5LBdxGnHoIQCCj4TOjAruUiluS/U7PGpHbDEAzTBE2EGxXU cjejMJpG/6Fpud7Gbupf9gt48u1dP6b6fYzfGYNA6pQ7TfjjTFSA/AKGBIr86y1dWgRQ RZTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691608834; x=1692213634; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DE94Q6lf2K2gSTbQ4obZ5qNHgQeup5/EEo7g9MBB54w=; b=YBYMMIamd/TYAodF3qdZ0TXsaqsE9uhJg8H7kXXHyS12wcdZk2m2GB0weuHaCf8Cvu rfFt1SL4YAkGKLCInkroz2o6aeVtRQXmyycVOvYj7swvQfEkWt9LTTW3Lfj/BE2C0nCq HSUohnLQDdmGiiYWHPZNY+o48TAE9aO654dfQx0MkD0aRrJvwiedsvbv7e6+sbHyYD7x JO22kJiQdlYQuk9YoC2xPx+MZzHParA7IIVssLzeWu5GvgJRtz0izQK1jzLw6LiECZ+I JkGpBASDHT6TE5H6OkVj4YJ881ysLgk7xHpmA5mNs9ruEpQQrC7JvXIHx9VnhMo3LOI+ i3aw== X-Gm-Message-State: AOJu0YxVsHnF4q9db9Ug+DKiy6v73Y7jawHHq91T5BU0q71JfdU/YJng EC5VViyai6l+zT/mlYvSvATwTFI4KZ+R18iCrRw= X-Received: by 2002:a2e:8550:0:b0:2b9:b9c8:99 with SMTP id u16-20020a2e8550000000b002b9b9c80099mr104092ljj.22.1691608834133; Wed, 09 Aug 2023 12:20:34 -0700 (PDT) Received: from [192.168.1.101] (abxi185.neoplus.adsl.tpnet.pl. [83.9.2.185]) by smtp.gmail.com with ESMTPSA id o3-20020a2e9b43000000b002b9ed203af1sm2863218ljj.132.2023.08.09.12.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 12:20:33 -0700 (PDT) From: Konrad Dybcio Date: Wed, 09 Aug 2023 21:20:25 +0200 Subject: [PATCH v3 2/6] arm64: dts: qcom: msm8998: Add missing power domain to MMSS SMMU MIME-Version: 1.0 Message-Id: <20230531-topic-8998_mmssclk-v3-2-ba1b1fd9ee75@linaro.org> References: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> In-Reply-To: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , AngeloGioacchino Del Regno , Michael Turquette , Stephen Boyd , Jeffrey Hugo , Imran Khan , Rajendra Nayak , Joonwoo Park , Jeffrey Hugo , Will Deacon , Robin Murphy , Joerg Roedel , Jeffrey Hugo Cc: Marijn Suijten , Dmitry Baryshkov , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691608824; l=906; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=EM5tWZgcQ/PtQiCuUMktQpuJVbPaCBzE0y/oEdPpoBk=; b=DgG5WM7aCnxlKKTKRxJyT1NXqA7+tx0CEHA0dPTjvPgAtp5Ajxf5aVQKXXHPrMj6JtpuzIu7l Adop0zBmFK0CA+8JhrdwrZpDm3sn/DQGCO1GR9TImxjwOVAXckjOEC3 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773781602609790354 X-GMAIL-MSGID: 1773781602609790354 The MMSS SMMU has its own power domain. Attach it so that we can drop the "keep it always-on" hack. Fixes: 05ce21b54423 ("arm64: dts: qcom: msm8998: Configure the multimedia subsystem iommu") Reviewed-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index e40f6461f4fd..39db67211fae 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -2770,6 +2770,8 @@ mmss_smmu: iommu@cd00000 { , , ; + + power-domains = <&mmcc BIMC_SMMU_GDSC>; }; remoteproc_adsp: remoteproc@17300000 { From patchwork Wed Aug 9 19:20:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 133534 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:9d8d:b0:139:fa0d:b2d with SMTP id d13csp153167rwo; Wed, 9 Aug 2023 14:25:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjGJcHt3oBmYxbtn+E0mbN/ETFINCumk/deuMG0xPGZaIfZehCsnUCwxWvblbr5abQDxd8 X-Received: by 2002:a17:90a:7788:b0:267:faba:705 with SMTP id v8-20020a17090a778800b00267faba0705mr438673pjk.10.1691616329992; Wed, 09 Aug 2023 14:25:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691616329; cv=none; d=google.com; s=arc-20160816; b=t5PsoMJunAZaTVnehMDixgkcU8sH3YHwIQWGxfs4r5Hnkzo8MBrOiJO5Vb6i70aEZV xQKRgWWHzwFtelppriWApYFgo3SAYOMVx+69ynbfHUOSAPvU6JouSKdTJuqVGa78NNNe S6ti9gS/VIY6UjD0uG3pOIrwzSngCiLd4BRK3qT1HtTzV2FSGIKOEjqFOJSS9Wl/UMrz Ifdb7lT2T8pOBN18dUlAQ67mXdQYBLT6rWppT33oJmNQjYXvAdtolPe/nxovUHM+Tv5T MrFCTaGFNNcGC+se/i3ehdkEX16+yTeVBwBvEixCXnkuSDAu1UZkH8NrWbpkk+TGIgd2 0Ceg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=TJRcX7l83GzG4nljjiXsSgTVORkCZorOu6CVVdtQF3E=; fh=VohwHOOqzSlyJV69dvs7BsalUDFtNFz6jeRDBhhLiNI=; b=DX/E5lrubABLb0PYBAu6HpwD2jwWKW32Y9s44kBhomh4LO5y7zVyATQQjav7orgLBV sNzYFO02ZfFUaPyL+2jLL2V/aJA9RQoNUMNyJ5oq7PImTkCECDxlxTw9G4lgzH49PjsX HviWuruPL8hkSHaJhBNc3yq3ixoyov9gm1QzJSr5k/CT5EiJ4DGneOXNUfaUrXGWI/ux zTQQ1qODiFSLtZ4KlcY34oLtsLGqu5HVbIACCxggm5KZOeKk0QDh2JpTDeakMnLzywJm kjC6sCGUVPWUKO+5WtZUUkewZNhY7eZ/0HMq/9bKvR+iuU00h9lFgE7WG3v1wSnWa2DK PJ6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J67BqW4P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ob2-20020a17090b390200b00263a985aba5si2360510pjb.149.2023.08.09.14.25.15; Wed, 09 Aug 2023 14:25:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J67BqW4P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233691AbjHITV0 (ORCPT + 99 others); Wed, 9 Aug 2023 15:21:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233666AbjHITVT (ORCPT ); Wed, 9 Aug 2023 15:21:19 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 858AB358C for ; Wed, 9 Aug 2023 12:21:00 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b9a828c920so2621201fa.1 for ; Wed, 09 Aug 2023 12:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691608837; x=1692213637; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TJRcX7l83GzG4nljjiXsSgTVORkCZorOu6CVVdtQF3E=; b=J67BqW4PzqZ3LQWy0xRUu2fPeiS0tkYFmGkV8qggyN4tk0Dk0oUfVjDADdP0QFanwR olOGQjV3qFvbRfIGzyqylFnevJTih4Dpjdu8EtcMJ74XvJl8YZfUoLa90KrTAMGprVLI bS6OLJehb/0Hh/fLPS85pVJuLlki/+tZ/9KG7PxDHOipRiNsBCUka2PHikg1QDidIXQl B+Hkg8Z3Opm1oBnCxg+ky7ePEN23reVd9SCgVz6w8aqbIrWezCMq5BwPT0FaUpyV4uhz wDjt/ZV0LlftrlbmAyB0UyLRPI5n/JPFDhmaY6FOQhEHx1MTU25pjWb2MIrSHWvkQ00Q fNWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691608837; x=1692213637; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TJRcX7l83GzG4nljjiXsSgTVORkCZorOu6CVVdtQF3E=; b=BvUFTDttmbdmnRj/5VMhrSeUJjjHs61SkDS9uZ+v7dczGOmHze+jytitEX9Eozz+TQ FCyodNPwg9KSe6mvj/wDNwodx3r9yG0DcMWfcYF3Js0xa86OywjO8jTHYZCWFbfnT6u4 goZq5uG2Di6ejrkGyH9LFURK+8ciuNYh3Stb48JsHYzi4l1ZqwjNGpTaB95byIJwchaW /i6QkfpIOTlXWq/Tk5qBTG23Ab28sr0QC9GSnSGDOynVXSD5Kjg8wLyO/ytnPBwmIdGv jUlJZfKpoNqvNysQycebRuopWzobdQXssSlIruRQ+LOpx4z86o1M84BwblVug7PnoBvf 70ew== X-Gm-Message-State: AOJu0YxiH+2uja1eNZf1r1dSNy26BgmYx2gislzVdCUi4VpVQ0tNqJkb l7YA/zjx7Gz5tHzh3IW26pmKK3UZp2CrjWo/xgs= X-Received: by 2002:a2e:730f:0:b0:2b9:e7d7:64bd with SMTP id o15-20020a2e730f000000b002b9e7d764bdmr92624ljc.47.1691608837194; Wed, 09 Aug 2023 12:20:37 -0700 (PDT) Received: from [192.168.1.101] (abxi185.neoplus.adsl.tpnet.pl. [83.9.2.185]) by smtp.gmail.com with ESMTPSA id o3-20020a2e9b43000000b002b9ed203af1sm2863218ljj.132.2023.08.09.12.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 12:20:36 -0700 (PDT) From: Konrad Dybcio Date: Wed, 09 Aug 2023 21:20:26 +0200 Subject: [PATCH v3 3/6] clk: qcom: gcc-msm8998: Don't check halt bit on some branch clks MIME-Version: 1.0 Message-Id: <20230531-topic-8998_mmssclk-v3-3-ba1b1fd9ee75@linaro.org> References: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> In-Reply-To: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , AngeloGioacchino Del Regno , Michael Turquette , Stephen Boyd , Jeffrey Hugo , Imran Khan , Rajendra Nayak , Joonwoo Park , Jeffrey Hugo , Will Deacon , Robin Murphy , Joerg Roedel , Jeffrey Hugo Cc: Marijn Suijten , Dmitry Baryshkov , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691608824; l=1627; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=4vcJD39xmmwGxR16do/vEynX3nfOkYLGbzSw65dGFMA=; b=V6n6R9yvH/Elr5qcWR9xj0kZ2oYv/FkZVkxEuDifmy96KAhGojMvRCcOz1x/M+gxV1oaooOtj YvOhwXH9HlDBckManxwXKBZRQC8h4oe4BVD+Miqo6zg7UuiZETyqzCN X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773788284986958676 X-GMAIL-MSGID: 1773788284986958676 Some branch clocks are governed externally and we're only supposed to send a request concerning their shutdown, not actually ensure it happens. Use the BRANCH_HALT_SKIP define to skip checking the halt bit. Fixes: db2c7c0a04b1 ("clk: qcom: Add missing msm8998 gcc_bimc_gfx_clk") Fixes: b5f5f525c547 ("clk: qcom: Add MSM8998 Global Clock Control (GCC) driver") Reviewed-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-msm8998.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c index 1ba516a0c0f3..257b27d8eeb6 100644 --- a/drivers/clk/qcom/gcc-msm8998.c +++ b/drivers/clk/qcom/gcc-msm8998.c @@ -2060,7 +2060,7 @@ static struct clk_branch gcc_gp3_clk = { static struct clk_branch gcc_bimc_gfx_clk = { .halt_reg = 0x46040, - .halt_check = BRANCH_HALT, + .halt_check = BRANCH_HALT_SKIP, .clkr = { .enable_reg = 0x46040, .enable_mask = BIT(0), @@ -2073,7 +2073,7 @@ static struct clk_branch gcc_bimc_gfx_clk = { static struct clk_branch gcc_gpu_bimc_gfx_clk = { .halt_reg = 0x71010, - .halt_check = BRANCH_HALT, + .halt_check = BRANCH_HALT_SKIP, .clkr = { .enable_reg = 0x71010, .enable_mask = BIT(0), @@ -2099,7 +2099,7 @@ static struct clk_branch gcc_gpu_bimc_gfx_src_clk = { static struct clk_branch gcc_gpu_cfg_ahb_clk = { .halt_reg = 0x71004, - .halt_check = BRANCH_HALT, + .halt_check = BRANCH_HALT_SKIP, .clkr = { .enable_reg = 0x71004, .enable_mask = BIT(0), From patchwork Wed Aug 9 19:20:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 133462 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp3034972vqr; Wed, 9 Aug 2023 12:49:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFfJlNl5dQ/ODr+opuM/VOBEp4JYyyl9Wp4zmCGPpfymnw9V+YfOKr4s7uGM67768l3Ariu X-Received: by 2002:a17:906:220e:b0:99b:e6ec:752c with SMTP id s14-20020a170906220e00b0099be6ec752cmr70960ejs.70.1691610544238; Wed, 09 Aug 2023 12:49:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691610544; cv=none; d=google.com; s=arc-20160816; b=P1Qgzxg9atpTQsAZNVoZMgc6pc3k1VQfoDhUrrz/mQK7QD4yRtWyAX8kA2kxQpbPv8 lCn6DdX5YRfBC6zO1CAlY9ho9k/AXCBBRJCAAdHjniC2q16JH+/kvzs62+RzYiOjBevg 2XomhiqP8vO6UuUxnMjV7mPgOZ60ozmxwTEuY/j6+4gw8FOmU3JVd9mAAkD1htxLhjCG DhYEr/M3NqNLkySUqnr4Ll+g6H42wHP4ndEUNfAQVeavo0qARQPxO5IHEX/3MvszdvXa 3MPXYeYlyhLP4TrLydh66IQcej3/3FU64S+crdhZ27inzwQlLDePak4RJQ0YDCLDoeLf 4Ebw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=gAg8mzz6tXJyaH1tEofpHQ5TEsFiQj+ho2hy+w4Tmaw=; fh=VohwHOOqzSlyJV69dvs7BsalUDFtNFz6jeRDBhhLiNI=; b=R5LFTQ+a4UasQ6kkjUVXtY7kZ7kZRq+fnIxTVtrpHsTlnE3Hq74GD1mbuOZTO4vKjI GmHNtkT1/vrRwbDMEVxw1/ZfA6b/LhR1V45yaptAO5/0o9ST7dv5uuQB3TV23nDSpfnP VehnWe9pKx/QeUah1/j3n8I8DHFSy4Eorl/cc4ravfstWfYmoSFHYfRHyNOHsFp9He8i uJBA/QvMJ4Bkbw+xAxN8aLEYuSkN5W2I9e7ekH5PpWxeoWxNE4F93fBp5fOdelmLZYnu ViQonu/vLQR/JTBB2H9U2zgiblyo/qkjSfEdL5WVy8OG/rIdeo7CFvnU8NHppQCT3mqV C6UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VzyIj7kp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z6-20020a17090655c600b009823816586esi5765458ejp.500.2023.08.09.12.48.36; Wed, 09 Aug 2023 12:49:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VzyIj7kp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233708AbjHITVe (ORCPT + 99 others); Wed, 9 Aug 2023 15:21:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233706AbjHITV0 (ORCPT ); Wed, 9 Aug 2023 15:21:26 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D0CC2127 for ; Wed, 9 Aug 2023 12:21:07 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2b9d07a8d84so2585991fa.3 for ; Wed, 09 Aug 2023 12:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691608841; x=1692213641; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gAg8mzz6tXJyaH1tEofpHQ5TEsFiQj+ho2hy+w4Tmaw=; b=VzyIj7kpmL0GI4+H4dQgi+UkUqLL/c7AY4Rxja5tdpF915CELH4iPRezqR4JDiLnJh hYWiJDYoMzzJV5MOSC8CjjSlzrYOHQ10ohlzh1bPxmj1pr+/0siODEQNxkxj8Yh9A15S zI/qS1L0OWycrmB7G1C/yp5U3na9yIXRmmtuRliwEkSdu6YiQewsJJXy6uF7YPyjbuSp yBKQ+5U3WetAiIi2o4FlPGztZERZdbxrFevAtYlQ7nZclkZyC3NgxUPVi2x2kQyOfnnJ /9NEypY0RwWjU0nhuHENuUW3M2BNeFJ+Ce+M5dutJ5CYEMVFUVzkHqcp1d3icMk49mwb AQOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691608841; x=1692213641; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gAg8mzz6tXJyaH1tEofpHQ5TEsFiQj+ho2hy+w4Tmaw=; b=hERzL6XKC6NruaZTlj//pVCbgtb5Zy7XCUDCttIhKm4HiOfqKz7zTRgw/VjAkuM498 G/uHUCSgx2ooChBEcfEwqRRZwsWNxZqPDMQ6pqJSYvYKCkdQ7Rvx7dAyG/vOKIT2yqOb YgFYWBSEYpnntAW7kfO+++4TJNaaOWT3N4jmSY/RZzv9gm0bHVaEDXJGrrVuXXA3+sJs RkedLjvWuk7WztMclL9HDZtRGH0mb574v+GIKKezqwI4Hidp9yXpqjIq9fQ1vH0JDGAy gMdWOxp0gKaqZBeQunSOoVbCBK8jWbKPb0VsShQv6JTdbswrx9Pvoea2eKjFgLgm0x+8 JJBA== X-Gm-Message-State: AOJu0YzFbX1xE9SsMigprceCvjUdW6bk8snTEcil6hdZQCTDApycYSjc uwOdEP7Y9k2hKDuuZ4p0pm8RjIyNecK+slb98uA= X-Received: by 2002:a2e:9c50:0:b0:2b9:5695:d10d with SMTP id t16-20020a2e9c50000000b002b95695d10dmr82394ljj.36.1691608841249; Wed, 09 Aug 2023 12:20:41 -0700 (PDT) Received: from [192.168.1.101] (abxi185.neoplus.adsl.tpnet.pl. [83.9.2.185]) by smtp.gmail.com with ESMTPSA id o3-20020a2e9b43000000b002b9ed203af1sm2863218ljj.132.2023.08.09.12.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 12:20:40 -0700 (PDT) From: Konrad Dybcio Date: Wed, 09 Aug 2023 21:20:27 +0200 Subject: [PATCH v3 4/6] clk: qcom: mmcc-msm8998: Don't check halt bit on some branch clks MIME-Version: 1.0 Message-Id: <20230531-topic-8998_mmssclk-v3-4-ba1b1fd9ee75@linaro.org> References: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> In-Reply-To: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , AngeloGioacchino Del Regno , Michael Turquette , Stephen Boyd , Jeffrey Hugo , Imran Khan , Rajendra Nayak , Joonwoo Park , Jeffrey Hugo , Will Deacon , Robin Murphy , Joerg Roedel , Jeffrey Hugo Cc: Marijn Suijten , Dmitry Baryshkov , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691608824; l=1407; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=haDOFYx+cWB8WYF0AFsxGiNUFhwDHpLSQyDe+vgkap0=; b=ivHa7Psm9IKmZjT3K/fiYAso4o3IjbutXh3aiP/PX5cuAobhTzT3jwBqR6ntC92H28DCKPHah 56lr1ds08k8Cbcneb+IbXt/B0FrSWryIzQYDSVIg30b+uHh5Nmoezjz X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773782218093811150 X-GMAIL-MSGID: 1773782218093811150 Some branch clocks are governed externally and we're only supposed to send a request concerning their shutdown, not actually ensure it happens. Use the BRANCH_HALT_SKIP define to skip checking the halt bit. Fixes: d14b15b5931c ("clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver") Reviewed-by: Jeffrey Hugo Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/mmcc-msm8998.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/qcom/mmcc-msm8998.c b/drivers/clk/qcom/mmcc-msm8998.c index c62aa270af1c..d0a5440e2291 100644 --- a/drivers/clk/qcom/mmcc-msm8998.c +++ b/drivers/clk/qcom/mmcc-msm8998.c @@ -2452,6 +2452,7 @@ static struct clk_branch fd_ahb_clk = { static struct clk_branch mnoc_ahb_clk = { .halt_reg = 0x5024, + .halt_check = BRANCH_HALT_SKIP, .clkr = { .enable_reg = 0x5024, .enable_mask = BIT(0), @@ -2467,6 +2468,7 @@ static struct clk_branch mnoc_ahb_clk = { static struct clk_branch bimc_smmu_ahb_clk = { .halt_reg = 0xe004, + .halt_check = BRANCH_HALT_SKIP, .hwcg_reg = 0xe004, .hwcg_bit = 1, .clkr = { @@ -2484,6 +2486,7 @@ static struct clk_branch bimc_smmu_ahb_clk = { static struct clk_branch bimc_smmu_axi_clk = { .halt_reg = 0xe008, + .halt_check = BRANCH_HALT_SKIP, .hwcg_reg = 0xe008, .hwcg_bit = 1, .clkr = { From patchwork Wed Aug 9 19:20:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 133504 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:9d8d:b0:139:fa0d:b2d with SMTP id d13csp135738rwo; Wed, 9 Aug 2023 13:49:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhq3z2fwW6sc/6unOMJS1CLDU730/fYtRq5eClOrCspW3IEfiPL3jxLusMuCU/4+XuFngN X-Received: by 2002:a05:6a20:a10d:b0:126:8b2d:4462 with SMTP id q13-20020a056a20a10d00b001268b2d4462mr26840pzk.24.1691614195977; Wed, 09 Aug 2023 13:49:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691614195; cv=none; d=google.com; s=arc-20160816; b=YtpfBOJxZH41j0SKCn6RxII4gi2b3f6psZN8LRT7qv/QjRog1qh/cvQnl7LpJEnLO/ KRHvi97jchpsBPE3lkmVIn2NbVSqCAuv0LptKxHne7OFmGvXjZsrsetE5smM8qXzElQF sF0oaUsPlQH3TFFg+3P1XeQlh8GDJZRtgxH3SIgw25cbWipk9kfVBfR34mU3Wg7qmH5v 1zNSlt7gmeergNVwHJ5w27/7Cs5f55fjwiHYlfkTNYC/pwQntB4EmySnG4px5Yyminxg kO2xH4efxEcEhSqXU0iMcgYIpQn/TNgEI5DDnpFz2FUw2JvH1+i/JNLkbfKSSOfulJPd mGlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=dlY5pXEYcBgHeb5qjzLwZeG+1V5JyWmwzq+8kailYB8=; fh=VohwHOOqzSlyJV69dvs7BsalUDFtNFz6jeRDBhhLiNI=; b=pP8Um/C5fjmZBvxhE36H0PYB3W00eteKk4iZyyIuMfSGtXtr6x5kOF9VWim6tmbLwF XPW/xXpfoA++C5giO1CKSUG3PhF+Eq9thlxJBSbBEkcXzi+KmkUf7JDSkn3u1L60deC+ abGoN+xUhQYTo8S+tSyw1ymAsgsRvl1YhIksUBt/gq4G6MNRV0pJklwED7DiT7Wu8pnb tOrO5B+YTipfupKtBLNa9YUZk24nC5wX3zOwub9zCPDpDx/bw8Q62o8t5NbX3F5NPIdF oAjFRAMoYyaYuIRwsWGx1ok4t51hFjLKRhVJG2vsgMoEF9i0aCaGuII+fClaWZpKmGss QWlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TfhFmGA2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l185-20020a6391c2000000b0053059dfafe4si51288pge.86.2023.08.09.13.49.42; Wed, 09 Aug 2023 13:49:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TfhFmGA2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233681AbjHITVh (ORCPT + 99 others); Wed, 9 Aug 2023 15:21:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233642AbjHITV1 (ORCPT ); Wed, 9 Aug 2023 15:21:27 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3033272B for ; Wed, 9 Aug 2023 12:21:07 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b9cdbf682eso2459171fa.2 for ; Wed, 09 Aug 2023 12:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691608845; x=1692213645; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dlY5pXEYcBgHeb5qjzLwZeG+1V5JyWmwzq+8kailYB8=; b=TfhFmGA2dH+TveOOjTBM+LXhYCAopnWok1rpSmme2kr7oBvmt6nTk4Lk3foM868G5b aE9Wmuy0c+DlCtfHBPYmxCwgVWB5e+v7Y0TU+N/+l+Gh7Kst7o4vWvI2m7BGaORPIiTS 0HDzZt+v6tbH0IzQWlaIeCuUzRK/dwMB0izv2EmHKw2eKdleSP97NFbbZX7vBUMJ/bGb 1PZ+GFC1voBzNGut5ABKsRcBAvdj+jJTZqGwUT6+khj8FECcLIeqS61IVGXUPNkz2p2L 5m+Rw4b24Bv1lc/C9wGVDXEOS2G6Jh5EKBw4EAmwAJAaGh7ydl2yhF3IQc45UUkimxm/ rIwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691608845; x=1692213645; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dlY5pXEYcBgHeb5qjzLwZeG+1V5JyWmwzq+8kailYB8=; b=dNFtEetrIyluVdwEX5As2s83rSEzFDUIHSaxGdzIwvkaWviWQZHO5MPwYJNzQ4X9c/ pDl8V/Bfx0/fzS0NtL/jyt6uG/APK4FQn545k1SqA6Xl4EzQY5AyyHiDBXi8Ewq39Ec4 CRmlCQQBDiPAf2LocyFVcAf/M8UFjUPE231oFQEotDPJK3CPYpzTLDXpb0br5jlFN8qe JepMfpXPheonCnwfya0zTWG/V503WAd6y7XUBDmBQuPRSQ0AgnBUeNbpK1elp8490P2j v3GHhZoIQuBTC7gOPJHPIRPy4iEKg3spInveIezjRU7MiH+z9jaJlb1qGMB8x8xvEz7C ys/A== X-Gm-Message-State: AOJu0YyrMJcQArzNgC5E1ciwzHjvHjwmfXd/aiMer+pAwyPhNOc+g58n flfS/ZnqY6FGRB2HW68rlgYF90XNu6hzqcFT+es= X-Received: by 2002:a2e:730f:0:b0:2b5:1b80:264b with SMTP id o15-20020a2e730f000000b002b51b80264bmr105482ljc.12.1691608845471; Wed, 09 Aug 2023 12:20:45 -0700 (PDT) Received: from [192.168.1.101] (abxi185.neoplus.adsl.tpnet.pl. [83.9.2.185]) by smtp.gmail.com with ESMTPSA id o3-20020a2e9b43000000b002b9ed203af1sm2863218ljj.132.2023.08.09.12.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 12:20:45 -0700 (PDT) From: Konrad Dybcio Date: Wed, 09 Aug 2023 21:20:28 +0200 Subject: [PATCH v3 5/6] clk: qcom: mmcc-msm8998: Fix the SMMU GDSC MIME-Version: 1.0 Message-Id: <20230531-topic-8998_mmssclk-v3-5-ba1b1fd9ee75@linaro.org> References: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> In-Reply-To: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , AngeloGioacchino Del Regno , Michael Turquette , Stephen Boyd , Jeffrey Hugo , Imran Khan , Rajendra Nayak , Joonwoo Park , Jeffrey Hugo , Will Deacon , Robin Murphy , Joerg Roedel , Jeffrey Hugo Cc: Marijn Suijten , Dmitry Baryshkov , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691608824; l=1105; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=87zmBNCrKExC5fA2pDw1hJreUEORhjqL4+NYXqa3bgY=; b=CtWmrvSHsvlErbsQsxLrU3ODuhQtNsTsNtB19xrNUGWfiV2aSZHRHHqxrLMUFEu1uiAStAAWj RMlV9Kb8TVNBKbiitjQkSgCh91rmQV5dVmkhomop/HO4nk1+OC6BFNa X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773786047015442121 X-GMAIL-MSGID: 1773786047015442121 The SMMU GDSC doesn't have to be ALWAYS-ON and shouldn't feature the HW_CTRL flag (it's separate from hw_ctrl_addr). In addition to that, it should feature a cxc entry for bimc_smmu_axi_clk and be marked as votable. Fix all of these issues. Fixes: d14b15b5931c ("clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver") Signed-off-by: Konrad Dybcio Reviewed-by: Jeffrey Hugo --- drivers/clk/qcom/mmcc-msm8998.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/qcom/mmcc-msm8998.c b/drivers/clk/qcom/mmcc-msm8998.c index d0a5440e2291..4fdc41e7d2a8 100644 --- a/drivers/clk/qcom/mmcc-msm8998.c +++ b/drivers/clk/qcom/mmcc-msm8998.c @@ -2627,11 +2627,13 @@ static struct gdsc camss_cpp_gdsc = { static struct gdsc bimc_smmu_gdsc = { .gdscr = 0xe020, .gds_hw_ctrl = 0xe024, + .cxcs = (unsigned int []){ 0xe008 }, + .cxc_count = 1, .pd = { .name = "bimc_smmu", }, .pwrsts = PWRSTS_OFF_ON, - .flags = HW_CTRL | ALWAYS_ON, + .flags = VOTABLE, }; static struct clk_regmap *mmcc_msm8998_clocks[] = { From patchwork Wed Aug 9 19:20:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 133565 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp35541vqi; Wed, 9 Aug 2023 15:06:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUeUzzw4uF/GTU0NYhvzZV3DHfiTC1kFcnUYA0c02xSu5oy7W3StNynsgdBjOUjzyQozYH X-Received: by 2002:a17:902:b70e:b0:1b8:1c1b:125a with SMTP id d14-20020a170902b70e00b001b81c1b125amr402188pls.2.1691618818814; Wed, 09 Aug 2023 15:06:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691618818; cv=none; d=google.com; s=arc-20160816; b=isUGEFTz77yQUPR4A228+O7R02Q4CIy9a7EYJSZs1M1eCpS2lEtF0AKl9MRiPE5mFY TIjZEX5LYhNqQZ/e9xAbuKNfhUHm/2tMPAA87lwUDgMjiR5wSVc0hUAFj3ZU+DPR0CxU 1s5N/N0T2tg4uLmcWjExsZkmRoshTTPjN98/Hix4fH2LgTbNEjiNoBfvWg/VxOYksV97 dmx6/xIQq9N10MsZmkhwfxuFjpwHsZ8PYNVZLm0SXRhX/K9h+QIdLbkBqHdqnC7Rh61y LU1gaNlmJlAaEO/XeZZ+VjWQXGQyPA5xG01YmRcYDjHnVByzioWeXMtwr2T9nJP1s96B 4qzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=PKzXZ2xoOmtz+1E6ZSxEFtLtyfPfJbw38y+S2GZug7o=; fh=tQ6WQpNN1otqzXehPf6W3PFXfcQlgqRAJCCJbW143lA=; b=S4d5+SB5CwocGAY1aFuhJFCnVtcjk0e/0YyNVBacgNHUyVGPDWjlJyxuRx4mdXAD9p 6xe7Zp85TAo3FXtXNEASfU0PcVEtEFHw1DvqOrLBzOiOnWUs0EVO9OZwtn/o0kn7KfZa k6mWH97leZs58r1QnbtoHh/++dsTfnEi5XXYHcgYjFqk47/ae2wBQCr4DMNxmy6y3ite eXHXtKJp3UItlnS9AISsLhr2PkWK/F5xK1fS74qNZ0SWb/jBLNN+2ZcXdMV80Xu8uT4D nWNtrxdSMVBo3GtqEn13qlBBPNU0qR47ZHC/9mpfKy5ceaJXrwVixZJbdTgz8y4kPHyf EUmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ktOkxMQc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b8-20020a170902e94800b001bc52116351si78392pll.70.2023.08.09.15.06.43; Wed, 09 Aug 2023 15:06:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ktOkxMQc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233803AbjHITVk (ORCPT + 99 others); Wed, 9 Aug 2023 15:21:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233718AbjHITVa (ORCPT ); Wed, 9 Aug 2023 15:21:30 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D04463C2F for ; Wed, 9 Aug 2023 12:21:09 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2b9ba3d6157so2395151fa.3 for ; Wed, 09 Aug 2023 12:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691608849; x=1692213649; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PKzXZ2xoOmtz+1E6ZSxEFtLtyfPfJbw38y+S2GZug7o=; b=ktOkxMQcgVGObAcCt3Knbm410wsa9H2uDdEZ/bh/kb/PTY1yoBH/UsES4eG/yOaN+q 3gzHgW9KgTARcZ05z2S8O6wE54tVnWFb2jvcTNOfCtBvkYbtIoOj1QkrguFI107bp+do XIxkH/f0RznHU8aaw59Qe4YS9C//aPlDruZn9wdBFkfbCjC09zY1y/vJyzxXw81sb67K AUd/rg7n58SkzCAUGrTNF8UDDGDtpx+DBjknpO/qGPt0fnfXauXI3wEATyfgOpbhPNNV Q9ZEZZdWFxXtIQCpYlCm57pEKF6boSnrhk0jAZQkOJXZ93ssJ/vJ8MX3oTGbPoWHECHb agsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691608849; x=1692213649; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PKzXZ2xoOmtz+1E6ZSxEFtLtyfPfJbw38y+S2GZug7o=; b=bAcc8FqyZEITzJJitSjKHircR/K2hugVAY82jRZf6FJUqdW6LJ4KONcwxIgtQYvDB/ pjbqtxiVjPoaJcWB7RkoHX3m6nHvU3c2Iwo+XNyxQ1i7qPXtSx4cahYwR3O3rZ8mqwqx hjJnwbc2gnKFlhBMlCYJ9zTgBdf5Y21WjwqrawBo4ky3scIWaYPYhXXK+Dn+SgZR2DKp vhIK6Gzu+fi6wKFHZuJXnOWHfg/fvoOU4UD/cEAkRl+NZQIJaAfS2UOFHXb20R3PRAAX tT+PGxcDQ6OWYk91AulSX7hfcDbd5mcrYEEfq7ma9oZsMFpdmWvngtNprovQzAAqVaYx 1kWw== X-Gm-Message-State: AOJu0YxsArdQHPj1ZjIp8EqEfQi3gRaco1RvOIikkXEqpj13x6q0v7Ag qVv+V4RDydMpy8DPY/fzad0R1iYRXzT+vEUPfVE= X-Received: by 2002:a2e:9a8c:0:b0:2b6:9da9:2884 with SMTP id p12-20020a2e9a8c000000b002b69da92884mr82130lji.40.1691608849543; Wed, 09 Aug 2023 12:20:49 -0700 (PDT) Received: from [192.168.1.101] (abxi185.neoplus.adsl.tpnet.pl. [83.9.2.185]) by smtp.gmail.com with ESMTPSA id o3-20020a2e9b43000000b002b9ed203af1sm2863218ljj.132.2023.08.09.12.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 12:20:48 -0700 (PDT) From: Konrad Dybcio Date: Wed, 09 Aug 2023 21:20:29 +0200 Subject: [PATCH v3 6/6] dt-bindings: arm-smmu: Fix MSM8998 clocks description MIME-Version: 1.0 Message-Id: <20230531-topic-8998_mmssclk-v3-6-ba1b1fd9ee75@linaro.org> References: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> In-Reply-To: <20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org> To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , AngeloGioacchino Del Regno , Michael Turquette , Stephen Boyd , Jeffrey Hugo , Imran Khan , Rajendra Nayak , Joonwoo Park , Jeffrey Hugo , Will Deacon , Robin Murphy , Joerg Roedel , Jeffrey Hugo Cc: Marijn Suijten , Dmitry Baryshkov , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Konrad Dybcio , Krzysztof Kozlowski X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691608824; l=2584; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=AwK2agC2XLAE1uApMOG3gNnll+6I3sbngtzNXhteFLY=; b=9iedVVmx0RYZnXA8MtHQb4WwXu0MUQvJzEqf1sqEeHux/YcxVW+ah4TFsuR9KgpG7fZyLt/gQ 3Eq/kgMEGY1ATnANKZsWUEs/orzBde4cvjS2RzEFnclWUMH/ZMEAhj7 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773790894768376034 X-GMAIL-MSGID: 1773790894768376034 MSM8998 was abusingly referencing one of the internal bus clocks, that were recently dropped from Linux (because the original implementation did not make much sense), circumventing the interconnect framework. Fix it by dropping the bus-mm clock (which requires separating 8998 from similar entries) and keeping the rest as-is. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/iommu/arm,smmu.yaml | 41 ++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml index 3a31a979709b..cf29ab10501c 100644 --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml @@ -270,6 +270,47 @@ allOf: contains: enum: - qcom,msm8998-smmu-v2 + then: + anyOf: + - properties: + clock-names: + items: + - const: bus + clocks: + items: + - description: bus clock required for downstream bus access and for + the smmu ptw + - properties: + clock-names: + items: + - const: iface + - const: mem + - const: mem_iface + clocks: + items: + - description: interface clock required to access smmu's registers + through the TCU's programming interface. + - description: bus clock required for memory access + - description: bus clock required for GPU memory access + - properties: + clock-names: + items: + - const: iface-mm + - const: iface-smmu + - const: bus-smmu + clocks: + items: + - description: interface clock required to access mnoc's registers + through the TCU's programming interface. + - description: interface clock required to access smmu's registers + through the TCU's programming interface. + - description: bus clock required for the smmu ptw + + - if: + properties: + compatible: + contains: + enum: - qcom,sdm630-smmu-v2 - qcom,sm6375-smmu-v2 then: