From patchwork Wed Aug 9 16:49:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 133399 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2985608vqr; Wed, 9 Aug 2023 11:11:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhV7tZR9pHOuHYDtttlpX2yNcH4JLb9HCVounMkfdLsanhth9axHn63xqRErnC2ajKdlEj X-Received: by 2002:a19:6414:0:b0:4fe:279b:7609 with SMTP id y20-20020a196414000000b004fe279b7609mr2195403lfb.17.1691604699945; Wed, 09 Aug 2023 11:11:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691604699; cv=none; d=google.com; s=arc-20160816; b=sVPN8uM89fbRR8U6O6tjlZ1UBxwvOCd0/9zARXwRImnT+3FQF4Zwg7/EA+hrCe0SwG 0TSM3vjwI9wMsm0kZZXApsTtbHzqEIAdgwZViVnYSVFKVXaqwuri2DfX/8FJ/EazUgrl HJPHzxn4SyGXYv0vsdTA9PZ7mMEnznA2Xwev7ChyrHzNog0JbdBKdLdX76WupgzSLTKJ 4id1SbW7Ceb9IMDjvZSU6vzAyfVcxNvEDdkVazr9B6e4sGaJwx0P++NCQHCZbnDXOtWa cDUDwv5xKV7tG8AjCZi832Tz1mNXHrRQlBpNI7Q2TAk6iadr5pa5mbGGrXew9kTtbHx2 gRug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:cc:subject:to:reply-to:sender:from :dkim-signature:dkim-signature:date; bh=zH38xtHL9HqIzLBGvvTBhROYV0QZSJpOfbkOR0Lj/7w=; fh=xeBNGOuZM5vy4okdFvBNsMTGHQ6tdBlFPaNKCUScG5A=; b=iadmsMtCWmgieCHkni6KYlouj5phAqEMoWGseZu0FDgHLOap/7giWt/GtE5XAmopY1 CPLN41T2v/ozxScpUd34d49pRLINWc4Lqf9BSZ6fX2dI56GfBpgwbbzklagQXLsw4VhL dx2EcwEWqtGjvzvLlJ3MwPRywJt1JIq73znAkZ0xyZt78kRwLJz21XfHjd4tO7cJssdA AUmGz1jQyI1kSEmXiJIokr01f6q66P5zx+lvbiaUYvEHUs5WAB7q6AgryigRPXtV6z6q mewGJ+wK7Kc/QnHiFNgouxd/kSKTt4YI0d3mwt6I6Ugp/0KHS5+IX/WBLdSZ4CVc9Ktl 3XiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Tz9QrgDE; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=L2+qmcdw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w17-20020a50fa91000000b005232300401csi7428643edr.24.2023.08.09.11.11.16; Wed, 09 Aug 2023 11:11:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Tz9QrgDE; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=L2+qmcdw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231661AbjHIQtz (ORCPT + 99 others); Wed, 9 Aug 2023 12:49:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231304AbjHIQtf (ORCPT ); Wed, 9 Aug 2023 12:49:35 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D31841BFE; Wed, 9 Aug 2023 09:49:34 -0700 (PDT) Date: Wed, 09 Aug 2023 16:49:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1691599773; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zH38xtHL9HqIzLBGvvTBhROYV0QZSJpOfbkOR0Lj/7w=; b=Tz9QrgDEHDorugHj8mio5yFNF9GQdvZliXTTnRo1SEMgoKYzgwdu2tD0sGXa7WidPdLUwg eRkM/3S8dzj/er8JEDZIsDU9JZX/69RoJayc01OHJsRBtSFpFzXdmwJQkEWVuvBguWCZaf a1d8ioCQvXjBrxKEhCvkqdT7Qiqs2eaivmS7zln3ULnVtj2Q1QV9fYOaxsmC4eIwpj1Jya jToh75r9JZtHbZI/+WoovIZSqmg9JoUYhFy/1vXwnxLP4XiLYWHCaECOMvSqNJ04VxCwHc gN7E0rfXp+eMfSaBxUgkBv4bI0lJQgbrtudwfVmnc+XsHruFzF40gWY5K/6f3A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1691599773; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zH38xtHL9HqIzLBGvvTBhROYV0QZSJpOfbkOR0Lj/7w=; b=L2+qmcdwXZ6165XeHZ52prG4+lvCnk05vLLBHWuBp1VhSPz1HH2ZRX4BtceDZaFGdB4i1k T414Fi9n+ZiprICQ== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/apic] x86/ioapic/32: Decrapify phys_id_present_map operation Cc: Thomas Gleixner , Dave Hansen , "Peter Zijlstra (Intel)" , x86@kernel.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Message-ID: <169159977304.27769.12345903887373451399.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773776089943989366 X-GMAIL-MSGID: 1773776089943989366 The following commit has been merged into the x86/apic branch of tip: Commit-ID: 6026bdba949934b45b7e3ae2babbb7c58d4daeca Gitweb: https://git.kernel.org/tip/6026bdba949934b45b7e3ae2babbb7c58d4daeca Author: Thomas Gleixner AuthorDate: Tue, 08 Aug 2023 15:03:59 -07:00 Committer: Dave Hansen CommitterDate: Wed, 09 Aug 2023 08:10:12 -07:00 x86/ioapic/32: Decrapify phys_id_present_map operation The operation to set the IOAPIC ID in phys_id_present_map is as convoluted as it can be. 1) Allocate a bitmap of 32byte size on the stack 2) Zero the bitmap and set the IOAPIC ID bit 3) Or the temporary bitmap over phys_id_present_map The same functionality can be achieved by setting the IOAPIC ID bit directly in the phys_id_present_map. Signed-off-by: Thomas Gleixner Signed-off-by: Dave Hansen Acked-by: Peter Zijlstra (Intel) --- arch/x86/kernel/apic/io_apic.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 8c47099..ff2d27e 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -1511,12 +1511,9 @@ void __init setup_ioapic_ids_from_mpc_nocheck(void) physid_set(i, phys_id_present_map); ioapics[ioapic_idx].mp_config.apicid = i; } else { - physid_mask_t tmp; - - physid_set_mask_of_physid(mpc_ioapic_id(ioapic_idx), &tmp); apic_printk(APIC_VERBOSE, "Setting %d in the phys_id_present_map\n", mpc_ioapic_id(ioapic_idx)); - physids_or(phys_id_present_map, phys_id_present_map, tmp); + physid_set(mpc_ioapic_id(ioapic_idx), phys_id_present_map); } /*